summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-29Updated coreKruno
Project: dictionaries 6c85a19c887b6147ec7d3a600b51cb2a44284fa2 Update Croatian dictionary to version 2.1.1 Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143 Reviewed-on: https://gerrit.libreoffice.org/53578 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29Remove unused SFErrCodes::TableFormatStephan Bergmann
...which was apparently unused (under its original name SF_TABLEFORMAT) ever since its introduction in 571f15004533c1e7a5472e033139d5765862fb73 "Unix PS- Print Environment". (Not sure what its appearance in the comment to AddTable, also there since that introductory commit, was ever supposed to mean.) Change-Id: I363e21e2e2d23aaf17c6f10b3936ba700203b9eb Reviewed-on: https://gerrit.libreoffice.org/55020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29tdf#117862 crash in profile export dialogCaolán McNamara
Change-Id: Ibb1ab10707262e8f0d36a805ab08562a5f0fecf4 Reviewed-on: https://gerrit.libreoffice.org/55033 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxTransformTabDialogCaolán McNamara
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: https://gerrit.libreoffice.org/55012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29we need to be able to query the ranges before creating the pagesCaolán McNamara
so don't create the pages until the first execute Change-Id: I5ecc31d5a08bae44c0a912e39b786420f2da86ee Reviewed-on: https://gerrit.libreoffice.org/55007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29Resolves: tdf#117712 closing help crashesCaolán McNamara
since... commit 9fa32e5dce345dea17129587c401c03520fb398b Date: Wed May 16 11:54:52 2018 +0200 fix leak of HelpListener_Impl in SfxHelpWindow_Impl Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce Reviewed-on: https://gerrit.libreoffice.org/55024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29uitest for bug tdf#104117 and tdf#80693Zdeněk Crhonek
Change-Id: I29bdf088c83ce69152d5c3edee2c855bfece4585 Reviewed-on: https://gerrit.libreoffice.org/55019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-29dont use SwClient/SwModify in unocore: FieldEnumerationBjoern Michaelsen
Change-Id: Ia307836869e54ab8f5a9727c913979cee4f259f4 Reviewed-on: https://gerrit.libreoffice.org/54868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-29these spinbuttons should be focusableCaolán McNamara
Change-Id: I5af98ef0815f91b8c615441299eb43d602ebf57b Reviewed-on: https://gerrit.libreoffice.org/55008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29disable inconsistent when setting true/falseCaolán McNamara
Change-Id: Ib612e7f38c7a1a638d69af2a6d26f1293fe0c8da Reviewed-on: https://gerrit.libreoffice.org/55011 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29remember button pressed to reuse for moveCaolán McNamara
Change-Id: I4a7f5bb8e46e190f33150f666a653bfc04957a0f Reviewed-on: https://gerrit.libreoffice.org/55010 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29only get notified for user events, not api onesCaolán McNamara
Change-Id: I4cbede587ed4de7950fd7ca435902baa26c8faf5 Reviewed-on: https://gerrit.libreoffice.org/55009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29forcepoint#43 endless update ole2 preview recursionCaolán McNamara
Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc Reviewed-on: https://gerrit.libreoffice.org/55002 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29Provide also an ooo.vba.word.XApplication objectTor Lillqvist
Create the objects on offer to Automation clients lazily It would be silly to create the ooo.vba.word.XApplication in every LibreOffice instance, even if no Writer functionality was going to be used at all in that process. I did not have to do what the old FIXME said, "make Application a proper service", whatever that means. Change-Id: I02a0ceb6290012b4bb6afacadc03871feaf57406 Reviewed-on: https://gerrit.libreoffice.org/55005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-29micro-optimization: do not check for ant if we don't need itRene Engelhard
Change-Id: I84644cddd8a318a2af23780ada9afc26fe23a9fe Reviewed-on: https://gerrit.libreoffice.org/54719 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-29add --enable-build-opensymbol option to build opens___.ttf from sourceRene Engelhard
... and handle opens___.ttf like unowinreg.dll (-> download.lst/$(TARFILE_LOCATION)) Change-Id: Id4723fb15c4b4b04133dedf97b1262441baa4756 Reviewed-on: https://gerrit.libreoffice.org/54938 Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-29Handle DISPID_NEWENUMTor Lillqvist
We get that when an Automation client wants to enumerate an object that is a collection. We need to create an IEnumVARIANT object and return it (as an IUnknown). I wasted days on trying to implement this IEnumVARIANT object using the same twisty maze of helpers, wrappers, UNO conversion utilities, etc as used for the other stuff here. The other objects have both UNO and OLE personalities. Could not figure out how to do it. Then I decided to just do it brute force, following some sample code, not bothering with any UNO personality at all for the IEnumVARIANT thing, and it worked right away. Change-Id: I6a175ea80b75d48d2f0b793f143f3a84715522c1 Reviewed-on: https://gerrit.libreoffice.org/54994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-29loplugin:unusedfields-in-constructor in scNoel Grandin
Change-Id: I074bb272b692dea553e1ec1e625c8afd766627d6 Reviewed-on: https://gerrit.libreoffice.org/54997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:unusedfields-in-constructor in variousNoel Grandin
Change-Id: Ie0fb647938e3cf730976fb2e435b92bfd67ef645 Reviewed-on: https://gerrit.libreoffice.org/54998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29Change SFErrCodes to scoped enumStephan Bergmann
Change-Id: Ib2f267397e419e8164bb2d732f7cbcca7acad1a6 Reviewed-on: https://gerrit.libreoffice.org/54996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29loplugin:useuniqueptr in DbTextFieldNoel Grandin
Change-Id: Ia6ad047859d52ef32e007c428763006673602482 Reviewed-on: https://gerrit.libreoffice.org/54847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29avoid using EditEngine in ScEditUtils::GetString() if possibleLuboš Luňák
According to 1ecdc7aaf66 it is really needed only for resolving fields, so if there's no field, simply concatenate the contents, as used to be the case before that commit. This should be faster and also safer in the case of Calc's threading enabled. Change-Id: I23a2e1873deb8538e2a1ae0dd80af7e5356c18a5 Reviewed-on: https://gerrit.libreoffice.org/54986 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-29weld SvxSwPosSizeTabPageCaolán McNamara
Change-Id: I51c83ec801884a07f7920309535a58b55171b0be Reviewed-on: https://gerrit.libreoffice.org/54934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxAngleTabPageCaolán McNamara
Change-Id: I03bd0a6a0805d549570ce44030a0f58ca2b98d05 Reviewed-on: https://gerrit.libreoffice.org/54818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29forcepoint#42 check available str lengthCaolán McNamara
Change-Id: Ie476968ddaa4c3e5475ae9aa6133e7aba38d5975 Reviewed-on: https://gerrit.libreoffice.org/54976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29forcepoint#41 null derefCaolán McNamara
Change-Id: I16e9e083811c6e14861da1ba1df7d46e8c8771d7 Reviewed-on: https://gerrit.libreoffice.org/54972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29forcepoint#40 null derefCaolán McNamara
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: https://gerrit.libreoffice.org/54968 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29loplugin:useuniqueptr in OTableSubscriptionDialogNoel Grandin
Change-Id: If8fa9edc62f75f41de1392688a169458ce003bda Reviewed-on: https://gerrit.libreoffice.org/54852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29tdf#117847 Impress: Deselected alignment remained checkedIlhan Yesil
The state of the attributes for alignment are now read and set correctly. Change-Id: I65047dac341729154ded0d5b01ace1207893a5ba Reviewed-on: https://gerrit.libreoffice.org/54907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-05-29tdf#42949 Fix IWYU warnings in sc/inc/m*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I43882919048c23e9b8d305f8cbba8f120207bb93 Reviewed-on: https://gerrit.libreoffice.org/54824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-29tdf#117503 DOCX import: fix out of sync first/later top marginMiklos Vajna
Improve the synchronization between the first page and follow page style, so that when the DOC export invokes sw::util::IsPlausableSingleWordSection(), it recognizes that originally these were the same Word section. If they don't match up, then the exporter will insert an explicit section break, meaning we get one more page in the export result compared to the original. Change-Id: I336cf347698187cdede47be2659cec51e4381e85 Reviewed-on: https://gerrit.libreoffice.org/54965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-29Add missing includeSamuel Mehrbrodt
Change-Id: I0b3af7ac36631748c0d33afb6d06d19761af9c41 Reviewed-on: https://gerrit.libreoffice.org/54926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-29loplugin:useuniqueptr in ODbTypeWizDialogSetupNoel Grandin
Change-Id: I5d1e737510d423f9caa44ad5b498ef5e781c24d0 Reviewed-on: https://gerrit.libreoffice.org/54856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in DbaIndexDialogNoel Grandin
Change-Id: Ife795db29256a50a93b668890c85473872d350a9 Reviewed-on: https://gerrit.libreoffice.org/54853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in dbaui::SbaSbAttrDlgNoel Grandin
Change-Id: Ia24f948370b30ccc3870e36c19312e9eebb309b3 Reviewed-on: https://gerrit.libreoffice.org/54851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:unusedfields-in-constructor in xmloffNoel Grandin
fields that are only referenced in the constructor Change-Id: I44bddb2dce2f30c21ea0f1ada4c1615c854d3334 Reviewed-on: https://gerrit.libreoffice.org/54823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29Only show Mail Merge toolbar after wizard finishedMike Kaganski
The toolbar is not needed while wizard works (since it's modal). This simplifies the logic a little. Also this allows to show the toolbar in the actual document used for mailmerge (e.g., when a new or existing document is used, nit the current one); previously, the toolbar appeared in the document active at the moment of wizard launch remained in that document, and actual document went without the toolbar. Change-Id: I44c45c41f1a3e06cd0fb1930092727b9e08caf74 Reviewed-on: https://gerrit.libreoffice.org/54864 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-29WITH_HELPPACK_INTEGRATION isn't substituted anywhereStephan Bergmann
(just used via SCPDEFS) Change-Id: I23a14b0e76399b5e6303ad11ad7d09966d951b6f Reviewed-on: https://gerrit.libreoffice.org/54915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29filter: fix build of embedded ole stream dumperMiklos Vajna
Change-Id: I7f9f34af52057b35f3778d84cfe98afa37817b6b Reviewed-on: https://gerrit.libreoffice.org/54939 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-28sc: simplify ScModule::GetClipDocHenry Castro
Change-Id: I36a79a41b989d37efc35a9f9b4bebca9bdaf9ee9 Reviewed-on: https://gerrit.libreoffice.org/54935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-05-28blacklist ocDBSum for calc's threadingLuboš Luňák
Triggers a number of asserts on hard-recalc (Shift+Ctrl+F9) with ooo#58183-1 that would require passing ScContextInterpreter* to a number of functions, so just blacklist it. Change-Id: I0c3666a3423cea7c77f530480b8b63506c4bbad2 Reviewed-on: https://gerrit.libreoffice.org/54933 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-28weld SvxPositionSizeTabPageCaolán McNamara
Change-Id: Ic642d6ab2470a14b3a1d83284407fc690d5eba88 Reviewed-on: https://gerrit.libreoffice.org/54945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28fix up position of anchor widgetCaolán McNamara
Change-Id: I35823a4c84f6134bf9b005fb1ab6df12d716d14e Reviewed-on: https://gerrit.libreoffice.org/54816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28toggle should trigger only through uiCaolán McNamara
Change-Id: I15619dad2189f81a074f8b9649c4e8b756120f2c Reviewed-on: https://gerrit.libreoffice.org/54944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28uitest Calc Fill random numberZdeněk Crhonek
Change-Id: I6922a537f06c7cced0f8b5390c8261c57d07b29b Reviewed-on: https://gerrit.libreoffice.org/54928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-28coverity#1435838 Uninitialized scalar fieldCaolán McNamara
Change-Id: I76446f3d70f3385b78ee382b265439765176f4f5 Reviewed-on: https://gerrit.libreoffice.org/54900 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28weld SvxSlantTabPageCaolán McNamara
Change-Id: Ib3b1bf1fa434c63b66f388a1f1815787b642fb88 Reviewed-on: https://gerrit.libreoffice.org/54817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28DBase: synchronize DB types known on Calc with those known on BaseJulien Nabet
by adding 0x31, VisualFoxProAuto on array of valid marks in lcl_MayBeDBase See https://opengrok.libreoffice.org/xref/core/connectivity/source/inc/dbase/DTable.hxx#40 and https://opengrok.libreoffice.org/xref/core/include/connectivity/dbtools.hxx#823 Yes, it should be great to have only 1 enum Change-Id: Ic3fb74c838aab5e744cbe1d70ad8ca4ce2c00b8d Reviewed-on: https://gerrit.libreoffice.org/54894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-28tdf#117850: Just call _Exit() in our applicationWillTerminate:Tor Lillqvist
Sure, it is just a workaround, but a very effective workaround. Change-Id: Id0daff048a27dae5cf8fb5e0e949c5b21e03fc86 Reviewed-on: https://gerrit.libreoffice.org/54924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-28Bin ten year old temporary hackTor Lillqvist
Cmd-W works just fine without any special handling at this low level, as far as I can see. Change-Id: Ib00964553984b7aeec89d9fab9fc425c08de910a Reviewed-on: https://gerrit.libreoffice.org/54917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>