summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-30EPUB export: add UI to set custom metadataMiklos Vajna
The motivation here is that when it comes to date or author, the typical metata for the Writer document won't match the metadata of the book the file represents, so allowing a custom override as part of EPUB export makes sense. Change-Id: I19aaed83ae0e69bc0dfa3084e1c9dc9cc534328f Reviewed-on: https://gerrit.libreoffice.org/45553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-30EPUB export: allow setting custom metadata explicitlyMiklos Vajna
If not set, fall back to the existing auto-find. The testcase now asserts that the priority is: - api - if that is not set, then xmp - if that is not set, then doc (And at the end libepubgen itself has some defaults as well.) Change-Id: Ie8fc646b81c4a287690fd2eeed43f4786b7938bf Reviewed-on: https://gerrit.libreoffice.org/45552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-30EPUB export: allow overwriting of document metadataMiklos Vajna
Pick up overrides from <base directory>/<base name>.xmp as a start. Change-Id: Ib64a6bbdadc53633fb1f0d4a7efdde2e3c96b5ef Reviewed-on: https://gerrit.libreoffice.org/45551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-30loplugin:unnecessaryparenStephan Bergmann
Change-Id: I981372300b03ecd7b46e08d6a279f5438b46d8df
2017-11-30catch IllegalArgumentException tooCaolán McNamara
Change-Id: Ib34bb87d94f8cc6d381e65ffbfe186e8d76d4e83 Reviewed-on: https://gerrit.libreoffice.org/45587 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30Move loplugin:fpcomparison to store/Stephan Bergmann
...after bc4e8de8eea1ccebda479c8e2db2f3c6dfff60d2 "Silence new loplugin:fpcomparison for now": > Nov 30 08:33:16 <sberg> noelgrandin, thoughts on whether fpcomparison is actually worth it, seeing the loooooooong blacklist there? > Nov 30 08:34:11 <noelgrandin> sberg, that's wasn't my idea, can't remember who came up with it. vmiklos was that you? > Nov 30 08:34:36 <noelgrandin> sberg, the original commit message was "Find code that compares floating point values with == or != > Nov 30 08:34:36 <noelgrandin> It should rather use rtl::math::approxEqual" > Nov 30 08:34:45 <noelgrandin> so in theory the replacement should be fairly manual > Nov 30 08:34:48 <vmiklos> i don't think so :) > Nov 30 08:35:15 <noelgrandin> might have been moggi, but he's not around so.... just disable it > Nov 30 08:36:19 <sberg> noelgrandin, yeah, in theory; in practice, I guess there's also cases where x==1.0 is what you want exactly (given x tends not to be a computed value after all, but some literal that's being passed around) > Nov 30 08:36:33 <sberg> noelgrandin, yeah, I'll disable it then Change-Id: I35f5328efa0ec02d9be837c12efab2b03a3dae52 Reviewed-on: https://gerrit.libreoffice.org/45550 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30Create script to list the uitestsXisco Fauli
Change-Id: Ie5a1b7151a32cc72da6a1c68bde2518897eea0f4 Reviewed-on: https://gerrit.libreoffice.org/45496 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-11-30catch SAXException in pptx testingCaolán McNamara
Change-Id: I9379ae268d5c42723a34d6f9e677fe800873ebfa Reviewed-on: https://gerrit.libreoffice.org/45580 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#111773 tdf#111780 Fix selection after merge cells in an Impress tableDaniel
Change-Id: I800c4fb8c37c07fb771f4310b207e459119a8e60 Reviewed-on: https://gerrit.libreoffice.org/45451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30have "make clean" also remove android's/gradle's output dirsChristian Lohmaier
esp. removing the jniLib one is important, as otherwise it is easy to package both x86 as well as arm libs into the apk, making it huuuge :-) Change-Id: I6364b82800a449682b618f0bb98a47825dcb0742
2017-11-30Don't do dynamic_cast twiceMike Kaganski
Change-Id: I1f1f7c13937af3b84cc1a1eaf2f5036bab774579 Reviewed-on: https://gerrit.libreoffice.org/45556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-30Do not check in qt5 checks for Qt4 bugs that were fixedTomáš Chvátal
Change-Id: I4d4725c775e98fe397e43d7b6ae02eb98dc79aa0 Reviewed-on: https://gerrit.libreoffice.org/45507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#113880 Fix a11y issues in tabs of the image properties dialogYousuf Philips
Change-Id: Ief5b95307cefe1091854ba872c37a702fe432b20 Reviewed-on: https://gerrit.libreoffice.org/45121 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#103317 Language and country tags removed from templatesLaurent BP
Detailed modifications: Blue_Curve - Remove unused user defined style - Restore preview object in page 2 of Notes view - Increase size of title - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - content.xml and styles.xml: remove asian and complex tags - remove my name in meta.xml - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Classy_Red - resize object preview in page 1 Notes view - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in Object 1/content.xml, styles.xml - Object 1/content.xml, content.xml and styles.xml: remove asian and complex tags - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) - styles.xml: change <table:table-template text:style-name="default"> in <table:table-template table:name="default" table:first-row-start-column="row" table:first-row-end-column="row" table:last-row-start-column="row" table:last-row-end-column="row">. It appears to get same table, and is validated. Forestbird - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - content.xml and styles.xml: remove asian and complex tags - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Lights - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - content.xml and styles.xml: remove asian and complex tags - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Lushgreen - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - styles.xml: remove asian and complex tags - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Nature_Illustration - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - styles.xml: remove asian and complex tags - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Piano: - change thumbnail.png - remove Configurations2 and settings.xml (update manifest.xml) - remove language tags in styles.xml - content.xml and styles.xml: remove asian and complex tags - remove my name in meta.xml - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina) Change-Id: Iea9b522012808b858fd78f09485bfdbf751a856f Reviewed-on: https://gerrit.libreoffice.org/44614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-30tdf#114155 change interface domain to 'wpt'Andras Timar
Change-Id: I91fc11482273b6bd1a165fc82d6b24fc726b70a3 Reviewed-on: https://gerrit.libreoffice.org/45573 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-30mailmerge.py: Use strip in server nameXisco Fauli
Using spaces in the dialog might lead to incorrect server name Change-Id: I29a1ffa867d2e415338accf98bb45c7d65b14fa2 Reviewed-on: https://gerrit.libreoffice.org/44052 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30lok: Replace this custom loop with STLPranav Kant
Change-Id: I3b93654ba3d41733209ff819ca1d0250fb47ce74 Reviewed-on: https://gerrit.libreoffice.org/45526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-30ofz#4484 don't set mnRangeOpPosInSymbol on StringOverflow caseCaolán McNamara
Change-Id: I35d86c97e4fb082a676a5eeadf8375738cecd7bd Reviewed-on: https://gerrit.libreoffice.org/45519 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30Detect also clang-format versions 5.0.0+Samuel Mehrbrodt
Change-Id: I651f078c20a1a51d636d359c1118f06b71083e8e Reviewed-on: https://gerrit.libreoffice.org/45561 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-30tdf#113901: Grid offset for notes and temporary notes modified.Vasily Melenchuk
Older calculations for gird offset were incomplete: are not used for notes (only for temporary ones on mouse over), were not taken into account during temporary note disappear and contain duplicated code from ScDrawView::SyncForGrid() New approach elminate described above problems. Change-Id: I5f92971e156f37f052b4e6d47b2f16480bdbaf7e Reviewed-on: https://gerrit.libreoffice.org/44464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-30coverity#1424321 Dereference after null checkCaolán McNamara
Change-Id: Ieadf71b99180418a875914094c4769c9df9f1db2
2017-11-30coverity#1424322 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4314ed8ecbfaf1435bc22688e9afb7b0b3bcbfd0
2017-11-30coverity#1424325 Uninitialized scalar fieldCaolán McNamara
and coverity#1424323 Uninitialized scalar field Change-Id: I00855321a4099720b903553a46f45f6919f71880
2017-11-30add xlsx fuzzerCaolán McNamara
Change-Id: Icce1317dc3ccfb598ce07ee61eddd873f1f98222 Reviewed-on: https://gerrit.libreoffice.org/45481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz#4481: move Path2DContext body to onEndElementCaolán McNamara
Change-Id: Ic06fb71c679e87069afda391e598d360b4b59cc2 Reviewed-on: https://gerrit.libreoffice.org/45516 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz: always free with xmlFreeParserCtxtCaolán McNamara
Change-Id: I90aed11ae0a29a0e9fc725b297e10a7ed30c9942 Reviewed-on: https://gerrit.libreoffice.org/45533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30Rework of chart-paletteheiko tietze
Change-Id: If85a78eb0d7f985872d95ae77a3d696a5f9d0f7a Reviewed-on: https://gerrit.libreoffice.org/45545 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-30tdf#114025 framework: avoid deadlock between Desktop init ...Michael Stahl
... and SolarMutex: the problem is that rtl::StaticWithArg will first lock the implicit mutex of the C++11 static variable, and then the SolarMutex. So if one thread creates the Desktop singleton with SolarMutex locked and another thread without SolarMutex locked, this can deadlock. If we use rtl_Instance directly with SolarMutex, then there is still a static variable, but the SolarMutex will always be locked first, preventing this deadlock. Change-Id: Ibd37fdfa96a4a2b57f661be3814dd597eb52d338 Reviewed-on: https://gerrit.libreoffice.org/45508 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-30Silence -Werror=pragmas with some GCCStephan Bergmann
...version "gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406" which reportedly supports C++17 but doesn't know -Wregister Change-Id: If8fd6f3c23ac26386fbc3ccd2df68d61d68ea793 Reviewed-on: https://gerrit.libreoffice.org/45509 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30sal: check for HAVE_GCC_BUILTIN_ATOMIC only once in interlckMiklos Vajna
Change-Id: Iaddc79cee0c06f72f636a3d35959922fd78f4e20
2017-11-30Silence new loplugin:fpcomparison for nowStephan Bergmann
...introduced with ba4a124b0c0c66fd275f5147d55eeec27ce78da9 "Resolves: tdf#114117 draw page shadow mangled" Change-Id: I31573d55ae7e5ff015d4582de1d436cdc673acf1
2017-11-30ODT filter: make sure we have a layout before exportMiklos Vajna
It is expected that the commandline --convert-to switch gives mostly the same result as save-as on the UI, but this was not the case for ODT, as the convert-to case had no layout available. As a result the explicit width of table columns or soft page-breaks were missing from the export result in the convert-to case. Given that Word formats already calculate the layout before export and during crashtesting we already wait for the OnLayoutFinished even before export, just enable calculating the layout before ODT export as well to shrink the cmdline vs GUI differences. [ No testcase: saving writerperfect/qa/unit/data/writer/epubexport/table.fodt with the writer8 export filter would be a reproducer for this, but the test doesn't fail without the fix even aftet not calling CalcLayot() via the mustCalcLayoutOf() override, so I'm out of ideas right now how to test this. ] Change-Id: Ib05958e857f0a353b8740f2a87a6cf2f45f3c764 Reviewed-on: https://gerrit.libreoffice.org/45518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: I9188f4579900d7eec375754aa94d21ac4e8456e2 Reviewed-on: https://gerrit.libreoffice.org/45504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30loplugin:unusedenumconstantsNoel Grandin
Change-Id: Iebcd8688ec807aa61989b4622ea0d3eca5c4c671 Reviewed-on: https://gerrit.libreoffice.org/45478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30Weaken SwarmSolverTest::testUnconstrained even further for nowStephan Bergmann
...after 1fa761af825641da5c87f80c2a17135f92418960 "Ridiculously large delta for SwarmSolverTest::testUnconstrained for now", to accommodate further Jenkins lo_ubsan failures with actual values of 3.67055466470122 (<https://ci.libreoffice.org/job/lo_ubsan/741/console>) and 3.88389164367578 (<https://ci.libreoffice.org/job/lo_ubsan/743/console>). Change-Id: Ibacb25ba82c2c279ef8dcd19c5ce7f6d5d8014d5 Reviewed-on: https://gerrit.libreoffice.org/45520 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30some global loplugin improvementsNoel Grandin
for some reason we're hitting more template AST nodes now? Anyhow, updated singlevalfields and unusedenumconstants to cope. For unusedfields, ignore field access inside Clone() methods, since it's like a constructor. Similarly for unusedmethods. Change-Id: Icb2f76fb2f06ae5df21f9d75312e42a2800befb9 Reviewed-on: https://gerrit.libreoffice.org/45470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30TypedWhichId for RES_PARAATR constantsNoel Grandin
Change-Id: If2257d32fdd66703735466982e6913070ac1166d Reviewed-on: https://gerrit.libreoffice.org/45402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30Enable loplugin:unnecessaryparen for integer and Boolean literalsStephan Bergmann
...taking care not to warn about those cases that are used to silence Clang's -Wunreachable-code Change-Id: I3c1da907f51cc786f81c1322fe71d75832cd9191 Reviewed-on: https://gerrit.libreoffice.org/45521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30Deduplicate conditional formats loaded from .odsTor Lillqvist
If there are several separate conditional format elements that can be represented as just one (with several ranges), try to do that. A particular customer document used to take 3 minutes 20 seconds to load, and it contained so many (tens of thousands) conditional formats that the Format> Conditional Formatting> Manage... dialog was practically impossible to use. Now loading that document takes 15 seconds and there are just a handful of separate conditional formats. Also add a simple unit test to verify the deduplication. Change-Id: I7c468af99956d4646ee5507390f1476caff52325 Reviewed-on: https://gerrit.libreoffice.org/45460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-29ww8: use sprm names instead of numbersMike Kaganski
Added sprms for Word 6 binary format; removed obsolete comments. Change-Id: Iac88f8df9397f81586e39c1cf152c762be8f9aed Reviewed-on: https://gerrit.libreoffice.org/45474 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-29Add SfxEnumItem to NatvisMike Kaganski
Change-Id: I11177cd99a3d895c7ec94661fa677a0edfcdf9bf Reviewed-on: https://gerrit.libreoffice.org/45536 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-29Support for GPG encryption in more ODF filtersKatarina Behrens
not only Writer but also Calc, Impress, Draw and Math Change-Id: I7f9fe86ffe5f9a812a5215617b9e673c73134202 Reviewed-on: https://gerrit.libreoffice.org/45472 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-29tdf#89210 Rename 'mode'Heiko Tietze
Tooltip and toolbar title renamed to 'Transformation' Change-Id: I735d266c748fc41d4fd9913000c937a1011b787f Reviewed-on: https://gerrit.libreoffice.org/45337 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-29ofz: Direct-leakCaolán McNamara
Change-Id: Id94586cc659a5e504c727c570dc9fc60c85c8820
2017-11-29Fix typosAndrea Gelmini
Change-Id: I543818f6176b22226683be9cc6c459eda0e53183 Reviewed-on: https://gerrit.libreoffice.org/45501 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-29ofz: handle bad key len and subsequent PK11_ImportSymKey failureCaolán McNamara
Change-Id: Ied93745f924cbcbc674b5c9a78545aa1f79fc61e Reviewed-on: https://gerrit.libreoffice.org/45513 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29Resolves: tdf#114117 draw page shadow mangledCaolán McNamara
when cairo had to stretch the 1 pixel dimension to fit the area. When its this 1 pixel case set the same settings we use for the stipple effect to get the expected interpolation Change-Id: I42d87d6d01ebdb44083351a9632860f5f0a3bf63 Reviewed-on: https://gerrit.libreoffice.org/45511 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29Updated coreGabriel Chiquini
Project: help ec6a05cc524a17ff090eaa7e506d7b5452ab227b Fixed UX bugs Clicking on tabs (Contents, Field, Index) now close the other ones Set focus into seach field clicking in those tabs Change-Id: I4b569aea86d4c5c441ce89dfa76f66844f0ebbc4 Reviewed-on: https://gerrit.libreoffice.org/44902 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-11-29tdf#76646 don't open link on Ctrl-click if not requiredSzymon Kłos
Change-Id: Ie081f8144e50f576b9f8acb2ddd5b1c891533964 Reviewed-on: https://gerrit.libreoffice.org/45499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-29postprocess: call check-elf-dynamic-objects on LINUXMichael Stahl
This runs fast enough that it can just be enabled. Isn't allowed to break the build just yet due to the existing GPG related problems. Change-Id: I6f2ed3d7aeee9e7770940d96894ecdf4d0bf2d9b