summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-05tdf#160084 Simplify comparison for basegfx::fToolsAaron Bourdeaux
Change-Id: I61bcc0054c71273945d3004839be92a25a26d261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165563 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-04-05a11y: Enable accessibility for comboboxes in sidebarAntony
* Updated window.cxx:Window::DumpAsPropertyTree to include accessibility data in the output * Added accessibility info to comboboxes inside sidebarstylespanel.ui & sidebartextpanel.ui * Reverted unwanted ui version change introduced due to glade Change-Id: If6833c9f42dbab90fb6277ed932062d86cf53416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165782 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit ca31493ad56647cf5d11dccaf70fa225327fab51) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-05cid#1596116 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6a4803ae079786880b5a8ff040f1215657604476 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-05Revert "convert OCellValueBinding to comphelper::WeakComponentImplHelper"Noel Grandin
This reverts commit 7510cca63690ea97eb02a43f698fc183c3d0434a. Reason for revert: deadlocking Change-Id: Id50926e401871be259fa955b68b1767fd7f6b9de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-05sw: layout: remove superfluous pages again in InternalAction()Michael Stahl
The bugdoc has a very large header containing hidden text changes height when toggling Formatting Marks. When toggling on, it crashes, because UnHide() iterates the text frames in all headers, but after the first one empty pages at the end of the document are removed, so UAF. Remove the pages without content earlier; SwLayAction::InternalAction() already does it after the "normal" page loop, but the 2nd page loop following that may also move content off pages, so do it again. Change-Id: Iaae6a16842b3494f25cba8fc036d15049b71961f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165801 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-04-05sw doc model xml dump: show SwTableLine::m_aBoxesMiklos Vajna
Which means we get boxes (cells) grouped by lines (rows), instead of a flat list of all cells in a table. Change-Id: Ibb14c6fb26b2f4b502b18544d9a08d964c45a97e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165806 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-04-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7 - Mute l10n in page title Change-Id: Id715ea5bd4b17ac866e8c5638e0f725b9aaa6b96 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165803 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-04Remove duplicate code.Moritz Duge
Change-Id: Ia32b0525ecdf5944c2ebd3045dc3d536941ed394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165763 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04Improved documentation (Emscripten, Qt5 usage, WASM examples)Moritz Duge
Sentence about Emscripten was probably obsolete since around commit 12a6b57c Change-Id: Ide59154439f8a069c2dbd58420c1c93844790a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165754 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04Remove duplicated includeAndrea Gelmini
Change-Id: I802dc451e12ad42f89dff553128f1324e161af28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165757 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-04-04IASS: make live slideshow non-experimentalThorsten Behrens
Change-Id: I36fb6eae8f77f02fa1a9bcf96a7c074d78ba86c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165804 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04tdf160518 DOCX: import hyphenation-keep to fix layoutLászló Németh
To fix layout interoperability, import DOCX compatSettings allowHyphenationAtTrackBottom and useWord2013TrackBottomHyphenation as hyphenation-keep setting "COLUMN", shifting last hyphenated lines of pages and columns, like MSO does. Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21 "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep". Change-Id: Ib2a06efc22a4f30d8f8be8a752460b09d09e97a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165798 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-04-04tdf#95405 Sidebar: Quick Find for writerkhushishikhu
Implemented the quick find deck on the sidebar of Writer with a corresponding panel in it. Change-Id: Ic4ce6823e11b27b3386e820a657bc5d973e47007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160500 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-04loplugin:unusedenumconstantsNoel Grandin
Change-Id: I889b4f63e098fecf22ffd4fb98937d62dbdd70b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04RESTART_REASON_MSCOMPATIBLE_FORMS_MENU is deadNoel Grandin
removed with commit 1d4cd39262fb71f72311e33ac2bdb7d925be5d98 Author: Heiko Tietze <tietze.heiko@gmail.com> Date: Thu Sep 14 10:48:46 2023 +0200 Related tdf#157006 - Remove global compatibility options Change-Id: If24282d2ec7c8d8c6631982b9fe866e3a7df3d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165790 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04loplugin:unusedmethodsNoel Grandin
Change-Id: I19f466a272c821185bea4b45efd34392e525c0d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04tdf#160301 import DOCVARIABLE fields as user fieldsOliver Specht
DOCVARIBLE fields in *.doc files are imported as user fields. Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04Missing include, againStephan Bergmann
At least the Emscripten build was hit again by what had been fixed with bddb0d87e809c96ee810de0e553f02bbe158907d "Missing include", after a0c53ab43840d1c84d7d246b2cbc73c3a8862155 "tdf#146619 Remove unused #includes from C/C++ files". Change-Id: I632ab297bc51aa07019e4bb0cb4ef8f6372a1374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165795 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-04Drop spurious .delete() calls from example codeStephan Bergmann
...that had been added there accidentally in 27ceca1996809c0f9390d1e9fb95dc7436ef1acf "Rework the Embind mapping of UNO interfaces" Change-Id: I390e4b694e95d665f7bc3d62b0f7ba2c887041bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-04tdf#63259 cycle case on sentencesOliver Specht
Cycle case will be applied to the sentence if the cursor is at a sentence end. Writer now also keeps the word/sentence selection after case change. Change-Id: I9dd561775ac612689526bcb118533ba81b5722be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165018 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04improve usability of variable fieldsOliver Specht
The value field of the Variables page of the field dialog is changed into a scrollable field to enhance usability in combination with longer values of variable or user fields Change-Id: Ib268cf22ff54604214fb090c3c93b7d145a9c9a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165750 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04gtk4 a11y: Implement new GtkAccessibleTextInterface::get_offsetMichael Weghorn
Implement the new `get_offset` method for `GtkAccessibleTextInterface` newly introduced in GTK 4 in GTK commits commit f802be88e98f817c3d6fa048bf79d82de60173d3 Author: Matthias Clasen <mclasen@redhat.com> Date: Sun Mar 10 10:27:56 2024 -0400 a11y: Use gtk_accessible_text_get_offset Implement GetOffsetAtPoint using gtk_accessible_text_get_offset. commit b9d2049991427e8dee443e9f3b683e52c96d6b83 Author: Matthias Clasen <mclasen@redhat.com> Date: Sun Mar 10 10:27:32 2024 -0400 a11y: Add gtk_accessible_text_get_offset This is not implemented yet. commit cfe35586107d7c42eb3af7aa38ee23df22f718d0 Author: Matthias Clasen <mclasen@redhat.com> Date: Sun Mar 10 10:02:24 2024 -0400 a11y: Add GetOffsetAtPoint We don't handle it yet. In order for this to actually work on the AT-SPI level, this also needs fixes on the GTK side. Pending MR: [1] With this, the previous Change-Id: I7d171b6696037a696f0d767d3134c7a7184f93a3 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Apr 4 11:08:10 2024 +0200 gtk4 a11y: Implement new GtkAccessibleTextInterface::get_extents and the mentioned GTK MR in place, a quick test with a Writer paragraph using Accerciser's IPython console now looks OK: In [1]: acc.queryText().getCharacterExtents(5, pyatspi.XY_WINDOW) Out[1]: (483, 219, 4, 18) In [2]: acc.queryText().getOffsetAtPoint(484, 220, pyatspi.XY_WINDOW) Out[2]: 5 [1] https://docs.gtk.org/atk/vfunc.Text.get_range_extents.html Change-Id: Ieb45e3d0d6f37350898ffee081491bf94b6dbea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165794 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-04gtk4 a11y: Implement new GtkAccessibleTextInterface::get_extentsMichael Weghorn
Implement the new `get_extents` method for `GtkAccessibleTextInterface` newly introduced in GTK 4 in GTK commits commit 7955efef6c31d23c8553dc3464e72273886a4417 Author: Matthias Clasen <mclasen@redhat.com> Date: Sun Mar 10 14:28:07 2024 -0400 atspi: Use gtk_accessible_text_get_extents Implement the GetCharacterExtents and GetRangeExtents methods of the atspi Text interface using the new GtkAccessibleText api. commit 3134003376fc37c6d5e7e6eb7c6f36307039a92c Author: Matthias Clasen <mclasen@redhat.com> Date: Sun Mar 10 14:27:42 2024 -0400 a11y: Add gtk_accessible_text_get_extents This will be used to implement GetRangeExtents in atspi. The `XAccessibleText` UNO interface currently only has a way to retrieve the extents of a single character, so just return `false` if the extents for a larger text range is requested. (LO's gtk3/ATK implemenation currently also doesn't implement AtkText.get_range_extents` [1]) To actually work, this also needs changes on GTK side to support non-GtkWidget GtkAccessible implementations. Pending MR: [2] [1] https://docs.gtk.org/atk/vfunc.Text.get_range_extents.html [2] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7104 Change-Id: I7d171b6696037a696f0d767d3134c7a7184f93a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165793 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-04a11y: Fix XAccessible{Editable,Multiline}Text docMichael Weghorn
Fix typos and slightly improve wording. Change-Id: Ib58dcb4d6039a55ade76d12d5fed33f4eac84776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165792 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-04ofz#67825 build failure clang frontend command failed with exit code 139Caolán McNamara
unotools/source/ucbhelper/tempfile.cxx:298:8: current parser token ';' unotools/source/ucbhelper/tempfile.cxx:46:1: parsing namespace '(anonymous)' unotools/source/ucbhelper/tempfile.cxx:278:1: parsing function body '(anonymous namespace)::getEyeCatcher' unotools/source/ucbhelper/tempfile.cxx:278:1: in compound statement ('{}') the very similiar unotools/source/config/docinfohelper.cxx compiles fine according to the log, so tweak to match that Change-Id: I8f1286c88d7c1a70fb3294c84bf1c55109d97ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-04Resolves tdf#154209 - Fixes resize issue in Index Entry dialogHeiko Tietze
Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-04-04Fix indentationMoritz Duge
Change-Id: Iabbdd5507493e2d8e7c635ff53d2e6762944df0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165755 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-04tdf#81012: avoid content frames in footnotes / endnotesMike Kaganski
This makes the behavior of the endnotes in the end of sections consistent with the behavior of dedicated endnote pages, where heading fields ignore headings in endnote content. Change-Id: Iad0218b75a678808b1266024fe4c81f040a631c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165789 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04-Werror=maybe-uninitializedStephan Bergmann
...as reported at least with some recent GCC 14 trunk. Lets assume that those calls to GetWindowPos are never meant to fail. (If it turns out that they can fail after all, the code would presumably need some modifications to mitigate the uninitialized reads from nL/nP.) Change-Id: I7695d3e54de2bf5d1e91b32cfdc84e994ccdd57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165783 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-04fix 'tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify'Noel Grandin
I messed up in commit 9c5fda14fff397d5d503f749ad019791d7e4ef83 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Mar 6 16:20:41 2024 +0200 tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify and forgot to actually use the new SfxHintId::StyleSheetModifiedExtended I created in the constructor of the SfxStyleSheetHint class Change-Id: Ica661a156d72c8a4b8ad415b6f45fe5d3458ba26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165787 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04improve font name in SwPageFrame::GetEmptyPageFont()Noel Grandin
Fix the problem similar to what commit 1d9221ebc86f2696a65c12287ea19eea44d680cf (tdf#124601 sw: fix misplaced images in table cells, 2022-11-30) did: use a font that we ship to avoid font fallback. Change-Id: I59be457e018c96f7edda80fb5d3787593d75b010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04Use osl::ResettableMutexGuardScopedReleaser instead of ad-hoc guardsMike Kaganski
Change-Id: I2aa09655c207d3647650b5e38011a600bd221699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04Introduce ResettableMutexGuardScopedReleaserMike Kaganski
And use it to guarantee reretting a guard, without having to do that explicitly in exception handlers. Change-Id: I4727cb5b7f37b25e203396957797d24a093e0797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165775 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04Drop one redundant checkMike Kaganski
Change-Id: I0ae90e10fad2d6e41d855ead69b8cdcf8d53f525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165719 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04svtools: improve font name in EmbeddedObjectRef::DrawPaintReplacement()Miklos Vajna
Once CppunitTest_sw_uibase_shells sets non_application_font_use to abort, it would fail here with: warn:vcl.fonts:29463:29463:vcl/unx/generic/fontmanager/fontconfig.cxx:1192: PrintFontManager::Substitute: missing font: 'Helvetica' try: Liberation Sans instead Fix the problem similar to what commit 1d9221ebc86f2696a65c12287ea19eea44d680cf (tdf#124601 sw: fix misplaced images in table cells, 2022-11-30) did: use a font that we ship to avoid font fallback. Change-Id: I1301c546d7cce90f0e687bc0db9dc69262eed4a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165779 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-04-04Update git submodulesJuan José González
* Update helpcontent2 from branch 'master' to c89178e82abacbb240e571fcbd9bd0f76b40642d - tdf#160467 Remove z-index in prism code block Right now code renders on top of header section. Remove z-index to fix it. Change-Id: Ic0cf226275eae1656107de27907a94af256d5555 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165768 Tested-by: Jenkins Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-04remove leftoversNoel Grandin
from commit e1e48bba55ff68397d514ab3771850678312f348 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Apr 1 18:40:26 2024 +0200 tdf#160399 speed up print preview Change-Id: I399752d473a4f6f782cdfcc53b4625dcdf7cb460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04SdNavigator: Show context menu only for active document navigationJim Raykowski
Change-Id: I3d622f92d411b30e5beea5432e10ae0a907eeb0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165667 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-04A small refactorMike Kaganski
Change-Id: I299cc7c2850a71ee563824c6361707d894f5ddcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165773 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04Drop a bit of redundancyMike Kaganski
POPPLER_CHECK_VERSION(0, 23, 0) implies POPPLER_CHECK_VERSION(0, 24, 0) Change-Id: I48f3763ef115719a3e3615623bfb40f7c79b8df4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165772 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04Related: tdf#160260 Drop xpdfimport.err.pdf, let PDF import return falseMike Kaganski
The problem was, that upon any error in opening a PDF, out Poppler wrapper used another bundled document, with a single page with a static text "This PDF file is encrypted and can't be opened.". That happened regardless of the nature of the problem (it could be an IO problem, as in tdf#160260, or other things from Poppler's poppler/ErrorCodes.h). For automated import (command line or API), it meant that it was not possible to detect the failure. This replaces this strange mechanism with a normal error reporting. For now, a simple "general input/output error" will be reported; but it is possible to use interaction handler to show details (see comment in xpdf_ImportFromFile). Change-Id: I30493118fc5dd0b1c62cae7718acfe95bb4b13b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165771 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-04tdf#159790 temporarily release mutex for child packagesPatrick Luby
This code is normally run on a separate thread so if a child package tries to acquire the solar mutex, a deadlock can occur if the main thread calls isRegistered() on this package or any of its parents. So, temporarily release this package's mutex while registering the child package. Change-Id: I45b534c44d5946637a5441927ed01a68aad4c448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04A number of bogus GCC 13 warnings still hit with recent GCC 14 trunkStephan Bergmann
Change-Id: I0ec7743cd79429591fcfc3eb9715ff36d06fc00b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-04Revert "osl::Mutex->std::mutex in GrammarCheckingIterator"Stephan Bergmann
This reverts commit 829fa53fe877d0f0fc33d634fa7fbfbed23b7676, which started all sorts of `make check` tests to hang for me due to a recursive locking attempt in > #5 std::mutex::lock (this=0x7f6af81e62c0) at ~/gcc/inst/include/c++/14.0.1/bits/std_mutex.h:113 > #6 std::unique_lock<std::mutex>::lock (this=<synthetic pointer>) at ~/gcc/inst/include/c++/14.0.1/bits/unique_lock.h:147 > #7 std::unique_lock<std::mutex>::unique_lock (this=<synthetic pointer>, __m=...) at ~/gcc/inst/include/c++/14.0.1/bits/unique_lock.h:73 > #8 GrammarCheckingIterator::NextDocId (this=0x7f6af81e6260) at linguistic/source/gciterator.cxx:317 > #9 GrammarCheckingIterator::GetOrCreateDocId (this=this@entry=0x7f6af81e6260, xComponent=uno::Reference to (SwXTextDocument *) 0x7f6af8430ec8) at linguistic/source/gciterator.cxx:339 > #10 0x00007f6b3b9e9da9 in GrammarCheckingIterator::startProofreading (this=0x7f6af81e6260, xDoc=<optimized out>, xIteratorProvider=<optimized out>) at linguistic/source/gciterator.cxx:773 > #11 0x00007f6b16441ec3 in SwDoc::StartGrammarChecking (this=<optimized out>, bSkipStart=bSkipStart@entry=false) at sw/source/core/doc/docnew.cxx:180 > #12 0x00007f6b164c4eae in sw::DocumentTimerManager::DoIdleJobs (this=0x7f6afad005a0) at sw/source/core/doc/DocumentTimerManager.cxx:169 > #13 0x00007f6b3e83a68b in Scheduler::CallbackTaskScheduling () at vcl/source/app/scheduler.cxx:509 > #14 0x00007f6b3eb1725f in SalTimer::CallCallback (this=<optimized out>) at vcl/inc/saltimer.hxx:54 > #15 SvpSalInstance::CheckTimeout (this=this@entry=0xffebe0, bExecuteTimers=bExecuteTimers@entry=true) at vcl/headless/svpinst.cxx:157 > #16 0x00007f6b3eb1761d in SvpSalInstance::ImplYield (this=this@entry=0xffebe0, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at vcl/headless/svpinst.cxx:395 > #17 0x00007f6b3eb17cd5 in SvpSalInstance::DoYield (this=0xffebe0, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/headless/svpinst.cxx:467 > #18 0x00007f6b3e86aa44 in ImplYield (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:394 > #19 0x00007f6b3e86b13b in Application::Execute () at vcl/source/app/svapp.cxx:369 > #20 0x00007f6b3c8e715f in desktop::Desktop::Main (this=0x7ffe5e22fcb0) at desktop/source/app/app.cxx:1615 > #21 0x00007f6b3e87e6fb in ImplSVMain () at vcl/source/app/svmain.cxx:229 > #22 0x00007f6b3e87e9c5 in SVMain () at vcl/source/app/svmain.cxx:261 > #23 0x00007f6b3c91de37 in soffice_main () at desktop/source/app/sofficemain.cxx:93 > #24 0x000000000040078b in sal_main () at desktop/source/app/main.c:51 > #25 main (argc=argc@entry=8, argv=argv@entry=0x7ffe5e22feb8) at desktop/source/app/main.c:49 Change-Id: I60b8b0ba00cae691d6089325e4379a86221dc95b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-04editeng: make it ContentNode::FindFeature clearerTomaž Vajngerl
Change-Id: Ia3498df3cb11b06ac71e3c75839cc98cc0f3d88c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165337 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-04editeng: prefix EditLine members, clean-upTomaž Vajngerl
Change-Id: Ie8c8ee86f139854137ba95875f51ddaf64cc5848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165336 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-03tdf#160260: make poppler wrapper executable Unicode-aware on WindowsMike Kaganski
Change-Id: I76dc31ee14d1794fa73f990e641540ff941c7201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165735 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-03external/lxml: Silence -Wincompatible-pointer-typesStephan Bergmann
...as seen with recent GCC 14 trunk, > gcc -Wno-unused-result -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -g -O0 -Wall -I/home/sberg/lo/core/workdir/UnpackedTarball/zlib -I/home/sberg/lo/core/workdir/UnpackedTarball/python3 -I/home/sberg/lo/core/workdir/UnpackedTarball/python3/Include -fPIC -DCYTHON_CLINE_IN_TRACEBACK=0 -I/home/sberg/lo/core/workdir/UnpackedTarball/libxml2/include -I/home/sberg/lo/core/workdir/UnpackedTarball/libxslt -Isrc -Isrc/lxml/includes -I/home/sberg/lo/core/workdir/UnpackedTarball/python3/Include -I/home/sberg/lo/core/workdir/UnpackedTarball/python3 -c src/lxml/etree.c -o build/temp.linux-x86_64-3.8-pydebug/src/lxml/etree.o -w > src/lxml/etree.c: In function ‘__pyx_pf_4lxml_5etree_11TreeBuilder_4data’: > src/lxml/etree.c:137698:66: error: passing argument 1 of ‘__pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData’ from incompatible pointer type [-Wincompatible-pointer-types] > 137698 | __pyx_t_1 = __pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData(((struct __pyx_obj_4lxml_5etree__SaxParserTarget *)__pyx_v_self), __pyx_v_data); if (unlikely(__pyx_t_1 == ((int)-1))) __PYX_ERR(3, 832, __pyx_L1_error) > | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | struct __pyx_obj_4lxml_5etree__SaxParserTarget * > src/lxml/etree.c:137074:105: note: expected ‘struct __pyx_obj_4lxml_5etree_TreeBuilder *’ but argument is of type ‘struct __pyx_obj_4lxml_5etree__SaxParserTarget *’ > 137074 | static int __pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData(struct __pyx_obj_4lxml_5etree_TreeBuilder *__pyx_v_self, PyObject *__pyx_v_data) { > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ etc. Change-Id: I19f6768bf031c04730972c1fa4a006e2a7d50e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165758 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-03tdf#146619 Drop unused 'using namespace' in: toolkit/Gabor Kelemen
Change-Id: Idab290ebc1394587c17dbec0c110bfa759cbdb8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165540 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-03tdf#146619 Drop unused 'using namespace' in: sd/Gabor Kelemen
Change-Id: I7e48be1962d1e643c49c8cc0d6ca01ffbbb97429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165567 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2024-12-27 02:51:46 +0000