summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-26fdo#43157 convert OSL_ASSERT to assert in sw/source/coreBernhard Widl
Change-Id: I6ffd9832ff1085c84fde8763045f3d1cb02137e2 Reviewed-on: https://gerrit.libreoffice.org/38974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26Write 0 of type 'unsigned char'Stephan Bergmann
regression introduced with ac2d415a52f22caf0012b7d9b17d015aca27db9d "loplugin:oncevar in sc" Change-Id: I1073e7e8b67ddf1dd633f004322c6bc46b9a8052
2017-06-26Fix int (sal_Int32) ambiguityStephan Bergmann
Change-Id: I32afd77a851da180d91011fa424a88be5871e8f7
2017-06-26loplugin:oncevar in sdNoel Grandin
Change-Id: I56649b4df8c517f152ed4e9132985bbef22f8634 Reviewed-on: https://gerrit.libreoffice.org/39241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26update constantfunction lopluginNoel Grandin
didn't find anything useful, so just updating the exclusion lists Change-Id: I66d37aee185290f454e5ac0baeafd1f67bfaf106 Reviewed-on: https://gerrit.libreoffice.org/39254 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26loplugin:oncevar in scNoel Grandin
Change-Id: Ice59e286debb6bd0eb692f2b2b0c2c5087c069c0 Reviewed-on: https://gerrit.libreoffice.org/39239 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26tdf#89139: pivotCache: output sharedItems children only for string fieldsMike Kaganski
... to avoid "corrupted" warning from Excel. In case of string fields, Excel expects the item list to be present, and containsXXX attributes of sharedItems to be absent, otherwise it shows a warning about file corruption. For numeric fields, it doesn't expect item list, othervise it also warns about file corruption. Change-Id: I5ded5b836587bed3177eb0a6b6c418e459e6be8b Reviewed-on: https://gerrit.libreoffice.org/39114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-26SmartArt: layout diagramGrzegorz Araminowicz
Change-Id: I854703ea3cb09ace2d0b01a47d9f07bb7a98b70e Reviewed-on: https://gerrit.libreoffice.org/39172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-06-26use implicit default copy assignmentJochen Nitschke
I guess Coverity complained that there was a copy assignment operator but no copy ctor, move assignment and move ctor defined. Change-Id: I10641c9f403e609406b2a1420b22abbfc9dbc6fc Reviewed-on: https://gerrit.libreoffice.org/39240 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-26ChangedUIEventListener is refcounted, mustn't be helt by unique_ptrStephan Bergmann
Fixes c0ce1ec3736be861a2ed58827fadb25269ab0117 "loplugin:unusedfields in sfx2 part1" part on "fix a memory leak in NotebookbarTabControl where it was not freeing it's m_pListener field", which now caused ASan to report heap-use-after- free during CppunitTest_sw_dialogs_test. Change-Id: Ic0209650692a34abd1ee451713615a03ed9c746f
2017-06-26Fix typosAndrea Gelmini
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-26loplugin:oncevar in sfx2Noel Grandin
Change-Id: I9aadcb9a12ef9b0c3f93ea255f2542e51d31fbf7 Reviewed-on: https://gerrit.libreoffice.org/39242 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26Translate German comments and debug strings (leftovers in r... dirs)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "r". Additionally: - Translates test strings in /registry/test/testregcpp.cxx Change-Id: I9fda72a3d1830268c4eb83d67ee7a95e38c31c0d Reviewed-on: https://gerrit.libreoffice.org/39210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26extensions: remove COMPMOD preprocessor definesJochen Nitschke
COMPMOD_RESPREFIX=abp was unused ever since initial commit in 2001. COMPMOD_NAMESPACE was used to set the namespace name qualifier of the helper in componentmodule.hxx to the extension's namespace name. I don't see why this is necessary as the helper is always compiled in a separate extension library. Change-Id: I287607008db3dc0ebc32731536747a921c91807d Reviewed-on: https://gerrit.libreoffice.org/39184 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26lotuswordpro: remove trivial copy assignment operatorsJochen Nitschke
Those will be implicitly-defined by compiler and a move assignment operator should be implicitly-defined now too. Change-Id: I03c4bb3b95e76c706b606a170ed02c2a39862b36 Reviewed-on: https://gerrit.libreoffice.org/39246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26s/catched/caughtNoel Grandin
Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264 Reviewed-on: https://gerrit.libreoffice.org/39164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26loplugin:oncevar in oox..saxNoel Grandin
Change-Id: I0fee8bcddaeea48335e3be05761d2ad2c45020e2 Reviewed-on: https://gerrit.libreoffice.org/39238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26osl: w32/pipe.cxx typo should have been caught, not cachedChris Sherlock
Change-Id: Iacdf76eec11aedc8a3308897edfda400790bdc19 Reviewed-on: https://gerrit.libreoffice.org/39245 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-26Updated coreOlivier Hallot
Project: help b915986913b52910c342eb831351897868226c0d Help-in-browser (v) * Add piwik analysis * handle SHARED module in search Change-Id: I7c3c653d5e1211eed6c45b521fc35a9dc52ed21e Reviewed-on: https://gerrit.libreoffice.org/39251 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-06-26Fix PageShape export to pptxPaul Trojahn
The export code is not called, because the PageShape is actually of type presentation.PageShape and not drawing.PageShape. A PageShape has no text at all, which results in an empty p:txBody element that fails validation, so it needs to be checked first if the shape actually has text. Change-Id: I559f15c2396739c74d5c4f36eb952754bc040ce8 Reviewed-on: https://gerrit.libreoffice.org/38574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25crashtesting failure on ooo61225-1.sxwCaolán McNamara
Change-Id: Ia953443ba352aea1b33b6efd312a0e95a6b8918e Reviewed-on: https://gerrit.libreoffice.org/39244 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-25loplugin:oncevar in l10ntools..mysqlcNoel Grandin
Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d Reviewed-on: https://gerrit.libreoffice.org/39188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25loplugin:oncevar in helpcompiler..jvmfwkNoel Grandin
Change-Id: Ia9b20a8ca95684cbeb21e3425972c43ba50df3cd Reviewed-on: https://gerrit.libreoffice.org/39187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25loplugin:oncevar in formula..frameworkNoel Grandin
Change-Id: I96d6af49c1994ebd7d6dcc41469127e3151b4350 Reviewed-on: https://gerrit.libreoffice.org/39186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25make some tools macros into functionsNoel Grandin
in the process, eliminate the need to explicitly specify the source/destination type at the callsites. Change-Id: Ie556645791a479989fb737933f1dd58e8533cb1c Reviewed-on: https://gerrit.libreoffice.org/39171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25fix constants used before definitionNoel Grandin
ERRCODE_AREA_SO and ERRCODE_AREA_SBX were being referenced before their definition., by ERRCODE_AREA_SVX_END and ERRCODE_AREA_SO_END Change-Id: I51af1752290479adf0985746253134a0924b1e17 Reviewed-on: https://gerrit.libreoffice.org/39150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25upload poppler 0.56.0David Tardon
Change-Id: If61037a2df12fd7389f46913d96f4b386460fc76 Reviewed-on: https://gerrit.libreoffice.org/39205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-06-25remove unused local varsJochen Nitschke
since commit 95c348afa8f4f17c058c449ded75025175af0e4a loplugin:unusedfields in svx part2 Change-Id: I6d5f3704f4efef0a9fb69623f46a216c509c8302 Reviewed-on: https://gerrit.libreoffice.org/39229 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-25osl: socket.cxx nullptr comparison cleanupsChris Sherlock
Change-Id: Ie0339482bf3a9b108e26008526bc5e73b761d27b Reviewed-on: https://gerrit.libreoffice.org/39223 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: for should be a whileChris Sherlock
Change-Id: Id4e92f0c7927bbc767061461361936dbad8da778 Reviewed-on: https://gerrit.libreoffice.org/39204 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: test condition fixes in unx/file.cxxChris Sherlock
Change-Id: I8debaa590c570ea7a6447668b053a2d4c507edf0 Reviewed-on: https://gerrit.libreoffice.org/39203 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: whitespace cleanup of unx/file.cxxChris Sherlock
Change-Id: I10c9a8d1474920afb7f6afc4d7d34172c398ab4d Reviewed-on: https://gerrit.libreoffice.org/39201 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: doxygen comments in unx/file.cxxChris Sherlock
Change-Id: I26d8b665e8940fd3821d29ced0046c2d1dd5a59c Reviewed-on: https://gerrit.libreoffice.org/39200 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25vcl: delete fake copy ctor and assignment operator of TextEngineJochen Nitschke
Change-Id: I9db651d2d9763aca8c70c1a313bab8d7d4d73e10 Reviewed-on: https://gerrit.libreoffice.org/39228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: cleanup headers of unx/file.cxxChris Sherlock
Change-Id: Ic1d171cf11cf36058f6d1f40c9ca041012e1b0e1 Reviewed-on: https://gerrit.libreoffice.org/39198 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25tdf#43157 - osl: convert OSL_PRECONDs in w32 & unx file.cxxChris Sherlock
Change-Id: Ic914d9240e6b06b7e6550fe311fd69e310254bd5 Reviewed-on: https://gerrit.libreoffice.org/39197 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25osl: remove unneeded comment in unx/file.cxxChris Sherlock
Change-Id: If2e4c06a1d083f82ab531a15ae0bd983f7a5586e Reviewed-on: https://gerrit.libreoffice.org/39199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25svx: pass struct by const reference ...Jochen Nitschke
and use references instead of pointers for output parameters. Change-Id: Ib91a821ff84e464639aa6f09a44ba00301f1d783 Reviewed-on: https://gerrit.libreoffice.org/39220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25tdf#107584: Load/save page background transparencyKatarina Behrens
Change-Id: I17bd01dc129f0e530d5e227a5ddc12f11486e85d Reviewed-on: https://gerrit.libreoffice.org/39206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-25osl: remove comment cruft from pipe.cxx on win32 and unxChris Sherlock
Change-Id: I774497c07f682a3923a6317af5804e477540995c Reviewed-on: https://gerrit.libreoffice.org/39225 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-25osl: whitespace cleanup of pipe.cxx for unx and w32Chris Sherlock
Change-Id: I9c8933616d36027314c990301e67a54c567429b5 Reviewed-on: https://gerrit.libreoffice.org/39222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-25osl: document pipe functionalityChris Sherlock
Change-Id: I1b2fa0db88bf9b25283ff532f9634eb4605775c3 Reviewed-on: https://gerrit.libreoffice.org/39221 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-25osl: variety of doxygen fixesChris Sherlock
Change-Id: I48e4bcce447a1efdb37d6dca9e5808ec8d73492b
2017-06-25osl: document and group code via doxygenChris Sherlock
Change-Id: I9945df95e14fbca47f7cea80b1d4097d00a3eb54
2017-06-25Updated coreOlivier Hallot
Project: help 181b72469b27cc2f711525838463e98a0920161c Help-in-browser: several improvements * tabs for Contents/Index/Search * product version (6.0, 5.3, 5.2, etc...) * capable to receive URL from LibreOffice help call (need to change help url in sfx2/: protocol://<host>/index.html?<params> Change-Id: I2244336ea47cdb923884ae97b9f4a586d85ec706 Reviewed-on: https://gerrit.libreoffice.org/39227 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-06-25Updated coreOlivier Hallot
Project: help bd033eb897b7c43f1f6e8c35cc50d4a73ace84af Help content n browser (iv) clean xslt cruft Change-Id: Icbcde2c6d40019ea6a14a05dd41b248397fc3c33 Reviewed-on: https://gerrit.libreoffice.org/39226 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-06-25gpg4libre: import public key payload if initial validation failsThorsten Behrens
Since maybe we don't know the key yet? Change-Id: I8b7e3f472d4731d9fb8bb675d81bdad257aa9230 Reviewed-on: https://gerrit.libreoffice.org/39194 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: save some space, extract binary key/sign dataThorsten Behrens
Since callers will base64-encode this anyway, again Change-Id: I0962d102fa0f2b95eaa2e608539cc291125f0321 Reviewed-on: https://gerrit.libreoffice.org/39193 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25gpg4libre: base64-encode and decode SignatureValueThorsten Behrens
which xmldsig-core actually requires Change-Id: I92a6e192865919d844009be042dad36106a19fc8 Reviewed-on: https://gerrit.libreoffice.org/39192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-25osl: doxygen parblockChris Sherlock
Change-Id: Ica1b604484c855a94c9a21fab04d62c2f5952fe7
generated by cgit (git 2.34.1) at 2025-01-23 01:31:27 +0000