summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-12SwModelTestBase: remove duplicated code to print execution timeXisco Fauli
This is already handled in class TimingListener in sal/cppunittester/cppunittester.cxx Change-Id: I77d330351d53ef084597e6f46099d1d16f59aae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173258 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-09-12Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to ec63fc11d91d92f31fd7aca15820fafd84d2c957 - tdf#162607 Remove dup's in hid2file.js, DBACCESS_HID* + bad bookmarks removed from tablewizard02.xhp + refactor Change-Id: I6aa3aa5c339319ad6c9d330986168d3c347a57c8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173259 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-09-12sw a11y: Send table selection-changed event for correct objectMichael Weghorn
Send `AccessibleEventId::SELECTION_CHANGED_ADD`/ `AccessibleEventId::SELECTION_CHANGED_REMOVE` when a cell in a Writer gets (un)selected on the table's a11y object and set the cell as the `NewValue`, as documented in the documentation for these events (see offapi/com/sun/star/accessibility/AccessibleEventId.idl). For the cell, an `AccessibleEventId::STATE_CHANGED` event for the `AccessibleStateType::SELECTED` needs to be sent instead, which already happens in `SwAccessibleCell::InvalidateMyCursorPos` (where the cell is also added to the vector of elements used here to send the `SELECTION_CHANGED_*` events). This now gives the expected result when using the following pyatspi script and selecting the first 2 cells in a Writer table with the gtk3 VCL plugin: pyatspi script: #!/usr/bin/python3 import pyatspi def listener(e): try: if not e.host_application.name.startswith('soffice'): return except: return print(e) pyatspi.Registry.registerEventListener(listener, 'object:state-changed:selected') pyatspi.Registry.registerEventListener(listener, 'object:selection-changed') pyatspi.Registry.start() Relevant output from the script: object:state-changed:selected(1, 0, 0) source: [table cell | A1] host_application: [application | soffice] sender: [application | soffice] object:state-changed:selected(1, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table | Table1-1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table | Table1-1] host_application: [application | soffice] sender: [application | soffice] Change-Id: I12a871f748c86fa271fafb839fd9ce8275f93cee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173257 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-12sw a11y: Don't resend obsolete table selection eventsMichael Weghorn
When a table cell was (un)selected, it is added to the vector of added/removed cells. `SwAccessibleTable::FireSelectionEvent` iterates over the cells in those vectors and sends an event for every element. The elements were never removed from the vector, however, meaning that obsolete events of previous selection activity would be resent every time any selection change occured. Clear the vectors after sending the events to prevent that. pyatspi script with which the issue could be seen with the gtk3 VCL plugin: #!/usr/bin/python3 import pyatspi def listener(e): try: if not e.host_application.name.startswith('soffice'): return except: return print(e) pyatspi.Registry.registerEventListener(listener, 'object:selection-changed') pyatspi.Registry.start() Selecting the first 2 cells in a newly inserted Writer table would result (among others) in these events for the cells: object:selection-changed(0, 0, 0) source: [table cell | A1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] (The fact that "selection-changed" events are sent for the cells instead of the table is another issue that will be handled separately.) Unselecting the second cell would then trigger these "selection-changed" events: object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | A1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] (Note the two last "selection-changed" events being resent from before.) Selecting the second cell once again would then trigger 4 events despite only a single cell having been newly selected: object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | A1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] With this commit in place, only a single event for the newly (un)selected cell B1 is sent in steps 2 and 3: object:selection-changed(0, 0, 0) source: [table cell | B1] host_application: [application | soffice] sender: [application | soffice] Change-Id: I36505d56b032196fa084492a87a118f5366db1dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173255 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-12use more concrete UNO classes in connectivityNoel Grandin
Change-Id: I5c70278add0aa0b0c4a7680c6615b75b688f2180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173247 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-12no need to dynamic_cast so much in AccessibleTableShapeImplNoel Grandin
when we know the underlying object is a sdr::table::TableModel unfortunately this reveals that the underlying object does not, in fact, implement XSelectionSupplier Change-Id: I29336a7cf945dcec1a8d7aecc78f793e95bae259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-12use more concrete UNO classes in scriptingNoel Grandin
Change-Id: I4eddf7ccdf2d0720a4204e578c9f21d8c78dbd35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-12use more concrete UNO classes in comphelperNoel Grandin
Change-Id: I1a81d2264a450c23a5196f980e91a686f69edca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-12ICU: upgrade to 75.1Xisco Fauli
Downloaded from https://github.com/unicode-org/icu/releases/tag/release-75-1 Change-Id: I882c57bf5ab613dc71f7ae1c31305596e1ca791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168750 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-12Update Yellow Idea Impress templateLaurent Balland
- simplify Header/Footer/Page/Date elements - remove some unused styles Change-Id: Ie8c75f9dd8dafe9ecf16ffc820832a88391b3507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173048 Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> Tested-by: Jenkins
2024-09-12Simplify a bitMike Kaganski
Change-Id: Id46a5029ce86f20ffae34aa6495d7311044999a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173177 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-12tdf#162921 on this error dialog there is 'Abort' button, not 'Cancel'Andras Timar
Change-Id: I28b86fa7fa0175d5b9737854ad0ece4e3a00760e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173217 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-09-12Temporarily skip unit tests on native arm64 buildBalazs Varga
which indicating unit test fails. Change-Id: I2689b0dda888e15e52ca60cc18e1705a1aefe968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173143 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-09-12tdf#162884 writerfilter: map to built-in footnote style nameJustin Luth
This partial revert fixes a 24.2.4 regression from commit 72ea1005b987159a6a59f9379e63321e0b0dd44f Author: Michael Stahl on Mon May 6 15:58:36 2024 +0200 tdf#160402 writerfilter: extend StyleMap with all Word styles Footnote anchor character formatting is controlled by the character style set in Tools - Footnotes Settings. The default name of that style is UI dependent, so only the English UI was importing properly when the localized name was used in the mapping. "Footnote Symbol" is the internal name - both the internal name and the localized name are find-able at the same time, so the only things that will have a problem are things that don't connect to the style, but just hold the string name. The unit test change is also a revert from mstahl's commit. make CppunitTest_sw_ooxmlexport9 \ CPPUNIT_TEST_NAME=testTdf109310_endnoteStyleForMSO and is an indication of another problem that this fixes, namely that a new Footnote Characters style is added with each round-trip. Bug 162884 was only reproducible with a non-English UI. To reproduce, I compiled with autogen.input --with-lang=de Thus no unit test... Change-Id: I63d37f13f435ff7ec41d6b22d74db83dc495150a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173141 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-12tdf#149865: reduce size of sample fileXisco Fauli
Change-Id: Ic0751f22f3158536dc5753db2ea9f133692e0d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173213 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-09-12external: remove a couple of gcc9 patchesXisco Fauli
Baseline uses GCC 12 now Change-Id: Id9a0f79aa801aa342fd943cebeb0f528f4964d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173235 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-09-12use less dynamic_cast in svx table stuffNoel Grandin
we already statically know the types of all these objects Change-Id: I976dbf2b150fcd2176df18a07c2e9f21b1d2fe65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173214 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-12use more concrete UNO type in editengNoel Grandin
Change-Id: I5cad4808a1e5f10022f8a0441eb81a279d9b6386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173196 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-12These bogus -Wdangling-reference still hit with current GCC 15 trunkStephan Bergmann
Change-Id: Ice2be2156474cf486ad1c461d65e2711ebf43d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173232 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-12tdf#161256 gtk4 a11y: Don't crash on missing context or invalid child indexMichael Weghorn
If an `XAccessible` doesn't have a context or `XAccessibleContext::getAccessibleIndexInParent()` returns an invalid index of -1, don't crash/assert, but let `lo_accessible_get_next_accessible_sibling` return `nullptr`. This works around potential bugs in underlying `XAccessible`/`XAccessibleContext` implementations for now. This is meant to fix the assert/crash seen in the backtraces attachment 196363 and attachment 196383 from tdf#161256 which I cannot reproduce locally on Debian testing. Change-Id: Ic1779d875161469bf296c558039e19f1d426a259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173216 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-12tdf#91739 wina11y: Create AccObject for parent as necessaryMichael Weghorn
In `AccObjectWinManager::InsertAccObj`, when no HWND was explicitly passed, it is attempted to retrieve the HWND from the parent's `AccObject`. If no parent AccObject exists yet, create/insert that one first. This fixes the following assert seen when using NVDA's SayAll feature to read the whole document with sample document mentioned in NVDA issue [1], also attached as attachment 196385 in tdf#91739 for reference: Assertion failed: pIAccessible && "Couldn't retrieve IAccessible object for relation target.", file C:/tools/cygwin/home/user/development/git/libreoffice/winaccessibility/source/UAccCOM/MAccessible.cxx, line 2755 It's also reproducible when manually trying to get the next flows-to relation target via NVDA's Python console when the first cell in the table has focus: >>> focus.flowsTo The issue is not reproducible when focus had been in the second cell before, as an accessible object has already been created otherwise in that case. Backtrace: 1 abort ucrtbase 0x7fff3b72286e 2 get_wpgmptr ucrtbase 0x7fff3b7241b5 3 wassert ucrtbase 0x7fff3b7244f1 4 CMAccessible::get_relationTargetsOfType MAccessible.cxx 2755 0x7fff1e028729 5 NdrSendReceive RPCRT4 0x7fff3d4ca2d3 6 NdrStubCall2 RPCRT4 0x7fff3d4625a7 7 CStdStubBuffer_Invoke combase 0x7fff3cfbc4ac 8 RoGetAgileReference combase 0x7fff3cf669c3 9 RoGetAgileReference combase 0x7fff3cf6674e 10 HSTRING_UserSize combase 0x7fff3cfbefb6 11 DllGetClassObject combase 0x7fff3cf470b3 12 CoWaitForMultipleHandles combase 0x7fff3cf6774d 13 RoGetActivatableClassRegistration combase 0x7fff3cf2eb26 14 CoGetMarshalSizeMax combase 0x7fff3cf5cfba 15 CallWindowProcW USER32 0x7fff3ccbef5c 16 DispatchMessageW USER32 0x7fff3ccbe684 17 ImplSalDispatchMessage salinst.cxx 475 0x7ffed452d378 18 ImplSalYield salinst.cxx 552 0x7ffed452da9d 19 WinSalInstance::DoYield salinst.cxx 581 0x7ffed452cfa1 20 ImplYield svapp.cxx 385 0x7ffed78befc4 21 Application::Yield svapp.cxx 474 0x7ffed78c2cd2 22 Application::Execute svapp.cxx 361 0x7ffed78bc656 23 desktop::Desktop::Main app.cxx 1691 0x7ffeecf689b7 24 ImplSVMain svmain.cxx 228 0x7ffed78d3d4c 25 SVMain svmain.cxx 261 0x7ffed78d45a2 26 soffice_main sofficemain.cxx 121 0x7ffeecfb9064 27 sal_main main.c 51 0x7ff782681013 28 main main.c 49 0x7ff78268105a 29 __scrt_common_main_seh exe_common.inl 288 0x7ff782681344 30 BaseThreadInitThunk KERNEL32 0x7fff3bb07374 31 RtlUserThreadStart ntdll 0x7fff3d85cc91 [1] https://github.com/nvaccess/nvda/issues/8152#issuecomment-2342167620 Change-Id: I246251f06d1885e0da96600ffc7dd0549854382f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173224 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-12wina11y: Drop superfluous AccObject::m_pIMAcc null checksMichael Weghorn
The `AccObject` ctor already asserts it's non-null, so there's no need to check again in various places. Change-Id: Ibba363d326198a89e391a4da54cff25c95eef776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173223 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-12wina11y: Move var decl to first assignmentMichael Weghorn
... and rename to use the "x" prefix for this uno::Reference. Change-Id: Ibf422aa48d6fbada49975fa8c5f43ad6c4c3ddee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173222 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-12wina11y: Move var declaration to where it's assignedMichael Weghorn
... and rename the variable to use the "x" prefix in line with naming conventions. Change-Id: Ife49161162654efdf1d543909218e31e464d2fc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173221 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-12tdf#107184 sw: Added base text group feature to Asian Phonetic GuideJonathan Clark
This change adds a new button, Group, to the Asian Phonetic Guide. Clicking on this button will automatically merge all base text runs into a single base text run. Change-Id: I8bc2881f0c31d501f8a347156145a483bb4c96cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173241 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-09-12Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4a1a76e6b7c74f0903b7695f137160e4c7e622f7 - tdf#162607 Remove dup's in hid2file.js Standard filter + Deleted shared/02/12090000.xhp because 12090100.xhp has much more info and duplicates contents + rebuild links to reach 12090100.xhp + renamed references to Default filter to Standard filter. + add section to standard filter icon for embed purposes + refactor Change-Id: Ib88b7574fa12910c4cf9c8af9cbf79577b600e4b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173237 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f0cce1baf94f2645e5eac9bd3dbc72de359179b5 - tdf#162607 Remove dup's in hid2file.js, NewTableDialog + Removed bookmarks not appropriate + moved some <ahelp> to UI and deleted here Change-Id: Ic85a4c43cd4861cefa1bf67348d386464234ed65 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173236 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-11cid#1608244 Overflowed constantCaolán McNamara
Change-Id: I0af85988e04b479b7dae5d68a97bdc41332e9d7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11Add extended tips to newtabledialog.uiOlivier Hallot
Change-Id: I3ef67bfb5989ce12cb4d64ebff555d7b5fe8c8ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173226 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-09-11Bump to latest Glade - no changesOlivier Hallot
Change-Id: Ia447b0322b270915c1865f2d93473bc6b2a32291 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173225 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-11Update Growing Liberty Impress templateLaurent Balland
- remove duplicate picture (add a rotation) - simplify Header/Footer/Date/Page elements in Handout, Notes and Master slides Change-Id: I933294fce99614448317ef572552f57bb585bc9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173047 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2024-09-11use more concrete UNO type in svlNoel Grandin
Change-Id: I794fba1f111709e0469812d48eb81cc4dc1f11d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-11tdf#162899 Accept BYTE and SHORT types in the Solver Options dialogRafael Lima
ScSolverUtil::GetDefaults should also accept values of types BYTE and SHORT. It currently only accepts LONG. As described in the bug ticket, this is important when creating Solver extensions using Python, since pyObject2Any forces small integer numbers to be either BYTE or SHORT instead of LONG. Change-Id: I17c7a344777c31ea333a4d21a2543d2de0b448fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-11lok: sw: restrict deletions on comment only modeJaume Pujantell
On Writer, when in readonly mode with comments activated restrict the hability to delete comments to only those made by the same user. Change-Id: Iaefb1166c680726c9c73a305ef67be812d3b97d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172596 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f93d46429c68770dd432fa6e7edcfc876891f8e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172890 Reviewed-by: Andreas Mantke <andreas.mantke@googlemail.com> Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2024-09-11cid#1607469 Data race conditionCaolán McNamara
Change-Id: Id9d55ce38c9348c5f8da3ce65af0cd1e0da96196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173187 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-11cid#1607383 silence Overflowed constantCaolán McNamara
Change-Id: I61b233714e613128d84bb19539727ac5a620a425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11cid#1607403 silence Overflowed constantCaolán McNamara
Change-Id: I5edaf48b4d6fb42d73bc34c2a028f5372ecbdc45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173190 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11cid#1607412 silence Overflowed constantCaolán McNamara
Change-Id: Ie4ca362c936c8cbb4850d438e0bd6c2ed91f95d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173189 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11cid#1607446 silence Overflowed constantCaolán McNamara
Change-Id: I175a7b4808641797efec33151353d0164921aa86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173188 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11tdf#159032: minimize sample fileXisco Fauli
it still crashes if the fix is reverted. Also rename it since the filename is confusing See https://gerrit.libreoffice.org/c/core/+/161652/comments/14d0a095_4e005629 Change-Id: I1a629b8be171d17600024ebdc4ab0584af2342f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173197 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-11Related: tdf#158092 add a comment to avoid symbols localizationMike Kaganski
The localizable string is to allow different position/precision of the components; but the localization of the symbols themselves (decimal and thousand separator, currency) happens in code. This comment is shown in Weblate UI. Change-Id: Ib2f62fc8edf12ad3b182b40e3a8981c43b7ed67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173104 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-11curl: upgrade to 8.10.0Xisco Fauli
Downloaded from https://curl.se/download/curl-8.10.0.tar.xz Change-Id: I1eb9506a73162ce2e2adf1fe1e02267c34bc78ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173194 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-11use more concrete UNO type in frameworkNoel Grandin
Change-Id: I3ee54f3967339ab52c04f48a047bc29fc5161680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-11use more concrete UNO type in toolkitNoel Grandin
Change-Id: I3527b51948e6b23cc9448a2c98dbe2765cef48b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-11cid#1607478 Overflowed constantCaolán McNamara
aFormMap is std::pair<SwPosition, sal_uInt32> and GetTabIndex returns sal_uInt32, so change nCurTabIndex to sal_uInt32 and continue use of SAL_MAX_UINT32 Change-Id: Ie404e8b649f37f753f943f90a648114f080ed6b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11Related: tdf#129061 Avoid formula import and use fallback for nowMike Kaganski
Until we support the correct inline formulas, their import fails badly in Impress, because we completely lose them in boxes with other content, and even where they are the sole content, they stretch to the size of the box incorrectly. Commit 4038d6c393c3cf6330671124ba69cdba98b24960 (tdf#117658 PPTX import: fix duplicated math object handling, 2019-11-13) opted to enable the Choice variant from the AlternateContent representing formula boxes. This change switches to Fallback graphic, losing the option to edit standalone imported formulas, but instead, allowing to see the formulas as they were created in PowerPoint. Unit test in sd/qa/unit/export-tests-ooxml2.cxx, created in commit 331a0a347e2ed238ff41c8cd7815b946cc95ac0f (starmath: fix OOXML export of non-BMP Unicode, 2016-01-21) was changed, because it depended on importing the formula from PPTX, which is disabled here. Since it was fixing the export part, the FODP source seems to be a reasonable replacement. Change-Id: Ibd0e2bcd68296020c3bc057cb6a563918926cf2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-11cid#1607652 Overflowed constantCaolán McNamara
Change-Id: I624949cf61caa1f4448375208a3d3db2315c43cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173162 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-11tdf#161007: Report Builder Wizard failsJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=161007#c7 Change-Id: Ide92b70f9006e229b59fab0c3eacfb37e0625ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173186 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-11cid#1607586 Overflowed return valueCaolán McNamara
doesn't make sense to compare to std::numeric_limits<sal_Int64>::max here, while sal_Int32 does Change-Id: Ic19beb6c2a0a46c5b45d37e833d566d91ddc10cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173161 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-11use more concrete UNO type in packageNoel Grandin
Change-Id: I95283bf49b8966d73035dd718fbcfcbdcacc78c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-17 07:07:09 +0000