Age | Commit message (Collapse) | Author |
|
Change-Id: I7655f6809c113a944df9a6db445803769155f3f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88849
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
(lexicographically, by Unicode code point values; to make it easier to add
further entries)
Change-Id: I4f5302d97555d22c043017c9bc289cc323b5c59f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88848
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...after b2945902e7a0ad9f033fe67f5ab217d6e31d8d84 "Avoid explicit casts to
smaller sal_uInt16 from larger long": As Mike Kaganski reported at
<https://gerrit.libreoffice.org/c/core/+/87442/2#
message-bc3d33b177eecba4255e299ac92c2f0c1712b57d>, clicking on "Templates" in
the start center causes the assert to fire at
> #3 0x00007ffff6296a66 in __GI___assert_fail
> #4 0x00007fffe6b11df8 in _ZN4o3tl13make_unsignedIlEENSt9enable_ifIXsr3stdE11is_signed_vIT_EENSt13make_unsignedIS2_E4typeEE4typeES2_ (value=-1) at include/o3tl/safeint.hxx:233
> #5 0x00007fffe6ad75f6 in ThumbnailView::SelectItem(unsigned short) (this=0x61a0000fc680, nItemId=1) at sfx2/source/control/thumbnailview.cxx:1011
> #6 0x00007fffe6ade62c in ThumbnailView::GetFocus() (this=0x61a0000fc680) at sfx2/source/control/thumbnailview.cxx:838
> #7 0x00007fffc27c292b in vcl::Window::CompatGetFocus() (this=0x61a0000fc680) at vcl/source/window/window.cxx:3895
> #8 0x00007fffc226604e in vcl::Window::ImplGrabFocus(GetFocusFlags) (this=0x61a0000fc680, nFlags=GetFocusFlags::NONE) at vcl/source/window/mouse.cxx:378
> #9 0x00007fffc2738071 in vcl::Window::GrabFocus() (this=0x61a0000fc680) at vcl/source/window/window.cxx:3029
> #10 0x00007fffe6c4a529 in BackingWindow::ClickHdl(Button*) (this=0x6190005e8880, pButton=0x61800031a080) at sfx2/source/dialog/backingwindow.cxx:585
> #11 0x00007fffe6c3c1eb in BackingWindow::LinkStubClickHdl(void*, Button*) (instance=0x6190005e8880, data=0x61800031a080) at sfx2/source/dialog/backingwindow.cxx:535
> #12 0x00007fffc2937f72 in Link<Button*, void>::Call(Button*) const (this=0x61800031a328, data=0x61800031a080) at include/tools/link.hxx:111
> #13 0x00007fffc291c13c in Button::Click()::$_0::operator()() const (this=0x7fff8c0ce0a0) at vcl/source/control/button.cxx:123
when mnFirstLine and mnVisLines are both 0. (And nNewLine is 0 because nItemPos
is 0. An alternative fix might be to replace
else if ( nNewLine > o3tl::make_unsigned(mnFirstLine+mnVisLines-1) )
with
else if ( nNewLine >= o3tl::make_unsigned(mnFirstLine+mnVisLines) )
but that would then set
mnFirstLine = static_cast<sal_uInt16>(nNewLine-mnVisLines+1);
to 1 instead of leaving it at 0, which is probably not wanted.)
Change-Id: I5b61cd25d52048e2cb2cf64f646d8ba9dd10adb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88847
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
... and SwPrintOptions
See tdf#94879 for motivation.
Change-Id: Ic99281a5a093b707dc271d0710b1bf6e5fc65807
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88845
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I218812c865e0474bffe43f97a596a0051d51445e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88591
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I74b65394367a11a07d104bfbab6afbfe49919b3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88336
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8fdcba471f3497545b7542f38a8fcb2ad40a4cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88821
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 43d879530fbcb1d073dc35627fa6c45d54aeb64a
- Fix English in some more strings
Change-Id: I4595da6a8db44aaf59d3ea3b4d6caff69c3f53c4
|
|
Edit field has type normal or error now
Edit field and okay button return feedback per tooltip
Change-Id: Ib2caf3280227cb00af25889ed111503745b471dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85101
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
because these are all on the hot path, and in the best case, with
enough inlining, the compiler can skip the call altogether and just
do a locked CMPXHG instruction
Change-Id: I099d6385f602e40e1767f9f1002b7514ecf436e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia972e95e88b4470576571e20221316c2abc93443
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88838
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I5e0a194698a85e81089a929a0979e2b4022555e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88612
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
File->Reload was displayed with a checkbox, suggesting the command would toggle something.
Of course it does not.
So remove this code which makes the command appear as toggle command.
Change-Id: I5dd87fd82524e211e0d3444b14bc22dc4469de2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88731
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
The parameter introduced in 26bcfbe48b30e0a525a0f25b73ddcacdd158256b
was unused.
Change-Id: Iee928520bb1a4033cf10f0ca60c687b73d09aaf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88829
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Change-Id: I9ec38d517d176ecd8dad074f3d96769f85eec311
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88745
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Seems the color widget was changed into a tree at some point, so
the entry amount is now in "Children" instead of "EntryCount".
Change-Id: Ief6e6d0ebc4a6571a7f7e978b838eb49b2e051cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88831
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
JunitTest and PythonTest modules check for these themself.
Change-Id: Ia453bc99571738b01cc8f161f346cb6c37b2e429
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88832
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Use start index from current loop variable, not full range; otherwise
we're always clobbering values from (possibly higher) upper rows.
Change-Id: I3add7c2358710f4ae3927e7b0a1c1ff544965a03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88785
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Ic40c1241854bdbcdf7987ab592e0f07ecdd73f0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88823
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
A less-than-zero check for an unsigned value of type size_t
doesn't make sense, and:
If the return value of fwrite differs from the count parameter,
it means that a writing error prevented the function from completing.
In this case, the error indicator (ferror) will be set for the stream.
Change-Id: I344e608b2bc03a4a117fc5cca1acb8e26eda247a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88817
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: If4e891742a59eb975be8353510dad71cadc546e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88671
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: If67a7c21b04f7195e8cbab6d90d1dd24426b5dea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88752
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Update dictionaries from branch 'master'
to 6e60b3ca21fb031486fd35572156232dc6da4c0c
- Updated Afrikaans dictionary
Change-Id: I778714df63b70d9beacc2e48dc538afe88fd1c5f
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/88773
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I06a4049d84d3ef755b713c045f686361782bdfc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88807
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7ba2523f537542d71af62f47acf0f6b3ee4acde3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88815
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic9aba102f7a6ac2112cf1f6d1c2f0a0b1beb8c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88814
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id5298615f0f3dad6e61955e23367c0345b33f2b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88813
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib1b374539f6ab70d3df3a36fc6bc99503eecd1fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88809
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: I1353634e9e5e65dd080daf7304d5e8a16bc77e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88808
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: Iab5e210199948b2fbe9cca2f2ff6a36341a6c1c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88780
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: I09afa3504312ba25c2d4b2292e818bc7648b07c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88812
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1ef4037e02e9b678bf5e5ce014174fb1c57ef456
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88806
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8e6bbff8f8d6fa71f71dbbef7ec498ea22d7212b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88740
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
...after <https://github.com/llvm/llvm-project/commit/
9ce6dc9872be4081fb98f6161c28581e1cbbe7dc> "CWG1423: don't permit implicit
conversion of nullptr_t to bool." (Direct-initialization from std::nullptr_t to
bool is allowed in C++17, but it appears that will be dropped from C++20, see
<https://github.com/cplusplus/draft/commit/
df3e38121431afd9adcf7dce725a670a235463ea> "CWG1781 Converting from nullptr_t to
bool in overload resolution", at which point the new check for initialization of
S::b and the res.isNullPointer() branch in ConstToBool::VisitImplicitCastExpr,
compilerplugins/clang/consttobool.cxx, will probably become moot.)
Change-Id: I99773d13d514d5ba5296843592b740ea949b2b1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88784
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes.html
Change-Id: I2377679bb925425ceb0bf80c5309005421fe2c2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88778
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1a45fbfad2fb8eee6f29e895beea4e508f65febe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88781
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I6b2e99a6485031e33c781be896e9426fffd08edf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88779
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
See instructions in solenv/gbuild/Trace.mk . This generates a file than
can be viewed e.g. in the Chromium tracing view.
Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The #ifdef on debug level got reduced to normal debug builds
as an Easy Hack in f0de4374fffe7f, but that means that the green
debug lines are now drawn in all debug builds. The frame info
debug text is at least obviously debug output, but "random" green
lines look like drawing problems, so disable them, unless
explicitly asked for.
Change-Id: I56ebc799ca72565cabee35552c4bd2641e2393c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88713
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
...after abc0344a234567aee0edcb4523036758d966481d "convert conststringvar plugin
to shared infrastructre", causing errors like
> [C ] cppuhelper/source/findsofficepath.c
> Assertion failed: (Ctx.getLangOpts().CPlusPlus), function isCXX11ConstantExpr, file llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 14567.
> Stack dump:
[...]
> 6 libsystem_c.dylib 0x00007fff7266ca1c abort + 120
> 7 libsystem_c.dylib 0x00007fff7266bcd6 err + 0
> 8 clang 0x000000010b857ca3 clang::Expr::isCXX11ConstantExpr(clang::ASTContext const&, clang::APValue*, clang::SourceLocation*) const (.cold.2) + 35
> 9 clang 0x0000000109f7497e clang::Expr::isCXX11ConstantExpr(clang::ASTContext const&, clang::APValue*, clang::SourceLocation*) const + 1022
> 10 plugin.so 0x00000001182741ab loplugin::SharedRecursiveASTVisitorBasic::VisitVarDecl(clang::VarDecl*) + 1051
[...]
> clang-11: error: clang frontend command failed due to signal (use -v to see invocation)
Change-Id: I18c37dba294b0effd85bead8aa6e5679f77502d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88777
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic2a4340972ad29305dadc56a33081a211cc0205b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88758
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
Tested-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I702c09bcd3a9a113b3d66c30edb6cf3b7e6a6593
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88776
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I06087a1385ca9da6a28d36ea4c0d2e40bdbf8f03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88774
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to e57ef3624253ee7108914532d5e06d61b42c254c
- tdf#130619 add help about quickstarter
- made sys-conditional (only for WIN)
Change-Id: I1c19727b98eb07bd3300de51775adf11f1bb7c07
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88704
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 2896f2eba4561b0d9e9c7dfc88cb00e22fb38807
- Content fixes after translation round
Change-Id: Icdb80c6e659e81492e3b9c43afd0f49cbea0ed86
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88772
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I3a725e4681c11f503dae57436b05b5a80ff2979c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88764
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia60d23c7a75086c2a68e0e295b99a3df3dfd164f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88771
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: Idc890cac4bb6aed4e36c3556a2abc0744fd086df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88770
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Thanks to Valter:
https://listarchives.libreoffice.org/global/l10n/msg12412.html
Change-Id: I2b79bc19de31b014cbf2519ae01e5214252f24a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86505
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|