summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-27Various -Werror,-Wvla-cxx-extensionStephan Bergmann
...as enabled by default now in recent Clang 18 trunk Change-Id: I59f9bbdf2ce064f170df01e6d7ec2341884ab5e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-27tdf#152571 speedup slow draw file saveNoel Grandin
with lots of images, we seem to spend lots of time calculating CRC. Replace the vcl checksum/CRC with rtl_crc32 in sal/, which forwards to the zlib implementation, which has all kinds of nice SIMD code for performance. Change-Id: I295e2ee91b3450fa558b06e67aac0fbb20b85f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-27fix erase logic in SkiaSalBmp::BlendWithNoel Grandin
regression from commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Author: Noel Grandin <noelgrandin@gmail.com> Date: Fri Apr 16 20:33:10 2021 +0200 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: I5cefa51c96d412f43f73277b590fd861397eb1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-27merge these checks together to avoid duplicationCaolán McNamara
Change-Id: I2821a48696a1661fa6e7cf94fc1649c51f2b4e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158564 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-27lok: a11y: impress: help screen reader to report shape selectionMarco Cecchetti
Refactored LOKDocumentFocusListener::notifyEvent. Implemented 2 new callbacks: - LOK_CALLBACK_A11Y_EDITING_IN_SELECTION_STATE: it says the client if editing in a shape or cell is active or it isn't. - LOK_CALLBACK_A11Y_SELECTION_CHANGED: it says if a shape has been selected/unselected, the name of the shape and text content are sent too for being reported by a screen reader. (cherry picked from commit 76899152ec3d1924cc72d2b869e197a1e34a0a1a) Conflicts: sfx2/source/view/viewsh.cxx Change-Id: I644bcc7daeb8772805688a9bccdabd0631ce0a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158562 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-27tdf#157930 sc: Add easy to use conditional formatting menuParis Oplopoios
Add menu options that open a dialog that can add conditional formatting in a cell range with common options. Change-Id: Ia54baba08e4b78c4c6e37fa7bff744af8cf06037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156831 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-10-27calc comment boost::property_tree::ptree use quotes comment id numbersCaolán McNamara
which does not conform to JSON standard and means that added/deleted comment ids are strings and not numbers as created by the related getPostIts found during: https://github.com/CollaboraOnline/online/issues/7334 where if the regular updating of comments via getPostIts doesn't happen then deleting/adding comments doesn't appear to work boost bug report found as: https://svn.boost.org/trac/boost/ticket/9721 https://marc.info/?l=boost-bugs&m=139351272302586&w=2 Change-Id: I0c43588ce1f92b83fb82c582f0c2c18a6672dc54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-27gtk4 a11y: Implement GtkAccessibleRange ifaceMichael Weghorn
Implement the `GtkAccessibleRange` range interface [1] added in gtk 4.10, which is bridged to the AT-SPI Value interface on Linux inside gtk. Also set the related properties to their values retrieved from the `XAccessibleValue` interface. (Those already existed before gtk 4.10.) The GType handling for implementing the interface only if the `XAccessibleContext` of the underlying LO a11y object implements `XAccessibleValue` is mostly copied over from the gtk3 a11y implementation (in vcl/unx/gtk3/a11y/atkwrapper.cxx) and adapted a bit. Let `lo_accessible_range_set_current_value` always return true independent of whether the given value was actually set, since LibreOffice (together with Accerciser) otherwise crashes due to no proper DBus reply being sent, when trying to set a new value via AT-SPI API, s.a. [2] and [3]. When setting a new value, take the type of the current value into account, as done for gtk3 in commit a0b7b47e3ec843d8012a7526c1e8e72d67cc41b1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 24 12:29:54 2023 +0200 gtk3 a11y: Take current type into account when setting new value With this change in place, the AT-SPI Value interface is now shown as available for a checkbox form control in a Writer doc when selecting the corresponding a11y object in Accerciser's tree view of the LO a11y hierarchy. When changing the value via Accerciser, the checkbox in LibreOffice gets (un)checked as expected. (Setting the value to 1.0 causes the checkbox to be checked, 0.0 to become unchecked.). The initial values (current value, min and max value) are set properly. However, when querying the current value after changing it, the initial value is still returned. This likely needs to be addressed by bridging the corresponding `AccessibleEventId::VALUE_CHANGED` event to Gtk/AT-SPI by calling `gtk_accessible_update_property` with the new value. However, there's currently no implementation for handling a11y events in the gtk4 VCL plugin yet, so leave that for later. More interfaces to expose more functionality to the a11y layer will likely be implemented in upcoming gtk versions (like an interface for Text [4]) and bridging those should presumably be possible in a similar way. [1] https://docs.gtk.org/gtk4/iface.AccessibleRange.html [2] https://gitlab.gnome.org/GNOME/gtk/-/issues/6150 [3] https://gitlab.gnome.org/GNOME/gtk/-/commit/0dbd2bd09eff8c9233e45338a05daf2a835529ab [4] https://gitlab.gnome.org/GNOME/gtk/-/issues/5912 Change-Id: I84136fd80361d21cf4f79ab17118bb14079ab785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158556 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-27Step 2 of removing cargo-cult pragma pack around rtl_[u]StringStephan Bergmann
see 8ae3ae4bf75fdd0aaa132c956d9da029baa3adc6 "Step 1 of removing cargo-cult pragma pack around rtl_[u]String" Change-Id: Ie9140b92da8895c4991a7f449359bb1747fdb23d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158553 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-27remove unused vcl_get_crc64_tableNoel Grandin
Change-Id: I8ebc2473884ad991a704c7e0955f262bccbf6dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-27tdf#157937 sw: fix freezing of cycle case on tracked changesLászló Németh
Add loop control to avoid never-ending iteration on selected text with tracked changes, where transliteration can result empty strings. Regression since commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9 "tdf#109266 sw change tracking: track transliteration". Change-Id: Ia5f92adfdda33562b4d1abe72c51134be8304639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158525 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-10-27jsdialog: send smaller messages for comboboxSzymon Kłos
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ib514607ad56b965c33439ad548ec90d516acfcf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158345 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit 9e2da48ec3dbe541ff52f6d69f98afb57afaac3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 53e7511706a73d0336ce183f614d53469836ef64 - tdf#155876 UI cmds Calc-View menu (07) + refactoring Change-Id: I766345780bb12a3ba9d9c8c3135f77d4d04bc78d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158519 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b41eeeaaa91ed78e387cfed551400984836164af - tdf#155876 UI cmds Calc-View menu (06) + refactoring Change-Id: Ic6a1cf590f8952ef82e540459603a0a499732ecf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158518 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-27At least use the oldest available -std:c++14 for MSVC gb_CXX03FLAGSStephan Bergmann
...if we don't have a proper -std:c++03 available Change-Id: Iffef738be486b402a2b6af1a2761eb905ac4ddf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-27tdf#157096: sw_layout: Add test for CRASH removing everything in documentOmkarAcharekar
Change-Id: I07fde27e71f112019532c57d90f46568af45fad9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158458 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-27tdf#156593 FILEOPEN OOXML: image shown in full instead of croppedBalazs Varga
Revert "Revert "tdf#118133 DOCX import: disable lazy-loading of tiff images"" This reverts commit c6bf16909db054ec5467ebdc0ea0c9dc07307048. Lazy-loading doesn't work with cropped TIFF images, because in case of Lazy-load TIFF images we are using MapUnit::MapPixel, but in case of cropped images we are using MapUnit::Map100thMM and the crop values are relative to original bitmap size. Change-Id: I2dbf6caf08d7899ec2eae683996d997809d62b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158509 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27Explicitly build the ODK examples against C++03Stephan Bergmann
...similarly to how CppunitTest_odk_checkapi already builds with C++03 to detect inadvertent uses of newer features in code that is meant to be still compatible with C++03. And fix any uses of newer features that had already crept in. Change-Id: I9fb4013099c1dff2c1ad5fba8fc93d9aa4efbde8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158523 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-27Clarify that o3tl::cmp_* is still needed for LLVM 12 libc++ for nowStephan Bergmann
...which is apparently used by Android builds, so <https://gerrit.libreoffice.org/c/core/+/158513> "Directly use std::cmp_*, drop o3tl::cmp_*" cannot go in, yet Change-Id: If8b3ef1e647b6e33c43d0fe5737daf63eda0b761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158524 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-27tdf#99822 sw floattable: allow nomimal overlap of objects from different cellsMiklos Vajna
The bugdoc had a table with a single row and 2 columns, both cells had too wide content. The first column had a too wide chart and the second column had a too wide (multi-page) floating table. What happened is that SwTabFrame::Split() wanted to recalc the split row, and there the overlap detection code pushed down the 2nd shape to the next page, but that next page only contained the 2nd shape, so the shifted down shape wanted to go up to its original position and this way the "format all content lowers" iteration in SwContentFrame::CalcLowers() never returned. Fix the problem by limiting the overlap detection to the same uppers, i.e. in case two floating tables are anchored in the same cell (the anchors have the same upper) to avoid the overlap, but in case the anchors have different uppers, then don't worry about this. This seems to match what Word does. Regression from commit 5127b1961b762643d47a26704556fd9b8664c6fc (sw floattable, nesting: add DOCX import, 2023-09-13), the original problem was already solved by 63007619da7e6c4a6d0c466a8fe54324252be14b (tdf#144798 DOCX import: handle ZOrder of chart objects, 2021-10-18), it seems. Change-Id: I21b9f0ae53bbc69d54a9a9f6870580e3a748ba7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-27tdf#157854 - UI: Part 12 - Unify lockdown behavior of Options dialogBalazs Varga
for Internet Proxy Page. Change-Id: I2332d272905e12a235d7729c0565922ad98960f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158499 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27tdf#157853 - UI: Part 11 - Unify lockdown behavior of Options dialogBalazs Varga
for Advanced Page. Change-Id: I3ef33e98cd5a39313f51eb90682f20cdc172f042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158496 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27tdf#157850 - UI: Part 10 - Unify lockdown behavior of Options dialogBalazs Varga
for Online Update Page. Change-Id: I48f66f786c165d3958d34cca17ee2837aa7a6c66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158490 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27jsdialog: don't send update in toolbox when not modifiedSzymon Kłos
Change-Id: I74087b54f9844ea5d22de03caf8724d38d525646 (cherry picked from commit 9d44086770d9a1c625d42676033f47a698dfa572) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158446 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-10-27jsdialog: enable simple conditional formatting dialogSzymon Kłos
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id9dad789bb772f7454f4bb35c42f4fde4d9a89c4 (cherry picked from commit fc2e0b49a6fa69a116e7a43c3c6ecb428a88f4c7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158447 Tested-by: Jenkins
2023-10-27Add flags to STYLEREFSkyler Grey
This commit is part of an implementation for the following STYLEREF flags - Search from bottom to top, which sets the STYLEREF field to search downwards first, or from the bottom of the page in marginals - Hide non numerical, which hides all characters that are not either numbers or punctuation commonly used as delimiters. For example, if your STYLEREF said "Chapter 2.1", this setting would make it say "2.1" This commit implements: - The document model - The layout - The UI Change-Id: I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158349 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-27sw floattable: fix nullptr deref in TableManager::endLevel()Miklos Vajna
This is never an empty reference in the interesting use-case, so just make sure we don't crash. Reported to be a regression from 2d43c34333076fad092f0cdc0f60f81580acdbee (Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at cell start, 2023-09-15). See <https://crashreport.libreoffice.org/stats/signature/writerfilter::dmapper::TableManager::endLevel()>, e.g. <https://crashreport.libreoffice.org/stats/crash_details/84c2a273-49a3-4e62-9cfe-5cd620767749>. Change-Id: I4cd9c35ae3813a67d13d9b9e60f0dd6058f510c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-27sw layout xml dump: move SwFrame::dumpChildrenAsXml()Miklos Vajna
Next to the rest of the SwFrame code. So it's more likely that it gets updated as SwAnchoredObject changes. Change-Id: I83343abf495832265ac7634bb7b31de89b63f039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158511 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-27Drop rTokenName argument from SvgNode::parseAttributeMike Kaganski
It was never used. Change-Id: I8bc7d625977a6cdc8fe6863037e72577dbfc46c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158493 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-27Commit 04c78e1a46a423071d7ea68724525ec7ef92e0e8 follow-upMike Kaganski
Drops duplicating map, and uses std::find_if with case-insensitive comparison. Likely to have some performance impact, but avoids the maintenance penalty of two maps. Change-Id: I7144556488aa134d9b9214b00ba9d7c4e0fb68a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154159 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-27vcl: flatten OutputDevice::BlendBitmap()Chris Sherlock
Change-Id: Idb0c21dd37af81fae0fd4152f0556edb20e63b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157190 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-27vcl: flatten OutputDevice::GetBitmapEx()Chris Sherlock
Change-Id: I85e7767cd2665febd289cc1fd023d30ab80cfe5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157191 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-27vcl: move textlayout.cxx from gdi to text directoryChris Sherlock
Change-Id: Ia8efd1d984c94b4fa6d77759fa8c8ec8834ac140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157415 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-27vcl: flatten TextLayoutCommon::GetEllipsisString()Chris Sherlock
Change-Id: I04a5eed7a6fbd2d4c7f31006c73729cf79a2ed02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157367 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-27tdf#156988 chardlg: default to AUTO escapementJustin Luth
As of 24.2, the default value for a superscript or subscript is automatic placement since d384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8. Therefore, it makes sense for the character properties dialog to also default to automatic. Normally this happens - since normally there is some kind of context, and in that case m_xNormalPosBtn was set with AUTO (m_xHighLowRB). However, in the case of finding a formating, there is no context for the very first run. That is what this patch intended to fix, since in that case too we want m_xHighLowRB to be set to true. For any other similar situation where there is no context, assuming DFLT_ESC_AUTO_SUPER or DFLT_ESC_AUTO_SUB should be appropriate. Change-Id: I1ee78c72bbb1c3d23fa39da29322436632f12b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158514 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-26cool#6893 cache the process component contextNoel Grandin
which we look up rather a lot Change-Id: Ie8bcf161a1d7a299a404f749cf08a13f33f7f1cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-26Update git submodulesStéphane Guillou
* Update helpcontent2 from branch 'master' to bcef222378f8d2225596ea624f9c82e9cb48a01d - add link to langpack downloads Change-Id: I237e89e0263cdf27105cf4395d2272f9d96e2235 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158444 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-26Replace use of "Calibri" and "Calibri Light" with "Noto Sans"Stephan Bergmann
...in CppunitTest_chart2_xshape, which had caused <https://buildbot.flathub.org/#/builders/6/builds/75165> to fail with > diff.cxx:324:Assertion > Test name: Chart2XShapeTest::testTdf149204 > assertion failed > - Expression: valInTolerance > - 3511; Found Value: 3485; Tolerance: 1; Relative: 0 > > diff.cxx:265:Assertion > Test name: Chart2XShapeTest::testPieChartLabels1 > double equality assertion failed > - Expected: 8383 > - Actual : 8399 > - Delta : 1e-08 > - Reference: /run/build/libreoffice/chart2/qa/extras/xshape/data/reference/tdf90839-1.xml > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[2] > - Attr: positionX > > diff.cxx:324:Assertion > Test name: Chart2XShapeTest::testPieChartLabels2 > assertion failed > - Expression: valInTolerance > - 3124; Found Value: 2966; Tolerance: 1; Relative: 0 > > diff.cxx:324:Assertion > Test name: Chart2XShapeTest::testPieChartLabels3 > assertion failed > - Expression: valInTolerance > - 3124; Found Value: 2966; Tolerance: 1; Relative: 0 > > diff.cxx:324:Assertion > Test name: Chart2XShapeTest::testPieChartLabels4 > assertion failed > - Expression: valInTolerance > - 2768; Found Value: 2531; Tolerance: 1; Relative: 0 Change-Id: I518d37bedf7d8738396e05011223bd970786a45a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158377 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-26Use std::from_charsStephan Bergmann
(which also makes readInt32 report failure, instead of running into UB, when the read value is out of range) Change-Id: I8449e4fe696c9b0ab5b868127ef517dc080c31ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158489 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-26cool#6893 improve listeners in SfxBaseModelNoel Grandin
reduces CPU spent in UNO query'ing, and adds type-safety, which exposed a bug in SfxBaseModel::disposing Change-Id: I4b973f7dc38f491ce7a6281ad378e439b5450add Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-26tdf#157897 - Clear print ranges before adding additional onesAndreas Heinisch
Otherwise, additional print ranges will be added for linked files after the external link will be updated. Change-Id: I0556fda6609d3e18f1ca992dc6a0399be01bc841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158365 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-10-26gtk4 a11y: Map checkbox role to gtk equivalentMichael Weghorn
This makes a checkbox form control in a Writer document show up with the proper role in Accerciser, no longer as a filler. Change-Id: I5566d27ecfbe9ec54dcfbf20693899b72d3af738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158505 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-26null-deref seen in ScTabView::UpdateEditViewCaolán McNamara
#0 0x00007f2bcc41df63 in ScViewData::GetCurYForTab (this=this@entry=0x3502d0b8, nTabIndex=nTabIndex@entry=6) at libreoffice/sc/source/ui/view/viewdata.cxx:1443 #1 0x00007f2bcc3ebf02 in ScTabView::UpdateEditView (this=this@entry=0x3502d0b0) at libreoffice/sc/source/ui/view/tabview3.cxx:2185 #2 0x00007f2bcc3ec636 in ScTabView::UpdateFormulas (this=this@entry=0x3502d0b0, nStartCol=nStartCol@entry=-1, nStartRow=nStartRow@entry=-1, nEndCol=nEndCol@entry=-1, nEndRow=nEndRow@entry=-1) at libreoffice/sc/source/ui/view/tabview3.cxx:2327 #3 0x00007f2bcc40735c in ScTabViewShell::Notify (this=0x3502cf20, rBC=..., rHint=...) at libreoffice/sc/source/ui/view/tabvwsh5.cxx:216 #4 0x00007f2bdc1885a9 in SfxBroadcaster::Broadcast (this=this@entry=0x31e31430, rHint=...) at libreoffice/svl/source/notify/SfxBroadcaster.cxx:40 #5 0x00007f2bcc022e6d in ScDocShell::PostDataChanged (this=this@entry=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh3.cxx:95 #6 0x00007f2bcc0101aa in ScDocShell::SetDocumentModified (this=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh.cxx:3015 #7 0x00007f2bcc010df3 in ScDocShellModificator::SetDocumentModified (this=this@entry=0x7fff2d168da0) at libreoffice/sc/source/ui/docshell/docsh.cxx:3330 #8 0x00007f2bcc040c1a in ScDocShell::MoveTable (this=this@entry=0x31e31430, nSrcTab=<optimized out>, nDestTab=<optimized out>, bCopy=bCopy@entry=false, bRecord=bRecord@entry=false) at libreoffice/sc/source/ui/docshell/docsh5.cxx:1010 #9 0x00007f2bcc441a41 in ScViewFunc::MoveTable (this=this@entry=0x333d0fe0, nDestDocNo=nDestDocNo@entry=0, nDestTab=nDestTab@entry=7, bCopy=bCopy@entry=false, pNewTabName=pNewTabName@entry=0x7fff2d169068) at libreoffice/sc/source/ui/view/viewfun2.cxx:3117 #10 0x00007f2bcc418459 in ScTabViewShell::ExecuteTable (this=0x333d0e50, rReq=...) at libreoffice/sc/source/ui/view/tabvwshf.cxx:593 #11 0x00007f2bdbd3d96f in SfxDispatcher::Call_Impl (this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., bRecord=<optimized out>) at libreoffice/sfx2/source/control/dispatch.cxx:254 #12 0x00007f2bdbd427ee in SfxDispatcher::Execute_ (this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., eCallMode=eCallMode@entry=SfxCallMode::RECORD) at libreoffice/sfx2/source/control/dispatch.cxx:753 #13 0x00007f2bdbd45a33 in SfxDispatcher::Execute (this=0x33379ed0, nSlot=<optimized out>, nCall=nCall@entry=SfxCallMode::RECORD, pArgs=pArgs@entry=0x7fff2d1694a0, pInternalArgs=pInternalArgs@entry=0x7fff2d169460, nModi=nModi@entry=0) at libreoffice/sfx2/source/control/dispatch.cxx:813 #14 0x00007f2bdbd83c0f in SfxDispatchController_Impl::dispatch (this=<optimized out>, aURL=..., aArgs=..., rListener=...) we have nulls in here for hidden sheets Change-Id: I8f1295e67552f3ec9306a031aaecd0838e18d98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-26No --without-fonts gb_CppunitTest_set_non_application_font_use,*,abortStephan Bergmann
...which had caused an (explicit --without-fonts) Fedora build to hit the std::abort in PrintFontManager::Substitute (vcl/unx/generic/fontmanager/fontconfig.cxx) during CppunitTest_sd_import_tests-smartart's testTdf134221::TestBody, apparently for some aTargetName = "DejaVu Sans" Change-Id: I3b050eb3225595e6ce22a8df22dbb11f920cac4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158492 Reviewed-by: Dan Horák <dan@danny.cz> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-26tdf#153519 use new IdleTask::waitUntilIdleDispatchedNoel Grandin
to wait until the Idle inside sw/ has done populating the navigator tree. Which required (*) moving the code down from test/ to vcl/ to avoid circular dependency issues. (*) adding a call SolarMutexGuard before Application::Yield inside IdleTask::waitUntilIdleDispatched (*) exposing the function to python by adding a method to the XToolkitExperimental UNO API Change-Id: Iee418f7a0beb1f5b53addb7fe25823d61720eb3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-26crash seen in Window::ImplTrackTimerHdlCaolán McNamara
#0 vcl::Window::ImplTrackTimerHdl (this=0x3403b0a0, pTimer=<optimized out>) at libreoffice/vcl/source/window/window2.cxx:231 #1 0x00007f2bdd31f5e7 in Scheduler::CallbackTaskScheduling () at libreoffice/vcl/source/app/scheduler.cxx:485 #2 0x00007f2bdd4e5176 in SalTimer::CallCallback (this=<optimized out>) at libreoffice/vcl/inc/saltimer.hxx:54 #3 SvpSalInstance::CheckTimeout (this=this@entry=0x261ef40, bExecuteTimers=bExecuteTimers@entry=true) at libreoffice/vcl/headless/svpinst.cxx:212 #4 0x00007f2bdd4e713d in SvpSalInstance::ImplYield (this=this@entry=0x261ef40, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at libreoffice/vcl/headless/svpinst.cxx:453 #5 0x00007f2bdd4e74a0 in SvpSalInstance::DoYield (this=0x261ef40, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at libreoffice/vcl/headless/svpinst.cxx:525 Change-Id: I66ec56603aeb8a7fe855253b961dafb0bc7b875e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158441 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-26add warning for suspicious potential double-trackingCaolán McNamara
Change-Id: I0fa7b2a108350a394b5d774aaed899215bdb20de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-26tdf#157083 Artifacts in logos (gen)Noel Grandin
regression from commit commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Author: Noel Grandin <noelgrandin@gmail.com> Date: Fri Apr 16 20:33:10 2021 +0200 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: I1c269bcfa9b565258bc99c2810e960ae965f9b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158491 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-26sw: fix comments in SwRootFrame::CalcFrameRects()Michael Stahl
Change-Id: I1af7fd09bb2d3636b97825724a988e7912a3653b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158428 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-26tdf#157846 - UI: Part 9 - Unify lockdown behavior of Options dialogBalazs Varga
for Accessibility Page. Change-Id: I4705904200715c1e41849a47a3dd684ddfa219c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158425 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-05 03:24:47 +0000