summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-20simplify usage of TempFile in scNoel Grandin
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: Icab41d12ab7846b8901a92c11fee05952b98fafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20tdf#112237 Show tooltips for Assigned Commands in Customize dialogJim Raykowski
Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-19Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 80034ff19535b6320a8ea113a9cf2f068e6aea31 - Wrong words Change-Id: I391a5fd97005fcffac324581856bbdb8a48f1ae9
2022-09-19tdf#132519: sc_ucalc_formula: Add unittestXisco Fauli
Change-Id: Ie2ff5a8961556cf21ca75a58d46f37754e0bb61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140183 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19tdf#151046: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I552d53f511373b170985185361621d8e149e582b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19loplugin:unreffun (clang-cl)Stephan Bergmann
...and with ScopedFontHDC::fsp gone, there appears to be no reason to keep ScopedFontHDC::m_aFSP alive for the whole lifetime of the ScopedFontHDC instance Change-Id: I1028bc24f49f3bbaf6e23c09aef4459418267154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-19tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor"Caolán McNamara
they are the same in light mode, so do the same in darkmode Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19size this OUStringBuffer at initial constructionNoel Grandin
Change-Id: I6414281cef5eedf1e797139695bf05c72c300447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19crashtesting: "unknown cell text: element" assert for text:bookmark #2Justin Luth
since... commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1 Date: Sat Sep 10 16:32:46 2022 -0400 tdf#103829 ods import: parse <text:tab/> From documentation, it looks like we can also have bookmark-start and bookmark-end, so adding these even though no examples found. I looked for how to insert bookmarks in calc - basically no UI or menu (except one notebookbar, no calc documentation, no abandoned bookmark code removal, no bookmark import code. IIUC, in writer a bookmark is basically a field. Perhaps it is similar in Calc? In any case, with this limited wealth of information, I don't plan on trying to fix the LO 4.1 loss of bookmark. Change-Id: I44708a5c7d69ce37f688ec7beb243e08844dbfa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140197 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-19Fix typosAndrea Gelmini
Change-Id: If24b9756d7fd8f6346580b4da84fac4f5ab1d3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140198 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19Fix typosAndrea Gelmini
Change-Id: If33ae9acbc1ed17398584efa3574566b2d854b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140149 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19sw HTML import: fix height of images when it is missing and width is relativeMiklos Vajna
This is similar to commit 456abae730a787693c3ad98f7e57eba5f6163a76 (sw HTML import: fix height of OLE objs when it is missing and width is relative, 2022-09-06), but this is for images, while that was for OLE objects. The idea is still that in case only axis is specified in the HTML and that's a relative percentage, then the ratio should be taken from the bitmap and it should be kept. Change-Id: I36184ff6531bff2775013462cd8cc711e1a249c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140178 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-19tdf#75702 sc: unit test for preserving text:line-breakJustin Luth
Change-Id: Id61e46ba4e0b3e2b534cf9f8bafe03fba10cd355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140182 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4b86dd440667832cd5510a1bd31ff35514532d06 - tdf#119421 Add sample files for conditional formatting Change-Id: Id5826f32bd2de2e286eecf57dc817f4b60a2599b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140196 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-09-19tdf#150650 Fix changing fill style to None via SidebarSamuel Mehrbrodt
Regression from 5491a82854e3e6dd2dbb4b0012cb4bbeb4ee22e0 Change-Id: I17cfb037f2064a508317090e6b66f20e253a9436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140150 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19no need to use an OUStringBuffer hereNoel Grandin
can just return the substring we need Change-Id: I9d605cb809f58fcf60c0ae2e29aaff17baa9faa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19use optional in processEntryNoel Grandin
which means we save the cost of initialising an OUString Change-Id: Ib139383b43f6d49303e20368ce4177b068c38ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 9abe3f66a8951fef89d79b5125931773778cda22 - tdf#119421 Enchancements to Conditional Format pages Add icons and how-to-get Change-Id: I1fb78ac737bc37745ee76d4508116edadd283938 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140130 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-09-19try harder to remove "OSL_PIPE" pipe on SIGTERMCaolán McNamara
a) When oosplash got SIGTERM it used SIGKILL on soffice.bin, (concealed behind osl_terminateProcess) so soffice.bin has no chance to cleanup. Try SIGTERM, followed by SIGKILL if that doesn't work, to give soffice.bin a chance. b) java intercepts SIGTERM so if JNI_CreateJavaVM was called then our SIGTERM handler doesn't get called. Add -Xrs to jvm args to avoid this. Change-Id: I09f93d8093bc7c094482eda73b4eadc5a6cebb83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140152 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19move code out of formulagroupcl.cxx to op_math* and opbase*Luboš Luňák
formulagroupcl.cxx is already large enough, move away code that implements some operations and also move some type declarations to a header. Change-Id: I28fe59275f4fb89c3e530d77b08e7f2fcad02781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139971 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-19tdf#150992: fix crash popart filter to an SVG imageJulien Nabet
part of bt: 6 0x00007f018c80186f in BitmapPalette::operator[](unsigned short) const (this=0x5576a198fe48, nIndex=176) at vcl/source/bitmap/bitmappalette.cxx:139 7 0x00007f018c3d1fce in BitmapInfoAccess::GetPaletteColor(unsigned short) const (this=0x5576a2bbc520, nColor=176) at include/vcl/BitmapInfoAccess.hxx:121 8 0x00007f018c85b63f in BitmapPopArtFilter::execute(BitmapEx const&) const (this=0x7fffb7394728, rBitmapEx=...) at vcl/source/bitmap/BitmapPopArtFilter.cxx:73 9 0x00007f018c83e66b in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) (rBmpEx=..., rFilter=...) at vcl/source/bitmap/bitmapfilter.cxx:22 10 0x00007f01905e5bd4 in SvxGraphicFilter::ExecuteGrfFilterSlot(SfxRequest const&, GraphicObject&) (rReq=..., rFilterObject=...) at svx/source/dialog/grfflt.cxx:202 some gdb info (gdb) p nIndex $1 = 176 (gdb) p mpImpl->GetBitmapData().size() $2 = 34 full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=182499 See https://bugs.documentfoundation.org/show_bug.cgi?id=150992#c2 for some comments the main thing that makes me think that the order is reversed is the "nLastEntry" treatment. Indeed with the current sort, mnCount with 0 come first nLastEntry = nEntryCount - 1 (unless there's no color at all) Change-Id: I3b89f2f4d6f115ea9f6752c49bad776a33f0b020 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140153 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19can return by const& in PopStringNoel Grandin
and avoid some ref-counting Change-Id: Id1e6fc09d1c517ce168cebb7a225aa6df48e72c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 30682f2fa484e9a831ac20c26bfd19aab6c42a82 - Reuse and sync help content Change-Id: Ia95c3da543efd8dddfdcfa635d316b3c10fa52eb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139569 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-09-19tdf#150402 Correct wrong Bound of Shape in SlideshowArmin Le Grand (allotropia)
Added and use mbContainsPageField that gets set in prepareHyperlinkIndices() which has to be run anyways, so this will cause no change in execution speed. It lets us detect the potential error case that a PageField is contained in the Text of the Shape. That is a hint that maBounds contains the wrong Range and needs to be corrected. For more backgrund information please refer to tdf#150402, Comment 16. Change-Id: Ifee01fffdb6e2f5915aa705afc7b5842781aae91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140144 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-19tdf#150802 Fix setting gradient from SidebarSamuel Mehrbrodt
Regression from adc536e9efc77690df62177aa722f9252bdbf96b Change-Id: I37db76373a3b9b4a1084e830233561abc4b1e6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140151 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19Update language-subtag-registry to 2022-08-08Eike Rathke
Change-Id: I08609e88c1bdb62f778db25156363fbc6d2adff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140148 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-19tdf#147507 sw: fix crash with Reject All around not content nodesLászló Németh
Regression from commit f3bec764ddbf3fd3ae986f034c89626bf22940e0 "tdf144058 sw track changes: fix table deletion at paragraph join". Change-Id: If08a2b85c3db9fe92ad623d3d7cb30f2feaaab36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140145 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-09-19Resolves: tdf#151046 INDIRECT() try named expressions and DB range names firstEike Rathke
... as older 1K columns allowed names that would now match a 16k columns cell address, which ConvertSingleRef() would already resolve. Change-Id: I9322732e554da20c81856c0a30c41a246356f65b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140147 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-19vcl: Handle alpha in Type 3 glyphsKhaled Hosny
Change-Id: Ic21089ae8aeca1402fd5c4c46851dcd06a480723 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140146 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19vcl: Fix Type 3 glyph widthsKhaled Hosny
It seems we need the values to be in unscaled font units not PS units. Modify LogicalFontInstance::GetGlyphWidth() to return unscaled values when requested and the TT-to-PS conversion conditionally in PDFWriter. Change-Id: I94e7cdc0ecf842a0cf87fddaa4467966f698ae3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140126 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19vcl: tdf#104403 PDF export for layered color fontsKhaled Hosny
Support color fonts using color layers from OpenType COLR table and color palettes from CPAL table. This uses PDF Type 3 fonts to wrap the layers into individual glyphs that can be drawn normally. Type 3 glyphs can use arbitrary PDF code, so here we output the layers in the regular font subset and then draw then in the Type 3 glyph with colors applied to them. This supports only version 0 of COLR table (solid colors only), the new but more powerful version 1 of the table is not yet supported. Change-Id: I4bf36f5b608a0ac15411104d8a6af893fb69a5c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140125 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19vcl: Add PhysicalFontFace::UnitsPerEm()Khaled Hosny
Change-Id: I9239085aabe450499193e74ac91d6a16437545c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140124 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19tdf#149797 Change highlight background color in some controlsIlhan Yesil
The highlight and highlighttext colors can be set for some controls. So as example a selected item in a listbox can now be paint with anothers colors then the standard blue. Controls are: listbox, combobox, edit field and some special edit fields like date, currency and others. Change-Id: Iace2dd9a1a61abb7819b6c81eb0b8030912db32b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136691 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-09-19make OUString::operator=(OUString&&) a little fasterNoel Grandin
one function call instead of two, and this function is pretty hot Change-Id: Ibb09ad9b930f337706fa392a1644077c82dbc61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19get_value is cheaper than at() in toRefCell()Noel Grandin
and we expect the position to be valid here, so throwing an exception is no better than a segment violation Change-Id: I20e4849c95da57e6a5fc0937c4f61fbe004d11d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Resolves: tdf#151017 we now want the background to be the stock widget bgCaolán McNamara
Change-Id: I44a800748ffafe91f3b6169617be30ef87919267 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19vcl: Add PhysicalFontFace API to get color layersKhaled Hosny
Change-Id: Ic221582a04982f0b1565089fa0beff1b34a749d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140123 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19vcl: Don’t use temporary files for CreateFontSubset()Khaled Hosny
The callers pass a path to a temporary file for the function to write to, then they immediately read from it. This change cuts the unnecessary use of temporary files and passes the subset font data around instead. The CFF subsetting code really wants files and needs more invasive change, so it still uses a temporary files but this is hidden from its caller. Change-Id: I2a2117e967b76fb903ff0d32c435925049bc6e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140122 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19small opt in FormulaTokenIteratorNoel Grandin
cheaper to init the stack with the first element, rather than calling Push Change-Id: Ia34f88b6534a663fae2ed08d0499d04d2f458847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Rename MouseNotifyEvent to NotifyEventTypeSamuel Mehrbrodt
Also contains keyboard and focus events, not only mouse events Change-Id: Iec1d6c341b01a489ba80fe9634ea3579afb02ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19sw content controls, plain text: enable DOCX filter with data bindingMiklos Vajna
- writerfilter/ had explicit code to not map plain text SDT to Writer content controls if it has data bindings specified, lift this limitation and set the value of content control from data binding, like Word does and Writer did it for input fields since b5c616d10bff3213840d4893d13b4493de71fa56 (tdf#104823: support for sdt plain text fields, 2021-11-24) - call DocxExport::AddSdtData() on the export side to do the opposite on export - give up on the idea to export content controls to DOCX by finding the text attribute in SwWW8AttrIter::OutAttrWithRange(): this needs buffering in both directions (need to start the SDT before the start of the run, need to end it after the end of the run), and solving this using marks and merges at a fast-serializer level looks like hacks on top of hacks. To be more specific, CppunitTest_sw_ooxmlexport7's testSdtAndShapeOverlapping seems to be very hard to fix with this design - instead, give not only the start position but also the length of the run to DocxAttributeOutput::EndRun(), which has random access to the doc model and can look up if there is a content control start or end that needs writing at the current position of the XML output, without any buffering, which also means less code - adapt CppunitTest_sw_ooxmlfieldexport's testSdtBeforeField, which didn't like the empty run at the start of content controls, which seems to be harmless otherwise - fix CppunitTest_sw_ooxmlfieldexport CPPUNIT_TEST_NAME=testSdtDateDuplicate by disabling the "set content control value from data binding" logic for date pickers because that logic in writerfilter/ sets the value as-is and it has to consider the requested date format before this can be enabled As a side effect, this gives PDF export for plain text SDTs, even if they have data binding set. CppunitTest_sw_ooxmlfieldexport's testTdf104823 is now updated to ensure that we import such SDTs as Writer content controls. Change-Id: I749a845b5a25454c51066b8ded892682f523b6b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140134 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-19Ignore also when a font has been substituted by itself with an empty styleTor Lillqvist
Change-Id: I40fbce716a11b010323ac07e0dacdc114f7d2320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140135 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-19tdf#151008 adapt anchor for eaVert and mongolianVertRegina Henschel
MS Office and LibreOffice act different whether anchor positions are rotated for vertical writing modes eaVert and mongolianVert. The patch converts the position on import and export. Currently shapes are not able to render mongolianVert. Nevertheless it is included so that the text block has already the correct position and the original position is restored on export. LibreOffice has vertical anchor alignments BOTTOM, that would require a third horizontal position in MS Office, which does not exist. It is mapped to anchorCtr='1' instead. Such does not occur in pptx-LO-pptx round-trip. Change-Id: I1b0e42a39ce3aba12cdb271b2aa8023dacb9c53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140118 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-09-19no need to allocate these separatelyNoel Grandin
Change-Id: I5e61c783806d78df94fa08840f7d3f37f1a743ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19sw: prefix members of SwFootNoteOptionDlg, SwLabPrtPage, SwMailMergeDlg ...Miklos Vajna
... and SwMailMergeWizard See tdf#94879 for motivation. Change-Id: I01521a5b96e45483bb810ea0e8cfb26cbf55bc40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140133 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-19tdf#150955 sw InsertBookmark: add hidden status to hidden MSO fieldsLászló Németh
In Insert -> Bookmark... dialog window, add hidden status to _Toc and _Ref hidden DOCX bookmarks to allow separating them from user-defined bookmarks using sorting. (In MSO, there is a checkbox to enable visibility of these hidden bookmarks in Insert bookmark dialog.) Note: UX field Hidden was only used for a lo:ext OpenDocument feature (with UNO-only creation of bookmarks with hidden anchor), see tdf#101856. This UX field was re-used for better handling of DOCX import of hidden (not user-defined) bookmarks created by MSO. Follow-up to fix for tdf#150956 in commit 5e71ec6aa0d4f9971f5e2b6f7091d18668c2f0b9 "tdf#150790 tdf#150791 tdf#150947 tdf#150956 sw, a11y: fix visible bookmarks". Change-Id: I52e9f2c0b65e62c14ac24138235f07fb213da737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140079 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-09-19Make impBufferDevice faster againArmin Le Grand (allotropia)
When the Primitives for the Glow-Effects were added (modified ShadowPrimitive2D, SoftEdgePrimitive2D and GlowPrimitive2D) a modified version of impBufferDevice was created and used. That lowered the speed for drawing objects with transparence by about factor 2.5 and was unfortunately not only done for these Primitives, but for transprent objects in general. For the mentioned factor refer to: Patch to demonstrate former and now repaint differences https://gerrit.libreoffice.org/c/core/+/129301 After having reworked those Primitives to use another mechanism and being decomposed so they will work in all now and future renderers, it is possible to go back to that easier and faster method to render Transparency. For extended information, please take a look at the added comments, mainly in vclhelperbufferdevice.hxx Identified a still bad behaviour when objects use a TransparenceGradient. Corrected that and added (at this opportunity) a method 'createAlphaMask' along with 'convertToBitmapEx' which is now used in the GlowPrimitive2D & ShadowPrimitive2D which only need the AlphaMask to do their job anyways (I had commented there that thjis is possible before). That will be faster for visualizing those Primitives. Change-Id: Ieac880384de26960c2c4b8740a1dee1e15d7ac9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140022 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-19simplify usage of TempFile in Graphic(In/Out)putStreamNoel Grandin
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: Icdfcb96b002c489dee51c03b69127c21be5c85ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19OSL_ENSURE->assert where we would crash if not trueMike Kaganski
Change-Id: I1d922034aa1be709bcd1c77886d773835683b7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140132 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-19OSL_ENSURE->assert where we would crash if not trueMike Kaganski
Change-Id: Ib6c2806070ae11b5542fcbba284f2640400bf984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140131 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-22 21:58:16 +0000