summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-09tools: don't leave SvStream::m_nBufFilePos pointing beyond the endMichael Stahl
... of the stream in SvStream::SetStreamSize(); this caused SvMemoryStream with SetStreamSize(0) and subsequent write to be pre-filled with 0 bytes. Change-Id: I0de704b319f5087bc6c1914881e38018212afbf2 Reviewed-on: https://gerrit.libreoffice.org/80478 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-09filter out the "Creating library" message from link.exeLuboš Luňák
It cannot be turned off, it doesn't bring any value and it pollutes gbuild output. Change-Id: Ie3684e5fc30c9c5d34bd991e928a8d3f11f0b823 Reviewed-on: https://gerrit.libreoffice.org/80492 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-09Resolve FIXME Decimal Separator should be OUString (connectivity/dbaccess/svx)Julien Nabet
instead of a sal_Char Change-Id: I14fd983dac7ceb83a788c26dd4ea9d1c87444c9a Reviewed-on: https://gerrit.libreoffice.org/80493 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-09cid#1448412 subvert Untrusted value as argumentCaolán McNamara
Change-Id: If2a2ed737c1807250550e3bb3a768807df08a5c1 Reviewed-on: https://gerrit.libreoffice.org/80522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09NFC writerfilter: preparation for adding CharProps to GetAnyPropertyJustin Luth
...for tdf#99602 specifically, but I've intended to do this for a long time. Currently GetAnyProperty doesn't look in Character Styles for the requested property. But it should. GetPropertyFromCharStySheet can re-use a lot of the code for GetPropertyFromStyleSheet, so split that up and explicitly identify the existing function as ParaStyle. Change-Id: I9843153a6c09a10d63a575cb1f35a56c21c9cb9c Reviewed-on: https://gerrit.libreoffice.org/80180 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-09Resolves: tdf#128037 don't create a11y element just to destroy itCaolán McNamara
Change-Id: I8d613d30116c0201154773421b4f9eb829a94620 Reviewed-on: https://gerrit.libreoffice.org/80538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09Make odk build-examples work on macOS 10.15Stephan Bergmann
...which apparently got even stricter with unsetting DYLD_LIBRARY_PATH when starting a shell, so the old workaround from 9ac2aad4c1cd0f8d513c02a897da90c42f2fa961 "OSX fix ODK example builds with enabled SIP" no longer worked for me (and CustomTarget_odk/build-examples_java failed with > dyld: Library not loaded: @__VIA_LIBRARY_PATH__/libreglo.dylib > Referenced from: /Users/stephan/Software/lo/core/instdir/LibreOffice6.4_SDK/bin/idlc > Reason: image not found ). Building on macOS 10.15 now requires to build a shell from upstream sources and pass it into toplevel make as a SHELL=... command line argument (but which I at least already needed to do anyway, to preserve a global DYLD_LIBRARY_PATH pointing at a nonstandard libc++, when building external/firebird). Change-Id: I00ec0649fafa1842bed3f2a1258e3184d6bcfdd1 Reviewed-on: https://gerrit.libreoffice.org/80532 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-09ofz#18093 guesslang was added to solenv/bin/native-code.pyCaolán McNamara
Change-Id: Ie0ec41df001c9c970a0cc4b43a6f0c788b5a048d Reviewed-on: https://gerrit.libreoffice.org/80537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09sc: rowcol: store sheet maximum sizes in ScDocument.Michael Meeks
For now, hard coded to MAXCOL, MAXROW while we re-factor. Change-Id: I5e1aafc91ba1434a9a248d33bf0da4f4a2dc3a1b Reviewed-on: https://gerrit.libreoffice.org/80434 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2019-10-09Related: tdf#123765 fix up some screenshottingCaolán McNamara
and add in two special cases for the mentioned cui dialogs Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326 Reviewed-on: https://gerrit.libreoffice.org/80488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09fix that InputStringDialog screenshot saved as null.pngCaolán McNamara
Change-Id: Ie820bb70d3e745246a9c7801c5473237788bfb55 Reviewed-on: https://gerrit.libreoffice.org/80535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09Access2Base - Support dialogs owned by non-Base docsJean-Pierre Ledure
So far, AllDialogs found only dialogs stored in Base (.odb) documents. From now on, dialogs in ThisComponent atr considered as well. Change-Id: I4977b09140c673ad7aca379c1a67a2d731384782
2019-10-09log output filenameCaolán McNamara
Change-Id: Ib6c0045edb5d4a5d86c40f354dc99ab2fb693ca4 Reviewed-on: https://gerrit.libreoffice.org/80534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09remove still pending timeout in dtorCaolán McNamara
Change-Id: I8ec8c62a9cd5349fa6e58c2d0515bd57edede97a Reviewed-on: https://gerrit.libreoffice.org/80523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09cid#1453854 silence Time of check time of useCaolán McNamara
Change-Id: Icfa358476db3166c29e893c09ec943aa3c38dba3 Reviewed-on: https://gerrit.libreoffice.org/80520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09cid#1448346 Improper use of negative valueCaolán McNamara
Change-Id: I30b1bf8fd1dcbbdf0804f33b04133bf450eced55 Reviewed-on: https://gerrit.libreoffice.org/80526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09use preferred button order when screenshotting dialogsCaolán McNamara
if the dialog was not already visible when we screenshot it the buttons haven't been sorted yet Change-Id: Ibce5c3eed4e9ef6d731ae813d5e0235e6e19ac25 Reviewed-on: https://gerrit.libreoffice.org/80497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09this text -> this testCaolán McNamara
Change-Id: Ibcbd9efb72b0081a3eb6da6df41b9b9fac0584ea Reviewed-on: https://gerrit.libreoffice.org/80519 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09cid#1452393 silence Using invalid iteratorCaolán McNamara
Change-Id: Idf3ec9c751f8c7d93ce82e25613757627b867cc4 Reviewed-on: https://gerrit.libreoffice.org/80521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09get SAL_USE_VCLPLUGIN=gtk3 make screenshot to workCaolán McNamara
for the "known dialog" cases of make screenshot which instantiate the real dialog, which are native in this scenario, and get snapshot of them. the rest of the dialogs still currently are visualized via the VclBuilder fallback Change-Id: Ic255c3aae2661829c5e6dba392a88f1c0e40e882 Reviewed-on: https://gerrit.libreoffice.org/80496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09make impress sidebar work on iOS - missing PanelFactoryTomaž Vajngerl
add org_openoffice_comp_Draw_framework_PanelFactory_get_implementation make it build Change-Id: I522f3d684c52caf15a78d5eff29e78e645588481 Reviewed-on: https://gerrit.libreoffice.org/80515 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-09no need to include vcl.dialog here anymoreCaolán McNamara
Change-Id: Ic902f09be90ec3989a20333a13562b3af679ff92 Reviewed-on: https://gerrit.libreoffice.org/80489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Typo Change-Id: I2ac2e142b2700912292a2a127ed28a99f34f6edc Reviewed-on: https://gerrit.libreoffice.org/80498 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-09solenv: drop no longer needed clang-format blacklist linesMiklos Vajna
These files were removed in the meantime. Also add ones which don't conform to the enforced style but somehow bypassed CI. Change-Id: I50cfc35d882615b52fc5ca157eb8ae92515bb2fe Reviewed-on: https://gerrit.libreoffice.org/80494 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-09With Cygwin, AC_PATH_PROG needs Cygwin-style pathsStephan Bergmann
(And instead directly specifying CLANGDIR as a Cygwin-style path in my clang-cl build's autogen.input doesn't work, as compilerplugins/Makefile-clang.mk spells a dependency on $(CLANGDIR)/bin/clang$(CLANG_EXE_EXT) which Make on Windows requires to be a Windows-style path.) Change-Id: I20ee3a2dfff0a3db66e1388cd6fc01084a6fd812 Reviewed-on: https://gerrit.libreoffice.org/80471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-09Bump the minimum iOS run-time version to 12.2Tor Lillqvist
Change-Id: I082a7d62e222e625d1d921bea39b45578118d225
2019-10-09Accept iOS SDK 13.1Tor Lillqvist
Change-Id: I02870b35f67dd9ca47061311186d74dfec823aa7
2019-10-09tdf#128013: fix Crash when linking an odp fileJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154847 Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 Change-Id: Id9355958b0c4a56215ff98f0e5be13a3074ce45f Reviewed-on: https://gerrit.libreoffice.org/80500 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-09loplugin:redundantpointerops check other pointer typesNoel Grandin
as well as unique_ptr Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf Reviewed-on: https://gerrit.libreoffice.org/80455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09use cppu::WeakImplHelper in HierarchyDataSourceNoel Grandin
Change-Id: I52da5a05e20f4971720e59589511eeacb1911b95 Reviewed-on: https://gerrit.libreoffice.org/80454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08loplugin:stringadd (macOS)Stephan Bergmann
Change-Id: I4dde1fa6f1f3e6d75abe5002655d3cd5fa685c0b Reviewed-on: https://gerrit.libreoffice.org/80487 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08loplugin:externalStephan Bergmann
Change-Id: I31bf0f87cb66ac19dfa49566e9a190c8af8d408e Reviewed-on: https://gerrit.libreoffice.org/80486 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08loplugin:nullptrStephan Bergmann
Change-Id: I69e746d32b8a900fd9ee74ddc90b72cc6f9361db Reviewed-on: https://gerrit.libreoffice.org/80484 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08My Windows clang-cl build still doesn't use LO_CLANG_SHARED_PLUGINSStephan Bergmann
...so disable the new configure.ac checks introduced with ad5cbcf6ba0afdc1d8d7405c2641cce8de4a360b "try to autodetect flags needed to build Clang plugins" that are only relevant when using LO_CLANG_SHARED_PLUGINS and would fail miserably for my clang-cl build Change-Id: I58f7f1f4608f1a615175f0c0d0d98c03c442a36c Reviewed-on: https://gerrit.libreoffice.org/80477 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08Clarify COMPILER_PLUGINS_CXX_LINKFLAGS vs. COMPILER_PLUGINS_LINKFLAGSStephan Bergmann
COMPILER_PLUGINS_CXX_LINKFLAGS was introduced with 39e7a72b3e328e6b3d87479d693b01315610457b "Support loplugin in clang-cl" to augment COMPILER_PLUGINS_CXX. Due to MSVC cl.exe command-line processing, certain linker-related arguments must come at the very end of the command line, so cannot be included in COMPILER_PLUGINS_CXX. COMPILER_PLUGINS_CXX_LINKFLAGS is specified in autogen.input (along with COMPILER_PLUGINS_CXX) and configure.ac merely passes it on to its use in compilerplugins/Makefile-clang.mk. ad5cbcf6ba0afdc1d8d7405c2641cce8de4a360b "try to autodetect flags needed to build Clang plugins" now needs a configure.ac-internal variable to store the output of `llvm-config --ldflags ...`, similarly to how COMPILER_PLUGINS_CXXFLAGS stores the output of `llvm-config --cxxflags`. It reused COMPILER_PLUGINS_CXX_LINKFLAGS for that, but that makes it hard for my clang-cl build to pass my specification of COMPILER_PLUGINS_CXX_LINKFLAGS from autogen.input to its use in compilerplugins/Makefile-clang.mk. So rename this new variable to COMPILER_PLUGINS_LINKFLAGS (matching COMPILER_PLUGINS_CXXFLAGS). Change-Id: I93b0b50ba94803041773757d9978222e2726f9b0 Reviewed-on: https://gerrit.libreoffice.org/80473 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2019-10-08tdf#123339 XLSX: fix horizontal alignment in commentsSzabolcs Toth
Import and export of VML element TextHAlign weren't supported by Calc, losing horizontal aligment of the comments assigned to the spreadsheet cells. Change-Id: I41766d3004dd07ab34a2619e28532281366bf235 Reviewed-on: https://gerrit.libreoffice.org/79963 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-08better name for a function in compilerpluginsLuboš Luňák
The function is not just about a spelling location. Change-Id: I96e9e9ef7e27a9763397b4b86473c1c30d0e3eeb Reviewed-on: https://gerrit.libreoffice.org/80381 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-08Fix typoAndrea Gelmini
Change-Id: I10c8518ebd3897fa32bdd67f7e4d726ce5ff1cec Reviewed-on: https://gerrit.libreoffice.org/80475 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-10-08CXX is now always set before CXX_X64_BINARY on WindowsStephan Bergmann
...since ea3d4e806cbdde18173da92187329f1ac2177e14 "Fix CXX_BASE for clang-cl builds on Windows", as a side effect, moved the conditional CXX=$MSVC_CXX further up. This addresses the comment in the commit message of 463a79cbc16c1b4aba1775d7f8ae0324753c322c "CXX_X64_BINARY must be clang-cl not cl when building with clang-cl": "Ideally, the code would be reorganized so that CXX_X64_BINARY is only set after CXX has been set." Change-Id: Iaa011aeff88669ddd5d33fc5b1109abf02edff54 Reviewed-on: https://gerrit.libreoffice.org/80468 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08loplugin:duplicatedefines RID_SUBSETSTR_GEORGIAN_EXTENDEDNoel Grandin
was defined twice in the same header Change-Id: I05941e59162e7d29e881a81de278970763d83b52 Reviewed-on: https://gerrit.libreoffice.org/80457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08loplugin:duplicatedefines in editengNoel Grandin
UNO_NAME_EDIT_CHAR_FONTNAME was defined twice in the same file Change-Id: Idaa5933cde25c59fd4a5642786b9d4bdd53b9a33 Reviewed-on: https://gerrit.libreoffice.org/80456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in FTPContentIdentifierNoel Grandin
Change-Id: Id4ea2006fab9607fdbd744ba73deb3dbd30b374b Reviewed-on: https://gerrit.libreoffice.org/80453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in fileaccess::FileContentIdentifierNoel Grandin
Change-Id: I944bd19d432c18708bc822e186cd2ea1ce304403 Reviewed-on: https://gerrit.libreoffice.org/80452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08jsdialogs: Expose the panel names.Jan Holesovsky
Change-Id: Ifa837bfcaba6e63c7058e34f1e386f571bfb4d61 Reviewed-on: https://gerrit.libreoffice.org/80481 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit b13e2e7d2b2767d4fadaf825756ee38bc941ad57) Reviewed-on: https://gerrit.libreoffice.org/80490
2019-10-08Introduce o3tl::unsafe_downcast for known-good dynamic_cast downcastsStephan Bergmann
(This helps rewrite code that silences Coverity unchecked dynamic_cast warnings, like 57b89ea1c2ff07b53c3cc002e5ec9e52abd0c1bd "coverity#704563 Unchecked dynamic cast", in a way that is cleaner and potentially executes faster.) Change-Id: I3319c0eeec2aa822f686feacd499a76c8c9b9499 Reviewed-on: https://gerrit.libreoffice.org/80458 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08no need for vcl::Window in vcl/abstdlg.hxx anymoreCaolán McNamara
Change-Id: I1a2dcfe676cf5a4a01aa0d8ef7625abc316e8e81 Reviewed-on: https://gerrit.libreoffice.org/80417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08Add missing source files in vcl/source/gdiTor Lillqvist
(A fairly ad-hoc small subset of the source files are included in the Xcode project to make it possible to set breakpoints in them in advance.) Change-Id: I6c2655337e1d623b299e65aa977650e7519b7bd8
2019-10-08lok: only generate sidebar JSON for mobile views, for now.Michael Meeks
Change-Id: I7a4b20cfc93ddd77752790a7c303f512a62afbb3 Reviewed-on: https://gerrit.libreoffice.org/80460 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-08Simplify some uses of dynamic_castStephan Bergmann
(SdrCaptionObj is derived from SdrTextObj, and SdrTextObj::SetVerticalWriting isn't shadowed anywhere along the derivation path to SdrCaptionObj, so dropping the dynamic_cast to SdrTextObj in the last block is fine.) Change-Id: I914a13cbdbeb4ba58f642c9696ef4ad456bc3322 Reviewed-on: https://gerrit.libreoffice.org/80451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08tdf#125289 Use default colors from the new standard paletteGabor Kelemen
These look quite similar to the previous ones and we have translatable strings for them Change-Id: Ib40f4087830098341dcd32ce81673f6f187fe685 Reviewed-on: https://gerrit.libreoffice.org/77074 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-16 08:41:15 +0000