summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-10Removed duplicated includeAndrea Gelmini
Change-Id: I1a9653fae13c2f515c7f36c9632b8e8ad58ab45c Reviewed-on: https://gerrit.libreoffice.org/80624 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-10avoid warning on teardown for non-dialogs/assistantsCaolán McNamara
Change-Id: Icba9df171fee73e16133794017ead1ad4a7fc470 Reviewed-on: https://gerrit.libreoffice.org/80613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10fix has-default without can-defaultCaolán McNamara
Change-Id: I3b7993a2575b51f30bc5b2eb24e84d71728aa934 Reviewed-on: https://gerrit.libreoffice.org/80611 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10'close' is available for GtkDialog and GtkAssistantCaolán McNamara
Change-Id: I7d9d74d2399160a603dc66e2006b4ebe9627873c Reviewed-on: https://gerrit.libreoffice.org/80612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10WaE: -Wreturn-typeCaolán McNamara
Change-Id: I6e9d667cc286ebab796398fac293077718bbf877 Reviewed-on: https://gerrit.libreoffice.org/80619 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10DestFileExists should be boolStephan Bergmann
Change-Id: I5803aa2498654c579f9fe6293e5204aa63edd589 Reviewed-on: https://gerrit.libreoffice.org/80607 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10Duplicate -Wno-missing-bracesStephan Bergmann
...ever since 9055fb48402eaeb9ba876b7893e2f9a39fea06b1 "clang-cl: Enable more warnings etc. (like in the Clang/GCC case)" Change-Id: I2c7b36f6d0852ebf6c660e79e6a9bad057ec0153 Reviewed-on: https://gerrit.libreoffice.org/80608 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10Picture can be in anonymous namespaceCaolán McNamara
Change-Id: I484443e70b6465a98851aede32df1975d55d75d0 Reviewed-on: https://gerrit.libreoffice.org/80604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10Adapt osl_replaceFile documentationStephan Bergmann
...to eedf523c123a82bf3cbc5f389783e22d75b2e2c5 "tdf#127069 sal: preserve gid of files in the unx osl_replaceFile()" Change-Id: I47627418a9cd662802e4de3aa4cad4128af82ad4 Reviewed-on: https://gerrit.libreoffice.org/80606 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10Set RTL_OS to "iOS" for iOSTor Lillqvist
We accidentally had left it as "MacOSX". Affects at least the "generator" metadata stored in documents. Change-Id: I72eeefdbe192409084f7ab7a24adbc39dcafb624
2019-10-10use a GtkMenuButton for button+menuCaolán McNamara
Change-Id: I84028ecc95b93112377806da3a1bbb879c4fd90a Reviewed-on: https://gerrit.libreoffice.org/80600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10guesslang needed in calc, impress and math! as wellCaolán McNamara
Change-Id: I04c48d7d375e42577b5b4c40ce75d5fcbeca21ac Reviewed-on: https://gerrit.libreoffice.org/80603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10vcl: only smooth bitmap transform when neededMiklos Vajna
If you have a very small bitmap and you rotate it by 90 degrees, then smoothing is not needed, but the result will be blurry. So in case scaling / shear doesn't need it and we do 90/180/270 rotation, avoid smoothing. Change-Id: I4b8fad4b0b70516d35eaecfa70a707e6e8362d18 Reviewed-on: https://gerrit.libreoffice.org/80589 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-10Don't show chart wizard on mobileSzymon Kłos
Change-Id: Ic4c65293462d56e1ecedcaaad71575f50b6c1dba Reviewed-on: https://gerrit.libreoffice.org/80592 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 805ee5251c5ad92b0738f155a63694bc1ecd0f38) Reviewed-on: https://gerrit.libreoffice.org/80598 Tested-by: Jenkins
2019-10-10tdf#98603 export runs with correct lang attribute (2/2).Mark Hung
Obtain lang attribute of rPr element from CharLocale, CharLocaleAsian, or CharLocaleComplex based on the script type of exported text. There are several other call sites of WriteRunProperties, like those in chartexport, and those for text fields, Here I leave the default to CharLocale so it fallback to western locale as it did before. Change-Id: I33679517dd88f9e415933decc02f10afc807ad3b Reviewed-on: https://gerrit.libreoffice.org/79973 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-10-10update creditsChristian Lohmaier
Change-Id: Ib98367116f9727f6ec54372d4cd90b657258b0d7
2019-10-10Silence -Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Required a workaround for loplugin:indentation, until <https://reviews.llvm.org/D68581> "Include leading attributes in DeclStmt's SourceRange" lands in Clang. Change-Id: I7192969d40fa4c50bbd603d059532b9344865248 Reviewed-on: https://gerrit.libreoffice.org/80596 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10sw: WW8: do not create fieldmark with start in frame and end in bodyMichael Stahl
Actually the start and end must have the same start node; presumably CheckNodesRange(..., true) does that. Change-Id: I04b34b593a4383b565289254bdb756d95c2b7916 Reviewed-on: https://gerrit.libreoffice.org/80594 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-10writerfilter: remove pointless if in appendTextPortion()Michael Stahl
Change-Id: Iff8171b48a2687bbadb4e2638675a73de96a7545 Reviewed-on: https://gerrit.libreoffice.org/80074 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-10Access2Base - CurrentUser based in PathSubstitutionJean-Pierre Ledure
com.sun.star.util.PathSubstitution service provides a "$(username)" variable since LO 5.2 This technique replaces the use of environment variables Change-Id: Icca82d88a123312031874d355655d26718fb215b
2019-10-10ofz#18093 fix buildCaolán McNamara
Change-Id: I9d72d01f2d8b7a96ca037001489ecf2f68492b57 Reviewed-on: https://gerrit.libreoffice.org/80591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10remove redundant empty checkJohn Zhang
Change-Id: I5ea0410e9cba2e78ecb9aa2bbeeb6b307a522ae5 Reviewed-on: https://gerrit.libreoffice.org/79373 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-10tdf#127814 DOCX: fix default paragraph margin in table cellsLászló Németh
when the table is started on a new page. Undefined w:before in w:docDefaults/w:pPrDefault resulted 0.5 cm paragraph top margin instead of 0 cm. Change-Id: I94a2aa9e9c5fcee6443b74bb261c300c6a8e1303 Reviewed-on: https://gerrit.libreoffice.org/80445 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-10x.insert(x.getLength() -> x.appendNoel Grandin
Change-Id: I865dbca65a5b29e35f90070dc743c42289598d9d Reviewed-on: https://gerrit.libreoffice.org/80588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10tdf#128057: convert file URIs to system path for IGraphBuilder::RenderFileMike Kaganski
It seems to handle file URIs incorrectly, failing when the characters in the URI are URI-encoded like %23 for #. Change-Id: Ibc1e27ce38d65781cdb8278c4787aafa00092754 Reviewed-on: https://gerrit.libreoffice.org/80567 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-10basegfx: warn on unused B2DVectorMiklos Vajna
This is similar to tools::Rectangle, doesn't do anything useful in its destructor. Change-Id: I761801a0cf6979e6611f4341b41445cb05d8925b Reviewed-on: https://gerrit.libreoffice.org/80566 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-10Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointeropsStephan Bergmann
...when the get member function is implemented in a base class, as happens for std::shared_ptr in libstdc++ (where it is implemented in base __shared_ptr; see also 7d361e96c9ea822790db21806e9fc05279423833 "loplugin:redundantpointerops"). And while at it, check for precisely the classes we are interested in (for which we know the semantics of get and operator*), rather than any classes whose unqualified names happen to match. Change-Id: I0c85ba46f191a2ee038c8175d979aa0c1be765cd Reviewed-on: https://gerrit.libreoffice.org/80585 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10tdf#127525 Replaces hotkeys for "Don't Save" button from "D" to "n".shameempk
Change-Id: I23455e7feb9effafa20722545196f19eb8b34d7b Reviewed-on: https://gerrit.libreoffice.org/80558 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-10rename TakeUnitStr to GetUnitStrNoel Grandin
and return a value instead of an awkward out-parameter Change-Id: Ia78bf0188dd9ca1078230ed7cd020ab77d05757e Reviewed-on: https://gerrit.libreoffice.org/80555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10rename TakeStr to GetStrNoel Grandin
and return a value instead of the awkward out-parameter Change-Id: I4c2c430329bab45787b3cd67339edce4c1c7a326 Reviewed-on: https://gerrit.libreoffice.org/80551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10rename TakeItemName -> GetItemNameNoel Grandin
and return a value instead of the awkward out-parameter Change-Id: I3b68c4e3b31f3ebc84ac5aecfb393c8d89e60b62 Reviewed-on: https://gerrit.libreoffice.org/80550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10rename TakeSdrDragComment to GetSdrDragCommentNoel Grandin
and return the value, instead of using an awkward out-parameter Change-Id: Ie1b2b31d36a2aa352b40b3582e0014e6b1f95390 Reviewed-on: https://gerrit.libreoffice.org/80549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10Revert "Optimize getNamespaceId (xmlreader)"Julien Nabet
This reverts commit def00961243da0662f394bdf58b1157cfd45dfab. Finally after other tests, it doesn't improve perfs Change-Id: Icbaaf751181069dd36dba0c676a4c9a2a6c8a9f3 Reviewed-on: https://gerrit.libreoffice.org/80565 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-10More loplugin:redundantpointeropsStephan Bergmann
...same as 7d361e96c9ea822790db21806e9fc05279423833 "loplugin:redundantpointerops" (that were presumably missed by that commit because I only pulled 682fdbf1312cf6ca70fe209bf4d7051dad8f5008 "loplugin:redundantpointerops check other pointer types" halfway through my local build) Change-Id: I1497e4fca2046cbcd107bb2ac5ed6f41bd68de98 Reviewed-on: https://gerrit.libreoffice.org/80569 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10tdf#98603 fix the missing char property (1/2).Mark Hung
- moLang is missed from assignUsed, so the attribute was never processed. - Set CharLocale, CharLocaleAsian, or CharLocaleComplex based on lang attribute of rPr (run property). Change-Id: I6a9a636d790d244d19e7b661a1a63b1249c2bd37 Reviewed-on: https://gerrit.libreoffice.org/79972 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-10-10No need to do anything when !HAVE_FEATURE_AVMEDIAMike Kaganski
Change-Id: I06d47b69d65c2ab2dbb5bcef19c0ac66eba4c128 Reviewed-on: https://gerrit.libreoffice.org/80571 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-10Simplify iterationMike Kaganski
Change-Id: I0340c47a007e541455d8bf339eaa7d438f5cb10f Reviewed-on: https://gerrit.libreoffice.org/80570 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-10loplugin:redundantpointerops (macOS)Stephan Bergmann
Change-Id: I40d51fbdd712d1e6e64cede05338c07a06261d8a Reviewed-on: https://gerrit.libreoffice.org/80568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-09this dialog should be modalCaolán McNamara
Change-Id: Id0d0ebea15bd8f6f842927391ea09b18870cdbf9 Reviewed-on: https://gerrit.libreoffice.org/80559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09rename ImpTakeDescriptionStr -> ImpGetDescriptionStrNoel Grandin
and make it return the result, rather than doing it via an awkward out-parameter Change-Id: Ia47c66b4f1bae781a679f2f4311e321fdc947928 Reviewed-on: https://gerrit.libreoffice.org/80547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09tdf#127785 Apply 180deg compensation for flipV to text rangeRegina Henschel
If a shape is vertically flipped, then the text is rotated by 180deg around the shape center. The rotation is done by SdrTextObj, where text rectangle and shape rectangle are the same, so the rotated text rectangle has the correct position despite flipping. But the text rectangle for SdrObjCustomShape is set by the shape author in the TextFrames attribute and might have an asymmetric position. The patch compensates the flip-rotation by pre-rotate the text rectangle. This replaces commit caaa8fe7c4bb88185b5b11591ee8a619cff0eced. The error in the old patch was, that it has uses a translation instead of a rotation, and has used a wrong place. The result was, that a text box, which has an own TextRotateAngle, had got a wrong position. Change-Id: Id38e8c1839afa5091cd251fc5237315ba7944263 Reviewed-on: https://gerrit.libreoffice.org/80310 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-09loplugin:redundantpointeropsStephan Bergmann
(All related to uses of std::shared_ptr, which builds against libstdc++ apparently missed (fix forthcoming) and which I only now found with my macOS build against libc++.) Change-Id: If581e689f0e5ff62d9ce35513c9ff87b00328766 Reviewed-on: https://gerrit.libreoffice.org/80548 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-09Improve loplugin:redundantpointerops diagnostic messagesStephan Bergmann
Change-Id: If09f5c916f2db98c5d1754d2fbc8f53c502799c9 Reviewed-on: https://gerrit.libreoffice.org/80543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-09tdf#120336 DOCX import: fix page break after tracked deletionLászló Németh
Actual text content lost its page break, when the last paragraph of the section was empty and preceded only with tracked deletion. See also commit b696600821d8aafb63b6a88016d299ef89478f56 "n#766481 dmapper: don't import fake paragraph containing sectpr only, take two" Change-Id: I6b1c47da2b618f10ca4887f050469f94efa2a7cb Reviewed-on: https://gerrit.libreoffice.org/80540 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-09Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for master and force-fix errors using pocheck Change-Id: Id874b535ebb3ffff16d16b2f55043caa7a477f7f
2019-10-09lok: Avoid accidental removal of filter optionsMuhammet Kara
Change-Id: I178bcb19aa3073ea72a3bc8712e5e904665b1510 Reviewed-on: https://gerrit.libreoffice.org/80463 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-09name all Notebooks 'tabcontrol'Caolán McNamara
Change-Id: I5159ed77c2b3ba2f06e381a738a49dbe17a6a4dd Reviewed-on: https://gerrit.libreoffice.org/80542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09screenshot each page separatelyCaolán McNamara
Change-Id: I48a0882162075133597ecdd5512a310f8e0bf0d0 Reviewed-on: https://gerrit.libreoffice.org/80533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09tdf#114441 changed some sal_uLong to better fitting typesChristian Barth
Change-Id: I114a6b028eb59a1ae38c31bc20439a35643fe972 Reviewed-on: https://gerrit.libreoffice.org/80159 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-09fix compilerplugins makefile typoLuboš Luňák
Change-Id: Iff01d234746221a775c7b4f5742ae508691a90d0
generated by cgit (git 2.34.1) at 2025-01-16 06:14:34 +0000