summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12tdf#130440: Add UItestXisco Fauli
Change-Id: I7621e0576dedcc759f44e9662a3926d238d952d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88437 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-12tdf#43157 Clean up DBG_ASSERTShubham Goyal
Change-Id: Ie41f91f873d7cada5e738d758ad6b677adcee989 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-12tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenusMichael Weghorn
This implements native PopupMenus for the qt5 VCL plugin, which not only gives them the native look and feel, but also makes context menus faster (tdf#128921), accessible (e.g. to the Orca screen reader, tdf#122053), and makes them work for a case in Base's relationship dialog where entries in the non-native context menu were not selectable/clickable (tdf#130341). For now, this always shows the popup menu at cursor position, which can be changed by taking the Rectangle passed to 'Qt5Menu::ShowNativePopupMenu' into account if there should be any need. Change-Id: Ie52cbc682acacb92716ff51e8bf7f1ab07d34cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88512 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-12tdf#84553 Correctly handle failures while getting a WMI Object.Michel Thomas
The output before this patch : checking for active Antivirus software... C:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\antivirusDetection.vbs(1, 1) (null): 0x8004100E found The link for which is : https://ci.libreoffice.org/job/gerrit_windows/57035/consoleFull Change-Id: I714442739a8daf132e95b9f6a750aa7abab3561e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88465 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-12Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabiStephan Bergmann
...for Linux aarch64, similar to 7a9dd3d482deeeb3ed1d50074e56adbd3f928296 "Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi" for macOS x86-64. But unlike on macOS (which is known to always use libcxxabi), be careful to only execute the hack in builds targeting libcxxabi. Change-Id: I5417fde425d2d6bac9400592193a9fe5d2bfe175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88458 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-12vcl: fix UB in Window::ImplGetFirstOverlapWindow()Miklos Vajna
mpWindowImpl can be nullptr here, see online.git's unit-load-torture test: vcl/source/window/window2.cxx:882:24: runtime error: member access within null pointer of type 'WindowImpl' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior vcl/source/window/window2.cxx:882:24 in Surrouding code already checks for nullptr mpWindowImpl, so fix it directly where the problem is reported, not a caller. (Also fix a similar case in Window::ImplCallFocusChangeActivate().) Change-Id: I34dee0fd49483c428a78fd48b54c00b2f0a26417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-12nModCode assigned but not usedMaxim Monastirsky
aModEvt.mnCode used to get the currently pressed keys before commit fe0451259d2fb93c809c1bfa3baf5abd90019c58 ("tdf#103158 ctrl+shift should work on key up"). Now it gets the previously pressed ones, by ignoring the last nModCode assignment. My intention in the mentioned commit was to only change aModEvt.mnModKeyCode to also include the released key, and nothing else. So let's revert the unintentional change to aModEvt.mnCode. Change-Id: Ic182119e732b79bc494c73f9bd72959f75cc38b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12Fix a crash in OpenSSL when checking updates in dbgutil build on WindowsMike Kaganski
... showing a message "OPENSSL_Uplink(00007FFF05F33000,08): no OPENSSL_Applink" with this call stack: libeay32.dll!OPENSSL_showfatal(const char * fmta, ...) Line 986 at C:\lo\src\build\workdir\UnpackedTarball\openssl\crypto\cryptlib.c(986) libeay32.dll!unimplemented() Line 23 at C:\lo\src\build\workdir\UnpackedTarball\openssl\ms\uplink.c(23) libeay32.dll!file_ctrl(bio_st * b, int cmd, long num, void * ptr) Line 334 at C:\lo\src\build\workdir\UnpackedTarball\openssl\crypto\bio\bss_file.c(334) libeay32.dll!BIO_ctrl(bio_st * b, int cmd, long larg, void * parg) Line 361 at C:\lo\src\build\workdir\UnpackedTarball\openssl\crypto\bio\bio_lib.c(361) [Inline Frame] libeay32.dll!X509_print_ex_fp(_iobuf *) Line 93 at C:\lo\src\build\workdir\UnpackedTarball\openssl\crypto\asn1\t_x509.c(93) libeay32.dll!X509_print_fp(_iobuf * fp, x509_st * x) Line 80 at C:\lo\src\build\workdir\UnpackedTarball\openssl\crypto\asn1\t_x509.c(80) neon.dll!make_chain(stack_st_X509 * chain) Line 446 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_openssl.c(446) neon.dll!ne__negotiate_ssl(ne_session_s * sess) Line 752 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_openssl.c(752) neon.dll!open_connection(ne_session_s * sess) Line 1706 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_request.c(1706) neon.dll!send_request(ne_request_s * req, const ne_buffer * request) Line 1011 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_request.c(1011) neon.dll!ne_begin_request(ne_request_s * req) Line 1245 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_request.c(1245) neon.dll!ne_request_dispatch(ne_request_s * req) Line 1456 at C:\lo\src\build\workdir\UnpackedTarball\neon\src\ne_request.c(1456) ucpdav1.dll!webdav_ucp::NeonSession::OPTIONS(const rtl::OUString & inPath, webdav_ucp::DAVOptions & rOptions, const webdav_ucp::DAVRequestEnvironment & rEnv) Line 918 at C:\lo\src\core\ucb\source\ucp\webdav-neon\NeonSession.cxx(918) ucpdav1.dll!webdav_ucp::DAVResourceAccess::OPTIONS(webdav_ucp::DAVOptions & rOptions, const com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> & xEnv) Line 187 at C:\lo\src\core\ucb\source\ucp\webdav-neon\DAVResourceAccess.cxx(187) ucpdav1.dll!webdav_ucp::Content::getResourceOptions(const com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> & xEnv, webdav_ucp::DAVOptions & rDAVOptions, const std::unique_ptr<webdav_ucp::DAVResourceAccess,std::default_delete<webdav_ucp::DAVResourceAccess>> & rResAccess, bool * networkAccessAllowed) Line 3934 at C:\lo\src\core\ucb\source\ucp\webdav-neon\webdavcontent.cxx(3934) ucpdav1.dll!webdav_ucp::Content::open(const com::sun::star::ucb::OpenCommandArgument3 & rArg, const com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> & xEnv) Line 2227 at C:\lo\src\core\ucb\source\ucp\webdav-neon\webdavcontent.cxx(2227) ucpdav1.dll!webdav_ucp::Content::execute(const com::sun::star::ucb::Command & aCommand, long __formal, const com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> & Environment) Line 553 at C:\lo\src\core\ucb\source\ucp\webdav-neon\webdavcontent.cxx(553) updatefeedlo.dll!`anonymous namespace'::UpdateInformationProvider::load(const rtl::OUString & rURL) Line 493 at C:\lo\src\core\extensions\source\update\feed\updatefeed.cxx(493) updatefeedlo.dll!`anonymous namespace'::UpdateInformationProvider::getUpdateInformationEnumeration(const com::sun::star::uno::Sequence<rtl::OUString> & repositories, const rtl::OUString & extensionId) Line 591 at C:\lo\src\core\extensions\source\update\feed\updatefeed.cxx(591) updchklo.dll!checkForUpdates(UpdateInfo & o_rUpdateInfo, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> & rxInteractionHandler, const com::sun::star::uno::Reference<com::sun::star::deployment::XUpdateInformationProvider> & rUpdateInfoProvider, const rtl::OUString & rOS, const rtl::OUString & rArch, const com::sun::star::uno::Sequence<rtl::OUString> & rRepositoryList, const rtl::OUString & rGitID, const rtl::OUString & rInstallSetID) Line 129 at C:\lo\src\core\extensions\source\update\check\updateprotocol.cxx(129) updchklo.dll!checkForUpdates(UpdateInfo & o_rUpdateInfo, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> & rxInteractionHandler, const com::sun::star::uno::Reference<com::sun::star::deployment::XUpdateInformationProvider> & rUpdateInfoProvider) Line 97 at C:\lo\src\core\extensions\source\update\check\updateprotocol.cxx(97) updchklo.dll!`anonymous namespace'::UpdateCheckThread::runCheck(bool & rbExtensionsChecked) Line 393 at C:\lo\src\core\extensions\source\update\check\updatecheck.cxx(393) updchklo.dll!`anonymous namespace'::UpdateCheckThread::run() Line 501 at C:\lo\src\core\extensions\source\update\check\updatecheck.cxx(501) updchklo.dll!threadFunc(void * param) Line 186 at C:\lo\src\core\include\osl\thread.hxx(186) sal3.dll!oslWorkerWrapperFunction(void * pData) Line 62 at C:\lo\src\core\sal\osl\w32\thread.cxx(62) ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(97) kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() The problem is missing OPENSSL_Applink function in soffice.bin (see workdir/UnpackedTarball/openssl/ms/uplink.c), because openssl/applink.c is not included. That started after commit 5c89198f69f4487b1c872269ec6f2931490b3d02, which enabled debug output from Neon in dbgutil builds. Just comment out the call to the OpenSSL function that uses file pointer API from the Neon debug code on Windows. Change-Id: Id0188990e9122ee9fd2b3b6b7292bbeb1d206515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88412 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-02-12tdf#126700 allow replacing the default documentsJan-Marek Glogowski
Per default, a document opened by a user action will always open in a new frame. For tdf#83722, this behaviour was extended to documents created from templates. But this currently also affects the default factory templates, if these are replaced by a config setting with a real template, which was not intentional. So this patch introduces a new MediaDescriptor property, which allows to mark a document as replaceable and automatically sets it for factory default documents. If this property is set to true, a document just acts as a placeholder while it's unmodified. I.e. the next opened document from its frame will close and replace it. Change-Id: I45ffa8709f7cdda949fac78f3b363f120f0c4a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88257 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-11fix svtools' sVendor for langpack install for DebianRene Engelhard
after a21987977eae34eaf02fa109201c802f77ea68d1 Change-Id: I4bd2b37e3f006209f55bccca9fe117b0c0c4efbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87908 Tested-by: Jenkins Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2020-02-11Fix FontColor does not change selected cells on calcMert Tumer
Change-Id: Iae2f72bff4fd6986fc8cc07ba09996b1af4eb140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 23e8e4521366aaf5831a3c1feaffdc41658ce7e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88398 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11tdf#129388: Avoid any actual painting of the slide sorter in the LOKit caseTor Lillqvist
The JS code in Online creates its own slides sorter thing anyway, the one is core is only needed as a data structure. Change-Id: I0eeb79c523b72f7b616f11443198d5af82b70643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87184 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88444 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11tdf#130440 only select first page if no other page is selectedXisco Fauli
Found while implementing the UItest. See https://gerrit.libreoffice.org/c/core/+/88437 it asserts on line 34 AssertionError: 2 != 1 as the first and second slides are selected Change-Id: I249dc0ac6faa55f0f15deedb848beabbc64aeed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88439 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Fix duplicate "stringresource" in MERGE_LIBRARY_LISTStephan Bergmann
...where both entries were added with 40fe721462df5bedacddc8829cefc3d739cf940f "add some more libs to libmerged", and defining Library_stringresource in scripting/Module_scripting.mk is conditional on BUILD_TYPE SCRIPTING. This will hopefully fix <https://ci.libreoffice.org/job/lo_callgrind_linux/7884/> (which apparently uses --enable-mergelibs), > /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/scripting/source/stringresource/stringresource.o: in function `stringresource::StringResourceImpl::isReadOnly()': > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/scripting/source/stringresource/stringresource.cxx:297: multiple definition of `stringresource::StringResourceImpl::isReadOnly()'; /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/scripting/source/stringresource/stringresource.o:/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/scripting/source/stringresource/stringresource.cxx:297: first defined here > /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/scripting/source/stringresource/stringresource.o: in function `stringresource::StringResourceImpl::loadLocale(stringresource::LocaleItem*)': > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/scripting/source/stringresource/stringresource.cxx:659: multiple definition of `stringresource::StringResourceImpl::loadLocale(stringresource::LocaleItem*)'; /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/scripting/source/stringresource/stringresource.o:/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/scripting/source/stringresource/stringresource.cxx:659: first defined here [...] Change-Id: Ie667487bced048d3b0b0081a9fa4abafa090f02b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88468 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-02-11tdf#130478 add direct dash paint in GDIPlus (win)Armin Le Grand (Collabora)
Not as easy as hoped, see more info in the adapted file vcl\win\gdi\gdiimpl.cxx itself. Change-Id: I265888c65658d5e8a2a04b6f064d2baf3e1d9bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88463 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-11UI test for tdf#128739Artur Neumann
cut, paste and undo with documents containing fieldmarks and bookmarks Change-Id: I4ee8edf061f7cdb08ae90bee32ac07b6a0980cc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84054 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Introduce INCLUDE: in the distro-configs...Jan Holesovsky
...to be able to have a common base for things, and then apply some additional stuff on top - in this case the Android branding for the CP builds. Change-Id: I43118bba84fddb8508cc4688c83c2d81a103d781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88440 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 8dd75f47d9d571ed557fd360b8f9ff7aaca335af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88400 Tested-by: Jenkins
2020-02-11neon: drop special whitespace href handlingJan-Marek Glogowski
Since whitespace (0x20, 0x09) in the URI path is now included in the neon_uri_parse_allow_others.patch to accept SharePoint IRIs as valid URIs, drop that hunk and document a link to the upstream discussion in the Makefile. Change-Id: I7b776e9bcaa716069b0f83a97499cf49e5ed1644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88447 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2020-02-11Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 614eb3429622290c320d137cfa9d8b908c56f9ab - update translations for master and force-fix errors using pocheck Change-Id: Ib8c90ab28e150c029e92a9621e65cf00ebba33c6
2020-02-11move GraphicReader class out of graph.hxxTomaž Vajngerl
Change-Id: Id78995bfb8e8308a388ed542690ad85e4d19ce12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88425 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-11clean-up namespaces in graphicprimitive2d.hxxTomaž Vajngerl
Change-Id: I98975660a54e21ec33007ca1f21e7fd39b92f257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88242 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-11remove graphicprimitive2d.{cxx,hxx} from clang-format blacklistTomaž Vajngerl
Change-Id: Ice9a6813743e4238d28d6007bb0092c69685a9fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88241 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-11tdf#130555: Prevent negative aSelection.Min()Stephan Bergmann
...which would violate the the preconditions of the later call to maText.remove. When BreakIteratorImpl::previousWord (i18npool/source/breakiterator/breakiteratorImpl.cxx) is called to e.g. move back over a single space at the start of the text, at least for an en-US locale it will fall through to the call to BreakIterator_Unicode::previousWord (i18npool/source/breakiterator/breakiterator_unicode.cxx) at the bottom of the function. That in turn calls icu::BreakIterator::preceding, which is documented (workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) to return icu::BreakIterator::DONE (i.e., -1, see workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) in that case, which causes BreakIterator_Unicode::previousWord to return a Boundary with startPos == endPos == -1. The documentation of UNO method css.i18n.XBreakIterator::previousWord (offapi/com/sun/star/i18n/XBreakIterator.idl) is silent about the expected return value in such a case. But lets assume that returning such a [-1..-1] Boundary is as intended, and locally address this case in Edit::ImplDelete, making aSelection start at the start of the text. Change-Id: I40e17ba602088e72aa6962cb41dd8e1cdf6e2561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88431 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-11make Base install via packagekit also confgurable (like fonts/langpacks)Rene Engelhard
Change-Id: I72f98e89d1c8e92f10da8e3843956658d035528d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87907 Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-11tdf#114694: Make default value in language settings the first elementYusuf Keten
For Languages, to make the default value ​​the first element in the list, I've added 3 parameters to SvxLanguageBox::SetLanguageList(). With this parameters, function adds default value according to its existence before other values. For sorting User Interface and Currency, I removed the make_sorted function. I added std::sort with lambda expressions for both of them. Change-Id: Iae37bfe09aaac4d8ecde1caad7a14e11df551eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87926 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-11tdf#57879 - Expand word boundaries to include connector punctuationsAndreas Heinisch
In the IDE expand word boundaries for strings in order to fully select names for double clicks and Ctrl+Shft+Left/Right. Change-Id: I4662b2170fdd5891dc020c08b9a9d8db8d477541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86597 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11ensure the module combobox gets updated with the current selectionCaolán McNamara
Change-Id: Ia9bf71c1890d9f2700a67ad9a3727dbf140c0492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11Fix csv dialog pops up on mobile when copy/pasteMert Tumer
Change-Id: I9e4b154090ad9da0d10a368656f6f63fe335cecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87132 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit f99605b6df506d51411d22d377eafd722685edbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88397 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11tdf#130494: DOCX import: limit paragraph-level character propertyLászló Németh
expansion for the whole table paragraph based on the last character context. regression from 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 (tdf#90069 DOCX: fix character style of new table rows) Change-Id: I49da23c268436488ff1537771869c38108113c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88199 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-11Fix typoAndrea Gelmini
Change-Id: I57990148b75dc00ab7725e6917bc7971f5dde2d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88445 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-11tdf#126744 Transfer paper size and orientation to new printerKelemen Gábor
when selected from the Printer dropdown list Change-Id: Iedd53575c2e9146b663cf21b42b495473abe5165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-11android: Actually let's avoid the exceptions via bridges only on aarch4.Jan Holesovsky
Change-Id: Id2830f09ca6afd11f6f866565f37bdb7ba45bfb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84205 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11tdf#129346: Add UItestXisco Fauli
Change-Id: I491659d3bc5657c4eda2d88849acb0c4972b0c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88429 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara
xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11add some more libs to libmergedNoel Grandin
and fix a consequent symbol name clash in basctl Change-Id: Idc836fcbb379e1046a60008391635eb6241b27c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11DOCX import: fix margins of inline shapes with effects, imported as Draw shapesMiklos Vajna
Effects have an extent, and unhandled effects (like this blurred shadow) need to take space in the margin of the shape to make sure they use the correct amount of space in the layout. This was working in general, but not in case the importer decided to import the shape as Draw shape + the shape was inline. (And also disable a new CppunitTest_sw_uibase_shells test on Windows, which is only stable on Linux, it seems.) Change-Id: I9d0531d9393d8c2cd274e6f54bbbfe8024bf270f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88427 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-11update creditsChristian Lohmaier
Change-Id: I21a49cb649ebdc6b8af50f0b92decb77887e721c
2020-02-11Writer Sidebar Wrap section update for better alignment and fitandreas kainz
Change-Id: I9bb3054f5e55346f09828e5ce7220445794c5880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88411 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-11weld FillControl item windowCaolán McNamara
Change-Id: I5f943a9cf881494fe8a9fecea6a957a7085a5582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11tdf#124176: Use pragma once instead of include guardsFurkan Ahmet Kara
Change-Id: I4f0ff5864f343c016ae88477e064b0c643cd0d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88268 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-11Drop some static_cast from long to sal_Int32Stephan Bergmann
...that would just silently hide overflow in the unexpected case that the given long values do not fit into sal_Int32. (These casts had been carried over in 3270fc628b2e6a8f73ff0d1e4389d9c7595e0a50 "use OUString(Buffer) in class Edit" from the casts to xub_StrLen, aka sal_uInt16, that were present ever since 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import".) Change-Id: I1775f44d386389f00051f11cc9d1911b10feb427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88432 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-11related: tdf#106742 sw: DOCX import/export: fix default of table indentMichael Stahl
There's a compatibilityMode in word/settings.xml in DOCX files: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/90138c4d-eb18-4edc-aa6c-dfb799cb1d0d If a document doesn't contain compatibilityMode, then the default is 12, but the code for table indent import/export assumed that the default is 15, so loading an ODF document and exporting as DOCX results in wrong table indent when loaded in Word. (regression from 9a31d1c83e08600507689dc18f6f0973bc7e4389) Change-Id: I3ce32286473640e5b7e12b487aef5f123bfb8d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88408 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-11tdf#42949 Fix IWYU warnings in writerperfect/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1ac2b3d254487f6b4e85b52eead13635d30a5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88416 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-11android hunspell: All languages we pack are the supported ones.Jan Holesovsky
Without this, we disable all the languages, because the env. variable is not set. Change-Id: If8f6a9ec6270391d1f8c2bf225c8ea4bb1aae688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88220 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88367 Tested-by: Jenkins
2020-02-11on main window getting focus gtk is destroying the popup windows itselfCaolán McNamara
so copy the data we need before it can do that Change-Id: If35d7ba0f272475e82f969bd80c6ff44131a3d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88376 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11surface attribute disappearedCaolán McNamara
Change-Id: I195fc92ff6fea962ceca06df5e5e562d729bcc5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11SplitWindow::ImplDrawBack is effectively unusedNoel Grandin
ever since commit facc94bb0aef58353d54e14f948790643ccbec32 Date: Thu Jan 30 14:36:57 2020 +0200 loplugin:unusedfields Change-Id: Idb09424a09074abe77d6d5b63ea4a526a3bb7ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to e6e4a01c2ae198bde731045f4451ba345877cadb - update Online Update help page - add headings - correct outline level - add control - align help page with dialog box - added "online update" icon - updated "note" about installation of Update module, a common intro, with sys-specific details. Change-Id: Id237acbb93ec90a6d7622135e5bdc212f28ca1a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87810 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-20 03:22:55 +0000