summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-25check if edit can be enabled after setting cursor into treeCaolán McNamara
Change-Id: I264dc4db7e3ddc64faf0edec18d96d2c46ce00f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25Resolves: tdf130874 reversed logicCaolán McNamara
Change-Id: I2ccac01f271ec803547ab36359f2273312df87e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89451 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25tdf#123757 DOCX import: separate different style tablesLászló Németh
to avoid of losing table layout, color etc. during their prohibited combination into one table: table style of the second table overwrote the table style of the first table, or without table style, the second table was overwritten by the table style of the first table. Change-Id: I0a2663d41f7d019e7b329198944a300260025b65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89416 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-25vcl: move GraphicID out of impgraph.{cxx,hxx}Tomaž Vajngerl
Change-Id: I0b3b17736a76be290f6e5b77ee547b7e650d4489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89449 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-25tdf#128814 follow up: check for nullptr and dispose unused sub pop menuJim Raykowski
Prevent nullptr crash in lcl_IsContent and dispose and clear sub pop outline tracking menu if unused. Change-Id: I6d3e1a48776426ae18156cc70b799f74f349bf5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89410 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-02-25tdf#130915 second treeview doesn't use its checkboxesCaolán McNamara
so we end up with blank lines under gtk Change-Id: I869c451dafe8dab0227ab8c914500ea059634c3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89447 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25[API CHANGE] remove BasicImport UNO interfacesNoel Grandin
which are unused since commit 4e97fa0f4e73acdf522643aeec486b1395e63727 Date: Thu Feb 20 13:09:32 2020 +0200 use fast-parser APIs for embedded script parsing and highly unlikely to be externally used since they parse document internal script code. Change-Id: I2e0e237fb31bba85f1ef63c88f3a6959eedf2ca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25fix --enable-mergedlibs buildNoel Grandin
after my recent additions to the list of libs exceeded Windows command line length limit (mostly affecting those people whose workspace was under a fairly long folder name) Change-Id: I4d60e9704db49f0a3f562200b737879fba7ee5a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25tdf#130915 SvTreeList::Move needs to move from lower index to higherCaolán McNamara
the reverse doesn't work Change-Id: I0d84e6e44b26c0c4f1f0d221de3fad03c183f6ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25tdf#130711: [tr] Extend Autocorrect list for Turkish language (Start with B)Hakan Bakacak
Change-Id: I566233c184fd67032828cfe53ea84fa1b5e876c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88825 Tested-by: Jenkins Reviewed-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org> Reviewed-by: Yusuf Keten <ketenyusuf@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-25Resolves tdf#127782 - New Print dialog is too highHeiko Tietze
Amends Iea41f9cf335b75210de0acf5688fddd5e3dd3dbb Change-Id: Ic669332245ad9c5ee6366765da8a5bc632dd159c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89423 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-25SVG export: try to reuse original bitmap data for JPG and PNG bitmapsMiklos Vajna
This has a number of benefits: 1) For a sample JPG photo, the SVG output is now 4,9MB, not 20MB. 2) Even the first export to SVG is fast, see commit 570be56b37e4ff105649e604ff4c8a6c368e2e79 (svx: cache PNG export of graphic shapes, 2020-02-25) for exact numbers. 3) Allow using less memory as the SdrGrafObj doesn't have to store a PNG result till the document is closed. We still require matching checksums, so in case anything problematic happens with the bitmap (grayscale filter applied, etc), then the optimization is meant to not help, but still produces correct output. Change-Id: Id3bc359a8dcc4c4d12d3b66ffb512cfa71939a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89419 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-25turn off dnd target indicator on old target when changing targetCaolán McNamara
Change-Id: Ia1cd181789679fd3f99c791806bd53cb74076556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89421 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25cancelling drag from drag-begin doesn't work, call it asyncCaolán McNamara
Change-Id: I9323e8ab4d3df9f2ded0c7bfb21582faa3b5e1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25Resolves: tdf#130922 don't crash removing non-existing elementsCaolán McNamara
Change-Id: Id05faf6537ae096d563c57dcde71cd65ae04152d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25Revert "WordCountDIalog in vertical mobile version"Szymon Kłos
This reverts commit 4ab0993f2537fade3c02b788508519070f44ebb8. This reverts commit 542f509a41cf0cae7fca0660ba3858c6b0e9bf52. Change-Id: I25a96f672ab83c14b806c24fb2f9397679775f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89375 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-25sw: DOCX export: limit FORMDROPDOWN listEntry to Word's abilitiesMichael Stahl
In theory wml.xsd says: <xsd:element name="listEntry" type="CT_String" minOccurs="0" maxOccurs="unbounded"/> In practice Word 2013 refuses to load a file with 26 listEntry in one FORMDROPDOWN field. Interestingly w:result w:val larger than the number of entries does not cause Word to complain. Go figure. Change-Id: I3a61533f9ee4ba3917a9c3bc55a483fd587f0471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89358 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-25tdf#42949 Fix IWYU warnings in svx/source/sdr/*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I332729acbf2f5b5b24b6907dad09c5c5ded94f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89290 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-25svx: cache PNG export of graphic shapesMiklos Vajna
One scenario where this is useful is: manipulate a JPEG photo in Online's Impress, e.g. resize it multiple times. Each time we generate an SVG preview of the shape, which includes the PNG export of the bitmap itself. This helps with a desktop CPU: debug:9976:9974: SVGFilter::filter finished in 3422 ms debug:9976:9974: SVGFilter::filter finished in 176 ms But it is meant to help on mobile, too, where writing such a bitmap as PNG takes 16-17 seconds without this. (This works because SVG writes the original bitmap, even if it's scaled. If that invariant will be broken in the future, we still emit correct output, but then the cache will be less useful.) Change-Id: I7204b04efeeb42c6eec67f04dfdb8a4ed50443a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89377 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-25inherit SdTransferable from TransferDataContainer instead of TransferableHelperCaolán McNamara
Change-Id: I0c3628e5e280e8060f0e6890902253ad455d6293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25Fix currency symbol selection in Calc on mobileTomaž Vajngerl
In LOK we use one language identifier for both - UI language and the locale used. This is a problem when we determine that we a language for UI is not available and fall-back to the default "en-US" langauge, which also changes the locale. This introduces a separate variable that stores the language tag for the locale independently to the language. Another problem is that in some cases we don't reset the staticly initialized data, when the new document is loaded, which is on the other hand used to define which currency symbol is used as SYSTEM locale. That can in some cases select the wrong currency symbol even when we changed the locale to something else. This fix introduces a reset function, which is triggered on every document load. Change-Id: I55c7f467600a832895f94346f8bf11a6ef6a1e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89320 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89343 Tested-by: Jenkins
2020-02-25tdf#91219 sw: don't allow anchoring a shape+textbox into itselfMiklos Vajna
We already have code that detects this in the simple fly frame case, extend that to cover the "paired fly frame + draw shape" case as well. Change-Id: I4b3c1d600407436b239fee311ae6bfe837804241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89381 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-25tdf#130912: "Before" and "After" text swapped in footnotesJulien Nabet
Change-Id: I8022d3ec2385d35283711a144f6d610357790771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89387 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25loplugin:referencecastingNoel Grandin
getting --enable-pch=normal working with clang means that the plugins now have a better view on some stuff, so trigger more warnings Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25Convert gentoken from Perl to Python.Jussi Pakkanen
See tdf#130911 for motivation. Change-Id: I62759a9c7766e5c62c6fbab06c15e8300df25935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89262 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-25jsdialog: Refresh dialog after actionSzymon Kłos
Change-Id: I83e5750f91789fcd01ba41cab616c5e768492bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89369 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-25Move SalInstanceEdit declaration to the header fileSzymon Kłos
Change-Id: I660de317b88c4e83ccc310743dc4ef5b4c955a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89370 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-25add GatherField member functionBjoern Michaelsen
Change-Id: Ifa2ea333ccccec240cc10374fd6539a8b3f6df46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89316 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-02-25Fix typoJens Carl
Change-Id: If3ba0858340e66294eff8aeec58f6252ce1e6227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89406 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-25six: upgrade release to 1.14.0 used by gdbJens Carl
Change-Id: I450f5cd83e116baab8d1750a9ed7def002e234c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89317 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-25Unit test tdf#130370 cut&paste / move with sheet-local named referenceEike Rathke
Change-Id: I28473558e028012ce0a4ca881549e808bc34aad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89391 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2020-02-24tdf#95845: Use CommandInfoProvider to receive UNO command labelsPelin Kuran
Change-Id: Id8fb7304ca5f8cc8c5b94504fb891b56769a57c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88756 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-24Postgresql unused POSTGRE_TRACEJulien Nabet
there was "#ifdef POSTGRE_TRACE", but it was nowhere to be seen except in the following purged files. Change-Id: Id77aef0869d112cb1a5282d8db79da4bc78a56e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89378 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-02-24tdf#130817: Add unittestXisco Fauli
Change-Id: Icb7db08dc7884074f980ab101eac8a1998482ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89367 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130814: Add unittestXisco Fauli
Change-Id: I9ed69e42cd7128aafc3621e51ce26249895629d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89335 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24IsDropFormatSupported(...::SIMPLE_FILE) is always falseCaolán McNamara
for this navigator as far as I can tell so reduce accordingly Change-Id: I8c8b62487d6aa94114c523d8d4a9ebb71a0896c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-24Fix typoAndrea Gelmini
Change-Id: I49b314270eb81bfaac709ad210d1c94743d95d4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89366 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-24Fix typoAndrea Gelmini
to complete: https://gerrit.libreoffice.org/c/core/+/89082 Change-Id: I8363f05f15c8d4ef032ccc8d469dc29231d74ca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89360 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24vcl: GCC 9.2.1 -Werror=format-overflowMichael Stahl
vcl/source/gdi/metaact.cxx:104:26: error: ‘%u’ directive writing between 1 and 10 bytes into a region of size 6 [-Werror=format-overflow=] 104 | sprintf(buffer, "%u", static_cast<unsigned int>(nMetaAction)); Change-Id: Iec295a5a2477b2a13d771c392e0de6c3920a2eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89350 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24boost: disable -Wmaybe-uninitialized from GCC 9.2.1 -OgMichael Stahl
This warning is notorious for false positives so let's disable it here. from sal/cppunittester/cppunittester.cxx:61: workdir/UnpackedTarball/boost/boost/function/function_template.hpp: In function ‘SequenceSequenceT& boost::algorithm::iter_split(SequenceSequenceT&, RangeT&&, FinderT) [with SequenceSequenceT = std::__debug::vector<std::__cxx11::basic_string<char> >; RangeT = const char*&; FinderT = boost::algorithm::detail::token_finderF<boost::algorithm::detail::is_any_ofF<char> >]’: workdir/UnpackedTarball/boost/boost/function/function_template.hpp:904:22: error: ‘*((void*)&<anonymous> +8)’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 904 | std::memcpy(this->functor.data, f.functor.data, sizeof(boost::detail::function::function_buffer)); Change-Id: Id3cf9fae8db190337b6a3eb0c847c019394088ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89349 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24boost: remove unused boost wrapper headersMichael Stahl
Change-Id: I543e60e295cf87f773f05faf6cfb8da285fac466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89348 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 03e9a3022cc686013fbadfe16aef8685800ac625 - Update help page for Navigator for Master - put Move Up and Move Down in same order as Navigator - Delete now needs a right click, also explain that file is not deleted. - add Related Topics sections (and move link down to there) Change-Id: I92c5ff4a5ef98f568a36e0a1edb8c20474110821 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89284 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-02-24tdf#130762: Add uitestXisco Fauli
Change-Id: Iff2cedfec6e17a46f160797d32fd1a565abfe0f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89342 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130717 Adding 3D Window option to Format MenuShivam Kumar Singh
Change-Id: Iae57419519ea0ff43549c9283e591e2d76eea7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89237 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-24Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 81d34863f3a8d919639341bbb15b1bc28bb68dec - update help page about working with Master documents - correct command for adding files - generalize command about exporting to text documents, and correct the command instructions. - add link in Related topics to Master documents Change-Id: Ifc7c0ed4893d837e3af98bdac751de60d0971080 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89283 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-02-24Update git submodulesMohamed Sameh
* Update helpcontent2 from branch 'master' to 1936bfe6697be30202547a7775bda81d6b8d0211 - tdf#129878: Add FMT error code into help pages Change-Id: I657fc04d54e2fdeedaea01d2d23e0ab79bf5d4ee Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89269 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-24Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 9040e3925e3f217b3b681a2dc931c177c26cc420 - update control and command labels in Font effects help page - "Effects" -> "Case" heading - update "case" labels in Writer - add "Text Decoration" heading - correct heading levels of controls - align order of control presentation with dialog box - adjust module-conditional display of controls - corrected menuitem name for showing Hidden characters Change-Id: I3d8a0bdcb1b6c8442ba662a751116ee3f2c2252b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87807 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-24Fix typoAndrea Gelmini
to complete: https://gerrit.libreoffice.org/c/core/+/89318 Change-Id: I6c5dea07cdcb59b44e9ee8472aa6a4cace394483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89355 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-24tdf#42949 Fix IWYU warnings in svx/source/[f-m]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I103c5c7f1a74e8c3a021a91c7a96ebc87cb19efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89263 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-04-28 05:33:47 +0000