summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-06-15tdf#35568 Repeat "first run" procedure on upgradeMike Kaganski
1. In isProductVersionUpgraded, if it was upgraded, set FirstRun. This will run in runGraphicsRenderTests, early enough in Desktop::Main(). 2. This will make sure that Desktop::CheckFirstRun() will do its tasks, including creation of the quickstart shortcut. It is simplified a bit, to use a better WinAPI. 3. Setting FirstRun to false is moved to m_firstRunTimer's handler, to make sure that it gets run eventually, even if the first launch was terminated before the timer fired. This will not make installer itself create the quickstart shortcut: it will happen on the program's first run after an upgrade. But users now won't have to enable the option manually each time. Change-Id: Ica6cc41f1e56b8970db27d14e2be3c47910293e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168902 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-15tdf#143148 use pragma once instead of include guardsrichtrimble
Change-Id: I1c9dff3b7d4dbaa3b3de224576b2182d1f893619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168649 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-06-15Simplify a bitMike Kaganski
Change-Id: Iae8af8904a445a523c1aecda6777ea4e2ce30598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168900 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-15SequenceAsHashMap::contains can be constMike Kaganski
Change-Id: I1f908eec2b8b809f5d1d9f8cac27bac9ba60df8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168899 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-15Reduce console noiseMike Kaganski
warn:unotools.misc:21376:31920:unotools/source/misc/mediadescriptor.cxx:372: url: 'private:factory/scalc' com.sun.star.ucb.ContentCreationException message: "No Content Provider available for URL: private:factory/scalc at C:/lo/core/ucbhelper/source/client/content.cxx:205" eError: (com.sun.star.ucb.ContentCreationError) NO_CONTENT_PROVIDER Change-Id: Ibb430ed0779f2064975b8fcc43204164adaeb8d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168895 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-15tdf#161563 sw: show "No Break" context menu only on a whole wordLászló Németh
It's possible to set CharNoHyphenation on shorter character sequences, than a word, but the result is not correct (use soft hyphens for alternative hyphenation within words), so limit "No Break" menu item only for selected words. (Not completely, because only Point() is checked for word boundary yet, not also Mark().) If no selection, cursor position must be within the hyphenated word (where "No Break" applied for the whole word automatically). This fixes also the assert in SwTextFrame::IsInHyphenatedWord(), when multiple nodes were selected. Follow-up to commit 2f0c7d5691acd4010443856788a54b0abc03098b "tdf#161563 tdf#161565 sw: add No Break to word context menu & visualize". Change-Id: I41b64e6a2eb0daf08f488420fc1eaba2045a28db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168898 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-06-15annot: support fill and line transparence for PDF annotationsTomaž Vajngerl
Change-Id: Iafff527a094e6cb550a9e060a191510f74d86075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168841 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-15Fix MSVC buildMike Kaganski
C:/BuildLO/core/svx/source/table/tablehtmlimporter.cxx(500): error C2220: the following warning is treated as an error C:\BuildLO\core\svx\source\table\tablehtmlimporter.cxx(446) : warning C6011: Dereferencing NULL pointer 'mpActDefault'. : Lines: 428, 429, 430, 440, 441, 443, 444, 445, 446 Change-Id: I2af1635a714cba3d27eb6b8b25db9b4c4aeaaade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168894 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-06-15tdf#158914 add back reusing weakly cached ScAccessibleCellsPatrick Luby
While commit 8e886993f32b7db11a99bdecf06451e6de6c3842 fixed tdf#157568, moving the selected cell rapidly creates a large number of stale ScAccessibleCell instances that aren't deleted until the Calc document is closed. So reduce memory usage by adding back the ScAccessibleCell cache that was in commit f22cb3dfab413a2917cd810b8e1b8f644a016327 now that a new fix for tdf#157568 has been implemented. The new fix for tdf#157568 is to do the following: - Check if the edit engine text has changed. If the input string is different than the edit engine's existing text, force update of the edit engine's text. Otherwise, the edit engine will still to be set to its existing text. - Before a cell loses focus, check if any accessible text changes have occurred and fire text and value changed notifications if needed. Change-Id: I106ad0138d5d834367be59ca625d41a692696d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167961 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-14tdf#68034: sc_goal_seek: Add unittestXisco Fauli
Change-Id: I675d59cd7e22c09ea1c673e016d71f8d3ed404a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168890 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-14android-viewer translated using WeblateWeblate
Interlingua currently translated at 75.0% (87 of 116 strings) Change-Id: I863bf24dd6469ec7a263811d3c7b6cb1dbd907f2 Co-authored-by: SoftInterlingua <softinterlingua@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168820 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-06-14wina11y: Fix handling for special text offset -1Michael Weghorn
As described in the IAccessible2 spec [1], -1 can be used as a special text offset: > Using IA2_TEXT_OFFSET_LENGTH (-1) as an offset in any of the > IAccessibleText or IAccessibleEditableText methods is the same > as specifying the length of the string. Replace -1 by the text length *before* doing the check whether end offset is smaller than the start offset. Otherwise, trying to query the whole text of a Writer paragraph containing the text "hello" in NVDA's Python console would incorrectly trigger an error: >>> focus.IAccessibleTextObject.text(0,-1) Traceback (most recent call last): File "<console>", line 1, in <module> File "comtypes\__init__.pyc", line 856, in __call__ File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__ _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None)) With this commit in place, it works as expected: >>> focus.IAccessibleTextObject.text(0,-1) 'hello' [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/_general_info.html#_specialOffsets Change-Id: I489a42270a56178cc8ee0564eec3dc82e15969c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168853 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-06-14tdf#147864 Replace 'Show All' and 'Hide All' in the Comments categorySujatro Bhadra
context menu of Writer Navigator with togglable commands 'Show Comments' and 'Show Resolved Comments' Change-Id: I7ac00c5366327f8d245ca49595eca2fd1fac472c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166539 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-06-14tdf#144208 speedup doc with lots of redline (11)Noel Grandin
reduce the amount of sorting work we need to do in the m_HintsBy* maps, by storing the range of elements we need to resort Change-Id: I93bd22c9bfcf41f7c02828e184ff1170700cdcc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168857 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-14tdf#161573: Do not show unrelated messages during broken ZIP detectionMike Kaganski
Change-Id: Iab7f4bb492e24eb2ca6448f3540d219a18c15d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168869 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-14crashtesting: avoid eventual assert when double inf is cast to sal_Int32Caolán McNamara
seen on loading forum-mso-en4-604220.xlsx and asserting on export to ods lets assume that an infinite Y position equates to ALIGN_BOTTOM which is the case seen in this example, and assume the same for infinite X and ALIGN_RIGHT if it arises Change-Id: I009a9cd94b7bd9ed66e18f8dbbb9eb91d37eaa65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-14crashtesting: out of bounds on reexport of forum-mso-en4-290152.pptx to pptxCaolán McNamara
probably since: commit 805fd61f8efaaac119bbe28ab51617c07f0d7058 Date: Thu Jun 6 19:47:45 2024 +0200 tdf#160591 PPTX export: fix colormap mapping in slide master Change-Id: I154f0ff1769fbda361ec62f1dd589ca0d7686bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168506 Change-Id: I3ec45b2a0b78324e8512acbcc3a7544c196f670d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-14when SAL_CUPS_PPD_RETAIN_TMP is set output what the ppd file was saved asCaolán McNamara
Change-Id: Ib17ec39a5b2691190c5eb1291d1977e1b83eba15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-14loplugin:ostr in swNoel Grandin
Change-Id: Ibc8c3ce70d572e2e07ee6ae1e46996943cf90a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168840 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-14sw doc model xml dump: SwStartNode::dumpAsXml() is never called for tablesMiklos Vajna
SwTableNode is a subclass of SwStartNode, and SwTableNode provides its own SwTableNode::dumpAsXml(), so this is dead code. Change-Id: I051398c0e004839b750ea642dc636eeab8d73fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168891 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-14tdf#161511: sc_goal_seek: Add unittestXisco Fauli
Change-Id: Icc05195a4870d5bb4f8c5ffc9b3bcae89367a89d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14tdf#68034: set the variable cell to value temporarily if neededMike Kaganski
Change-Id: I35fed710862ed87c477686e26bc8c82379c5e5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168854 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-14tdf#160522 Chart > 4 columns, Only 4 colorsNoel Grandin
regression from commit 337a9a454c1bc95214111578d3f9c0622c55c509 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon May 18 09:17:04 2020 +0200 use for-range on Sequence in chart2 Change-Id: I94f9460e45e5910af1de905605158f9dc1dbedfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-14tdf#150582 linguistic: fix always rejected words with U+2019 apostropheLászló Németh
During spell checking, words added to the user dictionaries still weren't recognized by Calc, Impress and Draw because of the unnecessary conversion their typographic apostrophes to ASCII apostrophes. Note: Writer has no such problem because of its (obsolete) apostrophe conversion for the user dictionary. First skip the obsolete apostrophe conversion in isValid(), but keep it as a fallback for Writer users. Change-Id: I09870a35d7a91017281ba4b228d338336e7bd9c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168858 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-14tdf#92091 Writer save and restore VCL state during recursionJonathan Clark
This change updates Writer to save and restore VCL device state while laying out text. This fixes issues caused by Writer mutating device state while recursively laying out text, particularly overlapping RTL and LTR text when used together along with footnotes. Change-Id: I077352551ce2072f5c5eab9bff4b98bbcc6e78f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168835 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-06-14sw: add update button to a11y check sidebar when using LOKitTomaž Vajngerl
Running the a11y check when the sidebar gets enable takes some time, because populating the widgets is quite expensive. Instead of running the check right away, add a "update" button to the sidebar, that needs to be clicked first to start running the accessibility check. This does not check the behavior of the sidebar in desktop LibreOffice. Also change the populate call to be async, which helps a bit to make the UI interaction more fluent, but doesn't fix the issue. Change-Id: Ia04f4a5fbae952035c1b8d4d7c56211e061d8251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167855 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 5e6d7927e27551aa63a2b22134b1a9ee6408d39a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168784 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14CppunitTest_sc_copypaste: inherit from ScModelTestBaseXisco Fauli
Change-Id: I0847ba4455cec24332030e87244c0d9c9ad2ad2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168859 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14reduce code duplication in SwpHintsNoel Grandin
Change-Id: Id62389b1a11cd0ec2d04923d037ddcf3ab6b71f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-14tdf#161346 sw: PDF export: fix crash on field in hidden text frameMichael Stahl
When creating a link rectangle for a SwGetRefField, the problem is that the cursor is positioned on 2 different nodes with 2 different text frames, neither of which is the node that contains the field; this happens because that node's text frame has a height of 0, so IsSelOvr() moves the cursor to a previous node. Check that SwCursorShell::GotoFormatField() did in fact go to the field. (regression from commit 9ba8d68c2b2fd06340bbdcb61dc3d57f6e3eb974) Change-Id: Ib74533f46dce8fb05224fddfff12e49577346b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168860 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-06-14CppunitTest_sc_jumbosheets_test: inherit from ScModelTestBaseXisco Fauli
Change-Id: Ifc35741c0d46dfbf3366696ea70284c382617a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168861 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-14Make isProductVersionUpgraded update ooSetupLastVersion againMike Kaganski
This was changed in commit dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1 (Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog, 2024-03-27). This change doesn't require opening a module (and checking if WhatsNew dialog is needed) to update the configuration - it will be updated immediately in runGraphicsRenderTests. Change-Id: I595b6898c46998e7a0805ffbf7a710dbf0d2a5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168855 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-14Update pdfium to 6536Miklos Vajna
Drop part of build.patch.1, which is no longer needed. Change-Id: Ie68364d473d344904fd55ced2cd0915534fa816c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168838 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-14tdf#158658 sw: text formatting: make TabOverMargin even more crazyMichael Stahl
... to better match Word's formatting. The bugdoc has a special case where a right-aligned tab is positioned at the right margin exactly, which causes the bFull condition in SwTabPortion::PreFormat() to be true. An obvious change to replace rInf.Width() - rInf.X() with rInf.GetLineWidth() in the condition makes no difference because m_pLastTab was already reset previously; instead, pass in the last tab from Format(), which indicates that the right edge position of the previous text portion was found via that tab. Additionally, change the condition that checks for TabOverMargin to also allow equal positions, i.e., exactly at the end of the paragraph. Change-Id: I5d3b1c13eca0bffa640745d7c5f4113699f79cad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168823 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-14tdf#158658 sw: text formatting: try to make TabOverMargin more crazyMichael Stahl
... to better match Word's formatting; this commit is not based on a complete diagnosis of Word's compatibility-mode tab-in-margin formatting disorders. 1. in SwTabPortion::PreFormat() allow a left aligned tab beyond the width of the paragraph, like already done for TabOverSpacing 2. in SwTextFormatInfo::GetLineWidth() add some extra width to the paragraph so text can be hidden in the right margin. (it's very unclear what Word does here exactly, in one case it puts 339 additional "a" characters in the margin but then the 340th "a" goes onto a new line...) 3. in SwTextFormatter::NewTabPortion() allow manual tab stops to be positioned beyond the width of the paragraph, like already done for TabOverSpacing testTdf118672, testTdf120287b, testTdf120287c fail but the files, converted to RTF, render in Word 2013 basically the same as in Writer with this change. Change-Id: I5f74ced09c704bfd9967df61351c8bac6540e714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168819 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-14sw: show "wait" pointer while accessibility check is runningTomaž Vajngerl
Change-Id: I234af45560db7940d07669be9abd1b1ec50a74cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167880 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 10ef0f03bb6a9efc0dcabe8710b59bd7b41a2fcf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168783 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-14prefer simple HTML format over RTF while pasting clipboard contentOliver Specht
This changes applies to draw text, only JUnit test is included Basic HTML table import is included. Change-Id: I00387f3932c0aa54099c9bc7390ad86b4398b417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162871 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-06-14tdf#144208 speedup doc with lots of redline (10)Noel Grandin
don't call SwRDFHelper::getStatements for every single paragraph, we can call this once and re-use the result Change-Id: I0277ecbb113b8333839172bddd7978f4b3a7259a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168850 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-14sw: fix SwTextFrameInfo::GetSpaces() for line containing only spacesMichael Stahl
This would assert: frminf.cxx:139: void AddRange(): Assertion `rRanges.empty() || rRanges.back().second <= nPos' failed. Change-Id: Ib41f4c6c971fee9307140c108e74d5df7d94c973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168824 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-14tdf#161563 tdf#161565 sw: add No Break to word context menu & visualizeLászló Németh
Add No Break option to context menu of words hyphenated automatically, giving as easy access to fix paragraph layout, as context menu of misspelled words – like DTP software do. Also add this option to context menu of words with enabled "No Break" to disable it. To avoid unwanted paragraph layout during further text editing or formatting, visualize words excluded from hyphenation with a light gray dotted underline, when Formatting Marks is enabled. Follow-up to commit b5e275f47a54bd7fee39dad516a433fde5be872d "tdf#106733 sw: implement CharNoHyphenation" and commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372 "tdf#106733 xmloff: keep fo:hyphenate in character formatting". Change-Id: I81bb410abcf999c8d9a3dca28acfc5c21aa0f260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168827 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-14tdf#144208 speedup doc with lots of redline (9)Noel Grandin
only compute start/end once, the cost of calculating them is not trivial Change-Id: I48d001be00359c50ec8ca28134079d062867a520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168839 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-14Flatten a bitMike Kaganski
Change-Id: If021f2edf8e4029d22118a2ed369b21a3a7215da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168836 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-14annot: make sure the annotation subtypes in PDFium match with oursTomaž Vajngerl
Change-Id: Ic18f394b532118f39988a650d046880b049c9ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168810 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: read PDF FreeText annotation "DS" and "RC" keysTomaž Vajngerl
DS (DefaultStyle) and RC (RichContent") contain xhtml, css3 rich text content for the text presented by the FreeText annotation in the document. This adds reading of those 2 things to the PDFium library, PDFium based import and the PDFAnnotationFreeTextMarker class. Change-Id: I32f89640611c730c8a1a8d1a2107e2e11669ec18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168787 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-14tdf#161338: Pass a flag to ScDocument::Solver to avoid #NA! on errorMike Kaganski
This fixes the remaining problems: 1. It didn't restore variable cells with text of formulas properly. 2. Undoing after accepting the "closest value" dialog gave #NA! in the variable cell. This doesn't change the behavior of XGoalSeek::seekGoal. Change-Id: Ic9fbd3c99e6491b1c54b2e3b334090e51b1be661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168763 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-14vcl: convert PDFiumLibraryTest to CPPUNIT_TEST_FIXTURETomaž Vajngerl
Change-Id: I5022bec2622c7dc7ddf1e58b4a370551574281c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168786 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: add support to import Stamp annotation from PDFTomaž Vajngerl
Stamp annotation shows an arbitrary bitmap in the document, where the most common bitmaps are stamps like "Approved", "Confidential", "Expired", "Sold",... Change-Id: I332e34cbb346a686ee16eac7ca437ec4048e65ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168760 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: add annotation marker for free text annotationTomaž Vajngerl
Added new class PDFAnnotationMarkerFreeText as we need a marker to know if the annotation is a special one. Change-Id: Ica0e72dd6bf62b322676c8e87659a3850074522a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168759 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-13tdf#156717 Fix "LibreOffice Community" in PDF metadataHossein
These settings are available to set the brand when building LibreOffice: 1) Community flavor: yes / no This is set via --disable-community-flavor, that defines HAVE_FEATURE_COMMUNITY_FLAVOR, which is used in cui/source/dialogs/about.cxx. 2) Product name: A string (set via --with-product-name='name') This defines PRODUCTNAME, which is used in many places in the code. Not every LibreOffice build is a "LibreOffice Community" flavor. This patch fixes this issue by using community brand only when variable HAVE_FEATURE_COMMUNITY_FLAVOR is set. Change-Id: Ib74450f380fed7c24222f88e389ddb5363bda3c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168676 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-06-13README.md: add Python baselineIlmari Lauhakangas
Change-Id: Iffb83588cead716b009578d0f571f3d9cd2e83d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168818 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-06-13Let ScDocShell::GetLinkUpdateModeState honor isUntrustedRefererStephan Bergmann
Change-Id: I358911ad5180548767eadac3d15d0583598fe5e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168814 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>