summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-05remove unused StateChangedType enum valueNoel Grandin
Change-Id: I5b241e35af90cc5c0a2df15e596bb5d45f110e52 Reviewed-on: https://gerrit.libreoffice.org/64560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused VclEventId enum valuesNoel Grandin
Change-Id: I7887a7de37a024f2e97dbd20a27a1aa3fdfcfbfa Reviewed-on: https://gerrit.libreoffice.org/64559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused InvertFlags::HighlightNoel Grandin
Change-Id: Id881142f39a6160b8040d0446476767aad83f260 Reviewed-on: https://gerrit.libreoffice.org/64558 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused GraphicManagerDrawFlags enumNoel Grandin
Change-Id: I12ef5e6257db337c4432b251bc92107a2c2ea88b Reviewed-on: https://gerrit.libreoffice.org/64557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxBaseModel::storeSelfNoel Grandin
Change-Id: I73524a15b5ac33ee6243a2e0e563b9986e887e40 Reviewed-on: https://gerrit.libreoffice.org/64528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxObjectShell_ImplNoel Grandin
Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d Reviewed-on: https://gerrit.libreoffice.org/64527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxViewFrame::ExecReload_ImplNoel Grandin
Change-Id: I35a8a3a6ccbf811e529f761f840bfc7acf870056 Reviewed-on: https://gerrit.libreoffice.org/64526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in UCBStorage_ImplNoel Grandin
Change-Id: Iec07d23087dafd34a6c777a7c1825ebc9cbe7858 Reviewed-on: https://gerrit.libreoffice.org/64525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in OLESimpleStorageNoel Grandin
Change-Id: I5ef95846640efac00055336435356efdd0a8326d Reviewed-on: https://gerrit.libreoffice.org/64524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in ww8 export codeNoel Grandin
Change-Id: I505c8005aebec40b8e812aea10deaf79eb7223ab Reviewed-on: https://gerrit.libreoffice.org/64523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SwModuleNoel Grandin
Change-Id: I6c17853cc84365cb86b3dd2525ab8f2ff7844369 Reviewed-on: https://gerrit.libreoffice.org/64516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05Include vcl/outdev.hxxMike Kaganski
Breaks Windows builds since commit 1c8eb8ba49340b7b59a9f1a5f28cd8bee06cd4d1 D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2027: use of undefined type 'OutputDevice' D:/lode/dev/core/include\vcl/svapp.hxx(63): note: see declaration of 'OutputDevice' D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2227: left of '->GetSettings' must point to class/struct/union/generic type D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2228: left of '.GetStyleSettings' must have class/struct/union D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2228: left of '.GetAppFont' must have class/struct/union make[1]: *** [D:/lode/dev/core/solenv/gbuild/LinkTarget.mk:293: D:/lode/dev/core/workdir/CxxObject/oox/source/ole/axcontrol.o] Error 2 make: *** [Makefile:283: build] Error 2 Change-Id: I017bb5b99d4f314bb83cacddbe681d51cb0f9b14 Reviewed-on: https://gerrit.libreoffice.org/64589 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-05tdf#121399 Join cmd reading thread in gtk3_kde5Michael Weghorn
Stop reading commands from the pipe on kde5 side once the "Quit" command has been sent, in order to have the thread that is reading commands from stdin finish properly. Join the thread in the 'FilePickerIpc' destructor, rather than just deleting it while it may still be running, which resulted in 'terminate()' being called. Change-Id: Ia184987e7994cc1de0208ff2757a3cf06c8b7194 Reviewed-on: https://gerrit.libreoffice.org/63835 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-05tdf#121892 Guard Gtk3KDE5FilePicker::execute with SolarMutexGuardMichael Weghorn
Adhere to what gtk3's file picker does as well. Threading is involved in Gtk3KDE5FilePickerIpc::execute(). Change-Id: I4fa0a12f46ed13ef04211cb8577e77d1db5e8eae Reviewed-on: https://gerrit.libreoffice.org/64502 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-05tdf#117332: select replaced text to properly replace it next timeMike Kaganski
... othervise the next drag event will insert the new range immediately after the just inserted, resulting in invalid reference. Regression after commit 42aece949ec96c775b31216bddd723aa5321e966 don't replace content of formula field when selecting range, tdf#58635 Change-Id: I7dfdc1ce041ebadf4406dbb605676d87cd489efa Reviewed-on: https://gerrit.libreoffice.org/64574 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-05tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScDDELinkObj. Change-Id: I121d9fe6a66c549e402b0cf6fd54fea1201e443f Reviewed-on: https://gerrit.libreoffice.org/64511 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Update End Statement in BASIC Change-Id: I513db8eb06bc396b71ca2aaed1a6a50ec3ac5c2f Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/64438 Tested-by: Jenkins
2018-12-04NNNN already includes LongDateDayOfWeekSeparator, do not duplicateEike Rathke
Seems these were always wrong in some locales. Change-Id: I5dfc89a607d57c19034d6fac07a07bf3c5395ed8 Reviewed-on: https://gerrit.libreoffice.org/64541 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-04Related: tdf#121904 widget hidden but label and frame remainCaolán McNamara
if we want to hide the text direction widget, we should hide the rest of the elements too. For now show them all. Change-Id: Icb2ef69c50eb2335170dda9bfcfcb947ce4d6d19 Reviewed-on: https://gerrit.libreoffice.org/64551 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#121904 use min size for attribute dialogCaolán McNamara
Change-Id: I98cdda7e384dce35f02d20d5b98b61168d34f786 Reviewed-on: https://gerrit.libreoffice.org/64552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#118373 xmlsecurity: avoid stderr output on libxmlsec version checkMiklos Vajna
Make sure that our normal SAL_WARN() reporting is registered during the xmlSecCheckVersionExt() invocation, just like it's registered during other libxmlsec API calls. Change-Id: Ia19368b55dbae47974f48954f86b50e36d1462ff Reviewed-on: https://gerrit.libreoffice.org/64550 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-04tdf#118684 save correct font height in oox formatMartin van Zijl
Use the correct defaults for font height, underline and strike-through when saving to DOCX from Writer. Change-Id: I1bee606e05daf9976488ea5db72af7320e51fc8f Reviewed-on: https://gerrit.libreoffice.org/64478 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-04Resolves: tdf#121641 properties invisible after 'reset'Caolán McNamara
Change-Id: Iedb2b11be0e008501273925d6ae7137b28c3b912 Reviewed-on: https://gerrit.libreoffice.org/64537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#121815 just use valid cached layout glyphsJan-Marek Glogowski
I'm not exacly sure when and why the font cache is invalidated, but as a result this also invalidates the cached layouted glyphs. So just check the glyph layout cache state before trying to use it. But actually the status bar should update it's cache, so I'm not sure where to really put the fix. At least this won't crash LO anymore. Change-Id: I5f3ff8b9d56808af74d1419e878819d6019cd893 Reviewed-on: https://gerrit.libreoffice.org/64529 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-04In flatpak build, disable problematic test using gpg for nowStephan Bergmann
...which fails as documented in solenv/flatpak-disable-gpgconf-socketdir-test.patch, presumably because the gpg software in org.freedesktop.Sdk//1.6 (which has e.g. "gpgconf (GnuPG) 2.1.14-unknown") doesn't shut down a started gpg daemon again. Lets see if this will get fixed by <https://github.com/flathub/org.libreoffice.LibreOffice/issues/54> "Build against org.freedesktop.Platform 18.08" (where org.freedesktop.Sdk//18.08 has e.g. "gpgconf (GnuPG) 2.2.9"). Change-Id: I9c7ad326ff8f2278ec58ee484d088f6fba97694d
2018-12-04Building LibreOffice needs gperf 3.1 nowStephan Bergmann
...since e8e3b00bafefffa1b8a35c5721988fb3bf1f817c "Require at least gperf 3.1, which no longer emits 'register'", but org.freedesktop.Sdk//1.6 only has "GNU gperf 3.0.4" (and org.freedesktop.Sdk//18.08 also only has that version, so this fix will remain relevant even when <https://github.com/flathub/org.libreoffice.LibreOffice/issues/54> "Build against org.freedesktop.Platform 18.08" eventually gets addressed). Change-Id: I5a4fc6692aa077c989348903a3ed1f178922cfcb
2018-12-04Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: Idffd274a18df14a96e61bf61ba09f837fdbbf9c7
2018-12-04tdf#121855 like osx case don't search near-infinite calc grid for focusCaolán McNamara
Change-Id: Ie6bccd2781fbbdc5f4d5dc2eb6903191aafe8265 Reviewed-on: https://gerrit.libreoffice.org/64519 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04Fix af_NA wrong separator inheritance, use en_NA instead of af_ZA (en_ZA)Eike Rathke
It didn't matter originally, but en_ZA separators changed with commit 5c10c448b299faf43d9df28bdb9dc4fbb00540aa CommitDate: Mon Sep 3 13:38:13 2018 +0200 tdf#119613 [*-ZA] decimal separator is comma, group separator is space and commit 464154aa26ae77883dd59fcbaab9e084aa035c9d CommitDate: Mon Sep 3 13:38:23 2018 +0200 Related: tdf#119613 inherit af_ZA separators from identical en_ZA so the separators didn't match the formats inherited from en_NA anymore. Change-Id: Iccf951b27b5575706e0f6bae12b5df4b53e335ac
2018-12-04Bump (Linux) Clang baseline to 5.0.2Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ...". This no longer sets CLANGVER, CLANG_VERSION, and CLANG_FULL_VERSION when using Apple Clang (on macOS), which uses different version numbers from upstream anyway. But those variables are only used in the context of compiler plugins, which do not work with Apple Clang anyway (which lacks necessary include files). (Also, move "AC_SUBST(COM_IS_CLANG)" up to where it belongs.) Change-Id: Iee37c42ecacf52fa5a07e35241bcd404025e1cdf Reviewed-on: https://gerrit.libreoffice.org/63899 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-04Remove obsolete CLANG_VERSION checksStephan Bergmann
...now that the (Linux) Clang baseline has been bumped ot 5.0.2 (see <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..."). (This commit precedes a commit that will actually enforce Clang >= 5.0.2 in configure.ac. However, it was easier to do it in this order, as that other commit will drop CLANG_VERSION when building with Apple Clang (where version numbers are different from upstream), so these checks would start to fail there.) Change-Id: Icb3df0d0cf476e14c5453f02bdfc9e5bed066ca1 Reviewed-on: https://gerrit.libreoffice.org/63898 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-04Some date format corrections, tdf#116868 follow-upEike Rathke
Order is 'D, MMM YYYY' instead of 'MMM, D YYYY' 'NNNN, ' displays separator twice. Change-Id: Id84af3e1bb94dad0e8405c680e63f48f38415fba
2018-12-04fixes for OpenCL COVAR()Luboš Luňák
Change-Id: Ie171eea334de65b993554146c11adb95e0dbb85e Reviewed-on: https://gerrit.libreoffice.org/64245 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-04make OpenCL SLOPE() handle problems more gracefullyLuboš Luňák
It's silly to just return NaN just because the function can't handle something. If nothing else, at least a proper error should be reported (or in this case, the fallback to the core function will take care of it). Change-Id: I9c971082f4c5c9836318cf63d15fa7c278274273 Reviewed-on: https://gerrit.libreoffice.org/64244 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-04check that OpenCL NORMDIST() takes a proper number of argumentsLuboš Luňák
Change-Id: I885a1b70556311f5a0862fec24a3596dbeada5d6 Reviewed-on: https://gerrit.libreoffice.org/64243 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-04opencl SERIESSUM does not handle plain double argumentsLuboš Luňák
sc_subsequent_filters_test in ScFiltersTest::testFunctionsODS() also checks "SERIESSUM(2;3;2;3)", which the opencl code does not handle. At least bail out gracefully instead of returning 0. Change-Id: I154dca8cc437a6225b4eb98012232d80683f0114 Reviewed-on: https://gerrit.libreoffice.org/64242 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-04fix opencl YIELDDISCLuboš Luňák
Otherwise the yielddisc unittest fails. Change-Id: I2ebb0fbf9d4aea6678c91d0289418991aa92dbb5 Reviewed-on: https://gerrit.libreoffice.org/64241 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-12-04tdf#117425 - Increase the length of the Name Box drop down menuheiko tietze
Now 20 MRU plus... Change-Id: I069021bf1f42da793f7ec79a7e0eacbea519bc14 Reviewed-on: https://gerrit.libreoffice.org/64515 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-04Translate German variable namesJohnny_M
Change-Id: Ibaf473a2146fd925b4d8e8ffdbb6f214844a18cc Reviewed-on: https://gerrit.libreoffice.org/64424 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-04sw: fix paragraph enumeration going past selection endMiklos Vajna
SwCursor::MovePara() may move the uno cursor past the end of the selection range, check for this explicitly. In practice this makes sure that in case a 1-paragraph cell text is selected, we never jump to the next cell for a selection created from the previous cell. Change-Id: Ibe2d00cfa75ed0c32b9c89d86cfae3b51d70ddc6 Reviewed-on: https://gerrit.libreoffice.org/64509 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-04tdf#34171: check foreign lockfiles to tell who has locked documentMike Kaganski
MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-04Translate German variable namesJohnny_M
Change-Id: Ie287f9122d4ac362b533cb9270e60337c4985113 Reviewed-on: https://gerrit.libreoffice.org/64423 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-04Translate German variable namesJohnny_M
Change-Id: Iaad1cc232222428d594a109b882aa21ccfd3aea4 Reviewed-on: https://gerrit.libreoffice.org/62841 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-04Infobar showing donation alternating with getinvolvedheiko tietze
Change-Id: Ia103201667c3469071f19450589bd22faf3ae80e Reviewed-on: https://gerrit.libreoffice.org/63883 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-04NB: update draw groupedbar_compactandreas kainz
Change-Id: I10f801de49cdf3d5fb37657ee88842223bf50570 Reviewed-on: https://gerrit.libreoffice.org/64385 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-04tdf#45904 Move XNamed Java tests to C++Jens Carl
Move XNamed Java tests to C++ for ScDDELinkObj and refactor class XNamed. ScDDELinkObj doesn't allow to set the name, so test that a exception of type RuntimeException is thrown. Change-Id: Ie110c3c0ea22d205d4f2c4575f3db3676dda9ce3 Reviewed-on: https://gerrit.libreoffice.org/64497 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-04NB: update writer groupedbar_fullandreas kainz
Change-Id: I4fffde4c7ee687af1eb1c7f5eb28be16bb369e28 Reviewed-on: https://gerrit.libreoffice.org/64386 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-04tdf#120775: Implement DnD between 2 SalFramesKatarina Behrens
still only internal DnD (between multiple frames within 1 LibO instance) is supported Change-Id: I151162ee1075c8b2d71520aae950fc7214d752b7 Reviewed-on: https://gerrit.libreoffice.org/64477 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-06 06:42:31 +0000