summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-20Avoid wrong "no replacement graphic" state when updating OLE graphicMike Kaganski
Connecting from an external Java process on Windows, and running a code similar to this: XComponent xComponent = xComponentLoader.loadComponentFromURL(url, "_default", FrameSearchFlag.ALL, args); XTextEmbeddedObjectsSupplier textEmbeddedObjectSupplier = cast(XTextEmbeddedObjectsSupplier.class, xComponent); XIndexAccess embeddedObjectsAccess = cast(XIndexAccess.class, textEmbeddedObjectSupplier.getEmbeddedObjects()); XEmbeddedObjectSupplier2 embeddedObjectSupplier = cast(XEmbeddedObjectSupplier2.class, embeddedObjectsAccess.getByIndex(0)); for (int i = 0; i < 100; i++) { XGraphic replacementGraphic = embeddedObjectSupplier.getReplacementGraphic(); String graphicStatus = replacementGraphic == null ? "missing" : "present"; System.out.println("The replacement graphic is: " + graphicStatus); } (when 'url' points to a file with OLE) could produce output like this: The replacement graphic is: present The replacement graphic is: present The replacement graphic is: missing ... 94 more copies of "missing" The replacement graphic is: missing The replacement graphic is: present The replacement graphic is: present i.e., the replacement graphic suddenly disappears, and then re-appears. This happens when some idle needs to update the replacement graphic, e.g. when generating a thumbnail. This happened because the code in EmbeddedObjectRef::GetReplacement cleared the graphic prior to calls to OLE object's async methods to get the graphic stream. The code does not depend on the current content of mpImpl->oGraphic, so this change takes care to avoid this transient "no graphic" state. Change-Id: Ia825185a6e9b749697209443ee5db187b5ddbd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173690 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-20tdf#156047 Avoid white title on Vivid and BlueCurveLaurent Balland
When pasting a title on slide with a white title on a white background, user may think that paste failed. This change modify font colors to let pasted text visible Change-Id: I72c82850c4ecca47e54b5de1044b0c7806a443a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173361 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2024-09-20lok: add media (video) info to the presentation info JSONTomaž Vajngerl
Change-Id: Iba8f58d48cbe252b12f10ba20f9f5e2b10029c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173658 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-20dont use GetItemSurrogates for gathering SvxTabStopItemNoel Grandin
which is very expensive these days Change-Id: Iae80c9d677fd1db8606a6a3f9462fe16b110a540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-20dont use GetItemSurrogates for gathering SvXMLAttrContainerItemNoel Grandin
which is very expensive these days Change-Id: Idf133fc0532f12d297c0f44a3aad48b6eaa2206a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-20tdf#152298: Handle "keep with next, allow split, span some rows" caseMike Kaganski
All the rows on the table in bugdoc require to be kept with next (their first cells' first paragraphs have that flag). The layout finds the table break position after row 39; but then it checks that that row should be kept with row 38, that with row 37, and so on. The layout loop happens because the search for the break position can't find a row. But cell A38 spans over four rows; in this case, Word checks if this row can split, and splits the spanning cells, apparently as keeping "part" of the row with next. This change implements that algorithm. Change-Id: I234694138ac6b660781ad773cef20151daf874eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173675 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-20Check if split is forced when calculating fixed-height row's min heightMike Kaganski
Change-Id: Ib5780d229041823e9aa7ba1c086655eb7c8590eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173601 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-20When split is forbidden, avoid useless calculationsMike Kaganski
Change-Id: Ibfc8b839d4455c21293906f7e4625a09b0d3f4f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173600 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-20Re-calculate the available space before calling lcl_RecalcSplitLineMike Kaganski
Because we could change the split row several times after first remaining space calculation, thus obsoleting the old value. Change-Id: Ia8027b0df2b04089c31b7031ddb05bd33e6ade98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173674 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-20Optimize rows height calculation a bitMike Kaganski
Instead of adding heights in a loop, just get the distance between the top of the first row and the bottom of the last. Change-Id: I2082026c1c525f8230393ee8b59d1019f321fae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173596 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-20Related: tdf#152298 Consider bottom margin in remaining space calculationMike Kaganski
The value passed to lcl_RecalcSplitLine could be too large; then the call to rTab.Shrink succeeds, and the height of rTab changes as requested; but then the values of nDistanceToUpperPrtBottom and nDistanceToFootnoteBodyPrtBottom are negative, resulting in failed split and layout loop. Change-Id: I797baee701b6a07e0c9310ea8cf902795c053642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173595 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-19null-deref seen on rtf2pdf with tdf94049-1.rtfCaolán McNamara
Change-Id: I9cd64f5fb20ccea84446909414624314b7eb956b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173684 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-19Remove duplicated includeAndrea Gelmini
Change-Id: I9dc7bb716b29b0e9980734f254e8e385a571a560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173679 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-09-19tdf#163042 sw smart justify: fix cursor of single portion linesLászló Németh
Fixed problems with cursor/pilcrow positions in a shrunk last line of a paragraph with a single portion: – clicking before the last or the last but one characters of the line, the cursor could be positioned at the end of the line, not before the last or the last but one characters (especially a line with more spaces and bigger space shrinking). – when the text cursor was there at the end, the visible cursor position was inside the line instead of the end of the line; – pilcrow symbol was inside the line instead of the end of the line. Follow-up to commit 6b857398a59d16308d6185d01e003e401439f060 "tdf#162109 sw smart justify: fix overhanging last line" and commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46 "tdf#162220 sw smart justify: fix shrinking for single portion lines". Change-Id: I0057f17fe187381c4c5d78574dcd99e0dafc11b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173662 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-09-19fix macos build with clang 16Noel Grandin
Undefined symbols for architecture arm64: "o3tl::strong_int<unsigned short, LanguageTypeTag>::strong_int<int>(int, std::__1::enable_if<std::is_integral<int>::value, int>::type)", referenced from: sfx2::(anonymous namespace)::SvxInternalLink::Connect(sfx2::SvBaseLink*) in linkmgr2.o SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o ld: symbol(s) not found for architecture arm64 clang++: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [/Users/noelgrandin/lode/dev/core/sfx2/Library_sfx.mk:20: /Users/noelgrandin/lode/dev/core/instdir/LibreOfficeDev.app/Contents/Frameworks/libsfxlo.dylib] Error 1 make[1]: Target 'build' not remade because of errors. make: *** [Makefile:296: build] Error 2 Change-Id: Ia8c338a89156e18a1c96630ecad2bccbba7bb745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-19tdf#114441 Convert sal_uLong to sal_uInt32Sohrab Kazak
Change the variable that relates to the position of a footnote. Maintains the unsigned from previous because the variable is a position. The value doesn't seem to exceed the max. - ftnfrm.cxx + Change return types of the function lcl_FindFootnotePos + Change initialized types of variables that call above function, or use its value. Change-Id: Id44b8024eaa6e20d119f52ef03f62b30e6ae1c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173578 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-09-19ofz#71782 fix build failureCaolán McNamara
Change-Id: I4be65927215dbf9c10ecd51baca42b59b569d75b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173677 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19Fix typoAndrea Gelmini
Change-Id: Ib2f0d76465482663c7fd388ef065539c5ab2b330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173673 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-19cid#1608386 PA: Public AttributeCaolán McNamara
Change-Id: Ie82c097a6c3241a9ed3642ba4985acc77cdd7f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19cid#1607067 Overflowed constantCaolán McNamara
Change-Id: I039c80f489657cc4f47727af2e95b095592d6946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173668 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19cid#1606864 Overflowed constantCaolán McNamara
Change-Id: I08beb9bd76065ea846171e07fbf6e427ada37360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173667 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-19cid#1606656 Overflowed constantCaolán McNamara
Change-Id: I1503ebd911abf6e1e2060ce6dc3f0ac05e325982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173666 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19qt: Use more qobject_cast instead of dynamic_castMichael Weghorn
Change-Id: I236d016dd51f219b63a7d7fb6b0cb83a06b960c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173661 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-19qt: Use qobject_cast to cast to QtMimeDataMichael Weghorn
Use `qobject_cast` instead of `dynamic_cast` to cast to QtMimeData. Add the `Q_OBJECT` macro to the class, as the the qobject_cast doc [1] says: > Warning: If T isn't declared with the Q_OBJECT macro, this function's > return value is undefined. Change-Id: I5de2d8dbf62ed1293f3660acae44e3b13ab5df71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173660 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-19qt: Use qobject_cast in QtFilePickerMichael Weghorn
Use `qobject_cast` instead of `dynamic_cast` when casting to native Qt widgets. It should be faster. Quoting from the doc [1]: > The qobject_cast() function behaves similarly to the standard C++ > dynamic_cast(), with the advantages that it doesn't require RTTI support > and it works across dynamic library boundaries. [1] https://doc.qt.io/qt-6/qobject.html#qobject_cast Change-Id: I20d4cca6936eeeb6f8367f82a9d11f12ada63e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173659 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-19qt a11y: Destroy QWindow when popup gets hiddenMichael Weghorn
When a popup gets hidden, destroy its associated QWindow. This prevents a "top-level" a11y object being reported when a popup gets shown, then hidden again, e.g. after expanding the Paragraph Style combobox in Writer's Formatting toolbar, then closing it again. Showing the popup results in a QWindow being created that would not implicitly be destroyed when the popup gets hidden again. Due to popups in LO currently not using the Qt::Popup type, but Qt::ToolTip, they are considered for top-level a11y children of the app, see the commit message of Change-Id: I7aff5c435dfa8b6aadcbbedb0d84db19bb86c8ab Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Sep 19 09:15:37 2024 +0200 qt a11y: Defer QWindow creation until frame gets shown for more details. Only delete the QWindow for non-spontaneous hide events, as the QWidget::hideEvent doc [1] says: > Note: A widget receives spontaneous show and hide events when its > mapping status is changed by the window system, e.g. a spontaneous hide > event when the user minimizes the window, and a spontaneous show event > when the window is restored again. After receiving a spontaneous hide > event, a widget is still considered visible in the sense of isVisible(). With this commit in place, after starting Writer, opening the Paragraph Style combobox, then closing it again, only the Writer window is shown as a top-level child of the app in Accerciser when using the qt6 VCL plugin, as expected. Showing the popup again works just fine, as a new QWindow is implicitly created then. [1] https://doc.qt.io/qt-6/qwidget.html#hideEvent Change-Id: Iefa5d05ea128966c4417d53d122a6a0f1178fc00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173657 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-19qt a11y: Defer QWindow creation until frame gets shownMichael Weghorn
Calling QtFrame::windowHandle makes sure that the QWindow exists, by calling QWidget::setAttribute(Qt::WA_NativeWindow). QWindows that don't have the Qt::Popup or Qt::Desktop type, are listed as accessible children of the application, see QAccessibleApplication::child [1] in qtbase and the `topLevelObjects()` [2] helper method it uses. This resulted in various dummy "top-level" objects being reported as children of the LibreOffice a11y app object, and therefore shown in Accerciser. For Writer, there are 2 instances for each of the popups for the comboboxes in the formatting toolbar that get reported as toplevels, as can seen by printing the accessible ID of their parent objects in Accerciser (they have a parent different from the app, since they're not actually top-levels): Paragraph style combobox: In [4]: acc.parent.accessibleId Out[4]: 'applystyle' Font name combobox: In [5]: acc.parent.accessibleId Out[5]: 'fontnamecombobox' Font size comobobox: In [6]: acc.parent.accessibleId Out[6]: 'fontsizecombobox' While these *are* popups, the Qt::Popup type is currently not used for them in LO to work around another issue with these popus on Wayland, but the Qt::Tooltip type is used, see the QtFrame ctor and comments there. To prevent these wrong "top-levels" from always being part of the a11y tree due to that, defer creating the QWindow by calling QtFrame::windowHandle to when the window is actually needed, in QtFrame::Show. Pass the Qt::UniqueConnection connection type param in the call to QObject::connect [3], to avoid duplicate connections if the frame gets hidden/shown multiple times. (Other than the ctor, QtFrame::Show could potentially get called multiple times.) With this in place, Accerciser now only shows a single top-level frame after starting LO Writer with the qt6 VCL plugin, which is the actual Writer window. [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/qaccessibleobject.cpp?id=0681e720a9851f1873ce5a5f99b5567d2b418261#n160] [2] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/qaccessibleobject.cpp?id=0681e720a9851f1873ce5a5f99b5567d2b418261#n122 [3] https://doc.qt.io/qt-6/qobject.html#connect Change-Id: I7aff5c435dfa8b6aadcbbedb0d84db19bb86c8ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173656 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-19qt: Run whole QtFrame::Show in main threadMichael Weghorn
Instead of running only parts of the method explicitly in the main thread, ensure this for the whole method. Also, add a SolarMutexGuard at the beginning. Change-Id: I9c510b2d58ee5a3b05c1a16ce8e53077c7075caa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173655 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-19sw: add icons in sidebar's comment widgetMohit Marathe
Change-Id: I41c27573f065796c729773f484154f5f404cfa75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172380 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-09-19sw: make show option work in comments panelMohit Marathe
Change-Id: I49e5feb7c6585c14d22a57715329290029cbadcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172379 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-09-19add context menu for comments & some other changesMohit Marathe
Besides adding a context menu for comments in the comments panel, this commit adds the ability to make comments editable only when needed (through the context menu) Change-Id: I208a6531ce56d7ee2d7ed50703178babda9c5a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170996 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-09-19display reference text on threadMohit Marathe
Change-Id: Ieeabde081c88473efa127c906b7ba12ba14bec17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171233 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-09-19filter by author & timeMohit Marathe
Change-Id: Ia32a9a3672e3e3a81245e67e388218559120e449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170497 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-09-19unoxml: move these two tests where they belongXisco Fauli
so they can make use of CPPUNIT_ASSERT_STATEMENT_EQUAL They were moved ported from Java to CppUnittest in commit e42be49887e75c6ec748b6c48bb4e5eda295c715 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Wed Jul 3 10:09:54 2024 +0200 tdf#123293: port test from Java to CppUnitTest and commit d6ad09ca884fb7f35e2e24d532d85f6d818a7f1b Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Tue Jul 2 18:00:26 2024 +0200 sfx2: port checkRDFa from Java to CppUnittest Change-Id: I7b91bde6d968081a5b1c0bbee42208590e062ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173622 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-19cool#9992 lok doc sign: add password-less mode to create-certs.shMiklos Vajna
Now one can use './create-certs.sh RSA NOPASS' to create signing certs without encrypting them with a password. This is meant to be useful for the case when these certs have to be imported using the LOK API, and not interactively in Firefox, where one could ask for a password. Change-Id: I4cfc49ac8ff8c2420baa943b553a7a180a71e3bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173651 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-19libtiff: upgrade to release 4.7.0Michael Stahl
Fixes CVE-2023-52356 CVE-2024-7006 ofz65182.patch was apparently merged upstream and then reverted; Caolán suggested to drop the patch and see if ofz still finds a problem there. Change-Id: I0967708f19a7151b020372eca3c906b30f693db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173602 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-19package: add unit tests with invalid zip packagesMichael Stahl
Change-Id: I687028391833ea48884912b0e5f586b95eee3244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170054 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-19Resolves: tdf#141577 explicitly set current frame as active frameCaolán McNamara
of the current frame window. Creating the popup will grab focus into the dropdown, making the embedded frame lose focus, so it considers itself inactive (like right clicking in main frame area makes the embedded frame lose focus), so for this embedded object in another frame case make the original frame the active child of its parent after the popup has been created. Change-Id: Id6e12babcf4ebce05c297888b7b04756f2a12ccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173624 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19ofz: Timeout in schtmlfuzzerCaolán McNamara
use same fuzzing rowspan limit as xml import Change-Id: Id75d8cb8859bb2a6494d6aea160905cc6b75cb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19tdf#162955 PDF export: avoid the popup rectangle with zero sizeTibor Nagy
Change-Id: I9a3cdda4d1dfa0b23a3ea6dd99341cb17ca47490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173580 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-09-19tdf#162963 export property TotalsRow to ODFRegina Henschel
DatabaseRange has got the property TotalsRow with UI and UNO. But this property was not written to ODF. The patch adds this as attribute calcext:contains-footer to <table:database-range> element. Related is issue OFFICE-4169 at OASIS. Change-Id: I99a51198585b9b7dfb840217bdf1312f2462c9bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173612 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-09-19Fix typoAndrea Gelmini
Change-Id: I291dcc19e429493289cd2be8367a0d1e0c6d2296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173646 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-19use more concrete UNO types in WeakRefWrapperNoel Grandin
Change-Id: I5805a681833003c01b5c06c4719606cb27ab600c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-19use more concrete UNO types in scNoel Grandin
Change-Id: I5b70733fb5be0a4f9a51e48197454ff0452770bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-19pull some code out of hot loopNoel Grandin
Change-Id: Ic19888296d1a7be7c691714b0353f18a1ea074f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173591 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-19Remaining GCC -Wcast-function-type issuesStephan Bergmann
As Clang supports that warning now too, lots of occurrences have meanwhile been cleaned up for good (0c29c417ef3f0b749042e5a461abae9c36cf655b "Avoid -Werror,-Wcast-function-type-mismatch", 1344e6261a1d856c71eca1e0cc29215a586bf335 "Avoid -Werror,-Wcast-function-type-mismatch", 85a2bb9f52a0d834b02681344ce56e0b091e1abd "Avoid -Werror,-Wcast-function-type-mismatch", etc.), so ce99754e9b5b954be4360f39356ed7198b298265 "Globally disable -Wcast-function-type new with upcoming GCC 8" in solenv/gbuild/platform/com_GCC_defs.mk should no longer be necessary. One remaining issue I encountered was dae7304df68493afcf6e9c9e490d65ea20d8211f "Silence Clang 19 trunk -Werror,-Wcast-function-type-mismatch", where GCC needs a different way for silencing the warnings in pyuno/source/module/ than had been used there for Clang. Change-Id: I5d0404b957d798114051209c31e022a898cf91f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173623 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-18libxml2: upgrade to 2.13.4Xisco Fauli
* 0001-ofz-70675-XML_ERR_FATAL-not-ending-parse.patch.0 is no longer needed. fixed upstream Downloaded from https://download-fallback.gnome.org/sources/libxml2/2.13/libxml2-2.13.4.tar.xz Change-Id: I7d39940ad5b197b302c57110e147aef7d2b911d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173621 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-18reset m_bEnd after use to quit lcl_workerfuncCaolán McNamara
so lcl_workerfunc can be launched again on-demand Change-Id: I23dd48dc433190413f5c63464dcce112128b81ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173564 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit fd88a5bcb271a1711f484a319ee23d6b7013b232) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173502 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-18Do not hardcode --with-locales=en for Emscripten buildStephan Bergmann
...which had been done in 7a9e4c4ba8c6b8e068005f3831b989e3c929e8eb "WASM add strip flags to configure.ac", but without giving a rationale. For --enable-assert-always-abort builds, it could have caused the > assert(pUpperMonthText[0] == "JANUAR"); in ImpSvNumberInputScan::GetMonth (svl/source/numbers/zforfind.cxx) to fire when running in a German-locale browser, because the rule to generate the DISABLE_DYNLOADING-specific localedata_static.hxx in i18npool/Library_i18npool.mk then only included English-locale fallback locale data, so pUpperMonthText[0] was always the English "JANUARY", regardless of locale used. With with_locales left uninitialized here, the generated localedata_static.hxx now includes the full set of locale data. Which comes with a small increase in size, though: For one non-debug build scenario, sofice.data stayed at ca. 68M but soffice.wasm grew from ca. 138M to ca. 143M. Change-Id: I46dae3f5c795ae30fc44d3ac4cb8dd162cd72966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173619 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: If731da0f4839dc98b0dab1fa61669b92d5cc70f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-09 15:59:39 +0000