summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-06-05Fix typoAndrea Gelmini
Change-Id: Ice2853eb7a14bd614b9bb53ce13667602c6e07eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168457 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-05tdf#161417 RTF export: handle endnotes at section endsMiklos Vajna
Similar to commit 566c7017a84e3d573de85a6d986b81d3f59de0fa (tdf#160984 sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd, 2024-05-29), but this is RTF, not DOCX. Additional complexity is that it's not enough to just write \aendnotes (sect end) or \aenddoc (doc end) to export the position, also \fet and \endnhere needs writing, otherwise Word ignores this. Last bit is to ignore section formats which are not nullptr but are -1, ignore these in RtfAttributeOutput::SectionBreak(), similar to how DocxAttributeOutput::SectionBreak() does the same already. Change-Id: I2327c979d5af402eb15523d97149f6409fcf4adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168468 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-05openssl: upgrade to 3.0.14Xisco Fauli
Downloaded from https://www.openssl.org/source/openssl-3.0.14.tar.gz Change-Id: Ib75738f257210532d0f01f429ec3b78a1a2410a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168456 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-05cid#1603200 Uninitialized scalar variableCaolán McNamara
cid#1603199 Uninitialized scalar variable and other fixups for: commit fbe8071e4f6be57d3e372d69a4c7cc4d37a83eb9 Date: Sat Oct 15 14:20:31 2022 +0200 refactor functions: return optional instead of bool Change-Id: I192017d0fc710ada7686e4c6dd313727b02f3889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168453 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-05loplugin:ostr in sw/.../unoNoel Grandin
Change-Id: I70205955fdfa261fdf2b8d66d546eded549464a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168427 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-05loplugin:ostr in sw/.../miscNoel Grandin
Change-Id: Id64ac6bdebe93af6364ccf39d4ae8df333e775d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168425 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-05tdf#144752: UNDO/REDO: make sure to select the replaced contentMike Kaganski
In the specific case of the bug, the non-empty selection means that the spell check won't skip the word with the cursor. But this also establishes consistency with other Undo/Redo cases, which generally select the text. Change-Id: Ib7c1c911908dc59947e610d735907be7a363ca87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168423 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-05Fix make 'clean' command in helpcontents2/Olivier Hallot
Change-Id: I1bc66a8f4a4c258983e1fa141cc106bd52c27dfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168412 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-06-05tdf#161417 RTF import: handle endnotes at section endsMiklos Vajna
This is similar to commit 2d2dd56e0b2dc708f1f758d7fc9a1263ff09b83c (tdf#160984 sw continuous endnotes: DOCX: import <w:endnotePr> pos == sectEnd, 2024-05-28), but that was for DOCX import, this is for RTF import. Change-Id: I6772f78360f681d18559556e71526eb76670bec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168424 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-05tdf#77388 sw: add missing commentLászló Németh
Change-Id: Ie288374f7d14171b84488adf5573915d8a5e6f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168417 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-05tdf#157533 sw: fix cursor position deselecting formula in tableLászló Németh
Fix lost cursor by deselecting formula object anchored as character as single content of table cells. In this case, the cursor was positioned inside the frame of the formula, disappeared in a flash. Fix also bad cursor position by deselecting formula object anchored as character at beginning of text lines in table content. Follow-up to commit 014e5f559a9acf319af24c721dbe6b0bc3bc5882 "tdf#161360 sw: fix cursor position deselecting image in table". Change-Id: Ia1a96359f473071c4cead580322aa9c1af1d3f24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168416 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-06-05sd: change CHECK_RANGE macro to template functionTomaž Vajngerl
Change-Id: Iecd6f37324b2788fac77b272ac56c3a2eb122dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168420 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-05annot: improve PDF annotation export and clean-up PDFNote classTomaž Vajngerl
Add support for exporting more PDF annotation types and props. Prefix member variables in PDFNote class, extract it out of pdfwriter.hxx file into it's own header file. Change-Id: I99fb4cbb0c68fcec6585c9c21d81daaef26344cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168418 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-05Clean up example codeStephan Bergmann
* Consistently use `const` to introduce variable bindings. * Don't rely on `xText` from the first example in the second one. * No (more) need to query for base interfaces. * No (more) need to delete interface references. * Add a missing delete of Any `next`. * Remove a redundant empty line. * Adapt to our 100 character line width. Change-Id: Ie116021a4b0cc6d88c6204e7ea5147a837c251f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-06-05tdf#136294: trigger pending spellcheck in SwCursorShell::UpdateCursorMike Kaganski
This allows to drop the partial fix created for tdf#124603 (except for unit test). The problem solved in commit 4c91e94e892943ef5e031d65f6f42864233cb4cd (tdf#92036: sw: fix idle spelling loop, 2015-09-09) is kept solved; when a word is marked pending, this is signalled to the viewshell. SwCursorShell stores that as a flag, which will then start an idle on cursor update, and finally call SwViewShell::LayoutIdle, which does the spell checking. If the cursor is still in the word that is pending the check, the cycle will repeat, trying spell checks only at cursor update, not as a busy loop. Change-Id: I5dc77baabffa723e261d553e40d40e5ace4266bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168413 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-05tdf#143123 Port Java clipboard examples to PythonRMZeroFour
This commit ports the Clipboard example from odk/examples/DevelopersGuide/OfficeDev/ to Python. The original Java example code was moved to a java/ subdirectory, and the new Python code was added to the python/ subdirectory. Necessary changes were made in the corresponding Makefiles. Along with the sample code in Clipboard.java, the ClipboardListener, ClipboardOwner and TextTransferable classes were ported. Change-Id: Ic3a48023cfc78b770ae64adb2aee2b4d0bcefaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165225 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-06-04NotoNaskhArabic: upgrade to v2.019Xisco Fauli
Downloaded from https://github.com/notofonts/arabic/releases/download/NotoNaskhArabic-v2.019/NotoNaskhArabic-v2.019.zip Change-Id: I2441e446d19a5f4b81aa6344e3937f4afe86be55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168409 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-04NotoSansHebrew: upgrade to v3.001Xisco Fauli
Downloaded from https://github.com/notofonts/hebrew/releases/download/NotoSansHebrew-v3.001/NotoSansHebrew-v3.001.zip Change-Id: I4c39f7b3f56bbdb1b8e8ced58129f15177841da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168407 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-04Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 1eb2e622fbd81928bc7e8b48f75332c787c01225 - tdf#161413 Don't allow note icon SVGs to shrink Change-Id: I0d760f0e784f3ef2beb0fa9f80fdb52f7222b298 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168411 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-06-04bin: add a diff-pdf-page.py script to diff reference vs our rendering via PDFMiklos Vajna
Thanks László Németh for the idea, the mechanism used in the tool was also used to generate the visual diff visible at <https://wiki.documentfoundation.org/ReleaseNotes/24.2#New_line_break_algorithm_for_interoperability>. Change-Id: I51afb08c60c7134f75a54acdb94b49d2ff94befd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168404 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-04windows packaging: reduce parallelism further to threeChristian Lohmaier
Some jenkins daily builders still run into issues from time to time, and even at a reduced parallelism of three it doesn't affect overall buildtime when building with just two or three languages and also not when building with all languages. There might be a number of languages where this has a penalty, but probably not a significant one. Change-Id: I778b5fe21fe8f9bb1fcca1da3c4c0eeeda6c29d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168403 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-06-04tdf#143123 Port Java PathSubstitution example to PythonRMZeroFour
This commit ports the PathSubstitution example in odk/examples/DevelopersGuide/OfficeDev/ to Python. The original Java example code was moved to a java/ subdirectory, and the new Python code was added to the python/ subdirectory. Necessary changes were made in the corresponding Makefiles. The example can be run with: ./instdir/program/python \ ./odk/examples/DevelopersGuide/OfficeDev/PathSubstitution/\ python/path_substitution_test.py Change-Id: I6c7a8af86cee2dc9cb5384e42bd9644847f28767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166264 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-06-04tdf#161417 DOC export: handle endnotes at section endsMiklos Vajna
Similar to commit 566c7017a84e3d573de85a6d986b81d3f59de0fa (tdf#160984 sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd, 2024-05-29), but this is for DOC, not DOCX. Change-Id: I4301d97115ba48f7ed1dacfdd5b29336bdaf9e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-04loplugin:ostr in sw/.../shellsNoel Grandin
Change-Id: Ie8d62b127cfa521d28dbd26073e4d6d89dfdcdf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168396 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-04Resolves tdf#161395 - Rename Whole Number to IntegerHeiko Tietze
Change-Id: Id4cce115823781e5f2a4870d38d1f456cdf417a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168395 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-06-04Revert "svtools: fix crash in BrowseBox::GetControlArea()"Miklos Vajna
This reverts commit ec5aa7e88b0d412041f8575111f0da295065cecb (svtools: fix crash in BrowseBox::GetControlArea(), 2024-06-04), not needed after commit 6f2b5043613bea755f01b413fd86ece0b3a29e5d (crashtesting: BrowseBox::GetControlArea crash, 2024-06-03). Change-Id: I1e86380041266b1fb83f11df37700f10cc88e5bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168399 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-04refactor functions: return optional instead of boolAndrea Rosetti
Change-Id: Ic4ff3ddaac161df13bf1e3e1372811a0685ec6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141417 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-06-04Related: tdf#128425 tdf#127293 - Extend function wizard descriptionBalazs Varga
about match_mode and search_mode options. Also do not allow wildcard match mode with binary search mode as it was decided at the odf meetings. Change-Id: Iadc1b6735ae62bb07675a664d9954ebc27519691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168366 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-06-04tdf#160712 Update Yellow Idea templateLaurent Balland
- use only Noto fonts - rename master slide "Cover" to "Yellow Idea" (see tdf#158496) - rename master slide "Contens" to "Contents" and Illustration3 to Illustration2 - change Thumbnail - use placeholder instead of dummy text - create groups of objects to ease manipulation - create styles Outlined Thick and Thin - use styles Outlined Yellow to keep same yellow everywhere - remove unused styles - remove pictures which were used only for shadow - replace drawing of figures with text on master Contents - master Infographics2: - replace drawings of figures with text - replace arcs with modifiable segments Change-Id: Ia04522d4e9196a14db8431d05922618648a68c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168027 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> Tested-by: Jenkins
2024-06-04Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to b256e08a31624c1c55894b4f11065c75423af30e - tdf#161413 Prevent SVGs without width from overflowing the container Change-Id: Idaf3a4f4d0d286520565623b29bbc186fbfd79d8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168400 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-06-04basctl: use SAL_RET_MAYBENULL in GetBindingsPtr()...Xisco Fauli
... GetDispatcher() and FindBasicManager() Change-Id: I6de6035f17b74313a5cbb9964ceafcbe3161ef2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168397 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-04svtools: fix crash in BrowseBox::GetControlArea()Miklos Vajna
UITest_writer_tests4 sometimes (but not always) crashes for me, typically not when it's execute alone, but when it's executed as part of 'make check'. The soffice process crashes on shutdown, after all tests passed without problems. coredumpctl gives this in gdb: Program terminated with signal SIGSEGV, Segmentation fault. #0 BrowseBox::GetControlArea (this=0x9bd3f90) at svtools/source/brwbox/brwbox1.cxx:2137 2137 auto nHeight = aHScroll->GetSizePixel().Height(); (gdb) print aHScroll $1 = {m_rInnerRef = empty rtl::Reference} (gdb) bt #0 BrowseBox::GetControlArea() const (this=0x9bd3f90) at svtools/source/brwbox/brwbox1.cxx:2137 #1 0x00007fbbd2022ed9 in DbGridControl::RearrangeHdl(Timer*) (this=0x9bd3f90) at svx/source/fmcomp/gridctrl.cxx:2646 #2 0x00007fbbd2022ea3 in DbGridControl::LinkStubRearrangeHdl(void*, Timer*) (instance=0x9bd3f90, data=0x9bd4468) at svx/source/fmcomp/gridctrl.cxx:2643 #3 0x00007fbbcedb8d79 in Link<Timer*, void>::Call(Timer*) const (this=0x9bd4488, data=0x9bd4468) at include/tools/link.hxx:111 #4 0x00007fbbcedb8c01 in Timer::Invoke() (this=0x9bd4468) at vcl/source/app/timer.cxx:75 Let's assume the problem is that somehow we can get here after the VclPtr is already disposed and just return early to avoid the crash. Change-Id: Ic27727dc3622d8da88256c80f873dc79795864b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168393 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-04Port framework/qa/complex/XTitle/CheckXTile.java to CppunitAdam Seskunas
framework - Remove CheckXTitle.java from makefiles - Create new makefile for CheckXTitle framework qa complex XTitle - Remove JUnit test framework qa cppunit - Add new CppUnit test suit CheckXTitle.cxx - checkDefaultTitle: tests if default title is the same after cycling through the default window and print preview - checkTitleDefaultFileName: tests if a window title set with SuggestedSaveAs is in fact set with said name - setTitleAndCheck: tests if after setting window title and cycling through default window and print preview, there is infinite recursion Change-Id: If7794f0f853ef427bb735a22752cff3635f5ff63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168168 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-04Make sure that the big value doesn't readily overflowMike Kaganski
As shown in https://gerrit.libreoffice.org/c/core/+/168235/6#message-5e7ed6fecf7fd36dc167193e25c3ec94daa11cb3 > looks like this started to break e.g. CppunitTest_sw_mailmerge2 with > > /sw/inc/swrect.hxx:251:48: runtime error: signed integer overflow: 13569 + 9223372036854775807 cannot be represented in type 'long' > #0 0x7f30b337cb90 in SwRect::Bottom() const /sw/inc/swrect.hxx:251:48 > #1 0x7f30b337234f in SwRect::Overlaps(SwRect const&) const /sw/inc/swrect.hxx:376:30 > #2 0x7f30b699354b in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3316:23 > #3 0x7f30b699376f in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3317:17 > #4 0x7f30b699376f in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3317:17 > #5 0x7f30b698d21e in Notify_Background(SdrObject const*, SwPageFrame*, SwRect const&, PrepareHint, bool) /sw/source/core/layout/frmtool.cxx:3415:13 > #6 0x7f30b5b941b4 in lcl_NotifyBackgroundOfObj(SwDrawContact const&, SdrObject const&, tools::Rectangle const*) /sw/source/core/draw/dcontact.cxx:955:13 > #7 0x7f30b5b7c9b9 in SwDrawContact::DisconnectFromLayout(bool) /sw/source/core/draw/dcontact.cxx:1689:9 > #8 0x7f30b5ba0cae in SwDrawContact::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/draw/dcontact.cxx:1544:17 > #9 0x7f30b399e3c2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:311:18 > #10 0x7f30b399e6c5 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:316:15 > #11 0x7f30b6656d23 in SwDrawFrameFormat::DelFrames() /sw/source/core/layout/atrfrm.cxx:3525:5 > #12 0x7f30b51785f8 in sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat*) /sw/source/core/doc/DocumentLayoutManager.cxx:235:14 > #13 0x7f30b4df70ac in sw::DocumentContentOperationsManager::DelFullPara(SwPaM&) /sw/source/core/doc/DocumentContentOperationsManager.cxx:2343:55 > #14 0x7f30b42b5701 in SwDoc::RemoveInvisibleContent() /sw/source/core/doc/doc.cxx:1576:57 > #15 0x7f30ba70c920 in SwDBManager::MergeMailFiles(SwWrtShell*, SwMergeDescriptor const&) /sw/source/uibase/dbui/dbmgr.cxx:1468:35 > #16 0x7f30ba6f7eff in SwDBManager::Merge(SwMergeDescriptor const&) /sw/source/uibase/dbui/dbmgr.cxx:556:20 > #17 0x7f30bbe0d561 in SwXMailMerge::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) /sw/source/uibase/uno/unomailmerge.cxx:786:24 > #18 0x7f30bbe103ce in non-virtual thunk to SwXMailMerge::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) /sw/source/uibase/uno/unomailmerge.cxx > #19 0x7f30d009b8ed in (anonymous namespace)::MMTest2::executeMailMerge(bool) /sw/qa/extras/mailmerge/mailmerge2.cxx:195:31 > #20 0x7f30d00eb3e5 in (anonymous namespace)::testTdf123057_file::verify() /sw/qa/extras/mailmerge/mailmerge2.cxx:597:5 > #21 0x7f30d00a11eb in (anonymous namespace)::MMTest2::executeMailMergeTest(char const*, char const*, char const*, char const*, int, char const*) /sw/qa/extras/mailmerge/mailmerge2.cxx:99:9 > #22 0x7f30d00efc32 in (anonymous namespace)::testTdf123057_file::MailMerge() /sw/qa/extras/mailmerge/mailmerge2.cxx:594:1 > (<https://ci.libreoffice.org/job/lo_ubsan/3194/>;) Change-Id: Ic34ad5c39d3b89c84f124e145a30714ba3752103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168364 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-04sfx2: use SAL_RET_MAYBENULL in GetDispatcher() and GetFrame()Xisco Fauli
Change-Id: Ic9876dbdd0dc0ce887a6eb135bd411f8e3dc9e12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-04Fix typoAndrea Gelmini
Change-Id: I2c8899e5ab779dbd94c5096c72e2fbb09e40d4ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168377 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-04Fix typoAndrea Gelmini
Change-Id: I29b5c1f75c9126ec274c4e4324c6f4577b9dae7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168378 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-04tdf#160844 we don't want scrollbars to be a target for Ctrl+F6, etcCaolán McNamara
Change-Id: Ie24c10fa16889a70717cbee15aef38a20308934d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-03cid#1602449 Resource leakCaolán McNamara
Change-Id: Ide5575adb3346a0ad36a484078dc02ef46a4c043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-03cid#1459023 Dereference null return valueCaolán McNamara
Change-Id: I3ff5f121a76a30d07a80b46d469b669010318701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168388 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-03crashtesting: BrowseBox::GetControlArea crashCaolán McNamara
see with forums/ods/forum-en-11050.ods Change-Id: I2b1dadf51ab8efa1b66f5b7463b05ad4dc52f91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168386 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-03tdf#77388 sw: fix missing table border at cropped imagesLászló Németh
At images cropped by the bottom or right cell boundaries, or at images with zero padding in table cells (e.g, in test document of tdf#160836), table borders were hovered by the image, resulting missing table borders. First paint the cell content, and after that the DOCX-like "collapsing" cell borders in SwTabFrame::PaintSwFrame. Note: this doesn't modify painting of the objects anchored to characters (which still hovers the cell borders), and painting of the text content of the cells (which are still hovered by the cell borders at zero padding, despite their non-transparent background color). Change-Id: Ie41ab275fd101bb9e26d4165362063f0332ac3c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168384 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-03tdf#160371: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: Ife3a319359391f0614260170c9ddfbac16e13cbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168379 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-03tdf#69724 Disable 'Change Bullet' btn until selection existsSamuel Mehrbrodt
Change-Id: I9c1fdeb4423a8fe45121ff58097582dcccdd12ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168359 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-03loplugin:ostr in sw/.../sidebarNoel Grandin
Change-Id: Ic905099e9b7266998a414416c288fe0db87a618c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168373 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-03tdf#160984 sw continuous endnotes: add enable/disable option UIMiklos Vajna
Doing this via a macro was possible already, but that didn't invalidate the endnote positions on the layout, so required a document reload, which was ugly. Implement the new SwViewShell::SetContinuousEndnotes() by removing the endnote frames in the document, so they'll be re-created at the expected place as the layout action ends. Change-Id: If96e70ab29c5a6c95fce36775e9a9a61277fc8a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168383 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-03tdf#161301: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: I9eece5baa5c283caee74131151519c5e72e9cc45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168376 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-03tdf#158789: sc_mathematical_functions: Add unittestXisco Fauli
Change-Id: Ia19dadffa511cb012e4d0271e1e3768e1e374be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168365 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-03Remove unused 'numTiles' from glitter vertex shaderJaviya Vivekkumar Dineshbhai
The 'numTiles' variable is not being used in the vertex shader. To test this PR, apply the Glitter transition. If it works as expected, then the change is successful. Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: Ia1f833e6009b1f8c774329945ba260d20b8c9f64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168222 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-03loplugin:ostr in sw/.../flduiNoel Grandin
Change-Id: If2c0761dc0c607cf5a0275f240521c0aaa916888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168363 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-29 00:52:24 +0000