summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-27WinSalFrame::mnWidth/Height should presumably be of type LONGStephan Bergmann
...as they are only ever set to LO-/HIWORD values cast to a signed integer type Change-Id: I82f9a80bab7c3b7e3ee5545725efd0d88601b8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27DWRITE_GLYPH_METRICS members are of INT32 and UINT32 typesStephan Bergmann
Change-Id: Ie09e0150bf73efd552e3a3b455ffc395d6b6370c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106754 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27RECT members are of type LONGStephan Bergmann
Change-Id: I8c0ad0878903c729be7149f81f5844a4baea7883 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27LOGFONTW::lfHeight is of type LONGStephan Bergmann
Change-Id: Iec7e8e84b8a6ee9e4ddbbbf5708bf9040418bbb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27calc notebookbar update for 7.1andreas kainz
Change-Id: I9b9e09c1ce0681e9a17ca79677d03200b1fc536d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106723 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-27DocumentPropertiesW returns LONGStephan Bergmann
Change-Id: I1ee167ef1bca530be9399dd081d7d25bd4155794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27loplugin:toolslong (Library_vclplug_win)Stephan Bergmann
Change-Id: I1e8c02a4fdb42a7bbc25764ceaf96972f175130a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106751 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27GetLastError returns DWORDStephan Bergmann
Change-Id: I4e886d1d5f94f8a25591c41e9f03300cfba641dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106729 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27RegCreateKeyExW etc. return LSTATUSStephan Bergmann
Change-Id: I78ebfd3e9eec9437ee405e99e2bcb96c53b1b84b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106728 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27GetShortPathNameW returns DWORDStephan Bergmann
Change-Id: I5e86f9d0fd9832d0c8500c5d38805ddef5d5304b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106727 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27Windows InterlockedIncrement/Decrement use LONGStephan Bergmann
Change-Id: Ib3e8e89332399eba443d9ff291f694cfceb95af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106726 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27CComVariant.lVal is of type LONGStephan Bergmann
Change-Id: I2f27089b37a5a73242bfb56d68db765a29dc4efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106725 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27tdf#138307 Chart import: fix lost custom shape textBalazs Varga
Do not set empty text to SdrOutliner, if it is already set. Note: Also fix the missing custom shape problem in tdf#72776 and tdf#93641. The wrong position (X:0, Y:0) of these shapes is another problem. Regression from commit 6f62a5c4ee2c1b7654c7fcaa618fb495e0d32f0a (tdf#128985: ODP: Style text directions revert to RTL on save and re-open) Change-Id: I07d8cb12836daf15db347f6bb19c17ed9373189e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104909 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-27tdf#138345 sw ms export: Char highlight: no export to char-styleJustin Luth
MS Word ignores w:highlight in a character style. It only accepts it as direct formatting or in para-styles. So never export the character background as w:highlight, but always as w:shd for character styles. Change-Id: I7c9f4f00d957a8add848746051d3c4b1522d1520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106182 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-27jsdialog: dump dialog titleSzymon Kłos
Change-Id: Id4c9f336039f8a0b8d1d43fdff4852f32e2c7ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106707 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27jsdialog: remember dialog instance & handle closeSzymon Kłos
Change-Id: I1b10d12edfa7ffca1061f50b5219baae1ac3caeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106706 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27jsdialog: drag and drop support for TreeViewSzymon Kłos
Change-Id: I67e2eb986b48591b7f758bbb5c1d72b6a322d4d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106705 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27tdf#42949 Fix new IWYU warnings in directory sc/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I217817e2e4a42b096f5a7fb6344568c10d69aab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-27Fix commentEike Rathke
Change-Id: I2ae6e3cadc0f182c4798e5d33b0c7f07fbcbbff6
2020-11-27Resolves tdf#134802 - Improved "Paste Special" dialog boxHeiko Tietze
* New design * Paste Format Only added * Code clean-up Change-Id: Id414b5f0d4cc27ffd861c2272d755f7ccbd06d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106540 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-27writer notebookbar update for 7.2andreas kainz
Change-Id: Id754c59acd5a548fb96b085e63d1e8f39805ca46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106721 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-27tdf#136801 : IsNumeric("+2") and CInt("+2") return correct valuesAnshu
Change-Id: I036f21c8196530973d2cdc366da7654ccd930892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-27Adapt solenv/flatpak-manifest.in to312a33b7636334f6ce3b6d1702bc5d3e45215601Stephan Bergmann
..."Update language-subtag-registry to 2020-09-29" Change-Id: Idea4df8f6a920cbceb37d5156417f6979d7a4fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106718 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27sw_fieldmarkhide: fix getFieldMarkFor() to return innermost fieldMichael Stahl
... like it's supposed to; if it finds the outer field and then the next field is inside but ends *before* the rPos then the loop is erroneously terminated. Change-Id: Ic5e469d1c05cecd7feca275dc1689af2c40567f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-27silence warnings about negative widths under RTLCaolán McNamara
I don't see any visual problems, but there are these annoying warnings Change-Id: Ifc8830503cdc57084272a973b09927069caabada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-27tdf#127294 add ToD Previewsandreas kainz
Change-Id: Icd049b0ae313e4c3095975a98f8765372fa22abf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106719 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-27external: update libxmlsec to 1.2.31Miklos Vajna
Change-Id: I73449aceed1804e44cc6806f9432e5ff43684fbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106711 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-27tdf#138481: Trust the built-in break iterator character data in ICUTor Lillqvist
Don't use our own char.txt. Quite possibly we wouldn't need to use the other data in the i18npool/source/breakiterator/data folder either. See the README file there for the sad details. Change-Id: I82923ae76407fdd3fa3642d818d43427fe4f5591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106632 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-27tdf#138507 error in loading formNoel Grandin
regression from commit 3de38e95561ab7ca114d9f3307702ba89c4e3e9a Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Nov 10 19:20:06 2020 +0200 use fastparser in forms Change-Id: I995677d4e381e8229e7f052cf54a134bdf49d378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-27Resolves: tdf#136272 convert DBL_MAX to 1.7976931348623157e+308Eike Rathke
... and the 4 subsequent nextafters to appropriate strings. An interim workaround to not write the out-of-range string 1.79769313486232e+308 until we have a proper rounding. Change-Id: I5f98a7f0a8e0421fd024a8cc37cc6f3a198d02d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106717 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-11-27Fix typo in commentStephan Bergmann
...introduced with cfddbf52ea6aed12b0c69a151d3caf4b5732a263 "Fix typo" Change-Id: Id3888f0216a7702d7f09d25d069d50f64859eff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106714 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-27Fix Firebird build on macOS on arm64Tor Lillqvist
Must set RAW_DEVICES_FLG=N for this architecture, too. Make the prefix.darwin_arm64 match the x86_64 one. Don't bother defining ARM64, just check for __aarch64__. Change-Id: I9de67493cb159ce97a46cdd1974b04753518c703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106716 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-26Fix typoAndrea Gelmini
Change-Id: I9bc856d4d7370f2a5fa09001d5b8b933bc72e96f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102095 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-26with SAL_RTL_ENABLED=1 calc tabbar arrows are rendered reversedCaolán McNamara
in... commit 6a54960f6b38a7d549ed33419cf55f4e718cf7b9 Date: Fri Jul 17 17:04:27 2020 +0100 tdf#134085 DrawTransformedBitmap in wrong place for RTL The return of mirror wasn't used, so no effort at a rtl mirror was made anyway. I confidently claimed that "we don't want to mirror polygons", and we definitely don't want to mirror images which was the immediately obvious problem there. It was also the case that the highlight polygons drawn there were missing entirely and the changes improved matters and put those polygons at the correct position. But it does seem that we *do* want to mirror polygons. Since... commit 4deadc3c78949c18bb886eb1f66caa8f3cd7a2df Date: Fri Sep 25 13:30:11 2020 +0200 disentangle AA and B2D use in VCL drawing this path has become more used and makes it obvious that the triangles in the tabbar buttons are reversed since the second commit. Change-Id: Id709b2abff04c609a3c644530bcdb60c83a82942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26tdf#138486 Artifacts in some impress templatesNoel Grandin
fields need to be signed regression from commit 548d77d0c06f7088dd3eb408797aa1fc1d7eb277 Author: Noel <noelgrandin@gmail.com> Date: Fri Nov 13 10:23:36 2020 +0200 tools::Long->sal_uInt16 in ImpErrorQuad Change-Id: Ia2a70d55d9af2ea3712ace3394c0de3931bee95c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26Fix typoAndrea Gelmini
Change-Id: I6dbac66a590cf0cc388796bed918d68800a1537e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106652 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-26tdf#124176: Use pragma once instead of include guardsGül Toksöz
Change-Id: I334fee9257c83aa940b256b049d4408ab2e53a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106609 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-26Fix typo in code: caos -> chaosMing Hua
Change-Id: I8894d83d0131f5bc49d6be7b158cf90401174bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106671 Tested-by: Jenkins Reviewed-by: Dante DM <dante19031999@gmail.com> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-11-26jsdialog: implemented Expander widgetSzymon Kłos
Change-Id: Ib0aee0e01c662a4d6a9231d9a1a951c9fa68eff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106693 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26tdf#131269 - fix importing PPT with different notes/presentations ordernd101
Normal PPT has the order of master-presentation-note slides. But for certain PPT document, the order is master-note-presentation. This fix is to change the importing of page list for those documents with different structure. Change-Id: I2d682a30a3550a6182fcfff7f71f4993ca27a5f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26tdf#136911 fix ppt hyperlink importnd101
If the hyperlink list is not found, try the secondary approach by searching through the record list. Change-Id: I5b3516e1005b102fb3b79f55c2485a7c41b56057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103081 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26New UBSan failures with Firebird 3.0.7Stephan Bergmann
While building ExternalProject_firebird: For one, the ICU UCHAR_TYPE mismatch > workdir/UnpackedTarball/firebird/src/intl/cs_icu.cpp:66:30: runtime error: call to function ucnv_fromUChars_68 through pointer to incorrect function type 'int (*)(UConverter *, char *, int, const unsigned short *, int, UErrorCode *)' from 61411db9f719d793f0665a4d278e0748e8fcd75f "external/firebird: ICU_UCHAR_TYPE breaks -fsanitize=function" returned in a slightly different form. Instead of passing in the problematic UCHAR_TYPE macro from external/firebird/ExternalProject_firebird.mk, Firebird now set it internally in src/common/common.h. And for another, it grew a new invalid-shift-base at > workdir/UnpackedTarball/firebird/src/yvalve/gds.cpp:2564:33: runtime error: left shift of negative value -1 (And beyond that there were no further new ASan/UBSan issues with a full `make check screenshot`.) Change-Id: Ie15cf6bde2df7dc784fec89045026f71747aa0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106477 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-26TYPEATTR::cFuncs,cVars are of type WORDStephan Bergmann
Change-Id: I9a597e7373aef64891e3323d20ba51cb12f897fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-26Use sal_IntPtr to transport HWND to IDataSourceLocator::put_hWndStephan Bergmann
The HWND hWnd source is in OConnectionHelper::implInitControls (dbaccess/source/ui/dlg/ConnectionHelper.cxx) and the IDataSourceLocator::put_hWnd call sinks are in PromptNew and PromptEdit (dbaccess/source/ui/dlg/adodatalinks.cxx). The IDataSourceLocator source code has virtual HRESULT __stdcall put_hWnd( COMPATIBLE_LONG hwndParent) = 0; with typedef LONGLONG COMPATIBLE_LONG; (both C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\msdasc.h), so it looks like an integer type large enough to hold pointers is what is appropriate here. (Which matches the fact that HWND aka HANDLE aka PVOID is a pointer type.) Change-Id: I3a18e9a1d2f75a1feac716ef6e7bca78165ffe95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-26The Windows oleauto.h SafeArray* functions use LONG for indexingStephan Bergmann
Change-Id: If973cc337e0674462cfe2a15e347881a861a761f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-26keep toolitem ids uniqueCaolán McNamara
which is a problem when we swap item ids under SAL_RTL_ENABLED=1 in sidebars Change-Id: Ib949f7836893b2f06b748fc3a2546788555782ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106662 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26Move SalInstanceExpander decl to header fileSzymon Kłos
Change-Id: I5399f5aca07dd27dfc668cad66cf347936bbba7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106664 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26add a way to invalidate the InterimItemWindow child contentsCaolán McNamara
Change-Id: Id7bbf6443f25eee7745123f127cd9d6424a684b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26ZipFile::GetFileLongestFileNameLength is unusedStephan Bergmann
...since 04366df3bca16d4e0cbe254551e44427ae6338bb "Simple Zip file-format implementation to avoid the need of minizip" Change-Id: I20fd35c1f48912b1744063aadf0b917ca56288d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106694 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-26added new parameter in uno:MovePranam Lashkari
new parameter UseCurrentDocument forces to use the correct document for moving/copying sheet tabs around When this parameter is true first parameter DocName will be ignored Change-Id: I207966af5e11fdaaa0bdd91c07e1923399680395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106478 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7e21086c2903d19ec0981d09d63d8f7c4e078242) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106515 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-13 00:53:39 +0000