summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-09loplugin:unusedmethodsNoel Grandin
Change-Id: I0308ddd467ab6e283c0503f98885a248eb28290c Reviewed-on: https://gerrit.libreoffice.org/58738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09Silence external/boost deprecated std::iterator warnings with MSVC 2017Stephan Bergmann
At least cl version 19.14.26433 generates such warning C4996 now. While the one about the using declaration in boost/iterator.hpp looks somewhat bogus, the one in boost/circular_buffer/details.hpp is about an actual use of std::iterator as a base class in Boost-internal code. If further such places in external/boost crop up that need fixing, an alternative approach could be to extend the external/boost/include/ wrappers to be also used with MSVC. (Globally setting _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING has avoided, as it also finds uses in our own code that should be fixed, like 58222feb7fee0c08fb54b9ee29f8f0674c5cf508 "warning STL4015: std::iterator is deprecated (clang-cl)".) Change-Id: I6a41421a590fcee57b4ac8bcb7c3631fdfdecb81 Reviewed-on: https://gerrit.libreoffice.org/58755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09tdf#101254: Enable arrowheads in sidebar for drawsXisco Fauli
It's enabled in Line and Filling toolbar so do the same in the sidebar Change-Id: Icc64705268a9efb46ab463131ddf486dad12f085 Reviewed-on: https://gerrit.libreoffice.org/58747 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-08-09remove Calc's software interpreterLuboš Luňák
- it's in practice never used nowadays, group threading has higher priority in the code and since SwInterpreter's allowed opcodes are a subset of group threading's, there should be no formula where control flow gets as far as using SwInterpreter - the only opcodes SwInterpreter allows are ocAdd, ocSub, ocMul, ocDiv, ocSum and ocProduct, which is a rather limited set and group threading should handle all that as well - if SwInterpreter performs anything better than group threading, there shouldn't be a problem doing the same for group threading - it's yet another code path that should be handled, tested, etc. and the added complexity is not worth it - it shares some code with OpenCL handling, which is both added hassle in case OpenCL code needs changes, and it also causes confusion such as people thinking SwInterpreter has something to do with OpenCL Change-Id: I99052862b60b6266c70dd436d1d7938177dc6bd9 Reviewed-on: https://gerrit.libreoffice.org/58643 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-08-09svl windows: remove last traces of pre-CNG signingMiklos Vajna
Mostly only the certificate selector was left + the global runtime switch. Change-Id: I11e8e0920806eb61848512df6dea48c594febfe4 Reviewed-on: https://gerrit.libreoffice.org/58751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-09menubar draw: add choosemodebar commandsandreas kainz
Change-Id: I1baee1ec55e310aec2ec1010234d739eec5020c8 Reviewed-on: https://gerrit.libreoffice.org/58749 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-08tdf#83659 Enable outline commands for text boxes and tablesMaxim Monastirsky
Change-Id: I2fff7354556769104e9ffaafc504d3159f63e4e8 Reviewed-on: https://gerrit.libreoffice.org/58748 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-08tdf#116350 Fix export of fontworkSzymon Kłos
Change-Id: Icf3a07c6b79296feb233bbe08a6d69ab21a41414 Reviewed-on: https://gerrit.libreoffice.org/58746 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08loplugin:singlevalfieldsNoel Grandin
Change-Id: I75554209ad247173381ea96a14c8bf532bed13a8 Reviewed-on: https://gerrit.libreoffice.org/58724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9ce151dfdb58fd4bb539aaa461a6c873c9ad18a5 Reviewed-on: https://gerrit.libreoffice.org/58716 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08sw TextGraphicObject: handle XBitmap for GraphicURLMiklos Vajna
This restores compatibility for API users who called getByName() on the bitmap table and expected that the result can be set as a value for the GraphicURL property. Changing the property type to cppu::UnoType<css::uno::Any>::get() is necessary, otherwise scripting languages figure out (via reflection) that the type doesn't match, and SwXFrame::setPropertyValue() is not called. Change-Id: Idd62f109e91dbaebf1138b9038f66c6c648d780e Reviewed-on: https://gerrit.libreoffice.org/58745 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-08tdf#42949 Fix IWYU warnings in chart2/source/inc/[d-l]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Try harder to use fw declarations, and a few newly analyzed files Change-Id: I50299e9115ced60468c7bc5e63013addbaec48c0 Reviewed-on: https://gerrit.libreoffice.org/58618 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08Remove presumably unused distro-configs/Jenkins/*_libreoffice-5-0.confStephan Bergmann
Change-Id: I0b6c2d116496da64f91cb5cafb81b69e02366d96 Reviewed-on: https://gerrit.libreoffice.org/58743 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-08tdf#116350 Correctly display text on arcSzymon Kłos
Change-Id: Ice8c141db20d43ccc8d6e2b56004a4a28d2b257a Reviewed-on: https://gerrit.libreoffice.org/58729 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08sw HTML import: apply default table autoformat on cells in reqif modeMiklos Vajna
The reqif xhtml subset doesn't allow formatting of cells, which means that the tables created with the UI and imported tables look different, e.g. the later ones have no borders. Fix this inconsistency by applying the default table autoformat during import (in reqif mode). The import result looks better this way, and the export will ignore it anyway. Change-Id: I310770594e7a00e62f23d9df8cb16c2b95e1e44a Reviewed-on: https://gerrit.libreoffice.org/58741 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-08Resolves: tdf#118281 control positions always in cmCaolán McNamara
Change-Id: I7803f673e835bd4575616d4e4b465ca144e282c8 Reviewed-on: https://gerrit.libreoffice.org/58720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-08Temporarily sprinkle test code with debug print statementsStephan Bergmann
...to hopefully find out why <https://ci.libreoffice.org//job/lo_ubsan/996/ consoleFull#-14523843999567f988-cbcf-4519-af05-6000b834f13f> still fails in UITest_writer_tests after c57191e0c45f9735a33953d6b95d54b0e10c876f "Try to make test_tdf81457_table_merge_undo deterministic". Change-Id: I142f89c508eb66a82e656b0ef32f595796b547fc Reviewed-on: https://gerrit.libreoffice.org/58728 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-08upload libwps 0.4.10David Tardon
Change-Id: Ib29c429a34a3895fa0747a54194dcd60ad41e45d Reviewed-on: https://gerrit.libreoffice.org/58704 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2018-08-08nss: remove inline patch message from nss-android.patch.1Michael Stahl
forgot to remove this in the 3.38 upgrade Change-Id: Idaa9fd8e8036f305ec64c4a474d904d72daef0e8 Reviewed-on: https://gerrit.libreoffice.org/58721 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-08tdf#112343 Change dependency from dbus-glib to dbusArkadiy Illarionov
Add check for GLib support for modules which depends on dbus and glib separately. Also fix copy-paste typo. Change-Id: Ibd33573b2f8dff9e0a7f2e0fc983d93878bb5357 Reviewed-on: https://gerrit.libreoffice.org/57157 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-08tdf#103961: delay merge of default props until exportJustin Luth
Until now, during docx import the pPrDefault properties have been directly added to the parentless styles. However, things like table styles are supposed to over-ride these document defaults, but not style defaults. Since the docDefaults are merged into the style, table-styles were unable detect if they could override them. Exporting doesn't export pPrDefaults well, so the properties still need to be merged into the style when round-tripping. Almost every existing unit test document is a proof test. It effectively ought to act as a non-functional change. Plus, this basically reverts 7f697ec27b1175ed94228155935d9ccd3cd5606c so that unit test still covers bug 103961. Change-Id: I4948299ddd610c07d828f2bd57c58734f1b94c49 Reviewed-on: https://gerrit.libreoffice.org/58203 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08tdf#118731 delay on showing dialogs that create SdrModelsCaolán McNamara
for their preview widgets. since... commit 4be44a7a6f2f480e55255d7cdd119f3d6577d085 Date: Thu May 24 19:09:44 2018 +0200 SOSAW080: Cleanup of SdrModel Change-Id: I102b64bdacc56a41091bbe60e932c2915f20323f Reviewed-on: https://gerrit.libreoffice.org/58693 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-08nss: upgrade to release 3.38Michael Stahl
Fixes CVE-2018-0495 and "the ASN.1 code". Remove one hunk of nss-android.patch.1 that should be obsolete with the current Android toolchain baseline. Change-Id: I5516edec17b72f53acd2749e8840805eead077bc Reviewed-on: https://gerrit.libreoffice.org/58697 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-08tdf#42949 Fix IWYU warnings in include/rtl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iae997959a0ec2c9edb1c795533692ec4e579449f Reviewed-on: https://gerrit.libreoffice.org/57313 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1 Reviewed-on: https://gerrit.libreoffice.org/58708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08the TimeEventHandler stuff is deadNoel Grandin
ever since commit c760d61bad637bf178566884039dd07d81ab17ed Date: Fri Jul 27 15:28:44 2018 +0200 remove SdrGrafObj::IsSwappedOut Change-Id: I68c98449b98a3ac5da3bf26917ad2a76226f470c Reviewed-on: https://gerrit.libreoffice.org/58707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unusedfieldsNoel Grandin
Change-Id: I9ae44279f1cce06bd6868005fbb878ba4894aed7 Reviewed-on: https://gerrit.libreoffice.org/58706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08improve SharedStringPoolNoel Grandin
we don't need two sets, we can simplify the logic and let the key in the map perform the same function that one of the sets was performing. Change-Id: If042fd0d1483fb603967164c429a085a4f0b31eb Reviewed-on: https://gerrit.libreoffice.org/58692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Missing include (incomplete SfxAbstractTabDialog)Stephan Bergmann
Change-Id: Iba9facc39f26a22f07de5372e0eebf9a4544c077
2018-08-08pdfium: replace FPDFFormObj_CountSubObjects() with backportMiklos Vajna
Change-Id: Ie7aaf6790c29818236f38b90409860dedecb3cb3 Reviewed-on: https://gerrit.libreoffice.org/58711 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08tdf#119136 GetPropertyFromStyleSheet infinite loopJustin Luth
So, apparently we accept a style that has no styleId and define it as such. Due to some reworkings, this function was called instead. Since we can "find" a style without a name, now every parentless style thought it inherited from this nameless style. Change-Id: I47b4119abd37ece94a39e636ddb7798b809ccb04 Reviewed-on: https://gerrit.libreoffice.org/58705 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I5729650d35dbc724906141c8fdf371eb5ceb80f4 Reviewed-on: https://gerrit.libreoffice.org/58714 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ie2be68fe9d106b5f370bc8927fcf65d16496ee3e Reviewed-on: https://gerrit.libreoffice.org/58715 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08Fix typosAndrea Gelmini
Change-Id: Ib734b3d578f8036182a2f3e22eb1f3f8951b7fad Reviewed-on: https://gerrit.libreoffice.org/58699 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08Fix typosAndrea Gelmini
Change-Id: I65836b437bbc27d4f6a5862fe436397d858564a2 Reviewed-on: https://gerrit.libreoffice.org/58701 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08CID 1438378: Allow only signed typesMike Kaganski
Change-Id: Ie342a356a599e42882f59fc823330bdfae233e5d Reviewed-on: https://gerrit.libreoffice.org/58710 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-07Mark external/mdds/gcc9.patch as upstreamedStephan Bergmann
Change-Id: I146dd8926e5e93a57162558286168e963f402f59 Reviewed-on: https://gerrit.libreoffice.org/58689 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-07CID 1438378: Use correct specializationMike Kaganski
Omission from commit 81302f33073e7629d724ed269f1fa21dad29e141 Change-Id: Icc2ac3ce87a199609a4faa32a2f6f999fc219f4d Reviewed-on: https://gerrit.libreoffice.org/58700 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-07added necessary library for pdf export on Android ViewerMert Tumer
Change-Id: I01413493100fd110175ec85790899a130954c78e Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/58688 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-07Mark external/cppunit/gcc9.patch.0 as addressed upstreamStephan Bergmann
Change-Id: I9071acc34d07f3819fb40c93bbee6b5bcc79a14a Reviewed-on: https://gerrit.libreoffice.org/58691 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-07Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I61893e446ec9549fae2bc0cde2fa5fcc5d77a713 Reviewed-on: https://gerrit.libreoffice.org/58662 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-07Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ic5c406eb281477c0831c1a13e8c5eaa63169c7e9 Reviewed-on: https://gerrit.libreoffice.org/58661 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-07more robust implicit intersection optimizingLuboš Luňák
For example, FormulaCompiler::MergeRangeReference() may replace the parameter tokens and merge two into one. Change-Id: Ie2933dec3ef73b5b605160e86a8ab3b5b1d17c1c Reviewed-on: https://gerrit.libreoffice.org/58684 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-08-07tdf#42949 Fix remaining IWYU warnings in sc/incGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. With this patch, find-unneeded-includes gives no more problems Change-Id: I24e62be7a387d7fd97a36f54eed0ba9d83ddaf0c Reviewed-on: https://gerrit.libreoffice.org/58667 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-07tdf#119052: hide edit style button in character styleXisco Fauli
Change-Id: I8ec82865b990ff19ead819c990f442edd7423d66 Reviewed-on: https://gerrit.libreoffice.org/58472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-08-07tdf#119130 only have the active postit as a dialog control...Caolán McNamara
in which pressing ctrl+tab cycles between text and button so we don't waste time searching thousands of SwAnnotationWins Change-Id: Iba34882c6588fc9414004f0ed3b2b779f77b30d1 Reviewed-on: https://gerrit.libreoffice.org/58682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-07coverity#1438379 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic8614c2c455a5a49592ee5f8ef0c91bf4d729e1e Reviewed-on: https://gerrit.libreoffice.org/58686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-07loplugin:includeformStephan Bergmann
Change-Id: Ibd50fa73a5ee63e3375ef0518df0ba84bf6fce1c
2018-08-07Qt5 move native control handing from kde5Jan-Marek Glogowski
The native painting code in the kde5 backend is Qt based only. To prevent multiple inheritance, it's moved into an extra class and just leaves the backend specific QImage blitting in the specific SalGraphics implementation. Change-Id: I3d5f58f42a37966794541fe1214c1b9557376a98 Reviewed-on: https://gerrit.libreoffice.org/58652 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2025-02-12 01:10:26 +0000