summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-08Fix iteration in sc/source/ui/docshell/externalrefmgr.cxxJulien Nabet
Like this since 2012 with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=63ade823e2d854b60df76790e3628a5ab78f653a commit 63ade823e2d854b60df76790e3628a5ab78f653a (patch) tree 69283e660118fb534f50ea1be7ba17b24c7b1c20 parent 51caf9b45403b92deadf934347f2d6f9ffecdf08 (diff) remove entry from unsaved ref container if doc is saved Change-Id: I4845c2c6b9ffd7b9f6b14276e1ca97817d584913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123233 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-08Clean up a bit iterator management in sc/bcaslotJulien Nabet
Change-Id: I2bced8cb78ccecf85798f3468aab87681d520180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123235 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-08Clean up a bit iterator management in oox/vmldrawingJulien Nabet
Change-Id: Icd4f4980332edc3fd9027cc4cace2b4a0d0c1315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123234 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-08loplugin:moveparam in connectivityNoel Grandin
Change-Id: Ie5c2f6ec1573ab2c47218dd4da8c9150b23bcd2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08remove unwanted xpad/ypad properties and replace with a margin-endCaolán McNamara
the xpad didn't do anything in vcl, and is deprecated for gtk. There was additional padding shown in gen anyway because a yalign of 0.5 wrongly horizontally centering, which is now fixed. Change-Id: I546ec72b0449185217213ee1ba061dd051122880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08vertical centering is WB_VCENTER not WB_CENTERCaolán McNamara
Change-Id: I75cff767008aa215ce43856da4cd31db1b6d83fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08remove (presumably) unwanted 'Widget name' propertyCaolán McNamara
Change-Id: Icf296074e21e02c2aeb63bc6a9d8ff0702cc4c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08resave with glade to tidy this upCaolán McNamara
Change-Id: I7b3499cc1044cb976415d3db6855283bf928c4b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123266 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08add mappings for emphasis propertyCaolán McNamara
Change-Id: I1406d57a47075bfad3973c6bbb825a7754e8f279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08fix "GtkBox does not have a child property called left-attach"Caolán McNamara
on launching development tools probably since... commit 81d6ed89d1e5268c2ea4ff527f3e6087dc1d8ccd Date: Mon May 17 13:59:25 2021 +0300 tdf#142276 Use vertical GtkBox insted of horizontal GtkGrid for the left side. Change-Id: I6d4e4a056fb25c6ffb44e0ed734eb7a553a78ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08tdf#83090 - Allow any font size in the toolbar/sidebarAndreas Heinisch
In order to allow any font size in the toolbar/sidebar, correctly round the height of the font in the status listener. Change-Id: Iebd07f5e710a01c5a9be4a7dd8c950d191d5d629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122332 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-10-08vcl: test PhysicalFontCollection and move to vcl::font namespaceChris Sherlock
- tested PhysicalFontCollection, noted odd behaviour with search names and normalization - moved PhysicalFontCollection.hxx to vcl/inc/font - moved PhysicalFontCollection into vcl::font namespace Note that I needed to regenerate the pch file otherwise errors were generated. Change-Id: Ifa0c7b871c40687bd15002565d2f7a3e408218f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122036 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08vcl: split out outdev.h into seperate headersChris Sherlock
outdev.h is a hodge-podge of functions - font substitution and an internal state struct for OutputDevice. I have split these into: - font/fontsubstitution: FontSubstitution, GlyphFallbackFontSubstitution.hxx and PreMatchFontSubstitution.hxx (all three define pure virtual base classes for later reuse) - font/DirectFontSubstitution.hxx: incorporates FontSubstEntry and DirectFontSubstitution - ImplOutDevData.hxx contains it's own class Each fo the classes has been moved to the vcl::font namespace. As outdev.h is now no longer, this has meant that I have had to regenerate vcl/inc/pch/precompiled_vcl.hxx Change-Id: Iaa92fa21271faff46f2a8a0f6488e01434c142db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121997 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08remove GtkLabel "xpad" propertyCaolán McNamara
Change-Id: I237eb9e35367b8b75c8e72b857620747840383cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08tdf#45525: sw_uiwriter2: Add unittestXisco Fauli
Change-Id: I266efb1fc95a782d0fd75e16bd099e5c5359f9f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123262 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-08gtk4: set draw-as-radio as true for GtkRadioMenuItemsCaolán McNamara
Change-Id: I1a49a3f44f46ed57e80fa54af0e2b6466b2a9b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08use more SfxItemSetFixedNoel Grandin
Change-Id: I18784bac5f7ad1d109f8a81e96084cd6e9548231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08loplugin:moveparam in vclNoel Grandin
Change-Id: I6dea009e1031174ecb3d4371e91c9c6d26c6e514 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08loplugin:moveparam in binaryurpNoel Grandin
Change-Id: Ia69e2307872813ede3339c0e9fbe1f2ae6a3508a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08don't warn about missing TopMostParentSystemWindowCaolán McNamara
Seen in tdf#144037 because the notebookbar is not a child of the toplevel window, but instead (like the menubar) is a child of borderwindow of the toplevel so from its perspective there is no eventual parent SystemWindow. This TaskPane thing could probably be dropped and likely no one would notice. But with tearable floaters like the color dropdown still a thing then F6 wouldn't work to move into them and someone might complain. Change-Id: I7174598a2ee01e98aca2f6e214adf94f7a555018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123258 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08Centralize VS-to-toolset mapping in configureMike Kaganski
This allows to define the mapping once, and avoid modification in multiple places each time a new VS version support is added Change-Id: I93de4c9d78c3f67a0a2e157007e9d13b6f557937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08Simplify VS IDE integration generationMike Kaganski
Do not require the IDE version in vs*-ide-integration. Instead, use VCVER environment variable, that is set in configure, to obtain the toolset for the VCPROJ files. When introducing support for new VS version, the 'VisualStudioIntegrationGenerator.retrieve_toolset' method needs to be updated synchronously to list the toolset. This simplifies the make command to make vs-ide-integration TODO: also set the toolset in configure, to simplify the code here, and also in places like external/python3/ExternalProject_python3.mk (see commit c156a8c708f74dd31e1ef024edc578c3915619cb). Change-Id: I95960029a933be2cab96898eee6be6ca6bc5794a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08add 'destructive-action' style to the close button of save changesCaolán McNamara
which gives a red "Don't Save" close button in the default Adwaita gtk theme for that undoable action Change-Id: I62b50c90ca53c8f05e656c9beaecbfb160ce5f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123249 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08add 'destructive-action' to the yes of delete header/footer messageboxesCaolán McNamara
Change-Id: If4d22caac6d1c6ce12b22e0f3d4395f349539e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08tdf#144970: sc_macros_test: Add unittestXisco Fauli
Change-Id: I0f44f15b7cf43d6a0cee13c427d473effc04c710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123250 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-08sort buttons using id instead of HelpIdCaolán McNamara
when created from the builder a widget's HelpId is the patch to the widget and always ends in the widget id so this is no change for that case, but when created directly by vcl for e.g. a MessageDialog while the id is set the helpid is empty, so this means that Yes/No MessageDialogs have their buttons sorted the same as if the Yes/No buttons were explicitly spelled out in a builder .ui Change-Id: Iee1a7146d2b6da76804856b1c4df8849ddd91a0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123253 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08tdf#144984 default edit width got widerCaolán McNamara
at... commit f72013ca65c7a33991d5fb124b919fe7cde269e2 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Aug 26 15:24:25 2021 +0100 use max of avg digit or 'average char' width to measure Edit space where this default was forgotten Change-Id: I50933ff5c1b8735624609a884fb9fc7701df7f97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-08tdf#143142 Solve the button cannot be used when table column is 6Verne-Lai
Change-Id: I6147c08ec36da59bb93b707fa206f9a8f681af3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123237 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-08Drop vs2017-ide-integration; add vs2022-ide-integrationMike Kaganski
VS2017 is not supported since 24973523ba59087185d434396fd614e73d72107f. Change-Id: I1a2af1eb8c9216eaed87d5454def2176728f719b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123161 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08remove unintended blank lineJim Raykowski
Change-Id: Ic7688a625d2c1be19f66e289d4517c7ce32ff4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123239 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-08loplugin:moveparam in svxNoel Grandin
Change-Id: I92fe2882c948e7297e5d54963647b4aa054f8f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08sw: handle mbIsLabelDoc when replacing compat optionsMiklos Vajna
This describes if the document contains labels for printing, surely we want to keep that when copying the contents of the document to an empty document. (Mail merge scenario.) With this, finally sw::DocumentSettingManager::ReplaceCompatibilityOptions() replaces all options where it makes sense to do so. Change-Id: Ic0be340578e9a01fac7e8c08fe2e6b6ffbb30039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123230 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-08tdf#130104 - FILESAVE XLSX: cell indent increased on each saveKevin Suo
In OOXML, 1 indent = 3 space char width. ----- The Old Method: ----- XLSX Import: As per the line: sal_Int32 nIndent = getUnitConverter().scaleToMm100( 3.0 * maModel.mnIndent, Unit::Space ); assume the width of space char is 88, then: If the OOXML indent is 1, then nIndent would be 264.5, and casted to 264. If the OOXML indent is 2, then nIndent would be 528.5, and casted to 528. If the OOXML indent is 3, then nIndent would be 792.5, and casted to 792. ... Also, as Mike Kaganski has pointed out, we use twips in sc indent internally, thus it is wrong to convert to Mm100 unit here. XLSX Export: As per the line: nTmpIndent = (nTmpIndent + 100) / 200; Assume we did not edit the document upon open, and simply save it. Now: If our indent is 264, then the calculated OOXML indent would be 1.82, and then casted to 1, while the expected value is 1. If our indent is 528, then the calculated OOXML indent would be 3.14, and then casted to 3, while the expected value is 2. If our indent is 792, then the calculated OOXML indent would be 4.46, and then casted to 4, while the expected value is 3. ... Then if you reopen the saved xlsx file with Calc, the increament of indent continues on each save which causes serious format loss. Most importantly, if you change the indent of cells using the Calc toolbar indent icon, one-click would be 10pt = 200 twips, see defined macro SC_INDENT_STEP. This causes a mess when you change the indent in an xlsx document. ----- The New Method ----- In this patch, I have changed the XLSX import to convert the excel indent unit to 3-spaces-width *in twips*. Then, per code advice from Mike Kaganski, as a mirror operation, I have changed the XLSX export logic to detect the width of the space char (which *should* be the same as the one detected at the time of xlsx import), and use this width to convert the indent in twips unit to excel unit. This way, the indent will remain the same on xlsx export. ----- TODO: ----- 1. On xlsx import of the file tdf130104_indent.xlsx, the default font (i.e. font for the "Normal" style) is "Times New Roman". However, when the UI locale is set to Simplified Chinese and "Asian" option is enabled in Tools->Options->Language Settigns-> Languages->"Default Languages for Documents", upon resave as xlsx, the default font for the document is changed to "Noto Sans CJK SC" on my system, which causes the space-width detected to be different from the width detected on xlsx import. This seems to be another bug, see tdf#131349. (Luckily the unit test in this patch passes, this is because the change of space width resulted from the change in default font is very small thus the conversion is not impacted.) 2. The UI part need to be improved, so that after xlsx import, if the user hit the "Increase Indent" or "Decrease Indent" toolar icon to change the indent, Calc should be able to detect that we are operating in an xlsx file, thus the "increment" should be 3 * width of space char, rather than the current SC_INDENT_STEP. Also, the if the user changes the default font of the xlsx document, the Calc should recalculate the indent for each cell to reflect the possible change in width of space char. Change-Id: I5f7a4ecbcd93079d1c19db3b0b641dda949f6fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123111 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-08loplugin:moveparam in svlNoel Grandin
Change-Id: I58c1ef97fd6cba281c90cc7ed9917e04b7f265ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08use SfxItemSetFixed in editengNoel Grandin
Change-Id: I892a69d50f7d641f9a941a55c7b3952d1c59c435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-08loplugin:moveparam in vclNoel Grandin
Change-Id: Ic43e02576454e3ee174304db350659dd113a1d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-07svx: add "m" prefix to some member variables in SdrObjEditViewTomaž Vajngerl
Change-Id: I2877f63d97ff6d15f08bd2dbaee6128b8a689cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123219 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-07Match order of the beginning of fldunit.hxx with FieldUnit.idlJulien Nabet
Change-Id: I5ddb120e66fed214cab484f9cd668dfa6f75d123 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123231 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-07Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 7f942a62c3e173d25ec8e3d7ee786b2087d49e42 - Create a guide on Calc macros on reading and writing cell values This patch also creates a new entry in the Calc tree menu to store all pages about Calc macros. Currently there are only two, but in future patches new pages will be added. Change-Id: Iac55c87d1159f4163ba3150e83160b4156d0d0f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122936 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-10-07Blind fix crash in ScDBData::UpdateReference(), tdf#126926 follow-upEike Rathke
Crash reports at https://crashreport.libreoffice.org/stats/signature/ScDBData::UpdateReference(ScDocument%20const%20*,UpdateRefMode,short,long,short,short,long,short,short,long,short) No reproducer yet, for a possible reproducer see https://bugs.documentfoundation.org/show_bug.cgi?id=126926#c12 but creating such a scenario with 8 AutoFilters / sheets wasn't sufficient. However, ScDBCollection::NamedDBs (maNamedDBs) uses a std::set so after erase(iterator++) iterator is still valid, but ScDBCollection::AnonDBs maAnonDBs uses a std::vector for which after erase(iterator++) iterator may be invalid if vector was shrunk and reallocated. So use the iterator returning erase() instead to have a valid following iterator, and for consistency do that for both. A reproducer may need a bunch of sheets / anonymous AutoFilter for a vector to shrink and be reallocated, and it may depend on the plattform/compiler's implementation. Change-Id: Ib57294d8af9f486b734f4294d8d310ce0fa20551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123224 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-07Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 82e70eb6efa88c3d21606292a042cd6978385480 - tdf#143687 Document the "IS" Basic keyword This patch also improves related help pages about the functions IsObject and EqualUnoObjects. Change-Id: I5f16596ed057c1104d5fa2650299861741bd7b2e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123153 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-10-07tdf#85148 New option on database wizard to connect to Firebird Serverjucasaca
Add a new option to the database connection wizard to connect to firebird database server Change-Id: Ie9c75187347a8532c1d869939c72a6f0a892d861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122073 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-07svx: defining "i" variable inside "for" statement is good enoughTomaž Vajngerl
Change-Id: I30c8eb216ecde97451f2c8501424f95fee36d680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123218 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-07svx: move LOKit specifics into it's own methodTomaž Vajngerl
Change-Id: I87f04d460d88c902426e881c03701b95414207d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123217 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-07ofz: Integer-overflowCaolán McNamara
Change-Id: Ib0c1863c5fed92622b4bd601021a1174cf6ee68d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-07vcl: test OutputDevice::Erase()Chris Sherlock
Change-Id: Id15ad1419a5f9d0e628c746770f05b2983c1f65b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122893 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-07use SfxItemSetFixed in scNoel Grandin
Change-Id: I5b1d66adb1b9e5dd0e470403ba7095183334cc66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-07loplugin:moveparam in editengNoel Grandin
Change-Id: Id8118e5f5b7acbff4f04935560c663b36093a5fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-07Add extended tooltips to new Paste Special dialogRafael Lima
The new Paste Special dialog in Calc has 4 new presets and a new checkbox. This patch adds extended tooltips for them. Change-Id: I7d4c5fdb140a49c50b733e50b23d2618127f2c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121413 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-10-07SwNavigator: Fix crash on image selectJim Raykowski
Fixes crash that occurs in update tracking test for bookmark when image is selected by testing that selection type is text before testing for bookmark. Change-Id: I53c64a71d3aff0f159bff31b98e2f453d7c2225a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123202 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-23 10:56:48 +0000