summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-03-30tdf#146619 Drop unused 'using namespace' in: shell/Gabor Kelemen
Change-Id: I4194a1e3b92ec5bd25a8f313f7ff441566079bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165517 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30tdf#146619 Drop unused 'using namespace' in: UnoControls/Gabor Kelemen
Change-Id: I6739c80a76289b042607a5b50ac04482f65b5a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165520 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30tdf#146619 Drop unused 'using namespace' in: unotools/Gabor Kelemen
Change-Id: I7af4b514dac89b3dbacdc21705a90a91458b4487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165519 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30convert TitleHelper to comphelper::WeakImplHelperNoel Grandin
Change-Id: I81571a0786a4d13e049dba82ba6e4f3509887fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-30convert CanvasFont to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: I91aab0365aa57670d484228797f97a2675894cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-30Simplify and avoid const_castMike Kaganski
Change-Id: I963bccd565750b41f16e3585f9a358678aa28500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165576 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-30This should copy from sourceMike Kaganski
Was this way since initial commit Change-Id: I4159d8969853a9f1e226326bcd5180aedeed50dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165575 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-30tdf#145081 Line spacing style type "Fixed" is not on the style sheet dialogGlen Campbell
Change-Id: I0dd668a2bedb16fe39793c5350c1d5a251949a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165400 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-03-30vcl: cleanup XPMReader class - rename members with clearer namesTomaž Vajngerl
Change-Id: I185a72a972d35c29d774a53476a345664497be6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165209 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-30vcl: remove partial XBM image loadingTomaž Vajngerl
This removes the code that handles the IO_PENDING and the graphic "context" handling from XBM image format. Partial loading of images complicates the image filter life cycle a lot (many exceptions) and is not really needed so much today as this was needed in the past. In most cases we load the whole image in one pass anyway. Even loading from the network should be fast enough to not cause issues for the user. Most image filters don't even implement this like PNG and nobody noticed for many years that this is not supported. To handle IO_PENDING case it is probably better to load the bitstream into memory and then load the whole image after that in one pass. This can also be implemented all inside (Imp)Graphic in a very straight forward way. Change-Id: Idb11f4ffa821467374b19f22b5841cfe940b9457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165208 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-30vcl: add resetLastUsed to ImpGraphTomaž Vajngerl
We reset the last used member variable in many places in the same way, so instead of duplicating the implementation, add that to a method. Change-Id: I747559ecf1a6736f976b4d560ab5052c19431898 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165207 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-30vcl: cleanup and prefixmembers of XBMReaderTomaž Vajngerl
Change-Id: Ib424c3818a7441f9a1c3a7fb2be2d0a7b9682ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165206 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-30vcl: change (graphic) Manager into a general memory managerTomaž Vajngerl
Graphic memory manager was changes so that it can work with any object that implements a specific interface (MemoryManaged). With this it will be possible to use other objects (that take a lot of memory) to be managed by the manager. It is also a first step to move memory managin responsibilities away from Graphic and move it into the specific objects instead (BitmapEx, Animation and VectorGraphic). Change-Id: I7638bd89a1c9ece5c4bc95b506d2192492894ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164958 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-30Related: tdf#160159 use a stock icon for the character mapCaolán McNamara
https://specifications.freedesktop.org/icon-naming-spec/0.8/ar01s04.html Where "accessories-character-map" is "The icon used for the ... character accessory program" Change-Id: I48c72aaa3827037eb6921571bcce061fe60ac135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-30ofz#67708 ignore oversized colspansCaolán McNamara
that can't fit in SCCOL ignore negative colspan and rowspans too Change-Id: I79a010bcd7d9d84de70f6dac2e09614d6d448227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-30Resolves: tdf#159498 Items in Template Manager dropdown should be left-alignedCaolán McNamara
Change-Id: I72d32793814b28b7452be701f0732dbd9dbbcb37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165559 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-03-30tdf#160378 Remove NewGlobalDoc from the Tabbed UI in sd and scRafael Lima
The command NewGlobalDoc is not supported by Calc, Impress and Draw, so they should not exist in the Tabbed UI. Otherwise, a gap appears, since there's no info about this command. Change-Id: I0dd2b4639cfb44437d6726d6f138c4767c5a3175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165351 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-03-30tdf#42982 Add error messages to thrown exceptionsRMZeroFour
As part of the efforts in #42982 to improve the UNO API error reporting, this commit adds error messages in several files to help improve debugging experience. Change-Id: I7a51d4fd1e3a57798d70bc3464b034649948a287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165253 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-03-30tdf#146619 Drop unused 'using namespace' in: comphelper/Gabor Kelemen
Change-Id: I96982faf40e7654b0f8f26b666a17cbd057886a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165516 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30tdf#146619 Drop unused 'using namespace' in: eventattacher/Gabor Kelemen
Change-Id: I3231636dcf6367565a88b58bd9bba9a89f8ec749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165515 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30tdf#146619 Drop unused 'using namespace' in: stoc/Gabor Kelemen
Change-Id: I86e2dd229e377995e52d323b1b5be5a9a280b68f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165514 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-30Fix extended tipsTaichi Haradaguchi
Fix wrong dialog names in extended tips. Change-Id: I60a91c6a06afdf0b993bd65dae8a2e3c6413528a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165122 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-03-30resave latest gladeTaichi Haradaguchi
Change-Id: I9d0bebea5382c297c9e04caa9d9677720d373069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165198 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-03-29tdf#157285 PPTX import: fix placeholder heightTibor Nagy
The "TextAutoGrowHeight" property doesn't shrink the shape automatically when its content is smaller than the current size. Change-Id: Ia7f94d7452d1a1c3f004aebd73b6ed5cbfd9b43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165551 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-03-29tdf#146619 Drop unused 'using namespace' in: ucbhelper/Gabor Kelemen
Change-Id: I9083ff77bc80fb1eb35305cbd3fb55bb25817b49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165513 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-29tdf#146619 Drop unused 'using namespace' in: io/Gabor Kelemen
Change-Id: I5cfd37be41e1d364f8d50b3a547453d418abb86d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165512 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-29tdf#146619 Drop unused 'using namespace' in: cppu/ cppuhelper/Gabor Kelemen
Change-Id: I4658c2a5c780fa5e8dd83381eb9978510973e0a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165511 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-29tdf#146619 Recheck xmloff/*cxx with IWYUGabor Kelemen
after cleaning up unused 'using namespace' clauses Change-Id: I9e4cd3790408ae6b0379819a8275feaf67e860cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164941 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-29Resolves: tdf#160368 crash on save after deleting sheetCaolán McNamara
to reproduce the underlying problem: data, calc, recalculate hard: which asserts that cell I367 is dirty during parallel calc checking the dependencies for a parallel calc is supposed to find what cells it depends on and either: ensure they are not dirty or detect its not possible to do the parallel calc checking starts in J9 where:: J9: =SUM(H$8:H9)-SUM(I9:I$9) J10 =SUM(H$8:H10)-SUM(I10:I$9) for the first sum it detects that the input range is H9:H367 and checks that for dirty results, but for the second sum it detects a range of just I9 and the dirty I367 is not detected and the problem arises on calculation The code to detect the range is: // The first row that will be referenced through the doubleref. SCROW nFirstRefRow = bIsRef1RowRel ? aAbs.aStart.Row() + mnStartOffset : aAbs.aStart.Row(); // The last row that will be referenced through the doubleref. SCROW nLastRefRow = bIsRef2RowRel ? aAbs.aEnd.Row() + mnEndOffset : aAbs.aEnd.Row(); where for the I9 case has nFirstRefRow true and nLastRefRow false so we just get a range of I9:I9 instead of I9:I367. Trying to create a doc from scratch to reproduce this case proves tricky, so trim down the original document to the sheet and subset of columns that can trigger it. Change-Id: I44bfd1f6d3a3ee13db9024c5b2efa2588cc30521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165510 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29Resolves: tdf#160028 Type to select currency in dropdown does not work for gtkCaolán McNamara
LibreOffice embeds RTL/LTR direction markers in currency strings, which defeats the default gtk search mechanism, so switch in our one instead. Change-Id: Ia118f8c8e27103c21955683f8a2fd3c17c2b2098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165557 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29resave with latest gladeCaolán McNamara
Change-Id: If56e9d6c09b9622670ef37e235dde8be2c3ca88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165556 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29Resolves: tdf#160159 update spellchecking area colors when style changesCaolán McNamara
so for the case of using "automatic" for the document background the spelling checking textbox background area updates to match Change-Id: I8723afb946176596b0a5fa43aa3bb3c036dee12c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29convert PlayerListener to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: I167354cbf998dd08ef8b5ffba744758539cabec5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29convert SvxDrawPage to comphelper::WeakImplHelperNoel Grandin
Change-Id: I72ea1f08c3c531cee3ac9301aaf87c76f95de3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29speed up ScPatternAttrNoel Grandin
we know that ScPatternAttr uses a single, contiguous range of item ids, so we can compute the item offset at compile time. Shaves 1-2% off some workloads. Change-Id: I623b8cb3e0d5d070118117196d2b48575f505725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29use std::mutex in StatusbarControllerNoel Grandin
remove some locking in reportdesign::OStatusbarController - those places are already locking using the solar mutex Change-Id: I76d8e3a7ad60e4a2be1f0aac42967553356e9202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29cid#67704 Integer-overflowCaolán McNamara
Change-Id: I42aa4b3e43636bf6f0c0f77c5028501229badee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29tdf#158237 Use C++20 contains() instead of find() and end()Aaron Bourdeaux
Change-Id: I529096d97991a89bdc68ec7f5d490ec21744fc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165499 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-03-29Use default HIDs in Gallery, simplify codeGabor Kelemen
and copy relevant help texts from helpcontent to .ui file Change-Id: I3791f7843d6d8a0285d0d3369c867e6b165a582f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165021 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-29tdf#143148: Use pragma once in dbui addresslistdialogwilmhit
Change-Id: Id0ebec238de937482111760f0a9732b621d082af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164952 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-29tdf#143148 replace include guards with pragma onceU-Aarons_Laptop\Aaron
Change-Id: Idd8ecf3ef95ce2296b31a1c7fb1ddadefdd573f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165293 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-29ofz#67699 Integer-overflowCaolán McNamara
Change-Id: Ifb949cb4816c21587f337827fe50f993a64a3f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29pre-thread -> per-threadCaolán McNamara
Change-Id: I1b5fa94370fc9432d76b25fe9cf663c926c32a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165508 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29crashtesting: fix SvNFEngine::CacheFormatRO assertCaolán McNamara
since: commit c6c6126aa3e8de256091b829b98b5943db6a8be6 Author: Caolán McNamara <caolan.mcnamara@collabora.com> Date: Thu Mar 21 17:25:35 2024 +0000 Related: tdf#160056 refactor SvNumberFormatter to split it into two constituent parts Change-Id: I4add9f383789ab03ceab751b07973448a41911ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-29Simplify a bitMike Kaganski
Change-Id: Idb10d594829eeffd9b37e5ae971283b2a9730168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165475 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-29Avoid bitwise assignment operators on boolMike Kaganski
Change-Id: I77509caf437c02792c34385cdf115f2c2a673754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165474 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-29convert SolverComponent to comphelper::WeakImplHelperNoel Grandin
Change-Id: Ia5accd94c3a3b498aa31829832110ec07b780112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29convert SwarmSolver to comphelper::WeakImplHelperNoel Grandin
Change-Id: I20a97cd2355648d02c1bb9a4d999c5a6ed4470a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165492 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29convert BasicScriptImplodNodeImpl to comphelper::WeakImplHelperNoel Grandin
and remove OBroadcastHelperHolder, since nothing uses it anymore Change-Id: Id07b4589e0893950974c6bf41e0d4f2d8dc7ee81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-29convert VCLSession to comphelper::WeakComponentImplHelperNoel Grandin
Change-Id: I74bc44f84dd6dccde602c31a0f87a1780e3e7231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-24 05:39:16 +0000