summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-03-30Remove undocumented perftune.ini FastPipeCommunicationStephan Bergmann
...originally added to OOo in 2005 with 9277dc7501f70d80ea1302c128c2786c01b69706 and e3eecbfeb639529f3a15c0acfe4697a619d454fb "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I149686eca8bda5ea7a363cd995447576e217ec13 Reviewed-on: https://gerrit.libreoffice.org/23600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-30Fix Android buildMiklos Vajna
Change-Id: I7247f19b03302b2270e0f6f32c6e6b6e760fd7bd
2016-03-30Related: tdf#65642 RTF filter: import \pgnlcltrMiklos Vajna
This as a side effect also implements support for DOCX <w:pgNumType w:fmt="lowerLetter" .../>. Change-Id: I47b60a0390ef081dc15b26e40393e35bf7bad130
2016-03-30Related: tdf#65642 RTF export: \pgnucltr testcaseMiklos Vajna
There is no reason this unit test is import-only, this area of the export filter was untested so far. Change-Id: Ia271bccf59c1b21474e7b854cbaa0992b722e552
2016-03-30tdf#97361 Refactor load_save_testslideon
Make new helper functions, minor style cleanup in other tests Change-Id: Ifb188fa8227cdd1a1a5af88e692315c5f93da67d Reviewed-on: https://gerrit.libreoffice.org/23547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-30tdf#96099 Remove trivial typedefs from vcl moduleslideon
This typedef was not needed. Change-Id: I442068a3e394a23551655294dc8f1765bc8f2887 Reviewed-on: https://gerrit.libreoffice.org/23618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30loplugin:stringconstantTor Lillqvist
Change-Id: I266bc972dbb6ab53920a0b453b181c3f5c608642
2016-03-30Improve wordingTor Lillqvist
Change-Id: If6d0e38070cd99de903639944ecc8db16c653302
2016-03-30Use const_iterator when possible (svl except svdde)Julien Nabet
Change-Id: Ie19467a020d1839146d5a6324e54ccf223d99dd6 Reviewed-on: https://gerrit.libreoffice.org/23603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30Replace MACRO_PRFIX and MACRO_POSTFIX in eventsupplier.cxxJulien Nabet
Change-Id: Ifd08a3414468e7685f55af66ed05f7a88187fa0e Reviewed-on: https://gerrit.libreoffice.org/23606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30Replace IMPL_FORWARD_LOOP in sfx2/source/bastyp/fltfnc.cxxJulien Nabet
Change-Id: Ic9eda24be82a54c3907ffe6eb749e927db87dee7 Reviewed-on: https://gerrit.libreoffice.org/23605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30tdf#98893 Remove expensive calls to GetCellType + GetValue/... in calcAleksas Pantechovskis
Change-Id: Ie9a16fa1b44d41cc9d10b50c37ba15f3b7e786c8 Reviewed-on: https://gerrit.libreoffice.org/23561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30add TODO comment for a bugMarkus Mohrhard
This bug is the first one that was discovered because it is now much easier to see which parts of the code work on cells, pattern areas and whole columns/rows. Change-Id: I8f22bf421298947d65bfc2fc9c986d85169e6545 Reviewed-on: https://gerrit.libreoffice.org/23636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ief094beebbff2bce9f087853cbda6adeeafe07fc Reviewed-on: https://gerrit.libreoffice.org/23635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30stylistic changes in ScDocument::FillInfoMarkus Mohrhard
Change-Id: I98bb25d414106259a809698941a000d6d0bc35e0 Reviewed-on: https://gerrit.libreoffice.org/23634 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30limit scope of another variable in ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ic53bcaa5e33f221a643de4e854990769b5c04a74 Reviewed-on: https://gerrit.libreoffice.org/23633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30limit the scope of a few variable in ScDocument::FillInfoMarkus Mohrhard
This makes the code at least a little bit easier to read as we can now see much easier when a variable is used to transport state between loops and when it is just a variable local to a loop Change-Id: Ib92ff1596bda35f9892accc820bc3596bafb7d96 Reviewed-on: https://gerrit.libreoffice.org/23632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Iac607e1fe915c8bc90316508c98855a60117d435 Reviewed-on: https://gerrit.libreoffice.org/23631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: If6f898d514dc454a7f1c5448769a95269e9066d7 Reviewed-on: https://gerrit.libreoffice.org/23550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30tdf#98960 fix OpenGL crash by optimized image scalingMarco Cecchetti
using area scale shader - 2 passes impl - sqrt scale factor Change-Id: I973ae0a281735787b045ce8fd5df03f8caa8f189
2016-03-29Replace some defines in sfx2/source/appl/newhelp.cxxJulien Nabet
Change-Id: I82d13a71b59bd9cefc800f592d2b8312b70d1725 Reviewed-on: https://gerrit.libreoffice.org/23604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29Revert "vcl: fix Android build"Korrawit Pruegsanusak
This reverts commit 8058189b53394fe335735cfd04f822f46b1a35b3 because these functions are now removed by dea0abc58c558d3c62e806d06035b1a30420264e Change-Id: I69b19319b645879edec04a47b16f78ab07fc9bcf Reviewed-on: https://gerrit.libreoffice.org/23516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-29framework: cid#1357163 fix the fix d5e4fe23Michael Stahl
The branch was never taken in the old code, and re-acquiring the mutex without releasing it first is pointless. Change-Id: Ic865dccf2c442d2625436e175aef91be59d05325
2016-03-29vcl: misleading copypasta in documentationMichael Stahl
Change-Id: I673940fde7484500cbf30d4a4b760a8bf4448e33
2016-03-29configure: put back lines erroneously deleted by 96c1ae1Michael Stahl
Change-Id: I495d7508cab853717952735a2a0365a915165e51
2016-03-29that should not have become part of the previous commitMarkus Mohrhard
Change-Id: Ia116e5f9fdbd34cd1017ec1f2dabf6e581c4c707
2016-03-29extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ifd39ec5ad7aebac532ea7145274005507a5b177f
2016-03-29tdf#93548 Refactor sal signal to reduce code duplicationAleksas Pantechovskis
Change-Id: Iff331a48fadc23da8b24f9ca3a841000313a03dd Reviewed-on: https://gerrit.libreoffice.org/23477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29Remove obsolete commentStephan Bergmann
The code it commented got removed with 77c52217238b6a1b08b74852aa79163306c688a9 "INTEGRATION: CWS sb83". Change-Id: I709db766806a75823e3436a0b3d5a6eba307ecca
2016-03-29Remove undocumented perftune.ini QuickstartPreloadConfigurationStephan Bergmann
...originally added to OOo in 2005 with 8a9d865b32b760804adf53b0d68fd74785890915 "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I7167c99e28b56c9048de32576e793e2eaa1fc6a6
2016-03-29avmedia: the Module makefile already checks and disables thatMichael Stahl
Change-Id: I4620a0358e06e56684954f208d19bd4350e397a5
2016-03-29cairo: fix malformed conditionals, these should have empty "then" branchMichael Stahl
Change-Id: Idc83582f0b4317a4d272bc5fa8eaf2dc98785fc6
2016-03-29LOK shouldn't reach this code anymoreStephan Bergmann
...after 79b0d4ba2cbc5a35adaa9628cc18eb0f46d01f9c "Don't launch the PipeReaderThread from LOK" Change-Id: I0a8674cc2df738e723f43e372f622dd5a02c5a7f
2016-03-29Bin pointless commentTor Lillqvist
The history of the file can be browsed using the version control system. Change-Id: Ibf087fb476a91bd36d5cafe62def4120ddece1a1
2016-03-29tdf#98859 use ObjectOriented approach for GdiplusArmin Le Grand
Current usage of Gdiplus uses direct procedure calls to e.g. allocate Gdiplus specific objects. This includes the risk to forget to free those objects. Using Gdiplus Objects in scopes avoids that. Change-Id: I48f086d708cce67229edff0983b96e63c19907d7 Reviewed-on: https://gerrit.libreoffice.org/23492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-29Don't launch the PipeReaderThread from LOKStephan Bergmann
ATTENTION: Users of LOK need to ensure somehow that no two processes operate on the same UserInstallation simultanously. Especially the lokdocview widget in gnome-documents is known to be problematic in this regard, cf. the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-March/073839.html> "LibreOfficeKit and the UserInstallation". Change-Id: I7bc2edb281c925e479b8006151d8549441c9e9e8
2016-03-29loplugin:staticmethodsStephan Bergmann
Change-Id: I090c01ef2fc52b8bec74ec78e23f1104877c734f
2016-03-29tdf#96099 fixes trivial typedefs, ::std::vector<OUString>Apachev Ivan
Change-Id: If01819b43c6cf4665e0aca90f9fb2b4363feae69 Reviewed-on: https://gerrit.libreoffice.org/23060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-29tdf#98882 DOCX import: set default para properties on the Standard para styleMiklos Vajna
That's what the DOC import does, and that's the reason e.g. the strange unwanted crop of the as-char anchored picture doesn't happen there. This also needs the "reset all existing style properties back to default" logic to be adapted: the Standard style has to be reset before the default are set, and later it should be left alone, otherwise the defaults are lost. Change-Id: Ie422a0b64b80a826fa4f469145a26283fb32d734 Reviewed-on: https://gerrit.libreoffice.org/23593 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-29Rename OfficeIPCThread to RequestHandlerStephan Bergmann
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
2016-03-29Extract PipeReaderThread from OfficeIPCThread (a misnomer, now)Stephan Bergmann
Change-Id: Ie30cc14bdc772fd898d24a3e3caf41ac9718712f
2016-03-29tdf#95932: PPTX import: Incorrect inheritance of shape styleMatus Uzak
Inheritance Order: 1. Reference Shape's properties, 2. Shape style, 3. Shape properties. You MUST NOT inherit reference shape's style, because it's already part of inherited reference shape's properties. That would overwrite shape properties applied at point 3, at slide layout/master level. Change-Id: Id1ab550295988b0087a67c6819dfe32f84825e4e Reviewed-on: https://gerrit.libreoffice.org/23182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-29cid#1357164 correct CovertyScan possible DIVIDE_BY_ZEROArmin Le Grand
Also covers cid#1357165, exclude possibility that value equals zero at the same place negative values get excluded Change-Id: If3fd6143fb13f0d29f5fba304f9f337f7a7aa74c Reviewed-on: https://gerrit.libreoffice.org/23592 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-29tdf#94449: special text attributes are not removed with paragraph styleOliver Specht
commit 3c0805e1f4f4d14e92c7e655d59c87de5c207e48 introduced removal of all character attributes applied to the complete paragraph if a paragraph style was applied. This should not remove special attributes like index entries, reference marks etc. Change-Id: I6fe92066269da2cf10c871ca319faf6fda91f4be Reviewed-on: https://gerrit.libreoffice.org/23591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-29ScOpenCLTest is not a FiltersTestTor Lillqvist
Remove unneeded derivation and thus the load() function implementation too. Change-Id: If796741198fea141c0d68505893a7f70f048d515
2016-03-29The OpenCL shared library is called libOpenCL.so.1 on LinuxTor Lillqvist
libOpenCL.so is just the symbolic link to it, typically from a development package. (On Fedora, from ocl-icd-devel.) (Sure, libOpenCL.so.1 is also a symbolic link on Fedora, to libOpenCL.so.1.0.0. But anyway, libOpenCL.so.1 is not from a development package, but from ocl-icd.) Change-Id: I18ca2e52e025001f709b1b57e12cd01d5b52d08e
2016-03-29Avoid running out of memory on Windows when OpenCL is availableTor Lillqvist
Call Clear() on the ScDocShellRef (derived from tools::SvRef) members of the ScOpenCLTest object in tearDown(). Otherwise the memory used by the ScDocShellRef objects in each ScOpenCLTest object would be held until when all the ScOpenCLTest objects are destroyed in the end. (CppUnit creates all the ScOpenCLTest objects in advance, then calls the test functions on them, and then destroys them.) The issue was a side-effect of the (otherwise nice) fix for tdf#89267. Change-Id: Ie5c59f2f089386c0abc135136397e1653c975fdc
2016-03-29Simplify codeStephan Bergmann
Change-Id: I793f6ce3297b114ebe79b9937e07291e1b238ab1
2016-03-29The whole block is only relevant for HAVE_FEATURE_OPENGLStephan Bergmann
Change-Id: Iae065ee34c5536843ddba39b72b6fff4836cbf86
2016-03-29vcl: replace boost::shared_array with std::shared_ptrMichael Stahl
The boost::bind here looks totally pointless too. No idea why this uses rtl_allocateMemory, let's keep that. Change-Id: If51ba9837a318f11094ee39225233212a848a955 Reviewed-on: https://gerrit.libreoffice.org/23502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>