summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-12-24Excel im-/export function name mapping for EASTERSUNDAY, tdf#162177 follow-upEike Rathke
Which isn't exactly needed because compiler uses RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML but the mapping is used for css::sheet::XFormulaOpCodeMapper even if that is almost (?) dead in Excel context. Gave warnings like warn: sc:566679:566679:sc/source/filter/oox/formulabase.cxx:1381: OpCodeProviderImpl: :initFuncOpCode - no opcode mapping for function ODF 'ORG.OPENOFFICE.EASTERSUNDAY' <-> OOXML '_xlfn.ORG.OPENOFFICE.EASTERSUNDAY' Change-Id: I0e7a74ef24fd03bd533b486bd11dab1f6287e2c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179262 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2024-12-23crashreporting: more checks of pActiveViewShXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::SetMode(ScInputMode,rtl::OUString%20const%20*,ScEditEngineDefaulter%20*) Change-Id: Ib0a07f4ee8d7da05960eaac14af561a6b624b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179263 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-12-23cid#1607743 Data race conditionCaolán McNamara
Change-Id: Ic7f4744fdb1cf43f6bcf6c66752f37be25c06cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178494 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-23crashreporting: check pActiveViewShXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::UpdateFormulaMode() Change-Id: I87ccb3c07b08ebe0a77b1ebb6a5f4e8c2ea89894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179259 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-12-23Simplify ImpScanMike Kaganski
Change-Id: I8928d3c7f0fc6884a75c05e77908df7f482c9e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179246 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-23crashreportScraper: open links in new tabXisco Fauli
Change-Id: I577b8d9ceff6c1aa74128a14a1e0f8ef57c3fd89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179258 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-23sw: FindSttNodeByType -> FindStartNodeByTypeXisco Fauli
Change-Id: I37dbe6583ef121fbb2439d413eaa6bcad9d07f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179257 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-12-23optimise ScBoundsProvider::GetIndexTowardsNoel Grandin
Especially when laying out rows in sheets with thousands of rows. By pushing the work down to a new GetRowForHeightPixels method, we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans. Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-23pdf: move PDFStructureWriter into own file, rename to COSWriterTomaž Vajngerl
This needs to duplicate some functions from pdfwriter_impl to make this possible. Change-Id: Ie738c9690306d6498c883f034a3fcd6483f24eef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176985 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178762 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-23pdf: change encryption to use new random IV on each encrypt callTomaž Vajngerl
This is how it's supposed to work - not to have same IV all the time we are encoding (that's why the IV is written to the stream). Change-Id: I17a1d98bd5cf6f06b830eaea04822b8793d4e0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178761 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-12-23pdfium: Log error when opening fails (useful for tests)Tomaž Vajngerl
Change-Id: I597d82bb40c73b900c08c8b37fd303e8f5e98eed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179179 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-23crashreporting: check Lower()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwLayoutFrame::AdjustColumns(SwFormatCol%20const%20*,bool) Change-Id: I690a6358c8964f5511aedf3246384649cf004d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179234 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-23crashreporting: check Lower()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwRowFrame::ShouldRowKeepWithNext(bool) Change-Id: I49ac8312e0288471780c405bb2cd7eb66163ab43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179233 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-23i18npool: drop macroXisco Fauli
Change-Id: I517ab7ba57c5f91282b6271e64113d868191dd5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179225 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-23Simplify a bitMike Kaganski
The previous code made sure that cNonIntntlDecSep is always equal to IntntlDecSep (in the code handling bOnlyIntntl). Frop the redundancy, and make the variable names simpler. Change-Id: I31c994cd49bdbf007e110f593297acf112cc420b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179198 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-23Fix a copypastaMike Kaganski
From commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d (resolved rhbz#919020 Basic CDbl() and CSng() scan localized number, 2013-03-19) Change-Id: I871d7fb06ccb5d15723f7acfb57701890607055f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179197 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-23tdf#164383 - sw a11y fix unnecessary "Avoid simulated captions" warningBalazs Varga
for caption frame. We should not have "Avoid simulated captions" warning about correct captions. Change-Id: I57fe53c5f9e1aa2affe0aec6520d1d6eed5d6990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178927 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-12-23tdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selectionMike Kaganski
Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-23Simplify a bitMike Kaganski
Change-Id: Ic02ee03a800e3e92fafd73efed5aa0fd803f454b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179195 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-22sc: move these to slowcheckXisco Fauli
so Jenkins will tests them on all platforms Change-Id: Idb17dc34b4b1f26067ed160037c7d81b800ed8f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178801 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-22Fix typoAndrea Gelmini
Change-Id: I0d22de1cc8e5a9817770c9cee9abbc3833b3b973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178938 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-12-22Fix typoAndrea Gelmini
Change-Id: I80788a1abf4c8c63821dd3ad3cc5b213500a9ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-12-22Fix typoAndrea Gelmini
Change-Id: I3ded88c7080b8c009937223bc9845367872dd25f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178939 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-12-22tdf#132111: don't claim a number format for multiselection / no set formatMike Kaganski
The "not set" state for RES_BOXATR_FORMAT is handled explicitly in many places, e.g., in SwTableBox::HasNumContent. This allows to detect number entered into cells without explicit format. Thus, this state is not the same as "text" number format, and it must not be selected in the Number Format dialog. The same is for multiselection with different formats. Change-Id: I4f4aa66a2cbfd1bf2efa8b99a6e7a2cf9c119712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179177 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: If3ea044a9f63e8fdbf920a40e8309f247a23c491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177153 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ib84ec9730aca0b528a61f06c1ac5a4ace7ae77fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177134 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Iae87151a8d16052864f587edfd97fe3eb2d8ba24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177087 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ie7e8a0e2f489126974b75c61e3b53d0014d01dcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177133 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ia0f52455804aadb8b8dff68a2665a409c9173b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177182 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I34fcfda19bc9ff35b49faf8892ab14c0f9808943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177184 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I32c8a4c8dd56ef781f40db1d3ca66823dd9b995f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177185 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-22tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I051f33ac28bdc1e3922d2d390ff3234204b80688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177186 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-12-22pdf: fix saving external PDF with form fields (CONTINUED)Tomaž Vajngerl
This updates the test with comments and adds options at test start to make the test more robust (without those it can fail depending on the execution order of other tests) Change-Id: Ia7ea7e8810cc63b754d2d7f1ff1757839026ed3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178760 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-12-22cid#1636855 Out-of-bounds readCaolán McNamara
Change-Id: Id2573d678b0059c1929d1a896cbfdf863676f945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179142 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-22reduce the amount of castingCaolán McNamara
Change-Id: I70f5607d8d5ccdadf1f5c69c846c93821f7681df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179141 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22cid#1636857 Dereference before null checkCaolán McNamara
Change-Id: Ib4411323cb5b1e1a44c56e890b6c0c1266d93eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179140 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22cid#1636856 silence Explicit null dereferencedCaolán McNamara
and cid#1636859 Explicit null dereferenced Change-Id: I6e618bebd0f61a1e796b367343bb98e7a01d29b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22cid#1529286 silence Explicit null dereferencedCaolán McNamara
Change-Id: I03909c8ed7e9f2bf410412b02790aee0fbca6d58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179138 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22cid#1636858 Dereference before null checkCaolán McNamara
Change-Id: I03aa87d1a265761ac2f781e33b6136a4c38cbb31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22Resolves: tdf#161832 select row before update that depends on selectionCaolán McNamara
Change-Id: Ic1d291a68009749ce1464de60a78baf3047ddcc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179092 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-22crashreporting: disable load from template during print previewCaolán McNamara
Change-Id: Ifc60a01f0e5e1f6cdab3680e69202f98471c2a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-22cui: Resave namedialog.ui with glade 3.40Michael Weghorn
This dialog can e.g. be triggered via "Tools" -> "Options" -> "Appearance", then clicking the "New" button. Change-Id: I59b2195274ef1ff7f56057dc439b03bb0610d106 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179111 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-22tdf#130857 qt weld: Support "Name Dialog"Michael Weghorn
Declare support for the name dialog that e.g. gets used in "Tools" -> "Options" -> "Appearance" when clicking the "New" button. This means that native Qt widgets are used for that dialog now when using the qt5 or qt6 VCL plugin and starting LO with environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set. Change-Id: Idaa3190d45efba87a74ef80a2999f3c6be7fa90d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179110 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-22tdf#130857 qt weld: Implement QtInstanceWidget::queue_resizeMichael Weghorn
Call QWidget::adjustSize [1]. [1] https://doc.qt.io/qt-6/qwidget.html#adjustSize Change-Id: Ic191d65b9c7a3aee5e0e9c945773d7732719d4e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179099 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-22tdf#130857 qt weld: Introduce QtInstancePopoverMichael Weghorn
When encountering a "GtkPopover" object in a .ui file, create a QWidget with window flags Qt::Popup and set a layout, as weld::Popover is a weld::Container subclass. Add new QtInstancePopover that QtInstanceBuilder::weld_popover creates. For now, methods in that class simply trigger an assert; actual logic still needs to be implemented. Change-Id: I9a0dfefd9fb79d24fe40dd5efe13ef0c3ab9b7fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179098 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-22tdf#130857 qt weld: Implement QtInstanceWidget::get_pixel_sizeMichael Weghorn
Change-Id: I082430e653f5634ecdcc101b370f531b2c0e25cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179097 Tested-by: Jenkins Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de>
2024-12-22tdf#130857 qt weld: Implement {s,g}etters for scroll area min/max/val/stepMichael Weghorn
Change-Id: I698e98ac16d8e1f2cd1e01a50570bd9012c94952 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179095 Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-21Simplify abstract dialog impls using vcl::AbstractDialogImpl* in scMike Kaganski
Change-Id: Iff9ac377a5cfa259c5911632ad16d2b1e3269868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178986 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-21Simplify abstract dialog impls using vcl::AbstractDialogImpl* in sdMike Kaganski
Change-Id: I93f40aef003aa52b4eef173f8f481c99fe4c0489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-21Simplify abstract dialog impls using vcl::AbstractDialogImpl* in swMike Kaganski
Change-Id: Ie2816ab4f4ad5f4d703d4f6669ae16a9fa60933e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178984 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>