summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-01tdf#134054 Qt5 really scale the toolbox buttonJan-Marek Glogowski
I missed that code in the HiDPI patch. Instead of some fixed 25px size, use the real content size and ask the QStyle for the real size. Change-Id: I227190baab2c1716aa40ef6d16d55dbded0830cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97538 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01tdf#130991 Scale the drop-down arrow size-requestJan-Marek Glogowski
When requesting the size of the drop-down arrow button, the arrow rect must be scaled, like all other native size requests. Change-Id: Ic0ccd96e812527c880868d385484655526ebb09b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97536 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-01tdf#132172 Qt5 just handle visible widget's focusJan-Marek Glogowski
I investigated the state of isWindow() and the SalFrameToTop flags for the detached find toolbar (tdf#126607) and the Impress presentation and the tabbed "page size" drop-down and all had the same status (isWin: 1, flags: 12). Than I had a look at the gtk3 implementation, which just handles focus requests, if the widget is already mapped (gtk_widget_get_mapped). So I also dumped the visibility as the nearest equivalent in Qt to the X11 mapped state, and that was different. In the end Qt now also just handles the focus for already visible widgets, like gtk3, which works for all the cases I tested (incl. tdf#125517). And omiting either activateWindow or setFocus breaks some cases... and I still don't understand the GrabFocusOnly flag, which is just handled in the X11 backends at all... Note: this doesn't happen with 7.0+, because the weld'ed version of that control (commit 3afc718eddcd81232392d46fccc24b8ec626c8df "rework PageSizePopup to be a PopupWindowController") doesn't expose this bug (and also doesn't support mouse-over highlight). Change-Id: Id085732f6a52bbc69ed47fbd3d57454756a03121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97549 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01update Skia to chrome/m85 snapshotLuboš Luňák
Change-Id: I3af3517c9c213e0db8365aecd0a008d817ca4dcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97592 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: ioStephan Bergmann
Change-Id: I150aa3666a9e1acf5fba445b9a709ccd9d8c7e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97593 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Fix typosAndrea Gelmini
Change-Id: I4f1c0d90fcb7726ceadd72c9cb9f96a57cade67a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97602 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: idlcStephan Bergmann
Change-Id: Id0716adf2b16839c1d940bc1d187bcc107ed79ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nutilStephan Bergmann
Change-Id: I2264559759133cb6617e8a7db28a26749bb59191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97590 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Related: tdf#131175 OOXML chart: insert hatch definition into the right tableMiklos Vajna
Both the chart and the containing document has one, but the intention is to insert this into the chart one. This is needed, but not enough to render the right hatch for data labels. Change-Id: I485d84e2ae33728963b648c05e730d418567fc0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97569 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-01Related: tdf#134360 table row/height widgets can get stuck insensitiveCaolán McNamara
Change-Id: I1be53f33f60c510757c67f1da8f863539ecbffdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97547 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nlangtagStephan Bergmann
Change-Id: I06102a8b7fe8cffaf1fe72b32c997c6225d37d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01tdf#133070 DOCX import: fix shape height relative to bottom page marginRegényi Balázs
using UNO API RelativeHeightRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Szabolcs Tóth Change-Id: I31db99fac5ad24971fa427671198b47906e9c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95451 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: hwpfilterStephan Bergmann
Change-Id: I6f5a81cf83d15b9c8a21bf0581c009bdfe03f4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97564 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: frameworkStephan Bergmann
Change-Id: I71eaaa7cbc1c38e541291d48eb5f05157fd4c8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: filterStephan Bergmann
Change-Id: I345f4677b0ac32f8373fb13c6db07041247e3982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01tdf#134404: sw: Add unittestXisco Fauli
Change-Id: I81e46e06ad7964e52b45ce3433a25758cc7d19fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97534 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: fpickerStephan Bergmann
Change-Id: Iea0c39a036c9e890ee3afee143923386d2ca775c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97562 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Remove some unused includesMiklos Vajna
Change-Id: I44c9ad2511d484e3c7fb1c33f25fcb343eabd232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: emfioStephan Bergmann
Change-Id: Id7ceb329a6fa6f2af15bf4599ef97dcbd44fa64d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97559 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: editengStephan Bergmann
Change-Id: Ic5294dc53b1a7b6c654619cde8ef5133c222ae1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97558 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: drawinglayerStephan Bergmann
Change-Id: If00914a6eda240143fbde57215e015a36d588c9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97557 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01loplugin:constantparamNoel Grandin
Change-Id: Ie9d4761747f7e97f63f34394b5a8b9f0bb287a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01loplugin:singlevalfieldsNoel Grandin
Change-Id: I8b0ae3ae7e742bf5a5078681a51e8a81d5110a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01tdf#132454 some more improvementsNoel Grandin
Defer moving around the vector by tagging the last bit in the pointer. This takes the undo operation from 10s to 8s on my machine. Also re-organise the fields a little to improve packing. Also add some design notes Change-Id: I38fa9156705c00bb9f64e2fc59ea862eba522942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: extensionsStephan Bergmann
Change-Id: Ifce7b61cc5bd0901c7ee43712dc236f5aec47edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97560 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cppuStephan Bergmann
Change-Id: Iac1bd5cb1ff1a1786471b2d8b8a3c500a2e15c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01avoid costly to-monochrome-bitmap conversion with Skia (tdf#134365)Luboš Luňák
The BitmapEx 1bpp monochrome bitmap mask constructor forces the mask to be 1bpp, which is done in software by BitmapMonochromeFilter. Which with Vulkan leads to fetching all the data from the GPU, usually only to be converted and then pushed back to the GPU. Similarly to MACOSX and iOS, just use AlphaMask, which is just better (8bit is easier to handle and in Skia's case it's also optimized to avoid fetching the data if possible). Change-Id: I5770c2b0c298c1534b7ff56cc905d2d668d3a8df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97525 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01optimize Bitmap::Erase() for Skia by delaying the erase (tdf#134363)Luboš Luňák
Tdf#134363 causes OutputDevice::DrawTransformBitmapExDirect() to create a huge 1bpp bitmap as mask, and Skia code then tries to convert all the bits to a format Skia would understand. Which is wasteful, as SkShader with the color given will do the same task much more efficiently. Change-Id: If0bba16f56fed9c3720be801b25a1e703054ed8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97488 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01remove code duplication for BitmapReadAccess pixel functionsLuboš Luňák
Change-Id: Ib243fea4276cfb86b4fdff8d0c84cea7c4523d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97487 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01avoid Bitmap::Erase() duplicating codeLuboš Luňák
Change-Id: I68d388175355fe1fcf5acc300730e8473fa559fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97486 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01do not use scanline padding for computing vcl bitmap checksumLuboš Luňák
This idea of checksums is still kind of broken (different RGB order or different scaling algorithm make the checksum different between different VCL backends). But at least don't include undefined garbage. Change-Id: Ia03bb960c50d3da51dad9b37de7a4f709d8ee206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97484 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01call InvalidateChecksum() in SkiaSalBitmap()Luboš Luňák
Change-Id: I52b6d9985639a6a81bf9c53bd35487b5c4992988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97485 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01change n777345.docx to check bitmap content instead of checksumLuboš Luňák
Bitmap checksums are unreliable, they often depend on underlying implementation and whatnot. Change-Id: Ifc13285d6eb7d6d050a1ec26b270e0533eaae8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: desktopStephan Bergmann
Change-Id: I1fadfc0fb62df56a890c6cd789435135671349a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: dbaccessStephan Bergmann
Change-Id: I49932a9d89d2933bebd313d3f1f64af84f0e52cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97552 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cuiStephan Bergmann
Change-Id: I403229592145d6e126f5a3f4c8b788d2deb70a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cpputoolsStephan Bergmann
Change-Id: I301e5008316fcc714b7ce955f8c262a8cbed3f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Resolves: tdf#85551 OFFSET() NewWidth and NewHeight must be >0 if givenEike Rathke
This also makes it necessary to adjust a test that reused the bug document for a different scenario but checked the result. Change-Id: I80136747445d5029aa5c894270448f002c567e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97553 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-01tdf#134357 we can reduce the min toolbar sidebar widthCaolán McNamara
since, commit 754bea8c6a17889f9d4d23bf98847b6b67253220 Date: Wed Apr 29 15:06:42 2020 +0100 remove the padding around the dropdown button of GtkMenuToolButtons the GtkMenuToolButton aren't as wide anymore so we don't need a min of 5 GtkToolButtons widths for tdf#130197, now the max of either 4 GtkToolButtons or that of 1 GtkToolButtons + 2 GtkMenuToolButton is sufficient Change-Id: I7296805b4b3c0d86ce3d08cadc8c2659104af619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97544 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30tdf#134043 DOCX import: new unit tests: ComboBox to DropDownSerge Krot
Change-Id: I513933b508ca531e17271a3cc821a6aef2244868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97531 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30Add Shape mbIsForeground flag and getters and setters for itSarper Akdemir
mbIsForeground is a flag that is set false if a shape is known to not belong to the foreground. It is set to false while shapes are being imported and the shape belongs to the master slide or is a group shape, right now. Change-Id: Id9738fc943f32a1e1a6e1888d179e69fd60bd022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95968 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30adding XShapeToShapeMapSharedPtr getter to ShapeManagerSarper Akdemir
Refactoring XShapeHash in layermanager as XShapeToShapeMap and XShapeHash in targetpropertiescreator as XShapeToNamedValuesMap. This refactoring describes what the types are more clearly and stops violating one define rule in the desired implementation. And adding getter getXShapeToShapeMap to ShapeManager to enable Animation::start() to access Shapes and XShapes of the current slide. Change-Id: I78d510ae43888fd6cf0f037e224b24f91b263b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95967 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: connectivityStephan Bergmann
Change-Id: I959a520f240faab062ecd4f6e2658d9fc9ce709f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97545 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: comphelperStephan Bergmann
Change-Id: I222ea673a44528cb04847a912cd8da971bb1be3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97542 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: configmgrStephan Bergmann
Change-Id: I85650691056c24d8c2e37ddce2c50a27193b4c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: chart2Stephan Bergmann
Change-Id: If4e61fdcf1749b2900512ae788422c435ae6af0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97541 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30tdf#134277 sw table: fix lagging shape at page breakBakos Attila
Shapes anchored to characters in table cells didn't follow their cells at page break, resulting lonely shapes at the end of the previous page. Co-authored-by: Attila Bánhegyi (NISZ) Change-Id: I2149ef58696a8f5dc6f41959060d2d57f938d025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30Attempt to fix three more cases of just "hoping" that things work rightTor Lillqvist
Change-Id: I81c87740b36beeb1288649712f6415cb6074348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97416 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97473 Tested-by: Jenkins
2020-06-30Resolves: tdf#131424 separator in TableRef column specifier is validEike Rathke
Even only a separator or any operator single character. Change-Id: I102dd7fd49c1a6a7f1d8c39f4a6139a51dbebe51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-06-30Resolves tdf#130436: Crash on redaction without DrawMuhammet Kara
Change-Id: Iaa418e9ad5c6e9ba1892cbb428a8a381f52c4246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97458 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-01 07:19:54 +0000