summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-10Related: tdf#113205, revert add icons to extensions/source/update/uiCaolán McNamara
the packaging of these is fixed now This reverts commit 4f89c98d715592be42d8d378786d79eb27acadcb. Change-Id: Idc4a3dd3485f7eb5f9009566e431c3e2a7944cb5 Reviewed-on: https://gerrit.libreoffice.org/66077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: ofz#12462 fix build failureCaolán McNamara
Change-Id: I6719a601b5f9e5b727406667f36a8bef93eb2adc Reviewed-on: https://gerrit.libreoffice.org/66081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10make format->page dialog asyncNoel Grandin
Change-Id: Ie2c63e2bac176002bc6616578aef2d4c763245c7 Reviewed-on: https://gerrit.libreoffice.org/66074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10make table-of-contents dialog asyncNoel Grandin
Change-Id: I839eaa820952ff39818b5ed9bd06a44eec3f39d3 Reviewed-on: https://gerrit.libreoffice.org/66069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10Resolves: tdf#122611 crash in empty template listCaolán McNamara
Change-Id: Ifab72f21e92382a3072a35447c6387e1fd405e15 Reviewed-on: https://gerrit.libreoffice.org/66070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Replace uses of rtl/instance.hxx with plain local static vars in basegfxStephan Bergmann
Change-Id: I13fbecf59e99547bbe85124dc9aa2777eef015d7 Reviewed-on: https://gerrit.libreoffice.org/66072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10tdf#121978 use round again for Calc function SECOND.Winfried Donkers
Round was inadvertedly replaced by floor in commit 273b3e10eab70ebc084cb62568bd699fddfb376e. Change-Id: Ie0824e228c62509952a11b866638482a409c851d Reviewed-on: https://gerrit.libreoffice.org/65579 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-10tdf#122056: catch DisposedException to avoid crash w/ screen readerKatarina Behrens
The repro scenario is closing a slideshow with screen reader on. Some object are already disposed by the time [full-screen] win with presentation closes Change-Id: I7e2ae7a5b694daaf7355ef93d87a998c9f2e345a Reviewed-on: https://gerrit.libreoffice.org/65931 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-10tdf#120877: make menu items checkable as neededKatarina Behrens
Change-Id: I5a07526aa5187313977d6f7c244541be83b5edbc Reviewed-on: https://gerrit.libreoffice.org/65930 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-10Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Does not compile as such Change-Id: I353cde4e67424cb5b56071adc897c28462242985 Reviewed-on: https://gerrit.libreoffice.org/66086 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-10Related: tdf#44076 do not leave cast to int to undefined behaviourEike Rathke
... if the double is an out-of-int-range value. Also catch domain and pole and range errors. Move this to it's own sc::power() function that can be reused for example by ScMatrix::PowOp() to be congruent. Change-Id: I88331e02e6cdfb5e1dcbf81622d3fc7ce4510478 Reviewed-on: https://gerrit.libreoffice.org/65986 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-10pass ScTokenArray around by unique_ptrNoel Grandin
Change-Id: I611554b1c4cbc506dbfc32748e9f14c9e8eb5156 Reviewed-on: https://gerrit.libreoffice.org/66022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10VirtualDevice must be a complete type here (Windows --disable-pch)Stephan Bergmann
...when instantiating implicitly defined special member functions of SFX2_DLLPUBLIC SvxCharView Change-Id: I6eae49bc33811122c3d276440698721e08391ac2 Reviewed-on: https://gerrit.libreoffice.org/66062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10Resolves: tdf#122356 on row-activate click ok buttonCaolán McNamara
instead of proceeding directy to the ok response. Because there is an additional handler installed in the okbutton to do extra stuff that is needed to make this work Change-Id: I9646ea6978533084c6c9c48b03806e46eaa49c33 Reviewed-on: https://gerrit.libreoffice.org/66046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: tdf#122598 avoid crash on macro recording endCaolán McNamara
Change-Id: Ie9f9fc8b4a4a7852a5da37c7d190ca020391012e Reviewed-on: https://gerrit.libreoffice.org/66028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: move extension 'source' resources to 'res'Caolán McNamara
so they get picked up by the usual postprocess packaging machinery Change-Id: Ia677f74229a86fdb72da294d42335341fb773ab9 Reviewed-on: https://gerrit.libreoffice.org/66054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10tdf#42949 Fix IWYU warnings in sc/source/filter/xml/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I39b7da64f92520f1fb583b2a2f038955e5de2f24 Reviewed-on: https://gerrit.libreoffice.org/65690 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-10oox smartart, org chart: fix vertical order of assistant nodesMiklos Vajna
It seems the manager -> assistant -> employees ordering is not part of the file format. The order is stored twice in the file: the hierRoot algorithm has 3 layout nodes as a children, and also the data model has an order of the presentation nodes: both describe that employees go before assistant nodes. In contrast to that, PowerPoint orders XML_asst nodes before XML_node ones, so teach the hierRoot algorithm about this. This requires tracking the data model node type for each in-diagram drawingML shape, so that layout can determine if a hierRoot algorithm children has an assistant node or not. Change-Id: Ib81f3666fb092ed3b036d830f69ba7e1b94f8331 Reviewed-on: https://gerrit.libreoffice.org/66048 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-10tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Doğa Deniz Arıcı
Change-Id: Ieb5c1e13ae647b49fd563f1759d744bd5f008ce1 Reviewed-on: https://gerrit.libreoffice.org/65758 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in SwTextNodeNoel Grandin
Change-Id: I3f263a617e0ca48cbbe894a061910f1af767bb11 Reviewed-on: https://gerrit.libreoffice.org/66037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in swNoel Grandin
Change-Id: I13ab934932a24f49a0e37257d397de7ed88f66bf Reviewed-on: https://gerrit.libreoffice.org/66034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10fix leak in SwDrawFrameFormat::GetDescriptionNoel Grandin
and simplify. ever since original code was committed in commit da12dc5adf9086d418ff0d09abee23fdd8f68cda Date: Wed Sep 8 14:20:23 2004 +0000 INTEGRATION: CWS swundo03 (1.48.34); FILE MERGED Change-Id: I9aae40eade34051219f1fe838b373e0f3317d2c6 Reviewed-on: https://gerrit.libreoffice.org/66026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10Revert "tdf#42949 Fix IWYU warnings in include/rtl/*"Miklos Vajna
This partilally reverts commit 55ca35ab99fb1164cb2095384ed0937a533d9d3c, the removal of <utility> was not correct, std::move() still requires it. Change-Id: I1f905e332874b0aa72f537e37251f822258577d6 Reviewed-on: https://gerrit.libreoffice.org/66033 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10o3tl::string_view -> std::string_view (in configmgr)Stephan Bergmann
Change-Id: I64131f59ce859a252baa9c84291d262bcb04fffd Reviewed-on: https://gerrit.libreoffice.org/66012 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10use unique_ptr in SwCacheNoel Grandin
Change-Id: I2b961380dcb5eb26ce517f7b56e5c32f5e6429e4 Reviewed-on: https://gerrit.libreoffice.org/66011 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in ScRangeUtil::IsAbsTabAreaNoel Grandin
Change-Id: I3a5f88eef1e7a8241921f2fed15a1ebc2c4c3445 Reviewed-on: https://gerrit.libreoffice.org/66006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10Removed executable permission on source filesAndrea Gelmini
Change-Id: I1853e7a82078c9bc7149098bf9acc0ddf65109c8 Reviewed-on: https://gerrit.libreoffice.org/66040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-10Fix typoAndrea Gelmini
Change-Id: I39bec0dffbd1f89a49484eff335fdf66b78f1ec5 Reviewed-on: https://gerrit.libreoffice.org/66059 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-10sc: Drop empty reordermap.cxxTakeshi Abe
Change-Id: I6d3183cf281363538c603d126660064a205cda5b Reviewed-on: https://gerrit.libreoffice.org/66058 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-09EmptyTuple is unusedStephan Bergmann
...since b3c3e116ff0eb9b550b73d3901395c042e31d192 "unusedcode.easy: Removed unused code" Change-Id: I472af471c82676b226685bf67ee90857b6607c5e Reviewed-on: https://gerrit.libreoffice.org/66045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-09tdf#122595 Capitalize item in list Order in Print dialogueRoman Kuznetsov
Change-Id: I395735c60eaf33b58781abe5d7e1c7b4793cfccf Reviewed-on: https://gerrit.libreoffice.org/66027 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-01-09tdf#81750 new unit test: no duplication of field contentSerge Krot
Change-Id: I53eeca0dfad9176935a70b98a19b2ce044969031 Reviewed-on: https://gerrit.libreoffice.org/66004 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-09sw: DOCX: recognize TOC title during importSerge Krot
Change-Id: Ifa4fb59858d61580f76e3d104aa4caa6b5902d1b Reviewed-on: https://gerrit.libreoffice.org/64735 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-09Related: tdf#122527 gtk < 3.20 and gtk_image_new_from_surfaceCaolán McNamara
seems to be a problem Change-Id: I2aac780a44ce392372af9f688cde594d67fea3df Reviewed-on: https://gerrit.libreoffice.org/66013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Related: tdf#122598 macro dialog from record macro has no parentCaolán McNamara
Change-Id: I4ef2bca2ada4accefcf9a5314ad60c6177d1ae19 Reviewed-on: https://gerrit.libreoffice.org/66030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122449 crash after dismissing edit index entry dialogCaolán McNamara
Change-Id: I109833e175fce96c12877fefb4b093e518782ce8 Reviewed-on: https://gerrit.libreoffice.org/66038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122353 silence useless selection-changed event attemptsCaolán McNamara
Change-Id: Ie84fb12e6561d93832159779d233102a34b1c78c Reviewed-on: https://gerrit.libreoffice.org/66042 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09tdf#122345 filter/ww8 export: no fake section at end of documentJustin Luth
If Writer has a section that is ending, then the part after that would need to be another section for MS formats. However, if the section ends at the end of the document, there is no need to start a new section. This is particularly important for exporting RTF (preventing accumulating sections/paragraphs), but it also affects docx and doc (without noticable benefit or harm, but now instead of "fake" section properties it will end with the properties of the real section - which can only be a good thing, right?) This is one step in the right direction for resolving the comment //0xffffffff, what ... is going on with that!, fixme most terribly reinterpret_cast<SwSectionFormat*>(sal_IntPtr(-1)) Change-Id: Ie0641eb78c11103b33e3d849fe0b7935476a6505 Reviewed-on: https://gerrit.libreoffice.org/65974 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-09tdf#122559 EMF+ Add transparency support for drawing linesBartosz Kosiorek
Change-Id: I62081f33eb04e70742d61418fa336f184f0f359b Reviewed-on: https://gerrit.libreoffice.org/65996 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-01-09Resolves: tdf#122348 make return in spinbutton signal value changeCaolán McNamara
before going on to close the dialog afterwards Change-Id: I9764512a944e52b0d2bff2d11c8cf74c057e2623 Reviewed-on: https://gerrit.libreoffice.org/66024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: crash in double-split when first timeout hadn't expired yetCaolán McNamara
Change-Id: Ieba97589a3794cf5ed95839e20cc4028cfedae3a Reviewed-on: https://gerrit.libreoffice.org/66018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122597 chart dialog should be modalCaolán McNamara
Change-Id: I66881168fe2c6f3d033f2037e3d1b884bb74bc1a Reviewed-on: https://gerrit.libreoffice.org/66015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Related: tdf#122308 missing parent for losing signature warning dialogCaolán McNamara
Change-Id: I3132550cc5549b61d13cd420876cf007bc80d39b Reviewed-on: https://gerrit.libreoffice.org/66007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09update uitest debugging instructions to account for gtk3 backend issueNoel Grandin
e.g. when debugging UITest_writer_tests2 it gets stuck when the uitest invokes dialogs Change-Id: I8276a8d7e885be5f47309beeec1f4c3c9d12ee32 Reviewed-on: https://gerrit.libreoffice.org/66002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-09use unique_ptr in ScViewOptions::CreateGridItemNoel Grandin
Change-Id: I350e606b14a5a7f269fecca1d176f40c4343c344 Reviewed-on: https://gerrit.libreoffice.org/66005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-09Resolves: tdf#122467 drop down field name is too narrowCaolán McNamara
ellipise only when we have to Change-Id: I79820dc84fc9ac0a755700c70bca9edbb14cf371 Reviewed-on: https://gerrit.libreoffice.org/66000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09tdf#122273 modal dialog on modeless dialog needs special handlingCaolán McNamara
Change-Id: Idb5111b3f795f55c4b5644b5bcc6145106ff1392 Reviewed-on: https://gerrit.libreoffice.org/65583 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09use unique_ptr in SwContentNode::CreateOLENodesArrayNoel Grandin
Change-Id: I4ff33dbdc4d87fd00e4a2b995fff1238c7e2a679 Reviewed-on: https://gerrit.libreoffice.org/65995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-09tdf#107792 vcl/win: replace ScopedHDC with type aliasDmitriy Shilin
Change-Id: I2d12ebc2a7e353ce685ec5132b0a65b393c36212 Reviewed-on: https://gerrit.libreoffice.org/65962 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-09use unique_ptr in pGlobalOLEExcludeListNoel Grandin
Change-Id: Ib52e594b469818a0567c9c6b5cd460375d997abc Reviewed-on: https://gerrit.libreoffice.org/65994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>