summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-24tdf#127411 improve sizing of status items in the status barNoel Grandin
Change-Id: I6ea3fbb893d0141010ee1abd1720d6cdad97b528 Reviewed-on: https://gerrit.libreoffice.org/80440 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24Resolves: ofz#18414 drop apo anchor if it will be deletedCaolán McNamara
Change-Id: Ic9dc053582055cae717df6244873cee14f6e44c6 Reviewed-on: https://gerrit.libreoffice.org/81433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-24Resolves tdf#128227 - Rename "Text Frame" to "FrameHeiko Tietze
Change-Id: I2158152acb64f458020e1375a8b93162117d11fb Reviewed-on: https://gerrit.libreoffice.org/81434 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-24jsdialogs: send associated uno commands for comboboxesSzymon Kłos
Change-Id: I170cad78b8c014e8ceab197b0ded03adc32940b1 Reviewed-on: https://gerrit.libreoffice.org/81431 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-24Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - UBound/LBound functions return a 'Long', help says 'Integer' Verified on Windows, GNU/Linux and MAC OS: Typename(Ubound(array)) and Typename(Lbound(array)) equal "Long" Inherited from aOO Change-Id: I389c2d70c10e374ffe674dd8ef40d787d55389cd Reviewed-on: https://gerrit.libreoffice.org/81416 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-24Only define ShutdownIcon::getShortcutName for _WIN32Stephan Bergmann
...where sfx2/Library_sfx.mk only defines ENABLE_QUICKSTART_APPLET for WNT and MACOSX anyway, and compiling ShutdownIcon::getShortcutName on any other platform would have lead to a non-void function without a return statement Change-Id: I78726fb50ba58571b5397e83a0c1b44f808b2d1e Reviewed-on: https://gerrit.libreoffice.org/81430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24loplugin:classmemaccess (clang-cl)Stephan Bergmann
Change-Id: I4a403babbd24e7145aca4486230ae5b14b9eb581 Reviewed-on: https://gerrit.libreoffice.org/81428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24This is fixed now on Clang trunkStephan Bergmann
...since <https://github.com/llvm/llvm-project/commit/ dc3957ec215dd17b8d293461f18696566637a6cd> "Include leading attributes in DeclStmt's SourceRange" Change-Id: I21859dfdcb454a9dd4444ce299548bf75043b1ab Reviewed-on: https://gerrit.libreoffice.org/81424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24tdf#115967: Revert "sw: Use primitive renderer for graphics"Xisco Fauli
This reverts commit 302af8c2da58719844d22483b65a9fe5b3674684 I would like to revert it until a better solution is proposed due to the number of duplicates already reported After the commit, Libo exports LTR formulas in RTL documents to PDF as RTL formulas it also introduced other problems like tdf#112513 and tdf#117560 Unittest added Change-Id: I097fb5801eb728bd258ae96bd981c6725e7aa06a Reviewed-on: https://gerrit.libreoffice.org/81262 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-24sc: rowcol: tdf#50916 convert documen*Noel Grandin
Change-Id: I101ff537181058500d240c44114bfefedc03aee4 Reviewed-on: https://gerrit.libreoffice.org/81429 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24Update git submodulesMattia Rizzolo
* Update dictionaries from branch 'master' - flake8 fixes to the dictionary-to-thesaurus script tested to work with both python3 and 2.7. Change-Id: I52fe00e1f33e605010cd99885c1a41396440e49d Signed-off-by: Mattia Rizzolo <mattia@mapreri.org> Reviewed-on: https://gerrit.libreoffice.org/81411 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-24external/glm: Avoid -std=c++2a -Werror,-Wdeprecated-volatileStephan Bergmann
...as seen with recent Clang 10 trunk clang-cl: > In file included from vcl/source/gdi/salgdilayout.cxx:24: > In file included from vcl/inc\openglgdiimpl.hxx:31: > In file included from vcl/inc/opengl/RenderList.hxx:16: > In file included from workdir/UnpackedTarball/glm\glm/glm.hpp:98: > In file included from workdir/UnpackedTarball/glm\glm/./core/type.hpp:32: > In file included from workdir/UnpackedTarball/glm\glm/core/type_half.hpp:116: > workdir/UnpackedTarball/glm\glm/core/type_half.inl(43,6): error: compound assignment to object of volatile-qualified type 'volatile float' is deprecated [-Werror,-Wdeprecated-volatile] > f *= f; // this will overflow before > ^ Change-Id: I97fdfc0650344db1401cdce126f6755df00c5a0e Reviewed-on: https://gerrit.libreoffice.org/81427 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24tdf#128077 crash with calc dialogs and multiple windowsNoel Grandin
regression from commit bf359d01ac8b1e0292e8a92c38e58c03e6c17d8b add a Dialog::runAsync for the non-controller case we end up destroying the dialog controller while the controller is in it's own method, so keep it alive for the duration. Change-Id: I0f26b4d40351ad62378f58c560f1a6d69d57a88e Reviewed-on: https://gerrit.libreoffice.org/81425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24readlicense_oo: update requirementsIlmari Lauhakangas
Linux requirements according to what is available in CentOS 7. Matches https://www.libreoffice.org/get-help/system-requirements Change-Id: I91e6141198f441e01f976b58a3adeed3cd80abdd Reviewed-on: https://gerrit.libreoffice.org/81339 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-24no-op in SalBitmap::ConvertToGreyscale() is also a successLuboš Luňák
Change-Id: I6bf3378c89c630aee0a890ac2807a31ea040cd52 Reviewed-on: https://gerrit.libreoffice.org/81374 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-24sw UNO API: remove unused IsLayoutInCell propertyMiklos Vajna
This was added just for the DOCX import in commit c3c80b6b63e998fd3117b5039e65a2ee9df90954 (tdf#115094 Part II: OOXML Feature: Add layoutInCell to Doc model, 2018-11-14), but was always undocumented. Additionally, this is no longer necessary, the DOCX import doesn't set this property anymore. So better remove it instead of documenting it. Change-Id: I4ddb2958dcfa836bf637904c0c4b60012cbc7a28 Reviewed-on: https://gerrit.libreoffice.org/81426 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-24lok: valueset: dump as property tree the selected itemHenry Castro
The client side requires the data of the selected item to apply CSS border styles. Change-Id: I19f662329e4cfce45e32f82dcf9398dc9c3ecaec Reviewed-on: https://gerrit.libreoffice.org/81421 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-24android: Allow specification of the API level.Jan Holesovsky
Change-Id: Icf33e2703f42a7866ce895437cf5f276066eeebe Reviewed-on: https://gerrit.libreoffice.org/81227 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 59eee888bf7174114e5749855d95e8ff7dd15013) Reviewed-on: https://gerrit.libreoffice.org/81327 Tested-by: Jenkins
2019-10-24android: Allow using SDK and NDK directly from the Android Studio.Jan Holesovsky
Just specify: --with-android-ndk=$HOME/Android/Sdk/ndk-bundle --with-android-sdk=$HOME/Android/Sdk in your autogen.input, install the appropriate components via Android Studio and you are done. Change-Id: Ic99790b781b9017eb4e642380e230d6f7b49e9b7 Reviewed-on: https://gerrit.libreoffice.org/81228 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 246f1b5b4485b7db9f9584e4b3b819c87e331c0e) Reviewed-on: https://gerrit.libreoffice.org/81328 Tested-by: Jenkins
2019-10-24pdfium: Switch the condition for better readibility.Jan Holesovsky
Change-Id: I8acf1e98f032f6943b2e7d09ac276f0f1ac4b120 Reviewed-on: https://gerrit.libreoffice.org/81061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 105d98caa70389c12ad4f9a2a2b7474a4be73aa2) Reviewed-on: https://gerrit.libreoffice.org/81326 Tested-by: Jenkins
2019-10-23Don't use broken StringAdd::getSourceAsStringStephan Bergmann
it caused clang-cl to crash when processing desktop/source/app/opencl.cxx Change-Id: I0a39697e75242cd00f12b60477d51a1e5bf96a4f Reviewed-on: https://gerrit.libreoffice.org/81409 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23Fix call to NamedDecl::getNameStephan Bergmann
...which fails at least with clang-8.0.0-3.fc30.x86_64 with "clang-8: /usr/include/clang/AST/Decl.h:277: llvm::StringRef clang::NamedDecl::getName() const: Assertion `Name.isIdentifier() && "Name is not a simple identifier"' failed." Change-Id: I6999240e2b518b6818a43d1e5ac92224300b343f Reviewed-on: https://gerrit.libreoffice.org/81415 Tested-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23jsdliaogs: send data for text styles comboboxSzymon Kłos
Change-Id: I5827799f8adf8db697ac2e2a96eaba2a6fd2e2a4 Reviewed-on: https://gerrit.libreoffice.org/81401 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-23-Werror,-Wdeprecated-volatile (clang-cl)Stephan Bergmann
same as b89187aad86e2be000d2f4c9c380a95bf8430c2e "Simplify forced memory reads" in sal/osl/unx/file.cxx Change-Id: I31edbc72f88895e148609498d367a50e38723b11 Reviewed-on: https://gerrit.libreoffice.org/81408 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23loplugin:bufferadd (clang-cl)Stephan Bergmann
Change-Id: I854e1d4e6acef1c59842fe3921a42e95d0c8fd38 Reviewed-on: https://gerrit.libreoffice.org/81407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23loplugin:loopvartoosmall (clang-cl)Stephan Bergmann
Change-Id: I637fdfe2a22a8e85c89850e6815e4b28e0584dd4 Reviewed-on: https://gerrit.libreoffice.org/81406 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23put together the 'magic' flow-to constantsCaolán McNamara
as a side note, there's no actual use of FORSPELLCHECKFLOWTO anywhere that I can see Change-Id: I90d50d7f98dede3803fec1d22d32d5d57858c1e3 Reviewed-on: https://gerrit.libreoffice.org/81394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: I324496ff7c61d87a83b6b378810aa5c78cd7dba3 Reviewed-on: https://gerrit.libreoffice.org/81405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23-W4 must come before -Wno-missing-braces for clang-clStephan Bergmann
...or else -W4 would re-enable that and cause lots of warnings/errors. 87608490f205b2fbc2b453ad8ded33050ac29b90 "filter arguments to MSVC to avoid the annoying D9025 warning" had changed the relative order of those options on the command line. Change-Id: I2ff9de93cdc6e3dc63961af61169f0adf44f7c0b Reviewed-on: https://gerrit.libreoffice.org/81403 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23loplugin:getstr (--enable-chart-tests)Stephan Bergmann
Change-Id: Ia01bbbfb86335a5187207fabe10a80723022aa95 Reviewed-on: https://gerrit.libreoffice.org/81402 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23external/harfbuzz: Avoid UBSan nullptr-with-nonzero-offsetStephan Bergmann
...(new with Clang 10 trunk), as seen during CppunitTest_emfio_emf: > hb-ot-layout-gsubgpos.hh:390:20: runtime error: applying non-zero offset 2 to null pointer > #0 in OT::hb_ot_apply_context_t::skipping_iterator_t::next() at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:390:20 > #1 in OT::PairPosFormat1::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gpos-table.hh:910:22 > #2 in bool OT::hb_get_subtables_context_t::apply_to<OT::PairPosFormat1>(void const*, OT::hb_ot_apply_context_t*) at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:625:23 > #3 in OT::hb_get_subtables_context_t::hb_applicable_t::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:643:62 > #4 in OT::hb_ot_layout_lookup_accelerator_t::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:2624:24 > #5 in apply_forward(OT::hb_ot_apply_context_t*, OT::hb_ot_layout_lookup_accelerator_t const&) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1811:24 > #6 in void apply_string<GPOSProxy>(OT::hb_ot_apply_context_t*, GPOSProxy::Lookup const&, OT::hb_ot_layout_lookup_accelerator_t const&) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1864:11 > #7 in void hb_ot_map_t::apply<GPOSProxy>(GPOSProxy const&, hb_ot_shape_plan_t const*, hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1910:7 > #8 in hb_ot_map_t::position(hb_ot_shape_plan_t const*, hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1933:3 > #9 in hb_ot_shape_plan_t::position(hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:266:9 > #10 in hb_ot_position_complex(hb_ot_shape_context_t const*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:951:12 > #11 in hb_ot_position(hb_ot_shape_context_t const*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:994:3 > #12 in hb_ot_shape_internal(hb_ot_shape_context_t*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:1065:3 > #13 in _hb_ot_shape at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:1088:3 > #14 in hb_shape_plan_execute at workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:42:1 > #15 in hb_shape_full at workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:139:19 > #16 in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphs const*) at vcl/source/gdi/CommonSalLayout.cxx:463:23 > #17 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1312:36 > #18 in OutputDevice::GetTextBoundRect(tools::Rectangle&, rtl::OUString const&, int, int, int, unsigned long, long const*, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:2334:18 > #19 in drawinglayer::primitive2d::TextLayouterDevice::getTextBoundRect(rtl::OUString const&, unsigned int, unsigned int) const at drawinglayer/source/primitive2d/textlayoutdevice.cxx:297:26 > #20 in drawinglayer::primitive2d::TextSimplePortionPrimitive2D::getB2DRange(drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/textprimitive2d.cxx:305:63 > #21 in drawinglayer::primitive2d::getB2DRangeFromPrimitive2DReference(com::sun::star::uno::Reference<com::sun::star::graphic::XPrimitive2D> const&, drawinglayer::geometry::ViewInformation2D const&) at drawinglayer/source/primitive2d/baseprimitive2d.cxx:175:48 > #22 in drawinglayer::primitive2d::Primitive2DContainer::getB2DRange(drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/baseprimitive2d.cxx:199:36 > #23 in drawinglayer::primitive2d::MetafilePrimitive2D::create2DDecomposition(drawinglayer::primitive2d::Primitive2DContainer&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/metafileprimitive2d.cxx:51:67 > #24 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/baseprimitive2d.cxx:126:17 > #25 in drawinglayer::tools::Primitive2dXmlDump::decomposeAndWrite(drawinglayer::primitive2d::Primitive2DContainer const&, tools::XmlWriter&) at drawinglayer/source/tools/primitive2dxmldump.cxx:332:38 > #26 in drawinglayer::tools::Primitive2dXmlDump::dumpAndParse(drawinglayer::primitive2d::Primitive2DContainer const&, rtl::OUString const&) at drawinglayer/source/tools/primitive2dxmldump.cxx:130:5 > #27 in (anonymous namespace)::Test::checkRectPrimitive(com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::graphic::XPrimitive2D> > const&) at emfio/qa/cppunit/emf/EmfImportTest.cxx:80:34 > #28 in (anonymous namespace)::Test::testWorking() at emfio/qa/cppunit/emf/EmfImportTest.cxx:94:5 and similarly during CppunitTest_vcl_complextext: > hb-ot-layout-gsubgpos.hh:417:20: runtime error: applying non-zero offset 2 to null pointer > #0 in OT::hb_ot_apply_context_t::skipping_iterator_t::prev() at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:417:20 > #1 in OT::MarkMarkPosFormat1::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gpos-table.hh:1541:22 > #2 in bool OT::hb_get_subtables_context_t::apply_to<OT::MarkMarkPosFormat1>(void const*, OT::hb_ot_apply_context_t*) at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:625:23 > #3 in OT::hb_get_subtables_context_t::hb_applicable_t::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:643:62 > #4 in OT::hb_ot_layout_lookup_accelerator_t::apply(OT::hb_ot_apply_context_t*) const at workdir/UnpackedTarball/harfbuzz/src/./hb-ot-layout-gsubgpos.hh:2624:24 > #5 in apply_forward(OT::hb_ot_apply_context_t*, OT::hb_ot_layout_lookup_accelerator_t const&) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1811:24 > #6 in void apply_string<GPOSProxy>(OT::hb_ot_apply_context_t*, GPOSProxy::Lookup const&, OT::hb_ot_layout_lookup_accelerator_t const&) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1864:11 > #7 in void hb_ot_map_t::apply<GPOSProxy>(GPOSProxy const&, hb_ot_shape_plan_t const*, hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1910:7 > #8 in hb_ot_map_t::position(hb_ot_shape_plan_t const*, hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-layout.cc:1933:3 > #9 in hb_ot_shape_plan_t::position(hb_font_t*, hb_buffer_t*) const at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:266:9 > #10 in hb_ot_position_complex(hb_ot_shape_context_t const*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:951:12 > #11 in hb_ot_position(hb_ot_shape_context_t const*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:994:3 > #12 in hb_ot_shape_internal(hb_ot_shape_context_t*) at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:1065:3 > #13 in _hb_ot_shape at workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:1088:3 > #14 in hb_shape_plan_execute at workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:42:1 > #15 in hb_shape_full at workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:139:19 > #16 in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphs const*) at vcl/source/gdi/CommonSalLayout.cxx:463:23 > #17 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1312:36 > #18 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:961:45 > #19 in VclComplexTextTest::testArabic() at vcl/qa/cppunit/complextext.cxx:81:32 I have no idea whether this even remotely resembles a useful fix, though. Change-Id: I7671b84374cf119e173406bc60f6631a64dfc794 Reviewed-on: https://gerrit.libreoffice.org/81400 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23lok: svtools: change parameter from "ID" to "POS" in ValueSetUIObject classHenry Castro
The ValueSet control has an item list with a pair properties "(pos,id)". The "POS" parameter is the item "ID" not the position in the list and to not modify doc_sendDialogEvent function, let's have same uniform parameter for the action "SELECT". Change-Id: I5ce2cf0433bebcd77954f271c4aa09b0b446c0ab Reviewed-on: https://gerrit.libreoffice.org/81399 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-23Enable our gdb pretty-printers when printing backtracesStephan Bergmann
(-iex aka --init-eval-command appears to be supported by gdb since <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit; h=8320cc4fa3784dc5296745898de5357559f8125a> in 2012, so it is probably safe to assume it is generally available) Change-Id: I65134d62ecd509ab39fa42f3cddbef40b74ab9d0 Reviewed-on: https://gerrit.libreoffice.org/81393 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23Resolves: tdf#128130 enable mnemonics in pivot table expandersCaolán McNamara
Change-Id: Ia3196252a7399b4069fff0c2f82fb96fecd6fccc Reviewed-on: https://gerrit.libreoffice.org/81383 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-23In checkUnoObjectType, check for derived-from types tooStephan Bergmann
As discussed in the mail thread starting at <https://listarchives.libreoffice.org/global/users/msg54775.html> "[libreoffice-users] Experimental macro features: How to determine object types?", it is confusing if a variable dim'ed as com.sun.star.util.XSearchDescriptor cannot hold an object whose css.lang.XTypeProvider::getTypes only reports css.util.XReplaceDescriptor (which is derived from XSearchDescriptor) but not XSearchDescriptor itself. At least for now, keep the odd endsWithIgnoreAsciiCase check intact (instead of checking for strict equality). Change-Id: Idd8ae8cb11b0f2e9c6369842629fc5a21e1c5cc5 Reviewed-on: https://gerrit.libreoffice.org/81386 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23realloc sequence to amount of inserted elementsCaolán McNamara
Change-Id: I5c507287631dd5cc87a037d0af67de77aca556d1 Reviewed-on: https://gerrit.libreoffice.org/81385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23Reinstate CppunitTest_sal_rtlStephan Bergmann
...which had been dropped by 0f874472c672175135520101837ff0c9d4701d7f "size some stringbuffer to prevent re-alloc", presumably by accident Change-Id: I3b84e743c1adcdd8518114810dcee5c3f12c4290 Reviewed-on: https://gerrit.libreoffice.org/81388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23sc: rowcol: tdf#50916 convert docshellNoel Grandin
Change-Id: I52c641bfba397134ad5ed2a9e8005f8959092303 Reviewed-on: https://gerrit.libreoffice.org/81381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23sc: rowcol: tdf#50916 convert appNoel Grandin
Change-Id: I1b93d831fff69db26f3078bf21915ebe285e89f8 Reviewed-on: https://gerrit.libreoffice.org/81382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23jsdilogs: send data for font name & size toolitemsSzymon Kłos
Change-Id: Ia5ea058ba44b3a511a0bdbfc132a7de2d68f2e6b Reviewed-on: https://gerrit.libreoffice.org/81380 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-23ofz#18467 check against end of bufferCaolán McNamara
Change-Id: Ibeed87e2e3af90219e7bbbd773d369c90f78a364 Reviewed-on: https://gerrit.libreoffice.org/81371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23sw: add test for RTF/DOCX roundtrip of nested fieldsMichael Stahl
This reveals some funny code that was added in commit 24b04db5a63b57a74e58a7616091437ad68548ac which happens to break the RTF test; let's just disable that inside field commands, doesn't make much sense there probably. Change-Id: I77fd13d7c4b7d370dda8a342b72cbc2bbab604e1
2019-10-23update creditsChristian Lohmaier
Change-Id: Iad1765bef9e47d5a1588f43b170245c05d590f9a
2019-10-23Add document-level option to lock down saveSamuel Mehrbrodt
Change-Id: I40b5e8c780894645e467e3891062c499707d69c7 Reviewed-on: https://gerrit.libreoffice.org/81359 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-23Add document-level option to lock down printingSamuel Mehrbrodt
Change-Id: I85694021d74be79293079d04d5ba1d9b48cfa557 Reviewed-on: https://gerrit.libreoffice.org/81340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-23Add test for LockExport propertySamuel Mehrbrodt
Change-Id: I81533ccd34ac517b31afa1e7e6b818b74c42bc1d Reviewed-on: https://gerrit.libreoffice.org/81376 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-23sc: rowcol: tdf#50916 convert miscdlgsNoel Grandin
Change-Id: Ib8748b47e2432053ff9dfe7adec0309cd3931b2e Reviewed-on: https://gerrit.libreoffice.org/81372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23tdf#127909 follow the NSSInitializer selectionJan-Marek Glogowski
NSSInitializer contains the copy of the algorithm used in the certificate path selection dialog, but with commit aceab9cbf104 ("tdf#127909 don't always select the first entry") these were desynced, as the first default profile should be selected not the last one. Change-Id: I07816c74eb1184df17e4d251f27ff0bee715e82d Reviewed-on: https://gerrit.libreoffice.org/81367 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23Fix build; adapt to OUStringLiteral1 -> OUStringChar renameStephan Bergmann
Change-Id: I67294848205cf0441abf1c90206bdad0001ade96 Reviewed-on: https://gerrit.libreoffice.org/81377 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>