summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-24weld ODbaseDetailsPageCaolán McNamara
Change-Id: Ia0d953ee2d4a4f35ba6f59bb6bd6b1a04ed25f63 Reviewed-on: https://gerrit.libreoffice.org/62284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OConnectionTabPageCaolán McNamara
Change-Id: Icdbe5d95d0850d131018d21d0a21cb12109d565c Reviewed-on: https://gerrit.libreoffice.org/62283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24add adjustment to specialsettingspageCaolán McNamara
Change-Id: Ia897b8f01618e499817f16e8ac2d1e0a8bef3367 Reviewed-on: https://gerrit.libreoffice.org/62282 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24Reorganize FrameBorderPrimitive creationArmin Le Grand
Step1: Basic concept, move stuff to svx and new SdrFrameBorderPrimitive2D Step2: Adapt all creators/usages to use SdrFrameBorderData/SdrFrameBorderPrimitive2D, check functionality Step3: Re-implement mergre of BorderLinePrimitive2D during decomposition of SdrFrameBorderPrimitive2D to keep the number of primitives low from the start, make merge optional (not urgently needed) Step4: Migrate and isolate all helper methods and classes involved in geometry creation of border lines to the implementation (.cxx) of the new primitive Change-Id: I840b6765439bd995f2c57ef36315427b1f0f3e21 Reviewed-on: https://gerrit.libreoffice.org/62247 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-24Simplify containers iterations in test..toolsArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: If8fac9236a4696c8e56c0e81c60c429782581b96 Reviewed-on: https://gerrit.libreoffice.org/62262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24ScDoubleItem is deadNoel Grandin
i.e. no way to get any useful information out of it, at least since commit 8b3fcb6a4f80e803586120535768745f6637b34d Date: Fri Aug 11 10:01:25 2017 +0530 Removing unused SfxItemPool serialisation from svx Which means that SID_RANGE_VALUE is also useless. Possibly the commit that added this had a bug, and it meant to use SvxDoubleItem, which implements the necessary QueryValue/PutValue methods to be able to interact with macro code. Change-Id: I6ffb0c46f6f0864f202d71f0e157d7e1d0f54f51 Reviewed-on: https://gerrit.libreoffice.org/62232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Introduce OutputDevice type OUTDEV_PDFJan-Marek Glogowski
Originally I thought mpPDFWriter can be used to create PDF from any OutputDevice, but it's actually just set for the internal VirtualDevice of the PDF writer. So this gets rid of all the special mpPDFWriter and GetPDFWriter() handling and replaces it with checks for OUTDEV_PDF. But since ImplPDFWriter used to be a OUTDEV_VIRDEV, this also introduces OutputDevice::IsVirtual(), which now replaces most of the direct OUTDEV_VIRDEV checks. Change-Id: I11824143b6b8833ecc81119762448cbdf1145dbc Reviewed-on: https://gerrit.libreoffice.org/62257 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I8d2ff75a7b185daf331724616b4c61c5569c0664 Reviewed-on: https://gerrit.libreoffice.org/62226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24ReportDesign: FooterBackGraphic may be voidJulien Nabet
Fix this message on console: warn:xmloff:29095:29095:xmloff/source/core/xmlerror.cxx:170: An error or a warning has occurred during XML import/export! Error-Id: 0x20040001 Flags: 2 ERROR Class: 4 API Number: 1 Parameters: 0: FooterBackGraphic Exception-Message: The given value cannot be converted to the required property type. (property name "FooterBackGraphic", found value type "void", required property type "com.sun.star.graphic.XGraphic") Position: Public Identifier: System Identifier: Row, Column: 28,1 Change-Id: I630dcd77767a61ef82695d004a76e01a2d2e27d0 Reviewed-on: https://gerrit.libreoffice.org/62118 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24tdf#119561: fix assert when double click field in a tableJulien Nabet
by calling ClearMark so we clean table cursor and related stuff before creating a new cursor for field edition See https://bugs.documentfoundation.org/attachment.cgi?id=145578 Change-Id: I3a67fc5704d7a565f76e486bb12e4012e3336062 Reviewed-on: https://gerrit.libreoffice.org/61632 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24Add 5 properties to not pass to JDBC driverJulien Nabet
AppendTableAliasInSelect DisplayVersionColumns GeneratedValues UseIndexDirectionKeyword UseKeywordAsBeforeAlias So we don't get this kind of message: warn:legacy.osl:4402:4415:connectivity/source/drivers/jdbc/tools.cxx:153: OSL_ASSERT: 0 Change-Id: Id74e2a914d76e199c0f18d25d4169401ab500136 Reviewed-on: https://gerrit.libreoffice.org/61740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24tdf#120728: retrieve label pageJulien Nabet
See bt with: https://bugs.documentfoundation.org/attachment.cgi?id=145860 Change-Id: I0fc0d5a269d69637d3c164f6cea6f7dc8a79fffc Reviewed-on: https://gerrit.libreoffice.org/62082 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24calc context toolbar update celleditandreas kainz
arrangement is now like in drawtext Change-Id: I5d2e13b18bf2f3f4762858de8ce86a1d7269c3be Reviewed-on: https://gerrit.libreoffice.org/62246 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-24calc context menu cell add styles support (like in writer)andreas kainz
arrange like in other modules Change-Id: I9e96b9d820821a9743cbb4c254a69e6dd9627953 Reviewed-on: https://gerrit.libreoffice.org/62243 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-24Resolves: tdf#120862 double-click in bullets and numberingCaolán McNamara
Change-Id: I3d8aa529fc5ac8a8f80eb1fd6728786680f2aee2 Reviewed-on: https://gerrit.libreoffice.org/62277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24tdf#120746: Show the name of the persona as tooltip in the search resultsMuhammet Kara
Change-Id: Ie6de25e93f0e96a1a5b1cf5c4d465dfb45afc7f7 Reviewed-on: https://gerrit.libreoffice.org/62249 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-24tdf#42949 Fix IWYU warnings in include/opencl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I76f15a8e7724384e8ba773621bdcac1351b32a0a Reviewed-on: https://gerrit.libreoffice.org/62086 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-24tdf#120807 check for valid ImplGetWindowImpl()Jan-Marek Glogowski
Change-Id: Ia1135d11990abc303849bd1b6a549c82008c79de Reviewed-on: https://gerrit.libreoffice.org/62260 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-24tdf#120491 EPUB export: fix IngramSpark validator errorMiklos Vajna
Change-Id: I7b6d2217525dbf2e8c9c78a14ea7601c4170857a Reviewed-on: https://gerrit.libreoffice.org/62267 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-24don't try to verify .desktop files when building the menus.rpmChristian Lohmaier
the actual .desktop files are in the main rpm, the freedesktop-menus package only has symlinks pointing to it Change-Id: I0816255dd56cd2281b441836871d281e112a659a
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24Change PDFWriterImpl into an OutputDeviceJan-Marek Glogowski
It actually changes it into a VirtualDevice and should just be a refactoring. We get rid of the crude stuff in a follow up patch, While at it unfriend PDFWriterImpl from OutputDevice. Change-Id: Id43731ad076690292c30f9f3e05ff0dd58edc5e5 Reviewed-on: https://gerrit.libreoffice.org/62201 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-24loplugin:useuniqueptr in SwContentTreeNoel Grandin
Change-Id: I4f42497023883450a00f8b50a7dd6d30ca1cbac4 Reviewed-on: https://gerrit.libreoffice.org/62265 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24sw: prefix remaining members of SwIndexMarkPaneMiklos Vajna
Change-Id: I60e66fe3f92c5952172323ec2d4b0dda1f2ab5f1 Reviewed-on: https://gerrit.libreoffice.org/62266 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-24ww8export roundtrip forms passwordJustin Luth
This was already done for docx in LO6.0 with commit 2694162969cf86ef366d3ce812fccd0630acc800 Patch initially developed to support tdf#120499 and depnds on commit 953dad97c7ef7881c2ac6d73fe5266b44b15f3e2 Change-Id: I04b0693ed1e90f70b079040030c5bd9d2ccfbf13 Reviewed-on: https://gerrit.libreoffice.org/61952 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-24Translate German commentsJohnny_M
Change-Id: I4e0150aac5a785ea2cb0884dede1596164a18af0 Reviewed-on: https://gerrit.libreoffice.org/62079 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-24tdf#120450: Radiobuttons want to be checked tooKatarina Behrens
Change-Id: If9b67bf866ed9fe38f69d440deeb2eccb87301bc Reviewed-on: https://gerrit.libreoffice.org/62237 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-24clang-tidy performance-unnecessary-copy-init in scNoel Grandin
Change-Id: I93ded61c22bd533a6ffaddd20d6e527f176e7651 Reviewed-on: https://gerrit.libreoffice.org/62218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in test..xmlscriptNoel Grandin
Change-Id: I1ae16467a8e58e8a50f59b7a140e9f8b68bde07e Reviewed-on: https://gerrit.libreoffice.org/62254 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in swNoel Grandin
Change-Id: I515e3e8ddaee3e3ddc4bf3827fb85f3489e84539 Reviewed-on: https://gerrit.libreoffice.org/62253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in svxNoel Grandin
Change-Id: I27f4dd0cb08f9b62496a1c51eed732a678e1c2e5 Reviewed-on: https://gerrit.libreoffice.org/62252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in sfx2..svtoolsNoel Grandin
Change-Id: I1e92472b4aaeca1eb1372bd18d10cc9e0766dc39 Reviewed-on: https://gerrit.libreoffice.org/62251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in sdNoel Grandin
Change-Id: I4a494aebdae9b9cba3794e5eee1f3a29eb3ec838 Reviewed-on: https://gerrit.libreoffice.org/62250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24FmInterfaceItem is deadNoel Grandin
ever since commit a0c7b2bc4511da87c776b92aaa77ba7680542fa1 Date: Tue Nov 16 10:24:21 2004 +0000 INTEGRATION: CWS eforms2 (1.48.52); FILE MERGED Change-Id: Id8568ba19c4b7f1b7e5d8e8ebead0b4b2a1f5e0e Reviewed-on: https://gerrit.libreoffice.org/62231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24DSID_DATASOURCE_UNO is deadNoel Grandin
ever since it's introduction in commit 1519f106cad10c9832089a8bcad63e6890f7135b Date: Mon Feb 5 12:57:41 2001 +0000 #83430# +DSID_DATASOURCE_UNO Change-Id: If9573e259c8897c6cd5cce649bfde7ff3aef7f77 Reviewed-on: https://gerrit.libreoffice.org/62230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Fix empty capture group referenceMike Kaganski
Searching for something like (foo)|(bar) and replacing with $1$2 would fail assertion in appendCopy in include/rtl/ustrbuf.hxx, because beginIndex is negative (-1), because one of the references is always empty (SearchResult at TextSearch::ReplaceBackReferences() has both startOffset and startOffset equal to -1). In this case, we should simply return an empty string. Change-Id: Ibf91b1d17ab21c279cfcdc31e84d0c2eae567a53 Reviewed-on: https://gerrit.libreoffice.org/62248 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-23Constify VirtDevice::me(Alpha)?FormatJan-Marek Glogowski
Change-Id: I619c19837c3bb6124009787ba0fc53991b4c4d0b Reviewed-on: https://gerrit.libreoffice.org/62256 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-23Constify OutputDevice::meOutDevTypeJan-Marek Glogowski
Change-Id: Idfa57c545704626a8b8b7405cd32c49666a04746 Reviewed-on: https://gerrit.libreoffice.org/62255 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-23tdf#120449: Show keyboard shortcuts in native menusKatarina Behrens
Who would have thought that this information has to be stored in SalFrame Change-Id: I8fbdf1794184e8dfd0b0025d29a19938dbb2af03 Reviewed-on: https://gerrit.libreoffice.org/62236 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-23sc: speed-up: avoid usage of svl::SharedString where it is possibleSerge Krot
Change-Id: I55a1a634927cb1d7a04267d02322fcfa41d390d0 Reviewed-on: https://gerrit.libreoffice.org/61572 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-23remove all use_action_appearance linesCaolán McNamara
Change-Id: I031676e939f53a28b1a62654ffe0a91b95dea029 Reviewed-on: https://gerrit.libreoffice.org/62234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-23Resolves: tdf#120689 omit <definedName> for ocMacro in OOXMLEike Rathke
Change-Id: I7578d568d2afe5d3a45b31a8a349cd370b03fc67 Reviewed-on: https://gerrit.libreoffice.org/62204 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-23clang-tidy performance-unnecessary-copy-init in dbaccess..drawinglayerNoel Grandin
Change-Id: I49a152b2aea93d30b16192260f4f659c7e5fcaee Reviewed-on: https://gerrit.libreoffice.org/62215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23tdf#120803: avoid crash if no valid vcl::WindowKatarina Behrens
when called from the destructor it is no longer alive Change-Id: Ia68272253f9c459b2647a0bd389e833fb0b519e3 Reviewed-on: https://gerrit.libreoffice.org/62228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-23loplugin:useuniqueptr more exclusionsNoel Grandin
Change-Id: I70c6d4af999965497e23ec8180eb08aa6dc648c5 Reviewed-on: https://gerrit.libreoffice.org/62221 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23tdf#117348: Change default grid color to a darker grayMuhammet Kara
For Impress and Draw Change-Id: I8c7854062ae061ba2f7cd968ffd608b8d9b0ca5b Reviewed-on: https://gerrit.libreoffice.org/62025 Tested-by: Jenkins Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-23Special methods NewStandardLayer and SetStandardLayer not neededRegina Henschel
The method SetStandardLayer() is only used once, in method SdrLayerAdmin::NewStandardLayer(). This method is only used once, in OReportDefinition::init(). The difference between a layer 'Standard' and other layers is only in mbUserDefinedLayer. But this difference is no where evaluated. Therefore an ordinary layer is sufficient. The layer name is neither stored nor used in the UI, thus translation is not needed. A layer name must be set, but in this case it is not used in code, thus handle it same as for layer 'back'. Change-Id: Ifd4400d432d3b4702e950d3a717ed13d4075c279 Reviewed-on: https://gerrit.libreoffice.org/62144 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-10-23tdf#120475: Sync persona categories with MozillaMuhammet Kara
* Removed buttons which represent the static set of 6 categories * Added all categories from Mozilla: https://addons.mozilla.org/en-US/firefox/themes/ * Added extra category, named Featured, which will be selected by default * Sort results based on download numbers Change-Id: Ia3908f560dedbd08ce2c0d469fbe75a7d3dee15b Reviewed-on: https://gerrit.libreoffice.org/62183 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-23remove old poppler compat codeNoel Grandin
since we require poppler >= 0.12.0 Change-Id: Ie698ecbe776d12ef21ba8f12ac4dfa0575ed467b Reviewed-on: https://gerrit.libreoffice.org/62223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-01 09:50:15 +0000