summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-11cid#1470586 Dereference after null checkCaolán McNamara
since... commit d79a578c200ff30134cf5ec7ad5c66f3e5d2d4c9 Date: Tue Dec 8 23:50:27 2020 +0100 flylay: Modify no more Change-Id: Ief190dfb135d1bcc25004278cc68bf014554d533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11tdf#136929 docx export: keep frame with paragraphJustin Luth
EndParagraph was checking if any frames were to be attached. Well, startParagraph can occur multiple times before endParagraph, so the frames can be attached to the wrong paragraph. In this case, it was moving the text-body frame into the footer. So make a stack of these things, so that each paragraph can keep track of it's own setting. RTF can have endParagraph without startParagraph. Although that doesn't seem to apply in this DOCX-only context, just to be safe I'm assuming that it could in theory happen as well with a DOCX, and so never assume that the stack exists. Based on a code read, (and then a confirming unit test,) things seem to be complicated by multi-levels of textboxes that need to be squished. The for loop with a changing upper end really threw me for a loop, so I'm clearly documenting that. Change-Id: I1060736c0a2174af125d853ff7d72265e000c8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107516 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11tdf#123613 XLSX export: fix position of rotated shapesSzabolcs Toth
based on the bounding box of the custom shape. Change-Id: I63a2a4380ae0c6c0eb37d3e5e4dcbfc839b410a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107424 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-11update ToD statusbar previewandreas kainz
Change-Id: Ic36861e388b62179e1ef6b5c5f74eb27429de159 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107517 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-12-11pdfium: remove unused PDFiumPathSegment::getPointer()Miklos Vajna
Change-Id: I17386b92e99a223f4983767cf67bb9ba7acb806a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107579 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11FastParser.cxx changesdante
If custom entity list is empty, custon entities by unicode value have to keep working. Succefully loaded: <?xml version="1.0" encoding="UTF-8"?> <math xmlns="http://www.w3.org/1998/Math/MathML" display="block"> <semantics> <mi>&#x3C3;</mi> <mi>&#x221E;</mi> <mi>&sigma;</mi> <mi>&infin;</mi> </semantics> </math> Change-Id: I46cc5b04bd91d1aaadf3f99cb2079325bb0d08cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107498 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-10tdf#131990: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I99ed5b61479076f44bfabdf1cf3b95732fff79f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107581 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-10tdf#138762: crash when trying to open sidebar w chart in WriterAron Budea
In Writer when in chart edit mode, and the chart is deselected, the object selection remains. Opening Properties sidebar at this point crashed. Calc and Impress were unaffected. Regression from b5fdb148fe87a90f3e586efcea7aa6ef865fa42a Change-Id: I356c3a42c41dd38e4739df27c72c6d67722b1dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107500 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-12-10Catch inadvertent uses of OString(char) ctorStephan Bergmann
...similar to cbe944e323edb20f958bb46ea644de659b75382e "Catch inadvertent uses of OUString(sal_Unicode) ctor". The existing few places did mean to use that ctor after all, but this clean-up should come in handy when single-character instances of OString are replaced with OStringChar, which already rejects non- char arguments. Change-Id: I9dbd85b85c3be653c5e8084aed39689f8c6c3bb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107557 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-10cupsGetPPD returned a nullptr which OString newly aborts withCaolán McNamara
Change-Id: Ia42e9b501f3e5c769d9d151597e6384836369ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107571 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10add a way to provide a parent for a popup menuCaolán McNamara
Change-Id: Ic21726f243248a4b09f9e2f462e53df2e39df7df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10tdf#81226: sw_uiwriter: Add unittestXisco Fauli
Change-Id: If5f6ae5822b7af9618b447dc60180ffe3f9f04b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107569 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-10make Skia image cache size configurableLuboš Luňák
As asked for in tdf#136244 comment #11. The default fits 4x 2000px 32bpp images, which is 64MiB, which is not that little, but then 4x 2000px is not that much either. So, yes, configurable ... A good further improvement would be to make the cache grow more if the memory is available and reduce the size on memory pressure (https://lists.freedesktop.org/archives/libreoffice/2020-December/086404.html). Change-Id: Ifa05025ab34630e456465ac8a96950463fd18b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107468 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-10Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to a57c5901e98af74279502f6adbab65a3d101dd03 - Update AllLangHelp_shared.mk after file removal Change-Id: I78b49e10827e41df95eeacc1e7fe0fb19a9bc2d7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107573 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-10don't need a vcl::Window for PixelToLogicCaolán McNamara
Change-Id: Iccf5fe5e736017962a58d6471bb2d1890f77c6c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10Add comments wondering what some magic numbers might meanTor Lillqvist
Change-Id: Iece65c9d96561abc0a97726cd4eb642317dc0f9c
2020-12-10Don't leave an empty area at the bottom if we can move the text downCaolán McNamara
in writer's margin comment, which is what ScTextWnd does Change-Id: I2d71d32619e0f6f5c11f57584b1889c7c4fbe121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10Don't show HiddenParagraphs by defaultSamuel Mehrbrodt
Showing them means that the layout is different from what is printed. This probably shouldn't be the default. The similiar HiddenCharacter is also false by default. Change-Id: Id68408463ccbceab18b73ac78f24d1b4b4cbeaeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107385 Tested-by: Jenkins Reviewed-by: Oliver Brinzing <oliver.brinzing@gmx.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-12-10One more OUString::fromUtf(u8"...") simplificationStephan Bergmann
Change-Id: I0a658edab6c2f4a5b4ff58fb7a4b57bde3809962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-10Avoid calling OString ctor with null pointerStephan Bergmann
...in preparation of potential future changes from using OString to using std::string_view, where OString has an undocumented feature of allowing construction from a null pointer. This is mostly the result of a manual audit of potentially problematic getenv calls across the code base. But there can be other problematic places too, like the xmlGetProp call in tools/source/xml/XmlWalker.cxx. To identify those, rtl_{string,uString}_newFromStr aborts now in non-production debug builds when a null pointer is passed(and all places that hit with a full `make check screenshot` have been addressed here). Once we are confident that all problematic places have been identified, we should drop support for the undocumented feature (see the TODO in sal/rtl/strtmpl.cxx). Change-Id: I595cc6d4f1cda74add2a3db171323f817d362b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-10Drop pointless forward declarationTor Lillqvist
Change-Id: I3d5de86024ca411545ead5abecff33390ff6c2a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107533 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-10Drop obviously unnecessary forward declarationTor Lillqvist
Change-Id: I87afac091869356e2faa0d71ea36055482e3d8b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107532 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-10fix printing of 'margins in comment'Caolán McNamara
mangled since... commit c200aa27ee4a0f5a89af6e970c2c22580029eded Author: Caolán McNamara <caolanm@redhat.com> Date: Thu May 21 15:54:15 2020 +0100 remove Size arg from Window::Draw and depend on GetSizePixel which was a real monday-morning commit that bizarrely dropped drawing of the date/resolved widgets entirely and failed to notice that the PixelToLogic call in SwPostItMgr::DrawNotesForPage was originally called on the input pPostIt, not the output pDev Change-Id: I73b87f5889ef13018bcc43f97cd65169a3b77a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 9512494c315aee4af46fa9a9eca0e4be0210e3cd - tdf#138301,tdf#130738 add "Custom" condition in Data>Validity-Criteria help + add Custom and explanation to list of Allow conditions * correction to condition: "Whole Number" --> "Whole Numbers" * update two <h2>, one <h3> Change-Id: I1a6034af51c8dc5afe5a44a0043e26556cf94f8f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107374 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-10tdf#129961 oox: add PPTX import for table shadow as direct formatMiklos Vajna
PPTX export and ODP filter is still missing. Change-Id: I451b334ada80d9d228b7d7f36b5f26473b575ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107529 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to c9f02245818790a55c64b9dc66da43cdbb20af6a - Resolves: tdf#107229 remove unreferenced file shared/optionen/01040301.xhp was created to embed the entire shared/optionen/standard_template.xhp so that it could be used as a link to shared/optionen/01040300.xhp Maybe it made sense at the time it was done, but now it is easier to make the link in shared/optionen/01040300.xhp to point directly to shared/optionen/standard_template.xhp, so this file is no longer referenced by others, and its content came entirely from shared/optionen/standard_template.xhp. So now being deleted because it longer has any purpose. Change-Id: I1d356930c98c17020e768d272e8560fdf066b456 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107535 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2020-12-10tdf#138621 put icons back in File>Template submenuSeth Chaiklin
Change-Id: I3f1a28d12e559ae34f992d1856557593cd0c01d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107488 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-10Do not call GetAddrInfoW if we just want the hostnameSamuel Mehrbrodt
Calling 'gethostname' already gives us the current host name on Windows. For some reason, if that name does not contain a dot, GetAddrInfoW is called, which "provides protocol-independent translation from a Unicode host name to an address". So all this function does, is returning an address for a hostname, while we still only need the hostname and not the address. This causes a lag when creating the lockfile on opening a document if the network is flaky/disabled. See tdf#97931 and tdf#47179 for some problems caused by this. Change-Id: I0c543ea12c23506b2daa50da40bae1a471f6fe16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107513 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-12-10Resolves: tdf#138789 disable widgets on 'none' when status changesCaolán McNamara
instead of when chage is dispatched, the chart case has its own dispatcher that disables the base class one. This fixes the reported problem, and the related problem of updating when moving focus from one line that has style 'none' to one that doesn't, and vice-versa, where no change is dispached on received on context change Change-Id: I6afb396e75ba93c13fcae71c52618cfce7f9cecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10tdf#134626 sw: fix UBSan warning about deleted SwTextFormatCollMichael Stahl
sw/source/core/txtnode/ndtxt.cxx:5254:17: runtime error: downcast of address 0x612000a321c0 which does not point to an object of type 'const SwTextFormatColl' 0x612000a321c0: note: object is of type 'SwFormat' 00 00 00 00 50 4c 3c fa bb 7f 00 00 80 b8 ba 05 50 61 00 00 c0 81 5f 02 20 61 00 00 c0 b6 b0 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SwFormat' 0 in SwTextNode::TriggerNodeUpdate(sw::LegacyModifyHint const&) at sw/source/core/txtnode/ndtxt.cxx:5254:17 1 in SwTextNode::SwClientNotify(SwModify const&, SfxHint const&) at sw/source/core/txtnode/ndtxt.cxx:5306:9 2 in SwClient::SwClientNotifyCall(SwModify const&, SfxHint const&) at sw/inc/calbck.hxx:161:80 3 in SwFormat::~SwFormat() at sw/source/core/attr/format.cxx:240:22 4 in SwFormatColl::~SwFormatColl() at sw/inc/fmtcol.hxx:35:26 5 in SwTextFormatColl::~SwTextFormatColl() at sw/inc/fmtcol.hxx:56:20 6 in SwTextFormatColl::~SwTextFormatColl() at sw/inc/fmtcol.hxx:56:20 7 in SwDoc::DelTextFormatColl(unsigned long, bool) at sw/source/core/doc/docfmt.cxx:983:5 8 in SwDoc::DelTextFormatColl(SwTextFormatColl const*, bool) at sw/source/core/doc/docfmt.cxx:991:5 9 in SwUndoTextFormatCollCreate::Delete() at sw/source/core/undo/SwUndoFmt.cxx:203:12 10 in SwUndoFormatCreate::UndoImpl(sw::UndoRedoContext&) at sw/source/core/undo/SwUndoFmt.cxx:61:9 11 in SwUndo::UndoWithContext(SfxUndoContext&) at sw/source/core/undo/undobj.cxx:235:5 Any SwUndoFormatCreate that is added during CopyImplImpl() must go before SwUndoCopyDoc on the undo stack. SwNodes::CopyNodes() is pretty much the only thing of substance there that runs with Undo enabled; CopyBookmarks() and lcl_DeleteRedlines() and CopyFlyInFlyImpl() have it disabled. Let's see if the fix is really this simple... Change-Id: I4d586923f91a02861e9a4bd40d22701ceb0a0499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107522 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-10sw: avoid crashing in SwFrame::dumpAsXmlAttributes()Michael Stahl
Change-Id: I86e160341e1d391ee6eaf80ab76610d95943b092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107521 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-10tdf#129083: sw: Add UItestXisco Fauli
Change-Id: I0d7999c53d8fbf7fc69543f636fb536f3e15141c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107518 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 1f5e7cbaf41f21b72713814f1517be23f933258d - tdf#107229 simplify embedding for default template help ( source/text/shared/optionen/01040300.xhp ) * changed link from (shared/optionen/01040301.xhp ) to (shared/optionen/standard_template.xhp ). shared/optionen/01040301.xhp simply embeds all of "standard_template.xhp". No advantage in having a separate 01040301.xhp to embed into 01040300.xhp, because (a) makes relation to standard_template.xhp more difficult to see, and (b) the title in 01040301.xhp is only "change default template, but the reference from 01040300.xhp is also about customizing templates. * update to <h1>,<h2> ( source/text/shared/optionen/01040301.xhp ) with this patch, 01040301.xhp is not used by other files now. Could possibly be deleted. * update to <h1> Change-Id: I00b2ac9f9aad3865172ed985e3394492fa122d46 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107296 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-12-10we can use sal_uInt8 instead of intCaolán McNamara
Change-Id: Iefc668fa77ae0cf6ca373360a2512a3776981dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10jsdialog: enable define/manage named ranges dialogsSzymon Kłos
Change-Id: I6783ec5be11255608e694e43a32ec3c6d4de468e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107394 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107464 Tested-by: Jenkins
2020-12-10tdf#41466 DOCX import: fix VML v:shape/v:textboxRegényi Balázs
VML v:shape/v:textbox element was imported only as a text frame, losing (otherwise recognized) preset shape geometry, i.e. replacing a callout bubble (wedgeRectCallout) and other special shapes with a plain rectangle. Thanks to Attila Bakos for the initial help. Change-Id: I03a608822ed54a20ed07406a08c3539e72958f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105299 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-10tdf#138688 tdf#124646 sw: fix crash at pasting Calc dataLászló Németh
.. in a table before a numbered paragraph. Dispatcher calls of the workaround for tdf#124646 missed the temporary table in this case, selecting + copying nothing and after that trying to paste the same non-native Calc data again, resulting infinite recursion. Replacing FN_CHAR_LEFT with FN_LINE_UP solved the problem (FN_CHAR_LEFT selected the numbers of the numbered list instead of the temporary table). Fixing the fragile dispatcher calls, now we check the selection of the temporary table to avoid similar crashes. Unit tests are added for the fix, also for the original problem of tdf#124646 (avoid copying hidden rows from Calc, e.g. copying only visible result of a filtering). Regression from commit 0c3ac02d8a3c7ea50ae262daf134c28df5c8b343 (tdf#124646 Don't paste hidden rows of Calc sheets into Writer tables). (Note: to check/show the fix of the crash manually, run the test with $ (cd sw && make -srj8 UITest_sw_table UITEST_TEST_NAME="sheetToTable.sheetToTable.test_tdf138688" SAL_USE_VCLPLUGIN=gen) adding import time time.sleep(5) to the called function of sheetToTable.py) Change-Id: I7b90af8219d6fd00b75d91f7c92fff5744373cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107508 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-10use size_t instead of sal_uLongCaolán McNamara
Change-Id: Id0b5f95716ba0bd14f634d927ffb7a71c0bc5767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10std::vector seems a more natural containerCaolán McNamara
Change-Id: I5256e05a6f3c4853a81d9c4a94bbcbf27f0a3ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10tdf#138450 BitmapEx.Replace() is not workingCaolán McNamara
since... commit abd42bdc86904d1b310e8298393c887e0c195499 Date: Thu Nov 12 14:50:16 2020 +0200 tools::Long->sal_Int32 in vcl filters Change-Id: I4a74416547f35a9b5b3fe606de6938245d3ec6c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107503 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10salvtables.cxx isn't in clang-format/excludelist for 7-1Caolán McNamara
but is in master, which was a surprising find on a backport, keep it in master too seeing as its just a diff in new changes Change-Id: I4bc38c366fe2533b943499c877074173bd5e516e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10Online: "Copy hyperlink location" feature improvement.gokaysatir
Lambda functions are replaced with class pointers. Change-Id: I48628d3105533aad2463bd8ade1f65cf5b154b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104058 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-12-10flyincnt: Modify no moreBjoern Michaelsen
Change-Id: I1500f5944a5a9504ef8c9c48c2d43da710de3fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107512 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-10pdfium: no need to use FPDFPageObj_GetBounds() directlyMiklos Vajna
Change-Id: I74f968e0b76a2992d5f07524a29a7c8600983d3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 13cd181da4668aba0ba1e60c928d91c4892754db - Related to: tdf#138662 improve help for renaming Calc sheets * move <tip> and <note> to better location * move prefix explanation to better location with own <h2> - drop links to page that does not give any help about prefixes and add menu command sequence to get to the relevant place. * Revise explanation about naming (drop select, add double click) + add explanation about single quote restrictions. - drop warning about WindowManager (which was added in 2006) + add <literal> to restricted characters + add new <h2> headings to clarify page content * convert one "note" to a paragraph under a new heading * where paragraphs were changed, add <menuitem> as apppropriate * update to <tip>,<note>,<h1> Change-Id: I8a0e97b871331e0e3300a68252ae4096500aeeb1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107380 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-10flylay: Modify no moreBjoern Michaelsen
Change-Id: I1b001b71cf313b804960d91dd96bef036c610303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107444 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-09Fix loplugin:stringviewparam handling of comparison operatorsStephan Bergmann
Change-Id: I58456efb9588b544d998ac6a4c27d55457280742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107510 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09Improve loplugin:stringview diagnostic messagesStephan Bergmann
Change-Id: If1b94de205fb9c1cc0491603f27073dfde67a485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107511 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09tdf#138741 XLSX export: fix crash in setSkipUnusedFileIdsAttila Szűcs
Changed size of maConvertFileIdToUsedFileId vector to the same as maSrcFiles size. Some external references was not inserted into maRefCells, that resulted a smaller maConvertFileIdToUsedFileId as was needed. This crash was caused by: tdf#87973 XLSX export: fix lost file names in modified links f85d860ccbebd99bc128218148e2992c9415f221 Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1501f5222483bf3e9e41c9e921a024320231dce8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107434 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-09tdf#138778 add has_child_focus which considers a related popup a 'child'Caolán McNamara
Change-Id: Iab23e399f2650ece702fb1f62d1387acca472b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-10 09:42:34 +0000