summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-22tdf#45904 Rename test object for GlobalSheetSettingsJens Carl
Rename test object ScSpreadsheetSettingsObj to ScSpreadsheetSettings. Change-Id: Ia70cc82e0ee20571ad029590db735f932e5c7958 Reviewed-on: https://gerrit.libreoffice.org/51723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22loplugin:useuniqueptr in DrawDocShellNoel Grandin
Change-Id: I051fb0523622ef2ab93639f0d28b4dc5f4efdbac Reviewed-on: https://gerrit.libreoffice.org/51671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SmDocShellNoel Grandin
Change-Id: I1183edd427da0ee31547ebdad572ec5cac3fb33f Reviewed-on: https://gerrit.libreoffice.org/51670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SdTransferableNoel Grandin
Change-Id: I7ace5ab37ce6df240d3b7fbe8c0fd12618fa3031 Reviewed-on: https://gerrit.libreoffice.org/51669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in ScColumnNoel Grandin
Change-Id: If2f8e1f730fabaf124e515dbe58ec5d755d1e57b Reviewed-on: https://gerrit.libreoffice.org/51667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SwDefTOXBase_ImplNoel Grandin
Change-Id: I114cbf54420d8fb017e1ec5530d40413d8c34ed4 Reviewed-on: https://gerrit.libreoffice.org/51666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SwAccessibleParagraphNoel Grandin
Change-Id: I2648add548c214f7d448941db39622ca660f6fab Reviewed-on: https://gerrit.libreoffice.org/51665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SwAccessibleMapNoel Grandin
Change-Id: I47b64b30123918fb0d8251ae7ba113775cfb3625 Reviewed-on: https://gerrit.libreoffice.org/51664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in ScDPResultMemberNoel Grandin
Change-Id: Icf8a52bcf233994bc49a5d9094196154f20602ea Reviewed-on: https://gerrit.libreoffice.org/51663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in DrawViewShellNoel Grandin
Change-Id: I5125e973fbda75b2c7e52e294db74bc3bd5e0bd9 Reviewed-on: https://gerrit.libreoffice.org/51662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in PresenterTextView::ImplementationNoel Grandin
Change-Id: Ie5641d3a4b0791aa4ae4f126afeb3ec6f9760909 Reviewed-on: https://gerrit.libreoffice.org/51661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22move btndlg from vcl to toolkitCaolán McNamara
Change-Id: Iecc528bce1df9a67af43f9d9dd3ed41af24b0fad Reviewed-on: https://gerrit.libreoffice.org/51713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-22move MessBoxStyle to last consumerCaolán McNamara
Change-Id: I1edbf247999cd59cee4d268ed686e8ed9b61d99f Reviewed-on: https://gerrit.libreoffice.org/51712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-22weld OSQLMessageBoxCaolán McNamara
Change-Id: Idbdb07bc342a91695d15ea1a87d1863798ca34b0 Reviewed-on: https://gerrit.libreoffice.org/51676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21lok: be informative and exit when tilebench fails to initializeAshod Nakashian
Change-Id: I11078e36aafc715b7103998a17e0cb01926b8e97 Reviewed-on: https://gerrit.libreoffice.org/51618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-21block buttons with click handlers from setting a responseCaolán McNamara
which is effectively what vcl buttons do Change-Id: Ic4374b3a761b954548ff10d654422d14ef6e0763 Reviewed-on: https://gerrit.libreoffice.org/51710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21add get_widget_for_response supportCaolán McNamara
Change-Id: I49abb5e6621dbfe2fc92ef9c2a47568c62c372c2 Reviewed-on: https://gerrit.libreoffice.org/51709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21tdf#114749 Replace fonts in templatesLaurent BP
Replace Arial with Liberation Sans Replace Times New Roman with Liberation Serif (except if does not make sense) Replace Roboto Bk with Liberation Sans Reduce number of fonts declared Change-Id: I967818dd6079d43c9b0616541c6c7a7ddac13886 Reviewed-on: https://gerrit.libreoffice.org/51464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-03-21Updated coreOlivier Hallot
Project: help 4a1008b6ee7043031e9b050adcf836c2f0c88a47 Deploy videos in New Help (WIP) Add YouTube videos in New help. add makefile NOTE: <object> is not rendered in old help. NOTE2: Removed online objects from offline help Change-Id: I829fe1858002a454417d36d0651fe49097e008d4 Reviewed-on: https://gerrit.libreoffice.org/51679 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-21tdf#115117: Fix PDF ToUnicode CMAP for ligaturesKhaled Hosny
Move the glyph to character(s) mapping to CommonSalLayout where we have enough information to do this properly. This correctly handles ligatures at end of run that wasn’t handled before, and also fixes a bug in the PDF writer code when there is more than one ligature in the run (it forgot to clear aCodeUnitsPerGlyph vector after each iteration). Also drop the “temporary” fix for rotated glyph from 2009 that does not seem to be needed now (the document from that bug exports correctly after this change). Change-Id: I5b5b1f4470bbd0ef05cbbc86dfa29d2ff51249ea Reviewed-on: https://gerrit.libreoffice.org/51617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-21Fix lifetime of referenced-by-reference EnhancedCustomShape2dStephan Bergmann
...that is created as argument to EnhancedCustomShape::FunctionParser::parseFunction (and referenced from data reachable from aExpressNode), but still referenced during following aExpressNode->fillNode call. Reintroduce the aCustoShape2d variable that had been removed with 86c4672f4600daf19238ef25377406f445d9453a "OperationSmiley: Secured quite some places using CustomShape", causing the regression that in UBSan builds e.g. CppunitTest_sc_subsequent_export_test would fail with > /svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:261:57: runtime error: member call on address 0x2b1295491180 which does not point to an object of type 'EnhancedCustomShape2d' > 0x2b1295491180: note: object is of type 'SfxItemSet' > 1a 04 00 01 10 99 42 cb 12 2b 00 00 10 2d 8f 00 40 60 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SfxItemSet' > #0 0x2b131efeb12d in (anonymous namespace)::EnumValueExpression::fillNode(std::__debug::vector<EnhancedCustomShapeEquation, std::allocator<EnhancedCustomShapeEquation> >&, EnhancedCustomShape::ExpressionNode*, unsigned int) /svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:261:57 > #1 0x2b131f01f061 in (anonymous namespace)::BinaryFunctionExpression::fillNode(std::__debug::vector<EnhancedCustomShapeEquation, std::allocator<EnhancedCustomShapeEquation> >&, EnhancedCustomShape::ExpressionNode*, unsigned int) /svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:632:40 > #2 0x2b12e0915a5c in ConvertEnhancedCustomShapeEquation(SdrObjCustomShape const&, std::__debug::vector<EnhancedCustomShapeEquation, std::allocator<EnhancedCustomShapeEquation> >&, std::__debug::vector<int, std::allocator<int> >&) /filter/source/msfilter/escherex.cxx:2426:62 [...] when accessing the already-dead EnhancedCustomShape2d object. Change-Id: I8f3e598f81e8e01e2505483437025ddd4cee2ec9
2018-03-21tdf#116241 Customizing value highlighting colorsSzymon Kłos
Change-Id: I5d77e6207d1e29326282d7184c9348e59292977a Reviewed-on: https://gerrit.libreoffice.org/51653 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-21Move UNO API property testers header fileJens Carl
Move the header file form the global include path include/test to the module-specific path test/inc. Change-Id: I72c1f3b420bc387f4f5b9ab75f30f0e8462c1b75 Reviewed-on: https://gerrit.libreoffice.org/51682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-21Resolves: tdf#116429 unwanted extra step in undo insert shapeCaolán McNamara
Change-Id: I23065275baa60a09f2a3c15513e3f2b8160e2bf0 Reviewed-on: https://gerrit.libreoffice.org/51706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21add optional helpid to add_buttonCaolán McNamara
Change-Id: I9606d0788c78397feb0840463991c5498e759b5a Reviewed-on: https://gerrit.libreoffice.org/51703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21move these down to baseCaolán McNamara
Change-Id: I8489abb3d6b7115b19cff9522dc49589e7d6a9c4 Reviewed-on: https://gerrit.libreoffice.org/51702 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21tdf#115683 there are other cases of dialogs before document loadCaolán McNamara
Change-Id: I97ddbb528927fecb66072b42baa90272de2af39a Reviewed-on: https://gerrit.libreoffice.org/51704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21support both vcl and weld in genericunodialog for interimCaolán McNamara
Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f Reviewed-on: https://gerrit.libreoffice.org/51699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21Don't initialize data for --enable-dbgutil onlyStephan Bergmann
This had originally been introduced with 0f6149593129c3d208f07d0d017dec0c71760778 "Make it easier to catch code that assumes SalBitmaps are created pre-cleared". But it only made it harder to find the issue reverted with ebe247642d85d39b6e1ffae3cf92c31748f2e983 "Revert 'tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned'". Change-Id: I344e1ab4b390baa8364ade5fd2737a12708facdc
2018-03-21Revert "tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned"Stephan Bergmann
This reverts commit 460f39e687393b3a8906d2adc3e8f7a0c749851a. For one, it had started to make bitmap checksum equality check in svx/qa/unit/XTableImportExportTest.cxx, CppunitTest_svx_unit, fail most of the time in macOS --disable-dbgutil builds, as the bitmap checksum is now computed also over padding bytes containing random values (but --enable-dbgutil initializes those bytes). And why would fixing tdf#116213 for Windows require touching the macOS-specific code, anyway? For another, tdf#116213 comments 6 and 7 report further problems that are likely linked to this commit. Change-Id: I3e158813ab89a1ead3780abbf6b120ec52660231
2018-03-21Turn on clang-format for these filesMiklos Vajna
I (tried to) keep these files consistent locally with astyle in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies in these files doesn't happen again. (On the flip side, it's great to see that now others also touch this PDF/pdfium code. :-) ) Change-Id: I6065eab77c584197a82fe48e7d3e81b445106efd Reviewed-on: https://gerrit.libreoffice.org/51701 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21Avoid undefined floating -> integer conversion in TIFF importStephan Bergmann
...as started to happen when reading (invalid) filter/qa/cppunit/data/tiff/fail/RC4-crash-7.tiff in CppunitTest_filter_tiff_test after c81765629bf0f7b3a0a8bb1dbed599a7f49ee58c "coverity#1266496 Untrusted loop bound": > /filter/source/graphicfilter/itiff/itiff.cxx:270:47: runtime error: value -nan is outside the range of representable values of type 'int' > #0 0x2b5bae7ad928 in TIFFReader::ReadIntData() /filter/source/graphicfilter/itiff/itiff.cxx:270:47 > #1 0x2b5bae7b0017 in TIFFReader::ReadTagData(unsigned short, unsigned int) /filter/source/graphicfilter/itiff/itiff.cxx:320:27 > #2 0x2b5bae7e80f3 in TIFFReader::ReadTIFF(SvStream&, Graphic&) /filter/source/graphicfilter/itiff/itiff.cxx:1377:21 [...] With an error-reporting concept apparently missing here, just convert such out- of-bounds values to zero. (And make ReadDoubleData not go though the value- limiting ReadIntData for floating types.) Change-Id: I6e53e468e6b98fb7a7d5fd7f3336ee2168f76e30 Reviewed-on: https://gerrit.libreoffice.org/51700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21ofz#7043 already registeredCaolán McNamara
Change-Id: Ic94891c82944d04fe3391c0bd0731a6e3e4373e0 Reviewed-on: https://gerrit.libreoffice.org/51691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21coverity#1430229 Unchecked return valueCaolán McNamara
Change-Id: I100125d723a83ec7846cf9651ecebd3df697ce58 Reviewed-on: https://gerrit.libreoffice.org/51695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21coverity#1430228 Dereference after null checkCaolán McNamara
Change-Id: I15b63e0adba812a84517bae086548441edfab7dc Reviewed-on: https://gerrit.libreoffice.org/51697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21fix bug in SwFEShell::SetColRowWidthHeightNoel Grandin
which has been there ever since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 Date: Mon Sep 18 23:08:29 2000 +0000 initial import since ColLeft==0, the expression "eType & ColLeft" would always evaluate to false. Change-Id: Iab9e96e29b37242ff814f9cd3a7dcf38ac77a223 Reviewed-on: https://gerrit.libreoffice.org/51644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21coverity#1430232 Dereference before null checkCaolán McNamara
Change-Id: If15fe7c5f523a1c29a3d399a7b072180f9642439 Reviewed-on: https://gerrit.libreoffice.org/51694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21CppunitTest_services: check service impls support properties as advertisedStephan Bergmann
...blacklisting existing violations for now (to be cleaned up) Change-Id: Ie94de44d44e04ed45c0ae10d518157da76332bda Reviewed-on: https://gerrit.libreoffice.org/51654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21Remove redundant assertMike Kaganski
We had just returned on this condition Change-Id: I822a4fe62e24442800ca17b404862818095e641d Reviewed-on: https://gerrit.libreoffice.org/51685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-21Don't generate filters with empty IncludesMike Kaganski
Avoids VS warnings: > smoketest\Library_smoketest.vcxproj.filters : warning : Unable to > read the filters file "Library_smoketest.vcxproj.filters". Please > unload the project "Library_smoketest.vcxproj" to be able to edit it. > The required attribute "Include" is empty or missing from the element > <Filter>. Change-Id: I0f02e837823a5e7a0355fd0f895f00c63a5df6fc Reviewed-on: https://gerrit.libreoffice.org/51684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-21Fix typoAndrea Gelmini
Change-Id: Ib9aac2a629352a25d80061c2d4ca420e8144a94b Reviewed-on: https://gerrit.libreoffice.org/51683 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21drop debugging testCaolán McNamara
Change-Id: I29f954684dd0e42f497bb4c166288217058171d9 Reviewed-on: https://gerrit.libreoffice.org/51680 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21loplugin:emptyifStephan Bergmann
Change-Id: If113f176e6ec590d578f5225323f1efda77b7c23 Reviewed-on: https://gerrit.libreoffice.org/51674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21loplugin:emptyifStephan Bergmann
Change-Id: I79aee732d3437d13894a9b91506225b76b3a16be Reviewed-on: https://gerrit.libreoffice.org/51658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21loplugin:unreffunStephan Bergmann
Change-Id: I7ed192011a930ea871d7efd2d966e6b746e2da3f Reviewed-on: https://gerrit.libreoffice.org/51656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21sw: fix some IWYU warningsMiklos Vajna
Change-Id: I3682cc475de8342e4cdf122a35f6c1cfddd4c01e Reviewed-on: https://gerrit.libreoffice.org/51677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-21vcl: support rendering multiple PDF pages to bitmapAshod Nakashian
Change-Id: Id42ecabcad90dde84475a01e5df4ed94f221f5ce Reviewed-on: https://gerrit.libreoffice.org/51255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-21pdf: refactor poppler importerAshod Nakashian
This paves the way to add pdf parsing via pdfium. Change-Id: I384687bcdce3011682ebeec18ee3de44759feb1a Reviewed-on: https://gerrit.libreoffice.org/51254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-21tdf#68290 cursor moves with Enter in protected sheettagezi
Change-Id: I2ac848f1799d94f521628480664cdb579417772a Reviewed-on: https://gerrit.libreoffice.org/49085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21weld OExceptionChainDialogCaolán McNamara
Change-Id: I0092d2741055ab89ed4a97db9b8fad56144024c2 Reviewed-on: https://gerrit.libreoffice.org/51678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-18 04:51:07 +0000