summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-08-19cid#1616525 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I508df311ec1785be11077c1f657be57b84ed8cfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-19tdf#150461: deselect all when clicking outside of all list itemsMike Kaganski
Change-Id: I72185ccee716825b5e7b1bb7ae6bddb533604f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171988 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-19Fix typoAndrea Gelmini
Change-Id: I3277386244f3a00c2756525829924870e3a3d2bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172030 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-19Fix typoAndrea Gelmini
Change-Id: I0c09927dd928281a9a006bd03872b5484d6151ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171963 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-19Fix typoAndrea Gelmini
Change-Id: I3fac3dcde5aad559dcbc4c64aeedfd0f6fc1cd6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172029 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-19tdf#147021 Use std::size() or std::ssize() instead of SAL_N_ELEMENTS()Deepanshu Sharma
Change-Id: Ib32452077e625395e29569f56c55c6cb6285d82b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171626 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-08-19Remove now useless include in packageArnaud VERSINI
Change-Id: I8085fb69a752e69820113cf3074bf5e4e7c942de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172020 Reviewed-by: Arnaud Versini <arnaud.versini@pm.me> Tested-by: Jenkins
2024-08-18tdf#162466 calc: added handling of firstHeaderRow="0" on xlsx filesJaume Pujantell
Calc ignored the firstHeaderRow attibute on xlsx pivot tables causing it to add an extra row when firstHeaderRow="0". And then changed the value to "1" on export. Some xlsx pivot table filter tests have been changed because removing this extra row changed the position of the values. Change-Id: I95b722e4f4cc40083c752a045df4ffe37e7159c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171836 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171869 Tested-by: Jenkins
2024-08-18tdf#154018: Change corners to points for polyline and polygon context stringsTH Huang
Change-Id: Ic6b0835238e463e5c155b01a292a5eed72e446d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171743 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-08-18Emscripten: Document how Qt builds its own freetype, but we link against LO'sStephan Bergmann
Change-Id: I6413c64db3d50f163ee9cc4feda395a54aab3cf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172012 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-08-18Emscripten: Increase the main thread stack sizeStephan Bergmann
At least when LO tries to download a document and UUIInteractionHelper::handleErrorHandlerRequest wants to show a MessageDialog via Qt, the stack grows relatively large, and gray_convert_glyph (workdir/UnpackedTarball/freetype/src/smooth/ftgrays.c) alone allocates on the stack a buffer of size FT_MAX_GRAY_POOL * sizeof(TCell) = 1024 * 16 = 16K, which causes (silent, due to no -sSTACK_OVERFLOW_CHECK=2) stack overflow. So (somewhat randomly) double the size of the main thread stack to 128K; but, at least for now, keep the default value of 64K for other threads (which would otherwise inherit the explicitly set -sSTACK_SIZE value via the -sDEFUALT_PTHREAD_STACK_SIZE=0 default). Change-Id: I96583f4af93c84b15c67f310068c5631fb129d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172011 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-18Drop obsolete commentStephan Bergmann
...after 6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4 "Emscripten: Move the Qt event loop off the JS main thread" Change-Id: Iea9cb74fa2fc3dd036ee865e1bd8ede93fb33c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172010 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-08-18Simplify a bitMike Kaganski
Change-Id: I7b927cd3dade5bc73039541c3ec8c72a9de400b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172009 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18Add missing property to com.sun.star.graphic.MediaProperties serviceMike Kaganski
An omission from commit 8484e52675052848d2d3ffe07378ce2ad29fd288 "tdf#117427 missing API for determining and loading linked graphic", 2018-05-12, that introduced it. Change-Id: Ibf4c754931f813c5234daa5f7b7c907ed84efdef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172008 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18Emscripten: Clean up SolarMutexStephan Bergmann
...before disappearing through the QApplication::exec() hole, or else the SolarMutex would remain locked forever on the application's main thread. This requires changing SalInstance::ReleaseYieldMutexAll() to SalInstance::ReleaseYieldMutex(bool all). (Further recursive locking of the SolarMutex via SolarMutexGuard instances that would be present on the call stack leading up to the call to QApplication::exec() would be released during the stack unwinding, so just undo the one acquiring done in InitVCL, not all of them.) Change-Id: I9ef57abb7da7f840999700e4eaeeefd2da784645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171956 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-18Those XTest::is... methods return boolean, not anyStephan Bergmann
Change-Id: Ie76e3551cac714fee56a087aed6aa851c4569209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171957 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-18LOKit: Enable the "Interaction..." command for Impress.Hubert Figuière
Also enable the dialog for JSDialogs Fix the layout of the dialog. Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I4581da34921eb355ce8f59d7bfdf2f7d5d7493f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18cid#1556978 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556976 COPY_INSTEAD_OF_MOVE cid#1556965 COPY_INSTEAD_OF_MOVE cid#1556956 COPY_INSTEAD_OF_MOVE cid#1556953 COPY_INSTEAD_OF_MOVE cid#1556946 COPY_INSTEAD_OF_MOVE cid#1556934 COPY_INSTEAD_OF_MOVE cid#1556897 COPY_INSTEAD_OF_MOVE Change-Id: I6cf90b385042e7ca7d07138c28c0e95f97de8f61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171983 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-18cid#1557699 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557435 COPY_INSTEAD_OF_MOVE cid#1557307 COPY_INSTEAD_OF_MOVE cid#1557209 COPY_INSTEAD_OF_MOVE cid#1557192 COPY_INSTEAD_OF_MOVE cid#1557184 COPY_INSTEAD_OF_MOVE cid#1557183 COPY_INSTEAD_OF_MOVE cid#1557171 COPY_INSTEAD_OF_MOVE cid#1557150 COPY_INSTEAD_OF_MOVE cid#1557148 COPY_INSTEAD_OF_MOVE cid#1557123 COPY_INSTEAD_OF_MOVE cid#1557118 COPY_INSTEAD_OF_MOVE cid#1557116 COPY_INSTEAD_OF_MOVE cid#1557103 COPY_INSTEAD_OF_MOVE cid#1557078 COPY_INSTEAD_OF_MOVE cid#1557075 COPY_INSTEAD_OF_MOVE cid#1557071 COPY_INSTEAD_OF_MOVE cid#1557070 COPY_INSTEAD_OF_MOVE cid#1557067 COPY_INSTEAD_OF_MOVE cid#1557049 COPY_INSTEAD_OF_MOVE cid#1557046 COPY_INSTEAD_OF_MOVE cid#1557042 COPY_INSTEAD_OF_MOVE cid#1557036 COPY_INSTEAD_OF_MOVE cid#1557030 COPY_INSTEAD_OF_MOVE cid#1557024 COPY_INSTEAD_OF_MOVE cid#1557012 COPY_INSTEAD_OF_MOVE cid#1557009 COPY_INSTEAD_OF_MOVE cid#1557008 COPY_INSTEAD_OF_MOVE cid#1557004 COPY_INSTEAD_OF_MOVE cid#1556999 COPY_INSTEAD_OF_MOVE cid#1556992 COPY_INSTEAD_OF_MOVE cid#1556987 COPY_INSTEAD_OF_MOVE cid#1556984 COPY_INSTEAD_OF_MOVE cid#1556981 COPY_INSTEAD_OF_MOVE Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18Related: ofz#70815 Timeout, don't need this copyCaolán McNamara
Change-Id: I8d870a6e6743b98da3d0a173cff12748d513d8d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18Simplify a bitMike Kaganski
Change-Id: Ibe34a1c17d856146d191e784af06b8cb6301b912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172007 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18Related: tdf#132064 Use set to clear the With internal variableMike Kaganski
In commit f3f46b5fe729876d128f63f7ab158954ab6657d7 (tdf#132064: make With statement only evaluate its argument once, 2024-08-17), I made a mistake, clearing the internal variable in the end of SbiParser::With using an Erase call, which does not just clears the variable itself, but destroys the underlying object, which is not what we need. I don't know how to refer to a global Nothing object to assign to the variable; so just create an own internal Nothing, and use it in the assignment. Change-Id: Ic8ce52e0402d8461a9b9e4ee07614c4f0a46a95e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172006 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18tdf#150458: evaluate for loop's end and step once in VBA support modeMike Kaganski
As required by [MS-VBAL], and actual VBA implementation. It is a question if we also need to change it likewise in other modes (normal, compatible) - see tdf#150460. Change-Id: I1e83d57fe4be3bf264a64fe977909cf7684bc798 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172005 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-18Revert "Workaround a non-antialiased output on one of Windows buildbots"Mike Kaganski
This reverts commit 7a08c89b5af8f98045ad825ace6be2f035ad91af. Reason for revert: the cause of the failures on tb88 was low quality of RDP connection settings, which is fixed now. The bug that it affects the export still needs a separate fix. Change-Id: I36aece47108781abc3578092d5fb479a56fce050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171986 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-18tdf#156926 related: Ability to Delete all images in WriterJim Raykowski
Adds the ability to delete all content of a content type, excluding the Headings content type, using the content type's context menu in Writer Navigator. Change-Id: Ie5666b6b9b7ef2f3cdb63957b1b42b236b8674db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170643 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-08-17tdf#162304 layoutInCell: native ODT handling from top of PRINT_AREAJustin Luth
Making ODF work the same way that MSO does. Since this was the intention all along, I'm not going to bother with a compat flag for older documents. It is highly unlikely that a native ODF user would have all these: -turned on follow text flow -used "page text area" when trying to orient from top of cell (more likely to use "entire page" if they do associate page<->cell. -set a larger border spacing (since default is a miniscule 0.05cm). -this code-path is only in effect with FROM_TOP, an unlikely combination with "page text area". Change-Id: I979e6e0526102004c56285db6e7479c0ff6d660e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171610 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17Move the check out of the loopMike Kaganski
Change-Id: I151ac6399d2cc5870971f258614480fcbdff5c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-17tdf#162211 tdf#153909 layoutInCell vml: don't discard layoutInCellJustin Luth
This is just a clean-up patch, doing for the VML code path what was handled for drawingML This effectively reverts my patch for tdf#153909 commit ad0266eb84eafa32ccc4e0ddf3c6392860bc9b13, but it depends on all the changes made for tdf#162211. Change-Id: I3b5942c406ee73e91cdff1f1f73a2b92e0688474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171609 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17tdf#91632 doc import layoutInCell: vert page->margin, *->topJustin Luth
The same thing was done early in this series of patches for DOCX Microsoft's layoutInCell is very buggy for vertical orientation. So, instead of making our own implementation just as buggy, instead, alter the document so that the settings match the implementation. That way if MSO ever decides to re-fix layoutInCell, we are in a position to easily avoid the mapping to accommodate a new compat version. make CppunitTest_sw_ww8export4 \ CPPUNIT_TEST_NAME=testTdf91632_layoutInCellD Change-Id: I6d1a6c341dc1fdd51facb965c75f7d2578973eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171975 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17tdf#162211 tdf#160077 layoutInCell: use row margin for MSOLayoutJustin Luth
I think the bottom margin functions might be buggy, so I'm glad I don't need to use them (since MSO only does vertical layout against the top). This is only needed for "from top", because the only other choice, "top", is based on the print area, while this function uses GetFrameArea. GetFramePrintArea is invalid, so that can't be used directly. make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf160077_layoutInCell make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf160077_layoutInCellB Before this patch could pass sw.check, I had to fix the following unit test in a previous patch make CppunitTest_sw_layoutwriter2 CPPUNIT_TEST_NAME=testTdf116256 Change-Id: Iac487b94c81ce44165356f447eb37964da1985ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171507 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17tdf#162211 tdf#158384 layoutInCell: doTextBoxPositioning betterJustin Luth
by simply honouring FollowTextFlow as the comment states. I needed to look into this because of a failing unit test. I can't say I understand why sync needs to lay out two things instead of just laying out one and copying the screen position, but bug 158384 indicated that the wrong value was added, so I looked for alternatives to use instead of nLeftSpace. A better sounding alternative was textbox spacing to border, but that is already taken into account. Then I realized a negative offset was being applied against the cell edge - which is only allowed for bWrapThrough. Unfortunately, that once again breaks the unit test I have been trying to accommodate. I can only assume that the unit test's pressuppositions are false. So I'm changing the unit test to test things that are certain! make CppunitTest_sw_layoutwriter2 CPPUNIT_TEST_NAME=testTdf116256 Given how wonky textbox sync is, I'm not confident that ANYTHING here is actually correct. Change-Id: I2e73b7345b4d4c3da78d62644032cb573dc6821e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171577 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17tdf#132064: make With statement only evaluate its argument onceMike Kaganski
This is implemented by creating a unique variable at entry of the block, using it as the "with parent", and clearing afterwards. It uses an invalid name, so can't be used by a user. The generation of the bytecode is done in compatible way; only existing opcodes were used (which was the reason to choose the implementation with a variable), so compiled binaries in password-protected libraries are expected to work with older versions. The functional changes are: 1. The argument of With statement is evaluated immediately at the start of the block; previously, it evaluated first time, when the leading dot operator was used, and could even be never evaluated, if the operator wasn't used. This is consistent with VBA, and has a benefit that the lifetime of the object is guaranteed to cover the whole block (might be useful if other block statements depend on the object, similar to Python's 'with' statement contexts). 2. The primary goal of the change: it is only ever evaluated once, no matter how many times was the dot operator used in the block. Change-Id: I4dbd520538a57e3668ab706e8f45740db5d33393 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171980 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-17tdf#158556 improve FindNumRulePtrNoel Grandin
we dont need to scan the table if the entry does not exist in the map Shaves 2% off the load time of a large DOCX file Change-Id: Idf001487ae4a25a37f63218f1e98dbd6cc2a6ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-17cid#1606639 silence Overflowed constantCaolán McNamara
and cid#1606583 silence Overflowed constant Change-Id: I7cbd62b45126d66a4b9eeb2e2b61a7625c177708 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-17cid#1616506 Resource leakCaolán McNamara
and fixup headers Change-Id: I0a3e5f71f1dbfa9c1119c5b4bef634f27797927d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171972 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-17cid#1616505 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6521d25f7763ebe7f1b0d1213ab641c284c5e228 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-17impress/draw: make the SdActionDlg (Interaction...) dialog asyncHubert Figuière
Make SdAbstractSfxDialog_Impl support async for all. Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I9e2df8369f8f1fde252d079464a188c155a26057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171781 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-17tdf#160459 embedded starmath doesn't fit inside allocated areaCaolán McNamara
much to and fro with MapModes and rounding issue obscured that fundmentally that the 'etched-out' GtkScrolledWindow frame requires space which eats into what is available to show the formula, and in embedded mode we want the editing area to be equal in size to the area used for the preview. Change-Id: I1d126ddcc953131cf4add7da58ccd89e7fa86b66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-17Support for non-AA text on WindowsMike Kaganski
In commit 3ecd8f19a91ed7141304a2080fb11612b5ff30b3 (vcl cairo text renderer: support non-AA text, 2018-07-26) and its follow-up commit e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966 vcl: add a flag to determine if AA of fonts is used from the system, 2018-07-28), non-antialiased text got supported in bitmap export using cairo. This change makes that support available on Windiws, including Skia. Change-Id: I1fae726539347f826e2d62246d35315e7954cf83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171967 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-17chart2: move histogram calcualtion into HistogramChartTypeTomaž Vajngerl
Histogram is special in the way that the input data is not the data that is being shown in the chart - it needs to be calculated separately usign the input data. First we put the calculation in the (Histogram)DataInterpreter but that is not a very good place to calculate as we don't have the access to the chart properties and can't influence the calculation with it. This change puts the calculation into (Histogram)ChartType instead and will trigger the calculation when the data is requested. This is the first case of such a thing where we calculate the data on demand from the input data, so we will probably need further changes the chart code to better support calculated data sequences. Change-Id: Ia66f9d245f7d42973c728e1dd9a406b66eb2610a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171952 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-08-17tdf#161230 - Pie-of-pie and bar-of-pie chart data labels are misalignedKurt Nordback
Implementing label support for of-pie charts. This involves using the existing pie label code with an added horizontal shift, and adding special (simple) handling for the bars in bar-of-pie. This also fixes tdf#161228 Change-Id: Ifc7c1f28548caf216aba5c7dc411d05a0c9d8726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169566 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-17Fix wrong = where == was intendedMike Kaganski
Introduced in commit cd740ff560a88a62bc79f5ea5b92bdadf71ba728. Thanks Caolan for spotting this! Change-Id: Ieb046013f7bd09b539b01b5d360f52a9cb39e245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171783 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-17tdf#161741: LO crashed on redo of header changes: unit testJustin Luth
make CppunitTest_sw_uiwriter8 CPPUNIT_TEST_NAME=testTdf161741 Change-Id: I3f62fa600d4c1392f76fff02d51443ed51729e00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171960 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-17OnCalculate sheet event is fired before, not after recalculationEike Rathke
Change-Id: Ida6455457d40b06d90028c5c294a42e857fb3939 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171908 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-08-16feat(invert): Allow inverted background on initSkyler Grey
Previously for Online there was no way to save the background invert state and reload it. Worse, when someone changed the state it would become the default for new document loads. This patch allows Online to specify whether it wants the background to be inverted, which should allow smooth tab refreshes while also avoiding mingling state from different people. There is a change to online to support this here: https://github.com/CollaboraOnline/online/pull/9652 Change-Id: I8c22c03d3b4589736d48509004f7789dd5166389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171955 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-16Workaround a non-antialiased output on one of Windows buildbotsMike Kaganski
Seen as C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sd/qa/unit/PNGExportTests.cxx(1006) : error : Assertion Test name: testTdf162259::TestBody greater assertion failed Expected greater than: 350 Actual : 271 See e.g. https://ci.libreoffice.org/job/gerrit_windows/183201/consoleFull#-530547713d893063f-7f3d-4b7e-b56f-4e0f225817cd Change-Id: I0042138a728e1ca08c2b142db7f97635bffd7d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-16Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to a2c5184f0ddc6b4b2c86889a536655aa8ec19472 - tdf#162483 Update instructions for enabling remote control in Remote User Guide In text/simpress/guide/impress_remote.xhp - Updated instructions to reflect the current UI options - Replaced the outdated screenshot with the one shown in text/simpress/01/06080000.xhp, which depicts the current location of the "Enable remote control" checkbox. - Added a link to the Slideshow Settings page in the "Related Topics" section In text/simpress/01/06080000.xhp - Added self-link and section tags so that content can be easily embedded in other pages. Change-Id: I1f7f488d0678d28d69543f45f066884e81186c4b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171958 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-08-16sfx2: fix crash in SfxObjectShell::IsHelpDocument()Miklos Vajna
Seen while running the online.git unit-quarantine testcase: #0 std::__uniq_ptr_impl<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::_M_ptr() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:191 #1 0x00007f2f25fa398a in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::get() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:462 #2 0x00007f2f25f9fae2 in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::operator->() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:455 #3 0x00007f2f25f8bbd2 in SfxMedium::GetFilter() const (this=0x0) at sfx2/source/doc/docfile.cxx:3272 #4 0x00007f2f260067ce in SfxObjectShell::IsHelpDocument() const (this=0x5c6adc0) at sfx2/source/doc/objcont.cxx:589 #5 0x00007f2f0f6991c1 in SwLayIdle::isJobEnabled(IdleJobType, SwViewShell const*) (eJob=IdleJobType::SMART_TAGS, pViewShell=0x5a573f0) at sw/source/core/layout/layact.cxx:2218 #6 0x00007f2f0f69926d in SwLayIdle::DoIdleJob(IdleJobType, IdleJobArea) (this=0x7ffc9daf4180, eJob=IdleJobType::SMART_TAGS, eJobArea=IdleJobArea::VISIBLE) at sw/source/core/layout/layact.cxx:2234 #7 0x00007f2f0f699d81 in SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) (this=0x7ffc9daf4180, pRt=0x5a8fad0, pI=0x5a58860) at sw/source/core/layout/layact.cxx:2355 #8 0x00007f2f0fdccf21 in SwViewShell::LayoutIdle() (this=0x5a573f0) at sw/source/core/view/viewsh.cxx:826 Assume that in case the object shell has no underlying medium, then that's not a help document. Also fix the higher level problem that the LOK AnyInput callback should not be invoked while doing a LOK background save, as the object shell in the forked process has no underlying medium. That fixes the failure seen while running the online.git unit-save-torture test. Change-Id: Idcdd62cc177ac4b7edfbcef8906da2e42610ee98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171950 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-16tdf#158857: [Power Query] export xl/drawings/drawing*.xmlBayram Çiçek
xl/drawings/drawing*.xml: - import&export "macro", "textlink", "fLocksText" and "fPublished" attribute of <sp> element (using GrabBag). - import&export "descr" and "title" attributes of <cNvPr> - import "r:id", "invalidUrl", "action", "tgtFrame", "tooltip", "history", "highlightClick", "endSnd" attributes of <hlinkClick> Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: Idd865fc86c3538107e4c9808b0886733c798b01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-16Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to ad12e6e2b68b89d95e1fa92a8905348523ae8ec2 - tdf#156332 Fix broken links to Navigator and Navigation Toolbar help pages Create new file text/shared/01/navigator.xhp - Help link from the Navigator Sidebar Deck is broken. The Navigation Sidebar deck contains the same widgets as the Navigator window, so I've merged everything into one file. - Embedded help content from the existing help pages for Navigator where possible, to avoid retranslation and used switches to show and hide the relevant content. Created new file text/swriter/01/navigator_context_menu.xhp - There are a lot of items in the context menu for Writer, and the page was getting overly long and difficult to read. In AllLangHelp_shared.mk - Added file text/shared/01/navigator.xhp In AllLangHelp_swriter.mk - added file text/swriter/01/navigator_context_menu.xhp In text/swriter/01/02110000.xhp - Added variable and section tags to make content easier to embed in other pages - moved bookmarks to text/shared/01/navigator.xhp or text/swriter/01/navigator_context_menu.xhp as appropriate, so that pressing F1 will open that page In text/simpress/01/02110000.xhp, and text/scalc/01/02110000.xhp - Added variable and section tags to make content easier to embed in other pages - moved bookmarks to text/shared/01/navigator.xhp so that pressing F1 will open that page - removed bookmark for the Pointer function because it doesn't seem to exist in the current version of Impress. In text/scalc/01/02110000.xhp - - Added variable and section tags to make content easier to embed in other pages - moved bookmarks to text/shared/01/navigator.xhp so that pressing F1 will open that page In text/swriter/01/02110100.xhp - Added variable and section ids so that the summary section can be embedded in text/shared/01/navigator.xhp instead of re-stating the same information. - Moved the bookmark for .uno:AvailableToolbars?Toolbar:string=navigationobjectbar to text/swriter/navigate_toolbar.xhp In text/swriter/navigate_toolbar.xhp - Added bookmark for source/text/swriter/navigate_toolbar.xhp so that pressing F1 while hovering over View > Toolbars > Navigator opens the correct page. In text/shared/00/edit_menu.xhp - Updated howtoget instructions for the Navigator window to include instructions for the Sidebar Updated links to text/scalc/01/02110000.xhp to lead to text/shared/01/navigator.xhp in - source/text/scalc/01/04070000.xhp - source/text/scalc/01/06050000.xhp - source/text/scalc/guide/background.xhp - source/text/scalc/guide/cellreference_dragdrop.xhp - source/text/scalc/guide/format_table.xhp - source/text/scalc/guide/webquery.xhp - source/text/scalc/main0103.xhp Updated links to text/simpress/01/02110000.xhp to lead to text/shared/01/navigator.xhp in - source/text/sdraw/main0103.xhp - source/text/simpress/main0103.xhp Updated links to text/swriter/01/02110000.xhp to lead to text/shared/01/navigator.xhp in - source/text/swriter/main0103.xhp - source/text/shared/01/nav_rename.xhp Change-Id: If5509dcbe9c9babf2ef84be492f0edfb2e2a3792 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171921 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-03-22 04:05:39 +0000