summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-19sw: remove no longer building ww8toolbar dump codeMiklos Vajna
Such dumper code for other ww8 features is in the separate mso-dumper repo. If it is found really useful later, it can be still restored and fixed up to actually build, though. Change-Id: Id542fef9c0111c8bc88b943e268c9a02f3503d72 Reviewed-on: https://gerrit.libreoffice.org/48161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-19Fix typosAndrea Gelmini
Change-Id: I98279a1f4020be95c57390fd163ebe740f8cca9d Reviewed-on: https://gerrit.libreoffice.org/48171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-19Fix typosAndrea Gelmini
Change-Id: Icadf5cb88024b8889d49dc9c5210d0de8deaed3b Reviewed-on: https://gerrit.libreoffice.org/48172 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-19Unit test for tdf#114488Samuel Mehrbrodt
Change-Id: Ib9430d2c1cc05c7b73273270f8f96e716fc4dc3f Reviewed-on: https://gerrit.libreoffice.org/48129 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-19Remove noopMike Kaganski
IsTableNode() is true when m_pTableCursor is not nullptr. So, GetCursor() is only called when it is nullptr. In turn, GetCursor() only does something if m_pTableCursor is not nullptr. This is so from the beginning (commit 84a3db80 from 2000 already has it). Change-Id: I258129fc1bab0e3e5591702af1158c1ec2579d8d Reviewed-on: https://gerrit.libreoffice.org/48144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19sw: HTMLTable::m_pTopTable is always "this"Michael Stahl
Ever since commit cc144e5544a41acdc703f7d243ad1747b0a2b33d fix for i#76959 the pTopTable parameter of HTMLTable was always null. Simplify HTMLTable by removing dead code. Change-Id: Ie13313f54d6ee656e56a209bc29bcc77132de269
2018-01-19SfxReqest::Done takes a SfxItemSet& or a boolean, not a SfxItemSet*Caolán McNamara
regression from commit c40dfabd56ade10fe35690dc9810955c2e99e2c0 Date: Fri Jan 12 11:57:22 2018 +0000 Change-Id: Ia97ba286a2da0584a2e806ad7396a3633f9d913e Reviewed-on: https://gerrit.libreoffice.org/48160 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19convert these to true assertsCaolán McNamara
Change-Id: Ifd602f47dd57cdecff3c175d892993072fb82891 Reviewed-on: https://gerrit.libreoffice.org/48154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19pack these without holesCaolán McNamara
Change-Id: Idb5184e141c5a15d4d77268f8d45ee549c6e9a7f Reviewed-on: https://gerrit.libreoffice.org/47714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5468 Integer-overflowCaolán McNamara
Change-Id: Ie2792b7dffaffe939778a1546653424ac03ea30e Reviewed-on: https://gerrit.libreoffice.org/48105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19crashtesting: failure on import with bogus valuesCaolán McNamara
regression from... commit 7d8e94444d989d0ac4a4055b207726708e9ec0da Date: Thu Jan 11 08:47:15 2018 +0200 convert a<b?a:b to std::min(a,b) cause old promotion was to the largest type, so with a large 64bit nDiff and any 32bit nRequestedBytes the nRequestedBytes was promoted to 64bit, found to be smaller than nDiff, then would fit in 32bit. newer code cast both to 32bit, resulting in a negative nDiff which was smaller than nRequestedBytes, but going on to cause havoc. Change-Id: I9eb5c61302b3dccf5333c4dfbf9ac92ce49585b5 Reviewed-on: https://gerrit.libreoffice.org/48155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19Remove include of config_global.h from sal/config.hStephan Bergmann
(where it is not actually needed), and instead include it where needed Change-Id: I107f8d4002d3001393b89834dd30a30b0c53a792 Reviewed-on: https://gerrit.libreoffice.org/48152 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19EPUB export UI: show title from the doc modelMiklos Vajna
It was a bit confusing that the doc model had a title set, it was written to the EPUB file but the UI did not show it. Change-Id: Ife408e0dabd3fe48e8acc1f09be0c86f78ed4b80 Reviewed-on: https://gerrit.libreoffice.org/48150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19EPUB export: accept relative links for image popup from default media dirMiklos Vajna
Previously: - the user had to copy the linked image to the same dir as the doc - set a relative link on the image (in ODF, it resulted in "../foo.png") - copy the image to the media dir ("test" by default for "test.odt") - export to EPUB to have the image popup Now, additionally: - relative link may point to the default media dir (in ODF, it results in "../test/foo.png") - no need to copy the image - export to EPUB creates the popup So one less step is necessary. The downside is that this way the relative URL contain the base name of the document, so renaming the document breaks these relative links. Change-Id: I93894a28393d36a33dcec7bfe7c4a54fd83768da
2018-01-19EPUB export: handle text frame and image widthMiklos Vajna
So that an image and its caption in a text frame always go to separate lines. Change-Id: I439e370ad3bc8628f80a8db45499f8bffd84ef2b Reviewed-on: https://gerrit.libreoffice.org/48148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19...and anotherStephan Bergmann
Change-Id: I06aa51f0f46f3708540ebb218387cb028b9e65d3
2018-01-19EPUB export: fix validation error on invalid relative linksMiklos Vajna
It's valid to have a relative link that points nowhere in ODF, but the same is not true for EPUB. Change-Id: I7884032e277a0c53d0c513cea70dd2ee29ccd85c
2018-01-19Blind fix for sal_Int32 = longStephan Bergmann
...after 252ce90e39648c47bcfdb39547d0ac82bacdbae6 "sw lokit: add page syles to header & footer" Change-Id: Ia0b3f8194d889fc1022da08bac06c85cbb22dd3b
2018-01-19Blind fix for AndroidStephan Bergmann
...after 022588bf2060a53ae70db6b0f1de713e4ba3ee6a "Include android/compatibility.hxx from ubiquitous sal/config.h" Change-Id: I58c620fd25add4758ec981c9812811916fa09db5
2018-01-19Fix callback function typeStephan Bergmann
...that got broken with c394363c84064c041391627602665ea1fa74db60 "loplugin:constparams in basctl", causing -fsanitize=function to complain: > sfx2/source/appl/app.cxx:452:28: runtime error: call to function basicide_handle_basic_error through pointer to incorrect function type 'long (*)(void *)' > basctl/source/basicide/basobj3.cxx:48: note: basicide_handle_basic_error defined here > #0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28 > #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1 > #2 0x7ff639142148 in Link<StarBASIC*, bool>::Call(StarBASIC*) const include/tools/link.hxx:84:45 > #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37 > #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16 > #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28 > #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25 [...] Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e Reviewed-on: https://gerrit.libreoffice.org/48142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19SAL_W32 is just an alias for _WIN32Stephan Bergmann
...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19Don't set autogen.sh KEY=VALUE arguments as environment variablesStephan Bergmann
> Jan 18 15:18:25 <sberg> tml__, do you remember anything about > e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a ? looks odd to add configure > KEY=VALUE args to the environment > Jan 18 15:18:27 <IZBot> core - Include environment variables already in > autogen.sh's environment - > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a > Jan 18 15:22:54 <tml__> sberg: not really any recollection, sorry > Jan 18 15:23:09 <tml__> sberg: are you sure this isn't what makes it possible > to have CC=clang etc in autogen.input? > Jan 18 15:24:07 <tml__> or maybe this is related to propagating stuff when > make re-runs autogen.sh? > Jan 18 15:24:28 <sberg> tml__, configure already takes care itself of its > KEY=VALUE command line arguments > Jan 18 15:24:36 <tml__> sad that I didn't write a better commit message > Jan 18 15:24:55 <tml__> feel free to revert it, and see if anybody notices;) > Jan 18 15:25:04 * cloph_away used it for CC/CXX and devtools repo > Jan 18 15:26:11 <tml__> cloph_away: yes, but I think sberg says that should > work anyway, even without that commit The only reading from ENV after that code in autogen.sh (both today and at the time of e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a) is the if (defined $ENV{NOCONFIGURE}) { print "Skipping configure process."; check, which would now no longer work if you pass NOCONFIGURE= as an argument to autogen.sh (in autogen.input or on the command line) instead of as an environment variable. Change-Id: If50639978190d219b063ff39f81e29d2054c0443 Reviewed-on: https://gerrit.libreoffice.org/48133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19Also strip leading whitespace from autogen.input linesStephan Bergmann
...which allows to align --enable/--disable switches on the part being en-/dis- abled, as in > --disable-assert-always-abort > --enable-avahi > --enable-breakpad > --enable-build-unowinreg > --disable-ccache for better readability Change-Id: I490402c74ea1ee535deee6ef79274b588b614820 Reviewed-on: https://gerrit.libreoffice.org/48130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19loplugin:useuniqueptr in EditFieldInfoNoel Grandin
Change-Id: I8c4cc4ab212409bce54b64d59d07d77a924ed11c
2018-01-19loplugin:useuniqueptr in SfxAppData_ImplNoel Grandin
Change-Id: Ic8b02f5c6582a992b64f31435332ee37d826ad48
2018-01-19loplugin:useuniqeptr in SbxVariableNoel Grandin
Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c
2018-01-19loplugin:useuniqueptr in SbiStdObjectNoel Grandin
Change-Id: Ic66d817746de423549c87f58068e47f9942d04fd
2018-01-19loplugin:useuniqueptr in SbUnoMethodNoel Grandin
Change-Id: Ibeae1754a18152c3a17379c95e3caa536a8822db
2018-01-19loplugin:useuniqueptr in SbiGlobalsNoel Grandin
Change-Id: I0ebec3193b4369039f90be4223ebdf6d048b8478
2018-01-19loplugin:useuniqueptr in SbModuleNoel Grandin
Change-Id: I20525bd69c91ff35c9e569525a0d4556bc184982
2018-01-19loplugin:useuniqueptr in EMFPBrushNoel Grandin
Change-Id: I86622a13583137605bf2b6468113da2eb5e4ee0b
2018-01-19loplugin:useuniqueptr in EMFPPenNoel Grandin
Change-Id: I2c3c7be4bc3b43f03c45724e7a002e862b50f24b
2018-01-19loplugin:useuniqueptr in GeoTexSvxMultiHatchNoel Grandin
Change-Id: I3d25a50ed7ebf78214c0d358243f7e286503b8f8
2018-01-19loplugin:useuniqueptr in ZBufferProcessor3DNoel Grandin
Change-Id: I73005afdaf20efe15321a2a073beb3ae4f7a63e3
2018-01-19loplugin:useuniqueptr in SvgRadialAtomPrimitive2DNoel Grandin
Change-Id: I00d1772732075848b25eb34d7c4b0386551c7e5f
2018-01-19loplugin:useuniqueptr in EMFPPenNoel Grandin
Change-Id: Icc50b2ff1d6c7490b67d39aed7c3621b74c03bac
2018-01-19loplugin:useuniqueptr in EMFPRegionNoel Grandin
Change-Id: I19107173318180ec08864e523f4065181eac00cc
2018-01-19loplugin:useuniqueptr in EMFPBrushNoel Grandin
Change-Id: I17fc33cfd7c15734fd961fa76c676424900a4373
2018-01-19loplugin:useuniqueptr in hwpfilterNoel Grandin
Change-Id: Id276015425ea7de3cf55b9ef21b4e7ce54c2ce47
2018-01-19loplugin:useuniqueptr in idlNoel Grandin
Change-Id: I3681d119dda85400dbb33c96fab736c262f7ce8a
2018-01-19tdf#115065: nullptr dereferenceMike Kaganski
Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9 Reviewed-on: https://gerrit.libreoffice.org/48110 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Fix reg from 4cb3e1c05a16af3dad03db9d789dc7ea061b33cfJulien Nabet
Change-Id: I853a949e68d192c48a90321a8b3b75a5d443638b Reviewed-on: https://gerrit.libreoffice.org/48111 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18xSheetDoc cannot be null hereStephan Bergmann
...as the UNO_QUERY_THROW above would already have caused an exception Change-Id: Ie0453b67716c64ddaddfa6becd498952a497be63 Reviewed-on: https://gerrit.libreoffice.org/48106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18tdf#114720: Fix subtotal crashAhmed GHANMI
A condition was added in order to not make subtotal functions if category was not checked. Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864 Reviewed-on: https://gerrit.libreoffice.org/48099 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-18update copyright yearsRene Engelhard
Change-Id: I634c1132265295f90f624a53b93dddb2b18eabd5
2018-01-18deb#887593 apparmor: allow soffice.bin reading .mozilla/firefox and .gnupgRene Engelhard
Change-Id: I74b57cd510b1babbb4a537d307a6ffc9ee1d9ce5
2018-01-18deb#887593 add gpg and gpgsm to soffice.bin apparmor profileRene Engelhard
Change-Id: I4b37be72ebec86b9360ea2594b26815ddaab60cd
2018-01-18deb#887593 add #include <abstractions/X> to oosplash apparmor profileRene Engelhard
Change-Id: Ib9595b1e0fe888a6698c3c508a24390d3798b3e4
2018-01-18Include android/compatibility.hxx from ubiquitous sal/config.hStephan Bergmann
...instead of having to add it to more and more individual .cxx files, as the need arises. Change-Id: If1e893c79abf1c1bb7fb7b89dcb9bd423a7f1b94 Reviewed-on: https://gerrit.libreoffice.org/48108 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18Resolves: rhbz#1535541 fdo#88004 mimetypes are .macroEnabled not .macroenabledCaolán McNamara
Change-Id: If7942ec9d4cd40f29fae2b9a8f76df1ef08bfc17 Reviewed-on: https://gerrit.libreoffice.org/48120 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-06 23:49:16 +0000