summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-31Run soffice frpm instdir (but CustomTarget_automationtest still can't work)Tor Lillqvist
WScript.CreateObject() takes the symbolic name of the object class that it then looks up from the Registry to find the CLSID of the class. I don't really know how we could make this unit test work at build time. Keep it still commented out in the module makefile. Change-Id: I73418754db9ccc3f5d384754d4d3be74ae1f9dca
2018-05-31Log the call to CoRegisterClassObject()Tor Lillqvist
Change-Id: Idfca38ec2c931572b6978440862c7bfca8d536e6
2018-05-31chmod -xTor Lillqvist
Change-Id: Ied9d506281bba7e8e5c63151c2294eec6b8b52e1
2018-05-31focus rect for value setCaolán McNamara
Change-Id: I208cf42db4256bb7286222781cf2bf29f843c673 Reviewed-on: https://gerrit.libreoffice.org/55101 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31Revert "Simplify: Use AutomationInvokedZone::isActive()"Tor Lillqvist
Can't have the URE library 'stoc' depend on the non-URE library 'comphelper'. This reverts commit 3c041720304ec77202741b5d5c8df9b93bc70a70.
2018-05-31Comment out CustomTarget_automationtest for now, it can't work properlyTor Lillqvist
Can't assume that the necessary entries are in the Registry. Need to fix it to start soffice explcitly before running the VBScript. Change-Id: I809be88a2fe2afbda1f087501785ec7a9e2a358b
2018-05-31tdf#117884: intersect border with paint area of upper frame.Mark Hung
This patch fix regression caused by e87cc12eaf53 and allow table borders rendered in the left or right page margin. Also add another test case (testTableExtrusion2) to assure inner table can't have wider border than outer table. Change-Id: I7a86b379dee08fb2f23385183a42d0ebde007370 Reviewed-on: https://gerrit.libreoffice.org/54862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-05-31SOSAW080: Cleanup of SdrModelArmin Le Grand
First step: Find all constructors/derivations, mark all of them. Removed two-value-constructors, adapted code as needed Reduced constructors for SdrModel/FmFormModel to a single one. Removed PathName for List creation, this is not needed and anyways all calls used the default SvtPathOptions().GetPalettePath(). This is also true for usage of IsFuzzing() that is also part of the default creation process (without path). All usages that need an extra-List were setting it after construction explicitely. Removed UseExtColorTable. This prevents a single List to be not created by default, the ColorTable which is replaced later by all callers that used this. This is not needed since the default ColorTable gets constructed just by default, no expensive stuff is triggered (e.g. loading the ColorTable). Thus now a default ColorTable is created and kept for a short moment, destructed again when a ColorTable is explicitely set. Doing so is also more safe - it avoids not creating a default-ColorTable and then not setting one (what would be urgently required). f23c24a8548d5246b77b1cc359ba89564538e81a f124468c3898c5842d37123bdeb87d79a2b19c62 Change-Id: I865de4bb23f673c6684d83c2c6390439506dc5b6 Reviewed-on: https://gerrit.libreoffice.org/55028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-31Implement NewWorkbook and WorkbookOpen Automation callbacks in CalcTor Lillqvist
Change-Id: I1ff31d692100695a706bf128c18c4e3ae8b55ce3
2018-05-31Add a SAL_INFOTor Lillqvist
Change-Id: Ic197a9573968fb252cb52cc5089f9140d5375d3a
2018-05-31Add a unit test for the Automation client servicesTor Lillqvist
Written in VBScript, yay. Change-Id: Ibbdba804939c2646aef8f8a2bb3781eaf1a6d208
2018-05-31Must catch Exception here, not the more specific UnknownPropertyExceptionTor Lillqvist
Change-Id: I4b0b119af356f38f359f2ba5afa6081533790443
2018-05-31Simplify: Use AutomationInvokedZone::isActive()Tor Lillqvist
Don't need the mbFromOLE boolean flag and the special "FromOLE" parameter passed to the InvocationService:: createInstanceWithArguments(). Change-Id: I05e10a78955d87cb7c37e198c60c3ddcfdbc4275
2018-05-31Need to enter the AutomationInvokedZone here, tooTor Lillqvist
Change-Id: I2723146f2c549c630dfa0e5da330af228cb305a0
2018-05-31Add Author property to ooo::vba::excel::XWorkbook and implement itTor Lillqvist
Corresponds to the Author attribute of css::document::XDocumentProperties. I.e. the initial creator of the document. Change-Id: I07d3ce9dfb87900948d2bb7af14109b17546fb4c
2018-05-31Can simplify, our IDL compiler is more clever nowadaysTor Lillqvist
Change-Id: Ie62c47a0b60df5b7a7237cce981e850cbbe5aee9
2018-05-31Avoid a SolarMutex assertion failure in some use cases from AutomationTor Lillqvist
For instance when opening a Calc Document through ooo::vba::excel:: XWorkbooks::Open(). Instead just let the function return null. It does seem that callers are prepared for that. Change-Id: I7136133155f95a696b5ed3e661a9adb98396c9c5
2018-05-31comphelper: fix an IWYU warningMiklos Vajna
Change-Id: I565ce46c01edfe16d5639cc62cb5a4ca996db349 Reviewed-on: https://gerrit.libreoffice.org/55098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-31Enter AutomationInvokedZone appropriatelyTor Lillqvist
Change-Id: Ic76fc43fc521a6fd6642e22b71c311370788d4aa
2018-05-31Introduce comphelper::Automation::AutomationInvokedZoneTor Lillqvist
Enables finding out anywhere whether the thread is processing a call from an Automation client. Not sure how I have managed without this until now. Presumably the Invocation_Impl::mbFromOLE variable in stoc can be replaced by a call of comphelper::Automation::AutomationInvokedZone:: isActive(). Change-Id: Ib79ec5f6dff17af25c8539d2907c7cd5d7b9a62c
2018-05-31Do same trick in setValue() as earlier in getValue() for Automation clientsTor Lillqvist
Also, it is UnknownPropertyException that we need to catch, not RuntimeException. Did I not actually exercise my change to getValue() back in February? Change-Id: If13eaa9bbecd15f5330a4102ae932f2ec0c7ecd4
2018-05-31Decrease fragility in odd use cases with no current document (yet)Tor Lillqvist
Especially, this happens when an Automation client wants to open a Calc document. Equivalent to the code for the same situation in getCurrentWordDoc(). Change-Id: I209a72dcae49f18cd265e0c6c2790618e1ebb4a1
2018-05-31Make convertDispparamsArgs() handle mismatch in number of parameters sanelyTor Lillqvist
Parameters come in in reverse order in pdispparams. There might be less parameters than expected. In that case, assume the missing ones are "optional" (but can't be marked as such in UNO IDL), and fill in the rest with empty Anys. There might also be more parameters than expected. In that case, assume the oovbaapi UNO IDL hasn't kept up with added optional parameters in MSO, and just ignore the extra ones, as long as they are empty. An example: incoming parameters: <12, 13, "foo/bar.tem"> Expected paramters: (string filename, int something, int somethingElse, Any whatever, Any whateverElse) Here the existing incoming parameters are placed in reverse order in the first three outgoing parameters, and the rest of the outgoing paramters are passed as empty Anys. Another example: incoming parameters: <EMPTY, TRUE> Expected parameters: (bool flag) Here the TRUE is passed as the sole outgoing parameter, and the incoming EMPTY is ignored. Still an example: incoming parameters: <"foo.doc", TRUE> Expected parameters: (bool flag) This throws an error as the incoming non-empty extra parameter presumably indicates something important, but there is no corresponding outgoing parameter to pass it in. Change-Id: Ib04f9701099ecb899e792d99ff86588022b3bbf6
2018-05-31Implement EnumConnections, and fix handling of mismatched parameter numberTor Lillqvist
If we have too few parameters, fill with empty ones, as before. If we have more paramters than the called method expects, but the extra ones are empty anyway, ignore them. Do all of this in convertDispparamsArgs(). This improves interoperability with typical Automation clients. Change-Id: I47376993dc10b401e4c349e19b2bbe4be9f8f444
2018-05-31Make SAL_INFO logging style more usefulTor Lillqvist
Make it easier to search for a specific class and function in the output by outputting the 'this' pointer first, not between the class and function name. Change-Id: Ia6e087e3a4be9e701c418aedb9b6af5fd4f6e828
2018-05-31Initial steps to make also Calc usable from Automation clientsTor Lillqvist
Largely parallel to what we do for Writer. Yes, there is a fair amount of duplicated code now for the outgoing ("sink") stuff in sw and sc, that should be factored out (to vbahelper, probably). Change-Id: I8df4a81c3b9043e8d6b0b206e3c04660205987c7
2018-05-31Avoid crash if pDocShell is nullTor Lillqvist
Change-Id: I4d43bdd6789bdf01cd9b7b38377b19294a544477
2018-05-31Add ooo.vba.excel.XApplicationOutgoingTor Lillqvist
Change-Id: I50ba5482742296609187e8b41bd3a2910c44ca4e
2018-05-31drop Graphic::GetBitmapNoel Grandin
so that we flush out various code using Bitmap, in favour of using BitmapEx. This is part of the process of making Bitmap largely an internal detail of vcl Change-Id: Iaf2ead5e3d9960838723fb55b812b97108093d74 Reviewed-on: https://gerrit.libreoffice.org/55062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-31Add entries for Calc.ApplcationTor Lillqvist
Change-Id: Icee6f97abf9182621e43a0039b52c2f2e141fa01
2018-05-31Move two functions to perhaps less confusing locationsTor Lillqvist
Change-Id: I4360c588ee4866f4e680095c0cd0e8f7aceaa6d7
2018-05-31Can simplify, our IDL compiler is more clever nowadaysTor Lillqvist
Change-Id: Ia5f8c0fcc8d1eb9f6ec3db82b947a16ed3762d01
2018-05-31Add window geometry attributes, too, to ooo.vba.word.XApplicationTor Lillqvist
Like the other similar attributes and methods added lately, they just forward to the corresponding attributes of the "active window". Whether setting and retrieving such then actually does something useful or not I don't know. My main concern is that Automation and COM clients at least won't complain and abort because of unimplemented APIs. Change-Id: Ia8d22e3137d314268ac6771bb355e9f0686f52dc
2018-05-31Add Move() to ooo.vba.word.XApplicationTor Lillqvist
Change-Id: Ib230e730f68a30b82915ed6d7898bf1c02690b70
2018-05-31Add Resize() method to ooo.vba.word.XApplicationTor Lillqvist
Seems to be commonly called by 3rd-party Automation (and VB6) client code. Change-Id: I29ee5e7d95f3da2ffae0fac44151148be6e272ee
2018-05-31Add a WindowState attribute to ooo.vba.word.XApplication, tooTor Lillqvist
It seems to be something 3rd-party VB6 clients expect to be able to get and put. Change-Id: If5079da8ba99fde74b12b9590737d575f6636210
2018-05-31Can simplify, our IDL compiler is more clever nowadaysTor Lillqvist
Change-Id: I785c115ab7bcb7cfddc8e79bd5d31278f0c544dc
2018-05-31If a DocumentBeforeClose event handler says no, don't thenTor Lillqvist
Change-Id: I13601337a78d22eca1df185fb4d51b34a90925f3
2018-05-31Use correct index for incoming Arguments sequenceTor Lillqvist
Change-Id: I1c706a2139cb2596969c6c1d166d3f9fe9f91d39
2018-05-31Add DocumentOpen and NewDocument to XApplicationOutgoing and emit suchTor Lillqvist
Change-Id: Ia2a0ade0af45f1ba99b0cfa860bd1986edcf272e
2018-05-31Emit DocumentChange events less eagerly (to Automation clients)Tor Lillqvist
They are supposed to be emitten when a new document is created, an existing document opened, or a document is made the active document. (Hopefully our SfxEventHintId::ActivateDoc matches the last one semantically.) Change-Id: Ic53285fc3d1b9a61ababf77f06477081cef20f27
2018-05-31Initialise mxMSF in all casesTor Lillqvist
Change-Id: Ib7fcdbe934b66971995574226f982a6865faab1b
2018-05-31Add informative commentTor Lillqvist
Change-Id: I428c2bbaa273d893fa5a3cc42bb7f3d060f375ad
2018-05-31Add ooo::vba::word::XDocuments::OpenNoRepairDialog()Tor Lillqvist
Just call Open() with the same parameters. (Most of which are cheerfully ignored.) Change-Id: Ia9b980bf870bac04fab7e23843d29f66d5859037
2018-05-31Fire the DocumentBeforeClose event (call the callback)Tor Lillqvist
Change-Id: I9c7a17aa9bdbbba29cd12a0e3d09c9047e9b5678
2018-05-31Add ooo::vba::word::XApplicationOutgoing::DocumentBeforeClose() callbackTor Lillqvist
Change-Id: Iccdb7bc262b8f85caf7efb4407a1f00ff0cfb4a8
2018-05-31We need to keep an ooo::vba::word::XDocument ref in the SwDocShell for...Tor Lillqvist
... Application callbacks that want to pass a such. DocumentBeforeClose() is one. (Not yet implemented.) Change-Id: I1e065d608a55e054fb41b0006a76c731915f3ebb
2018-05-31First attempt at passing arguments, also in and inout, to Automation callbacksTor Lillqvist
Change-Id: Iff629243888153250b655a5e942ced024e3338a7
2018-05-31A few SAL_INFO tweaksTor Lillqvist
Change-Id: I4a9c6341891bc80d8ab7648ed972d57739aa4f4a
2018-05-31First attempt at implementing CXTypeInfo::GetFuncDesc() and ReleaseFuncDesc()Tor Lillqvist
The returned information for the methods is fairly bogus, though. Not sure now (a few months after I wrote the code) whether this added functionality was actually needed, or whether I just added it for potential future need, and with the intent that it needs to be improved significantly then later if actually needed. Change-Id: Ifb132f494cdd7172b4b1d05cc26e2370ea595f41