summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-26Drop obsolete workaround for LanguageTool 1.7Gabor Kelemen
Upstream patch for this issue was integrated for LT 1.8: https://sourceforge.net/p/languagetool/bugs/105/ some 10 years ago. It should be safe to drop this workaround now that LT 1.7 was dropped from core. Change-Id: I4ffec2247bcb6445cfcdb1c19018bdddec712c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133357 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26Drop unused LanguageTool extensionGabor Kelemen
Do not bundle LanguageTool which is at a 10 year old version (1.7) while upstream has a lot of new releases (now at version 5.5.x) It is not bundled by any downstream distributions so it makes no much sense to keep it integrated here. Change-Id: Icd2ef151b1b8d0252ffa3db0caaba576f2783fa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133356 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26Drop unused CT2N extensionGabor Kelemen
It is not bundled by any downstream distributions so it makes no much sense to keep it integrated here. Change-Id: I80180e53e050b8b3cd1b173ef01b51e8d706f295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133355 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26CAIRO_OPERATOR_DIFFERENCE define should have followed its usageCaolán McNamara
when that was moved to here Change-Id: I34565d3568c7e75a9f0abac94360e3ff769afbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26tdf#143956 Remove page size of Writer templates 3Laurent BP
This patch concerns "offmisc" templates: - Businesscard-with-logo: - use predefined style names to have them automatically translated - use automatic date format according to locale settings - update preview - remove useless duplicate code and unused styles - contributor's name to top to fit in A4 and Letter formats - remove 1 empty line in table to fit in Letter format also - remove useless stuff in settings.xml file. Keep these fields, because if certain settings are MISSING, xmlimp will consider the file in old format (thanks to Justin Luth) - reindent xml files Change-Id: Ie1b35fe420dbb445cb5070b8a3726c40184973ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121267 Tested-by: Jenkins Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>
2022-04-26tdf#147586: Initialize mbBulletColorFollowText to falseXisco Fauli
Otherwise, once it's set to true, it's never reset Change-Id: Ie8a752da4162775f40c2f84f480e6a103eb55942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133422 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-26rtf filter: reduce memory allocations countVasily Melenchuk
RTFValue in most cases contain only one value: either num, string, picture, etc. No reason to allocate all of them in the same time. RTF filter should became faster and consume less memory, however I did not made any measuremets. Change-Id: Ic12a941ce774b9066d7c57b38139af07851ac7b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131720 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-26tdf#132475 sw ms: import/export DI_CHANGE as fieldJustin Luth
and (only) the AUTHOR portion as FIXED for DOC/DOCX/RTF. The SAVEDATE import was failing as a field because of exception writerfilter/source/dmapper/DomainMapper_Impl.cxx:6950: Exception in CloseFieldCommand() com.sun.star.lang.ServiceNotRegisteredException message: "unknown service: com.sun.star.text.TextField.DocInfo.Change at /persistent/git/libreoffice2/svx/source/unodraw/unomod.cxx:191" In terms of marking the field FIXED: MS Word doesn't update the save date while the document is being edited (although a user could force an update via F9) but it does update the field at FILEOPEN! So, since it updates the date on FILEOPEN, it makes perfect sense to treat this as a normal SAVEDATE field in LO - not fixed at all. At opening time, it will ignore the last-displayed-text and load the values from the field just like Word. The difference will be that it updates the field immediately after a while-editing-save, but that's fine, because when Word opens the same file, that is what it will see. However, curiously enough, MS Word does NOT update the LASTSAVEBY user, and thus the modified author can be set as FIXED, with the normal caveat that a LO user won't be able to update the field (except by deleting and re-creating it). Change-Id: I5640432708cf3eebb6a60eaa500fdf0b8f3a6e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133209 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-26sw: document HtmlExportTestMiklos Vajna
sw/source/filter/html/ is a mix of HTML import and export, but SwHTMLWriter is the entry point on the export side. Change-Id: Ia95c4c342ad5677d286b28d69f89fd88aa801129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133417 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-26natvis: some extra patterns for SvRefs<...> and writerfilterVasily Melenchuk
Change-Id: I077232d641fee38da0f50cb838091c0fd0787189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133416 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2022-04-25loplugin:stringviewStephan Bergmann
Change-Id: I4bd3efe67217a4c4418cf308cc8e7a55cf4a604a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133390 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25loplugin:stringviewparamStephan Bergmann
...and loplugin:stringview(param) follow-ups Change-Id: I5ccb5c7b246a35aefb43c8f608d781b753f9830c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133392 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25loplugin:stringviewStephan Bergmann
Change-Id: I60b37ab39662c485855894642484b6d093070519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133391 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25oox: Remove obsolete TODOXisco Fauli
This can go after 1c924efe1f80207a5e104d755615b1eb9a91d418 < tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties > Change-Id: I9b9540cf0cdcd9ecbb39b92fe24b83a1810df7da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133382 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-25tdf#75263 - Export VBA-Project using detected charset on importAndreas Heinisch
Change-Id: Ia1f1bb31e077dcb4293c1106ac324a25a975a656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133064 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-04-25character dialog contents jumping around a little when label contents changeCaolán McNamara
Change-Id: Icc49b7b6a9163c769e80eb04dd4b725aaa725a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25repair mangled sizegroupsCaolán McNamara
Change-Id: I51b52fa160bca38f158e5e7aec5386ffdb286fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25tdf#132475 writerfilter: use proper date-field defaultsJustin Luth
When a field doesn't specify the format for a date, the system is free to implement it as it chooses. However, the user tends to disagree with that, so lets try to create a MS-similar default for these dates - since LO defaults to only displaying a date without any time component. For example: PRINTDATE \* MERGEFORMAT doesn't tell us how to display the date. MS Word uses different defaults depending on the language of the document. And that only make sense. For example, I noticed that of course en-GB's format is dd/MM/yyyy instead of en-US's M/d/yyyy. As a documentation example: 17.16.5.47 PRINTDATE Syntax: PRINTDATE [ switches ] Description: Retrieves the date and time on which the document was last printed, as recorded in the LastPrinted element of the Core File Properties part. Switches: Zero or one date-and-time-formatting-switch and zero or one of the following field-specific-switches. PRINTDATE (without any formatting switches) the results are: 1/6/2006 2:58:00 PM Change-Id: I41f3bdc155bd8cdc74177e4626b31ece9b47e16b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133208 Tested-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-04-25tdf#145240: Can't save drawing if I'm adding a short freeform line with no fillJulien Nabet
Here are the steps of the dup tdf#148693: 1. Open a new sheet in LibreOffice Draw 2. Select the tool Shape/Insert/Curves and Polygons 3. Draw a short line (I mean very short) 4. Click "File" > "Save" and select a random place to save => 1 0x00007fcd3c774fcb in o3tl::doAccess<com::sun::star::drawing::PolyPolygonBezierCoords>(com::sun::star::uno::Any const&) (any= uno::Any("[][]com.sun.star.awt.Point": uno::Sequence of length 1 = {uno::Sequence of length 2 = {{X = 0, Y = 0}, {X = 252, Y = 0}}})) at include/o3tl/any.hxx:284 2 0x00007fcd3c74f759 in XMLShapeExport::ImpExportPolygonShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, XmlShapeType, XMLShapeExportFlags, com::sun::star::awt::Point*) (this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *) 0x7bcb3a8, eShapeType=XmlShapeTypeDrawOpenBezierShape, nFeatures=15, pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:2342 3 0x00007fcd3c74d952 in XMLShapeExport::exportShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, XMLShapeExportFlags, com::sun::star::awt::Point*, SvXMLAttributeList*) (this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *) 0x7bcb3a8, nFeatures=15, pRefPoint=0x0, pAttrList=0x0) at xmloff/source/draw/shapeexport.cxx:811 4 0x00007fcd3c75cca1 in XMLShapeExport::exportShapes(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, XMLShapeExportFlags, com::sun::star::awt::Point*) (this=0x8770560, xShapes=uno::Reference to (SdDrawPage *) 0x2d6b258, nFeatures=15, pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:1006 Change-Id: Ie6d626999bf606f951f4f79a7c314559a9a886f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133273 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-25Introduce a better mechanism to suppress false loplugin warningsStephan Bergmann
...by annotating occurrences of false warnings with [-loplugin:<name>] comments in source files and letting individual plugins opt-in to watch out for such suppression annotations, rather than maintaining lists of excluded source files in the individual plugins. (See the new loplugin::Plugin::suppressWarningsAt.) Instead of making all calls to loplugin::Plugin::report check for suppression annotations, the intent is that this check will only be added opt-in to those places in the plugins that are prone to emitting false warnings. In general it is better to have plugins that don't produce false warnings in the first place, or at least let those warnings be addressed with trivial and harmless source code modifications, avoiding the need for any suppression mechanism. As a proof of concept, I have removed the exclude list from loplugin:redundantfcast and instead annotated the relevant source code. (And thereby found that three of the six originally excluded files didn't need to be excluded any more at all?) For now, this mechanism looks for comments (both //... and /*...*/, even documentation-style /**...*/) that overlap the current and/or the preceding line, because at least for code controlled by clang-format it is often easier to move comments to a line of their own, preceding the commented code. Looking also at the current line (and not only at the preceding one) opens the door for erroneous over-eager annotation, where an annotation that was meant to address a false warning on the current line would also silence a potentially true warning on the following line. This probably doesn't cause much trouble in practice, but is up for potential change. Change-Id: I91ce7a0e5248886a60b471b1a153867f16bb5cea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133365 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25tdf#136429: use FieldUnit value for min/max of some fields of numbering dialogJulien Nabet
Change-Id: I01428703a7bdb2090fd145e5373c37aff0d386ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133348 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-25tdf#148654 stop playing sound with presentation endsCaolán McNamara
Change-Id: I74aa4cd966b6966f7826d241fcf9bb9d64955464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25Resolves: tdf#141441 get and set selected entry when "unfrozen"Caolán McNamara
Change-Id: I4229460fb27ae3dc133c0f6a53c7792a87bf4db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25tdf#141391 sw: don't paste as nested table in first cell paragraphLászló Németh
Paste table content overwrote cells of the row(s) only if the text cursor was at the beginning of the table cell, otherwise the table cells on the clipboard were inserted as a nested table. This was a UX regression from commit 7600a2942ce2b9dac66836105bed6620d55abec2 "fdo#37156 insert table copy as nested table in non-starting cell position" especially when the user clicked not exactly at the beginning of a cell, which containing a 1-line text or data. Since commit 1e278d1d0cfb1d5375195aa764739f00633f21e8 "tdf#37156 Writer menu: Paste as Nested table" it's possible to force nesting (but not overwriting yet), this commit revert partially commit 7600a2942ce2b9dac66836105bed6620d55abec2: if the text cursor is there in the first paragraph of the cell, Paste table content overwrites the row, not embedding a nested table in the cell at the cursor position. This change results also better interoperability with the existing document editors. Note: table and text selection were checked with the change, too. Details: Heuristics to allow copying table rows or nesting tables without using Edit -> Paste Special -> Paste as Nested Table: At "table selection" (i.e. when cell(s) completely selected), or if the text selection starts in the first paragraph, or if there is no selection and the text cursor is there in the first paragraph, overwrite content of the cell(s). Otherwise insert a nested table, i.e. if nothing selected and the cursor is not in the first paragraph, or the selected text doesn't contain the first paragraph of the cell. Change-Id: I7746c6a464123bef6fb7dbff415ff0414e48365d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133377 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-04-25ofz#46794 TimeoutCaolán McNamara
Change-Id: I58bfdbe4bab0ee8b7ff49f937711dff649392bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25tdf#126672 Add search field to extension managerSamuel Mehrbrodt
Change-Id: Ie5c44e79cff236c5d306c34492a5c6c789d6fb60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133381 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-25external/firebird: Missing include in configure checkStephan Bergmann
...so that with Clang 15 trunk after <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626> "[C11/C2x] Change the behavior of the implicit function declaration warning" the check now failed to compile with > configure:21471: checking alignment of long [...] > conftest.c:177:3: error: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > exit((int)&((struct s*)1024)->b - 1024); > ^ > conftest.c:177:3: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit' and an exit code of 1 from the compiler invocation, which the check than silently mistook as an alignment requirement of 1. (Which then caused the somewhat obscure fallout of > workdir/UnpackedTarball/firebird/src/gpre/msc.cpp:463:10: runtime error: member access within misaligned address 0x7f59d8e68196 for type 'gpre_sym', which requires 8 byte alignment while building ExternalProject_firebird with UBSan.) The corresponding "checking alignment of double" a few lines further down had already been modified in ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 "Make firebird build for macOS on arm64", but without stating what actual problem (if any) it fixed. I thus moved that patch into the new external/firebird/configure-include.patch too, to have them grouped together. (An alternative fix could be to replace the use of exit with return from main in those configure checks.) Change-Id: Iefa02a06d45c83add5f56fad5d726aaecee6d815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25Recheck module chart2 with IWYUGabor Kelemen
See tdf#42949 for motivation This time using the new --noexclude switch to recheck validity of the excludelist; these were the obsolete exclusions Change-Id: Ifdf79b30ebaf198082c2194611a2ed2b664e6f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133309 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-25Update to glade 3.38.2Samuel Mehrbrodt
Change-Id: Ia57eef82cd74e14aa9f09143dcc0e5101eab9949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133380 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-25use string_view in CompareProtocolSchemeNoel Grandin
Change-Id: I3584042d0341d5c1b4f4e742e25e9eb0aa26f1da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-25tdf#143956 Remove page size from Draw templatesLaurent BP
Update BPMN template: - content.xml: remove lang and country tags remove asian and complex tags - meta.xml: indent and add title to enable translation - styles.xml: change style name to English to get automatic translation remove lang and country tags remove page size Change-Id: I23058c63dbc13fa66a1138c20e9840a360b72ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132647 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-04-25vector is a little faster than deque hereCaolán McNamara
Change-Id: I0471143b13ea8113919ed71abe956f27729cecad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133372 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25sw: make it easier to look up an uno command from a slot idMiklos Vajna
This way if I see a slot id 20456, then searching with git grep define.*20400 include/ */inc finds FN_FORMAT, and searching with git grep FN_FORMAT.*56 include/ */inc finds FN_FORMAT_FRAME_DLG. Change-Id: Ibda8b131f73c81221569618cda33e52b03448feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133374 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-25external/openldap: Don't use pthread_get/setconcurrency without declarationsStephan Bergmann
At least with glibc on Linux, those two functions are only declared in <pthread.h> when _XOPEN_SOURCE is defined. And with <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626> "[C11/C2x] Change the behavior of the implicit function declaration warning" in Clang 15 trunk that now causes hard errors > thr_posix.c:93:9: error: call to undeclared function 'pthread_setconcurrency'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > return pthread_setconcurrency( n ); > ^ > thr_posix.c:107:9: error: call to undeclared function 'pthread_getconcurrency'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > return pthread_getconcurrency(); > ^ (vs. just silently ignored warnings) when building ExternalProject_openldap. (And the way the corresponding AC_CHECK_FUNCS in workdir/UnpackedTarball/openldap/configure.in works, it always set HAVE_PTHREAD_GET/SETCONCURRENCY because it effectively checks for availability of the symbols in a library, not for declarations of the C functions in an include file.) But if we explicitly define _XOPEN_SOURCE, we now also need to explicitly define _DEFAULT_SOURCE or _BSD_SOURCE (which is otherwise implicitly defined by default in glibc's features.h if no other such macros are defined). Change-Id: I148d50c82ee2efc2a54f2cf4f84dead3941a3568 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133312 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25sw content controls, checkbox: add document model & UNO APIMiklos Vajna
Add 4 new properties: if this is a checkbox, and is so: - if it's checked - unicode value for the checked state - unicode value for the unchecked state This should be enough for the UI to be able to update checkmark state on click. Change-Id: I723532fd2d3377cf09a1127c69c55f9539649088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133363 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-25tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodesMichael Stahl
... in SwTextNode::JoinNext(). The 2nd node is deleted, so its frame is deleted, and if it is the start of a merged frame, fly frames on the node itself will be recreated already, but those on subseqent nodes need an extra call. Change-Id: I18999946334f5560b720d3d275610bc8b07973f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133335 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-25ofz#46905 Null-dereferenceCaolán McNamara
Change-Id: I26427ee1e010ce79e40c550459d9f53598570a7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25sw: prefix members of WW8_WrPct, WW8_WrPlc1, WW8_WrPlcField and ...Miklos Vajna
... WW8_WrPlcFootnoteEdn See tdf#94879 for motivation. Change-Id: Ie49a167ca443216322a2038d4d6568d43736019a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133361 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-25find-unneeded-includes: bail out early if no files are found with --recursiveGabor Kelemen
Change-Id: I5bd726b33e4fc7068baad91ff185763274307b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133308 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-24Remove brittle test from WmfTestHossein
The WmfTest::testStockObject() contained test for the number of children in the metafile dump. This can be changed when unimplemented records are implemented. The problem was revelead while implementing SetPolyFillMode record: <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/112114/> xmltesttools.cxx:234:WmfTest::testStockObject equality assertion failed - Expected: 42 - Actual : 47 - In <>, XPath '/metafile/push[2]' number of child-nodes is incorrect Change-Id: I627801b7ac535a2f0c736880d9675f3d0136136a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133353 Tested-by: Jenkins Reviewed-by: Hossein - <hossein@libreoffice.org>
2022-04-24Do not start a:path with lnTo in export to OOXMLRegina Henschel
This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2 The commands A, W, T or L of a draw:enhanced-path draw a line from current point to start of the arc or end of line, respectivly. If there is no current point the path is faulty and behavior is not defined in ODF. LibreOffice is tolerant and makes a move to the start point of the arc or to the end point of the line. With this patch we do the same now in export to OOXML, so the user gets the same shape geometry as in LO. If a path starts with lnTo, MS Office will show nothing. I wouldn't care about user-created faulty paths, but LO produces such faulty path when an EllipseRibbon shape from binary MS Office is imported. Even when that will be fixed, we need the fix here, because the faulty path had been written to document markup and will be used when such document is opened. Change-Id: Ic52ec3bc78231b26efb592ddadee2e3042fdc065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133349 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-04-24tdf#103859 EMF+ Use variable types according to EMFPLUS documentationBartosz Kosiorek
With this commit, the types of variable for Brush and Pen were aligned to documentation: [MS-EMFPLUS] - Enhanced Metafile Format Plus Extensions As a side effect the code was simplified a bit Change-Id: Ibabad628d0aaef510f61ee8b3d881c3f024cebef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133327 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-04-24Fix typoAndrea Gelmini
Change-Id: I85013e2fc1150b1830fa21da7ed77ac95ff7452e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133352 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-04-23find-unneeded-includes: add --noexclude argumentGabor Kelemen
To ignore the excludelist, thereby checking if its exclusions are still valid. It may happen that some refactorings make an exclusion obsolete. In this case the IWYU suggestion to remove a now-really-unnecessary header would be ignored forever. It makes sense to use it after a full cleanup of a module in normal mode. Change-Id: I8216a79ea2354ab428d6ce7a56a49e5cf67056fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133307 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-23Recheck module chart2 with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-23Fix typoAndrea Gelmini
Change-Id: If2bc62044609ef173ac147196a9f78363db002eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133345 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-23tdf#148591 rename two Vertical positioning regionsSeth Chaiklin
Page text area top --> Above page text area Page text area bottom --> Below page text area Change-Id: I3a63ec09e6a3dfbd51385139ea89454bd1792a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133288 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-22external/libassuan: Fix fallout of defining __STDC__ on WindowsStephan Bergmann
...since 1bb0e177124d5d6661b72df6c7d848fb23639652 "Fix autoconf>=2.70 gcc-wrapper breakage", which had the side effect of preventing various deprecated function declarations in system headers (e.g., isascii in addition to __isascii). This went unnoticed so far due to the traditionally lax handling of missing function declarations in C, and only now started to cause > conversion.c(94,9): error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > if ((isascii (*istr) && isprint (*istr)) || (*istr >= 0x80)) > ^ etc. with clang-cl 15 trunk after <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626> "[C11/C2x] Change the behavior of the implicit function declaration warning". Where undeclared functions have been used in Windows-only code, they have been replaced with their __STDC__-declared counterparts, and for occurrences in shared code Windows-only macro definitions have been introduced (as would have done in the system headers too, if __STDC__ was not defined) to not clutter the shared code with #ifdefs. Also, for getpid (resp. _getpid), the #include <process.h> was apparently missing from the upstream code, even without our __STDC__ hack in external/libassuan/ExternalProject_libassuan.mk (but never caused errors until now, either). Change-Id: I7442394d0c6e633bca1f6c7331d7ee51651179a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-22external/gpgmepp: Missing includes (Windows)Stephan Bergmann
> gpgme-w32spawn.c(288,8): error: call to undeclared function 'open'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > fd = open (trans_file, O_RDONLY); > ^ etc. with clang-cl 15 trunk after <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626> "[C11/C2x] Change the behavior of the implicit function declaration warning", which went unnoticed so far due to the traditionally lax handling of missing function declarations in C. Change-Id: I805ab10d2b0aae3f8b1f46ffeda57aff2bbcef2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133340 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-22external/libgpg-error: Missing include (getpid, Windows)Stephan Bergmann
This was apparently missing from d400009e7c74d13f01fda923d7399eac11b83b66 "gpg4libre: update gpgme, libassuan and libgpg-error" but went unnoticed so far due to the traditionally lax handling of missing function declarations in C, and only now started to cause > logging.c(845,57): error: call to undeclared function 'getpid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > (unsigned int)getpid (), pidsuf); > ^ with clang-cl 15 trunk after <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626> "[C11/C2x] Change the behavior of the implicit function declaration warning". Change-Id: I66dc409f629d9bda807bc9cca21a8a5ecdda79be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133338 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-27 19:14:40 +0000