summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
10 hoursSimplify abstract dialog impls using vcl::AbstractDialogImpl* in scHEADmasterMike Kaganski
Change-Id: Iff9ac377a5cfa259c5911632ad16d2b1e3269868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178986 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 hoursSimplify abstract dialog impls using vcl::AbstractDialogImpl* in sdMike Kaganski
Change-Id: I93f40aef003aa52b4eef173f8f481c99fe4c0489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 hoursSimplify abstract dialog impls using vcl::AbstractDialogImpl* in swMike Kaganski
Change-Id: Ie2816ab4f4ad5f4d703d4f6669ae16a9fa60933e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178984 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 hoursFactor out AbstractDialogImpl template for reuseMike Kaganski
Add a ctor to /opt/lo/bin/clang-format -i include/vcl/abstdlgimpl.hxx to construct the dialog in-place, to simplify factory methods. And move two abstract dialog impls where all others are in cui Change-Id: Ia3f3a5d6c1aaa5a9aca9c11990f833842e4536e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178983 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
10 hourscrash reporting: use SfxRequest to get parent for dialogsCaolán McNamara
0: return pWindow ? pWindow->GetFrameWeld() : nullptr; 2: SfxNewFileDialog aNewFileDlg(GetView()->GetFrameWeld(), SfxNewFileDialogMode::LoadTemplate); Reproducible by adding "LoadStyles" to the menu in writer, then print preview and then use that "LoadStyles" entry. Also dispatch "SID_TEMPLATE_LOAD", as used by "Load Styles from Template" entry in the dropdown from the "Styles Action" toolbar of the style panel, with an explicit frame it is associated with. Change-Id: I3d536b897fbf6be9e20e4238e6a761df56ac9701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179084 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
11 hourstdf#164233 vcl: Fix and simplify spin field mouse over checkMichael Weghorn
Instead of checking individually whether the mouse pos is over the SpinField's up or down button or the `mpEdit`, just check the SpinField's whole rectangle. The mouse event pos is relative to the SpinField, so use (0, 0) for the top left position of the SpinField's rect used in the check. This is not only simpler, but also fixes the case of the UNO control when the "Spin Button" options is disabled in which case there are no buttons and `mpEdit` is null, so `bMouseHovered` would always be false and adjusting the spin field value for that control using the mouse wheel wouldn't even work when mouse-hovered after the initial check was introduced in commit 869b88488ac443cc64943254064da20b0f361c56 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon May 13 16:37:45 2024 +0200 tdf#160824 vcl: Require mouse over spinfield to mouse-wheel through values Change-Id: I3a2ee3af8af872e4a330a4d5e9f5cd6a2de89754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
12 hoursUpdate git submodulesChristian Lohmaier
* Update translations from branch 'master' to 7bb37bc63384aa1654041c19cceac7463266f9fc - update translations for master and force-fix errors using pocheck Change-Id: I17e0a401077dd9cfc491eba7be3fb76032ebf87c
13 hoursRe-write ScTable::GetRowForHeightNoel Grandin
Cleanup up this method, making it more organised in how it iterates over spans, and adding asserts to verify assumptions. The asserts uncovered that we are sometimes fed bad data, so now we deal with that (and not sanitising the input is possibly why the original code was a little weird). Also, now that we are returning correct data, our caller does not need to correct the return value Change-Id: I094931bb2e93a3273b7a928fc7e83eed75e3db51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 hoursweld: Don't use "upper" as param name for lowerMichael Weghorn
Change-Id: I31e7c5f48680d5196db6f44e8e3cfd31d5a5fda9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178987 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
18 hourspdf: implement PDFEncryptor for PDF (2.0) encryption V5R6Tomaž Vajngerl
PDFEncryptorR6 implements PDF 2.0 encryption (ver. 5 rev. 6) using AESv3 (256 bit key length). The PDFEncryptorR6 is enabled when the PDF output is PDF 2.0 (other versions have been deprecated, so it is the only one available in PDF 2.0). Change-Id: I27f270197910405b5c2378a3873d2495f52f3206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176885 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178759 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
18 hourspdf: move creating access permissions to common placeTomaž Vajngerl
The access permission are needed independent to the kind of PDF encryption so they should be in a common place so they can be reused. PDFEncryptionProperties is the best place to create the value anyway. Change-Id: Ic6e6c3d9a8cb314523c0305eba9e64f3734d52b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176884 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178758 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
21 hourstdf#164171 Improve tooltip for Open DocumentsBogdan Buzea
Change-Id: Icee61b29fa1f233c6c28e47c57343820a1f723c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178953 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
23 hourstdf#130857 qt weld: Implement {g,s}etting scroll bar thicknessMichael Weghorn
Do it in a similar way as the GtkInstanceScrolledWindow implementation. Change-Id: I92d5b1d55ed390e012e59525dd9fc9e9ffc72cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178977 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hourstdf#130857 qt weld: Implement scroll bar policy {g,s}ettersMichael Weghorn
Change-Id: I0ee4cececc40f21a6ef4eeb034c44727578d309c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178976 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
23 hourstdf#130857 qt weld: Handle more QtInstanceTreeView::insert paramsMichael Weghorn
* Don't always append, but evaluate the insert position (with special value -1 to append). * If an iterator is passed for `pRet`, set its model index to the new item's model index. Change-Id: I2db8718f4b572d4ae3dcfa7183033f04174b72a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178975 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hourstdf#130857 qt weld: Implement QtInstanceWidget::set_busy_cursorMichael Weghorn
This is basically the the Qt port of the existing GtkInstanceWidget::set_busy_cursor. Gets called e.g. from RemoteFilesDialog::OpenURL (via the weld::WaitObject ctor/dtor). Change-Id: I0b61ae33ad47190c8f2258745ab483152dde1331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178974 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
23 hourstdf#130857 qt weld: Implement most QtInstanceMenuButton methodsMichael Weghorn
The QToolButton::menu methods to retrieve the menu doesn't exist in the QAbstractButton base class, so let QtInstanceMenuButton take a QToolButton pointer. Implement the menu item related methods in line with the corresponding QtInstanceMenu methods. Change-Id: I4d97f528fe112ba3b94069ce0173a5b63a415ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178973 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hourstdf#130857 qt weld: Set menu button's menu defined in .ui fileMichael Weghorn
Make the existing local helper function `extractPopupMenu` used by VclBuilder a static method in the BuilderBase base class for reuse by QtBuilder. Use it in QtBuilder::makeObject to evaluate the "popup" property for a "GtkMenuButton" object, get the corresponding QMenu and set it for the button. The code currently assumes that the corresponding menu is aleady known, i.e. was defined earlier in the .ui file than the menu button it belongs to. VclBuilder doesn't rely on that, so a handling similar to there could be implemented as and when needed. Change-Id: I95446fb7a369f2cfee0d8d51432933582bbfd570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178972 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
23 hourstdf#130857 BuilderBase: Drop explicit call to VclPtr::getMichael Weghorn
There's no need to explicitly call VclPtr::get to get the Menu* from the VclPtr<Menu>, so drop it, also to make the code reusable for QtBuilder, where the template type `MenuPtr` is just `QMenu*`, so there's no `get` method to call. Change-Id: I45eb23791a8b6cd099b79e276bdb18c3b8199923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178971 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hoursResave remotefilesdialog.ui with glade 3.40, but restore 2 propertiesMichael Weghorn
For some reason unclear to me, glade 3.40 would automatically remove the "pixbuf-column" and "text-column" properties for the "iconview" GtkIconView. Looking at the doc [1], this seems suspicious. (Actually removing the properties would event result in a crash when opening the dialog via "File" -> "Open Remote" in Writer.) Therefore, restore those 2 properties manually again after resaving with the newer glade version. [1] https://docs.gtk.org/gtk3/property.IconView.pixbuf-column.html Change-Id: Ifd8251384be93fb2ca372351ccb6b40bff682953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178970 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
23 hourstdf#130857 qt weld: Ignore "GtkCellRendererPixbuf" objectsMichael Weghorn
VclBuilder also doesn't seem to have any particular handling for that, just like for "GtkCellRendererText", so return early instead of asserting further down that this case isn't handled yet. Change-Id: Idf2a490fb944ac2596f64b96c6e3693fad894935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178969 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
23 hourstdf#130857 qt weld: Implement basic menu logicMichael Weghorn
Implement basic logic related to menus: * Creating menus and simple menu items in QtBuilder. * Setting and retrieving misc properties for menu items in QtInstanceMenu. Use the QObject::objectName property [1] to hold the ID for menus and menu items. Introduce a PROPERTY_ACTION_NAME to hold the action name/command name for menu items. This property gets set for the corresponding QAction objects. [1] https://doc.qt.io/qt-6/qobject.html#objectName-prop Change-Id: Ic866377e42202bde6d1f8bd215829ff99a4b682a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178968 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hourstdf#130857 qt weld: Introduce QtInstanceMenuMichael Weghorn
Introduce QtInstanceMenu as the native Qt implementation for weld::Menu. This mostly adds the basic structure. For all methods except QtInstanceMenu::clear, the actual logic still needs to be implemented. Change-Id: I983f2cd3976eee50f55b2ac702578833dbad3d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178964 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
23 hourstdf#130857 qt weld: Introduce QtInstanceMenuButtonMichael Weghorn
Add new QtInstanceMenuButton class as the native Qt weld::MenuButton implementation. The actual logic of the class methods still needs to be implemented, they all just trigger an assert when called right now. Create a QToolButton for "GtkMenuButton" objects in .ui files. Let QtInstanceBuilder::weld_menu_button create an instance of that new class and pass the button in the ctor. Change-Id: Ie5ba0bad8e351554323e8f4ec1281b2c5ae8fbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178963 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
24 hoursadd more coverage to testRowForHeightNoel Grandin
and more comments. Because I want better coverage before I go changing ScTable::GetRowForHeight And because it makes obvious the flaws in this method. Change-Id: Ic7ec7bdcbab2547387efaaf2c1ad8b7cd05d1b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
26 hourspdf: add function to pad the vector as required by PDF specsTomaž Vajngerl
Change-Id: I7196ad523b3084124a3b03fb2e4998d42fd91779 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176883 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178757 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
26 hourspdf: add /Perm encrypted access permission algorithmTomaž Vajngerl
+ add test Change-Id: Iba54dab6738c9707b37e434bab23ae286675436d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176882 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178756 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
26 hourspdf: generate U, UE and O, OE keys for R6 encryptionTomaž Vajngerl
Also test the algorithm against the known values from an example, to be sure we are calculating the values correctly. For this we need a couple of decryption algorithms, but those do mostly just the reverse of the encryption. Change-Id: I5499ed0b57671f44e48fe68961e07cde22be6b39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176881 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178755 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
31 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e4f4fd964633268c3e52cb2b4cc32a11000ad148 - Fix bad characters Change-Id: I3b8a1f8188d2b88fb8409df4a1e602102c4a3381 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178960 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
31 hoursmake modcfg ConfigItems listen to the config changes.Caolán McNamara
Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
31 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 6ecda866708ab53144cffd8ab3be134b949f3394 - Fix grammar Change-Id: I0843f2bf289d7950feaf6fdccf3e0f5e62a368f0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178965 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
32 hourscrashreportScraper: output to htmlXisco Fauli
it's clearer and faster and easier to add links Change-Id: Id3f41daae257cf002c63b9203ec9f24857b8fcb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178959 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
33 hourstdf#163691 Use std::copy() instead of memmove()Alin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: I429aa29f97d3f7cc904cac5664b988548fe7f46c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178954 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
35 hourssc: fix: can't switch focus from font menu back to edit windowRashesh
- Steps to reproduce: 1. Open Calc 2. Put the cursor in the font selection field, and type 3. Try to move the cursor back to the sheet and to type Change-Id: I596e5380d38f761a310c2a363389b0b03a0e94ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178787 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2c95e7186e053ed5f2e7d8388fbe087fa60636c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178796 Tested-by: Jenkins
35 hourssc: fix: unnecessary updates to ScPosWnd when named range are emptyRashesh
- follow up 115776004c875b3a8a861d070129187c893b136a Change-Id: I57072d1999e703975a43dc50077698d4b28df461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175869 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177646 Tested-by: Jenkins
35 hourssc: fix: unnecessary updates to ScPosWnd even if NamedRanges are sameRashesh
Change-Id: Idd32343f38d6294f5140835d99137dae9f1237ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 115776004c875b3a8a861d070129187c893b136a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177647 Tested-by: Jenkins
35 hourscool#10115 sc: enable ScPosWnd for lokit with jsdialogRashesh
Change-Id: I18829c48a2495e3aa31af83970c8c1c4791a170a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173987 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 9ffc274bbc414d1e98313af804386861beeff9bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177645 Tested-by: Jenkins
36 hourslet insertModificationXcuFile accept "/" to indicate all nodesCaolán McNamara
insertModificationXcuFile takes a set of paths to include and a set of paths to ignore from a given .xcu files adapt this to allow an include path of "/" to match all contents of the xcu. insertModificationXcuFile is more useful than insertExtensionXcuFile for the intended use case, because the latter inserts as an extension level layer, and cannot override higher layers. Change-Id: I8eabd9fb91184146a75b087cc31cee44f378d96d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hoursmake SwFmtAidsAutoComplConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: I92f57f9ea8a0ea109fbec9e18665adeb3c6d2837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hoursmake SwWebColorConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: I5190155eb0edb4639b09983cc58101a5a8c82f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hoursmake SwLayoutViewConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: Id86edc48c304d2ab35a5cb01a20d9dac20e04280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178926 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
36 hoursmake SwCursorConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: Ia653759378913758f0b2750c9d072b76523fa034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178924 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
36 hoursuse member init list and initialize before member LoadsCaolán McNamara
Change-Id: Iaca646e1a36b20adb29b5ff25649d08fc7055e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hourstdf#164285 secure access to SID_ATTR_TRANSFORM_SIZE_POINTArmin Le Grand (Collabora)
Change-Id: Ice52f9be8ecc1887de48f3538b5627514518aef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178936 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
37 hoursfix --disable-poppler build with clang plugins enabledCaolán McNamara
Change-Id: Ibc133de32a8c4343c5d941f78933cb8bae24f434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178937 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
38 hourstdf#164179 - Fix crash on BibEntry ComboBox selectVojtěch Doležal
One change in 7b99871635cd48c2a8a1d0afbd7afc60a45cc2ff (to ToxAuthorityField) caused crashing bug in IdentifierHdl due to it trying to call unsupported method on an input field to set its value. This patch not only fixes the crash, but also moves the volatile code into the SetFields method, which is also called in the constructor of the Dialog, meaning if similar change were made in the future, the crash would manifest immediately and hopefully not pass to production. Change-Id: I93abef0cdaa5c533523fbefd9514d1a287fd368b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178448 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
38 hoursstray semicolonCaolán McNamara
Change-Id: Ibe57036e31c704b8866de49934a58b0fa6c47496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
38 hourstdf#164396: Fix the minimum size for menuMike Kaganski
It is not the full size of our minimal system requirements - it's half of that: when the menu appears from the middle of the screen, it only has half of the height. Since the original commit 643a1492bd648fbd803ca86aca600cc2bdaf5819 (Add some fallback minimum size when screen size detection goes wrong, 2020-03-11) only mentioned misdetection of 0, this change should be safe. Change-Id: If62f4ee90dc062c37547fea4e72df2569d78f956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178940 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
39 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 053504317ac7f4c205f540d6871c9389dd6b9240 - tdf#163132 Adjust Impress Remote guide. as follow up of https://gerrit.libreoffice.org/c/help/+/171958 Change-Id: I2f6cb97fab60d463f127663ab3f9a6ce36a8a12c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178919 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
40 hourscrashreportScraper: fix idsXisco Fauli
Change-Id: I55b3529cdda0219fabb4ea14c8fa2a90e88b5a78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178914 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>