Age | Commit message (Collapse) | Author |
|
This commit adds the DotnetTest gbuild class to build a unit test
suite using the .NET SDK and the NUnit testing framework.
Also adds a DotnetTest target for the net_ure module, with unit tests
for the Any type, as well as some minor changes to the Any type that
came about when writing the test cases.
Change-Id: Idbc08ac8f0736dd7355092dd1e69a5f1b4137c4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168956
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
This commit adds the DotnetLibrary gbuild class to build a .NET assembly
using the .NET SDK.
Also adds an option to enable or disable building .NET components with
--enable-dotnet (default) and --disable-dotnet to the autogen script.
Also adds a net_ure/ directory for the updated .NET bindings, currently
consisting of the net_basetypes library.
Change-Id: I9256387a2463ff8476deee85d886c6b3dce8257b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166380
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
env python3 likely won't work in that case
Change-Id: I1b24119af21db9db04c9fa6445e59cb328f39252
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167162
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
if used defaults to Awake for Windows and caffeinate for macOS
Change-Id: I35f41bf1fb63af05ce2ec1a7f4d7b50b310536a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166743
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
|
|
Change-Id: I4272ea817a48880fd4206d6c73add7ccb8c4f6c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166335
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: Ifdec48aaf53b0444c2d7ceef554f64795e2f2c38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162172
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Since these are produced by the build, they should also
be removed in the "clean" target.
Without this, Jenkins CI builds for the upcoming
Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Dec 8 14:57:14 2023 +0100
android: Make the build fail on new lint warnings
were seen failing, despite the example file no longer being
part of the generated resources since
commit 1d7b1e2d4099aac15e695696e6a0640d6e01e23f
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Nov 15 13:16:26 2023 +0100
android: Drop "More Info" item in "About" dialog
, but apparently the file was still lingering around
from previous builds.
Build failure/Lint error from CI build [1]:
> Task :lintReportStrippedUIEditingDebug
Wrote HTML report to file:///home/tdf/lode/jenkins/workspace/android_arm/android/source/build/reports/lint-results-strippedUIEditingDebug.html
> Task :lintStrippedUIEditingDebug FAILED
/home/tdf/lode/jenkins/workspace/android_arm/android/source/lint-baseline.xml: Information: 237 errors and 11 warnings were filtered out because they are listed in the baseline file, lint-baseline.xml
[LintBaseline]
/home/tdf/lode/jenkins/workspace/android_arm/android/source/res_generated/raw/example.odt: Error: The resource R.raw.example appears to be unused [UnusedResources]
Explanation for issues of type "UnusedResources":
Unused resources make applications larger and slow down builds.
The unused resource check can ignore tests. If you want to include
resources that are only referenced from tests, consider packaging them in a
test source set instead.
You can include test sources in the unused resource check by setting the
system property lint.unused-resources.include-tests =true, and to exclude
them (usually for performance reasons), use
lint.unused-resources.exclude-tests =true.
,
1 errors, 0 warnings (237 errors, 11 warnings filtered by baseline lint-baseline.xml)
FAILURE: Build failed with an exception.
This could also be reproduced locally:
After a
$ touch android/source/res_generated/example.odt
, the above error would on build, and neither `make clean`
nor `make android.clean` would remove the file and thus
fix the problem for subsequent builds.
Add removing the directory to the top-level and Android-specific
clean targets, so either of these commands now takes care of this.
[1] https://ci.libreoffice.org/job/gerrit_android_arm/33845/console
Change-Id: I91c83ce4ddb236d87d7c51f4dcce85e99aae0107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160612
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Icd3535a90fc0a13b1df8f412e8a1a50e9d5e5b08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150052
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
it's usually run bypassing all the dependencies & make parsing using
LD_LIBRARY_PATH=instdir/program make cmd cmd='ALL_LANGS="$(ALL_LANGS)" workdir/LinkTarget/Executable/pocheck'
but it doesn't hurt to also have it as a dedicated target
Change-Id: I742373eb0e4d87ea22c80da0dcaaba7116cd2937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144250
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
this further frees the environment for Windows builders, to reduce the
risk of running into "environment is too large for exec" errors when
attempting to use xargs in a recipe.
Change-Id: I7e0b97163372018edb12329f24bb1dfafeefc526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144235
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: I41f48fd806d56f62d5e16d8f2530e63385eadddb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142025
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id7912ef0ac140688dea773143381de1cc1ed5ea1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141721
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I71e47a53d31b4d5c7e5a4baf85d49b798602865b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141722
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
while there is no builtin support to create a fat binary during the
actual build phase, we have a post-processing script that can merge two
separately built architectures into an universal binary one.
Thus enhance the makefile to support a more convenient way to build the
two archs without the need to manually move the package out of the way
to build the other arch.
1) assemble one architecture's package via
"make mac-app-store-package.prepare"
2) make clean and change targets in autogen.input to build for the other
architecture
3) build the other architecture and combine into universal binary and
also package into the final deliverable via
make mac-app-store-package.universal
(of course you can also use the .prepare target separately also in the
second build, and just mac-app-store-package will build the deliverable
for the current architecture like it did before)
Change-Id: I02c14e9b8c4f6e39d0d50cd3b4ffdd060b2d69bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141557
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: Ifd133889ffdc372831ce753deaca847b46705a53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141415
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
while most of the integration targets are meant to have a nice debugging
environment, others like the vim-ide-integration or also the vscode one
seek to provide a nice editing experience with code completion and code
lookup.
Ideally you'd be able to have the integration available immediately and
can use the editor while a build is running in the background. But from
a fresh builddir make vim-ide-integration (vscode-ide-integration) fails
because of the missing dependency. That dependency probably is optional
for the purpose of just providing a editing environment as opposed to
providing build-targets like the integration does for some of the other
IDEs, so I consider this commit more of a "good enough" workaround for
the time being.
Change-Id: I586445fed849d416fde9804a1e2a9c6ee0ed50eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141248
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
For providing coverage data of features in the LibreOffice code base,
here's a set of files with orthogonal, high-level ODF features like
bold & italic text, an image, a table in several variants etc.
Use `make coverage` or `make sw.coverage` to generate coverage data
for the entire code base, or subsets thereof.
Change-Id: If27f720e8728788c421e16a3abbc1cf39521a2fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139765
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
having one is one of the prerequisites of using TestFlight
Change-Id: I9e20eb99905071fade4179dfbe2da5b7e5dd1c24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136618
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
the network.server entitlement is only needed when the sdremote is
enabled, and the bluetooth one only when the bluetooth part is built.
Also warn about bluetooth not being built because of obsoleted/removed
API. It was "silently" dropped before (lost in the flood of configure
output).
Change-Id: I38d83aa1132307b5b4b5d6dceba8f9020ffb2373
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136617
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Nowadays the bin/find-unneeded-includes script is a better
solution for this problem
This essentially reverts the commits:
c716b3888e7e8150d1c1053ee6550afb56438b1f
096c7e889f3b9bd42a81fb0216e2a68fb27159fc
40e7eecb7efeeb9af59206d7a9c82ac55adf5279
Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
'make python3.all' was renamed to 'make python3.allcheck' (or use 'make python3.allbuild' to build without unit tests)
Change-Id: I5923382595deb952d3760a6173d40614e8ad5043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133343
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Running 'make vs-ide-integration' fails since some recent change
(no idea if that was a cygwin upgrade, or some change in core).
Using 'verbose=t', the last lines are
make[1]: Leaving directory 'C:/lo/src/build'
cd C:/lo/src/core && C:/lo/src/core/bin/gbuild-to-ide --ide vs --make C:/cygwin64/opt/lo/bin/make
python3: can't open file '/cygdrive/c/lo/src/core/C:/lo/src/core/bin/gbuild-to-ide': [Errno 2] No such file or directory
make: *** [Makefile:495: vs-ide-integration] Error 2
It looks like python3 gets called by shell with the script path as
given in the comand line, according to shebang in the script; but
cygwin's python3 can't parse Windows-style path to the script, and
treats it as relative path from cygwin's current directory.
Just use true relative path to the script, to avoid the problem. We
cd to $(SRCDIR) anyway.
Change-Id: Idc25cc74f7a23f0e5733f0d10044986888b43ba1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129930
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
|
|
Change-Id: I8cce598b96b1339afeb40679375a2f0a60ca4d9c
Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129719
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
And just echo a rename info for the 'all' target and exit with
an error, so people will actually adapt. 'all' had been modified
to run 'allbuild' in the original commit anyway. And since there
is no toplevel 'all' target, this just seems consequent.
And .PHONY the new targets.
Also advertise "make help" a bit more at the end of configure.
Follow-up on commit d6496fce2e51a3e44753e6b5c462824f182b48d5
("split gbuild's <module>.all to <module>.allbuild or .allcheck").
Change-Id: Ia74020375f0a024dc67ea37ae4b18655af9df084
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128490
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
This is similar to the removal of the 'all' target in the past.
Using 'make vcl.all' is supposed to build the vcl module and all
its dependencies, the problem is that it builds also tests, which
means not only building and running the tests but also their
dependencies too, so 'make vcl.all' may in fact also build Writer
because a unittest depends on something there.
So now <module>.allcheck is the new name for that, and newly
there's also the (IMO actually useful) <module>.allbuild .
Change-Id: I55baa014a657783e641cee67948ee8fb062b1982
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128349
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
This way we can get rid of the pre-generated locale data and the
special fuzzers target, which invokes a full gbuild make for
every prereqisite, always parsing the whole tree, taking ages.
This also reverts:
- commit d0780b21cfe235c4446adf649eb690f9c1771dd5 ("fix oss-fuzz
build") by adding epubgen and revenge dependencies.
- commit ff25d6a123beb42476bf42d189b3033a86835b2a ("ofz#41602 fix
more build failure"), which shouldn't happen anymore since
commit d47628f287f4377394c4ff488c433bfe254b6abe ("don't want to
link to system static libs for DISABLE_DYNLOADING")
Change-Id: I3aed9ec62da507254b42e4e7470bae1097b4bc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127031
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I9c58294fb607683929d370a5f2707901e2a88548
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127421
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I8cd1203bcdf1b98bb34c0fd1ec38ad3f6af0eaed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127422
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
to be consistent with the other ide integrations and to take care of the
extra step of running "make vim-ide-integration" to create the
compile_commands.json file required by the vscode integration.
Not using the autogenerated file created by configure directly might
also spare some users from having their own additions overridden
Change-Id: Ibb269197dc84f607b28ddad03adc919864e0c040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126860
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
I have no idea, why this was omitted; probably just an oversight.
While a path as the target specifier looks strange to me, e.g.
ids like ComponentTarget_svx/util/svx, they work as expected.
Change-Id: I6dd4d382dddb8ad67cdd397db3b1c985c14cd948
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127023
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Can't use $(gb_VERBOSE), as this runs pre-gbuild.
Change-Id: I7343ede538a246d54f3ce9fcaf104dfbdea08653
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126729
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Build target was kept for backward compat in 'rework the default make
target', so lets retire it after 1.5 years.
Use 'make build' instead (which is since the default target anyway).
Change-Id: I93d5237dce2abf2536a4d847d79d33d5b6d6cec9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126362
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
since...
commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
Date: Tue May 18 01:11:41 2021 +0200
Fix --disable-avmedia for DESKTOP build
Change-Id: I31404c1a4c2ba71fb47388d87b59ecbee87ff603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126324
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
can't use the internal Executable_lockfile because it needs itself to
link
Change-Id: I51e3a910bedc038bb6776cd67d16ea706fbc071f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126285
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
...introduced with e050b09c7ef193da9da4441d9984c793e35b5a8a "gbuild: serialize
dynamic link for static builds"
Change-Id: I31410cfe2291d51a860d33fed1861eb933bbb10e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126264
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4cb2b1aa2b923884f4a2af23d69ff71c66ecef81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126262
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Step #3 - "compile-honggfuzz-address-x86_64": [build LNK] StaticLibrary/libdtoa.a
Step #3 - "compile-honggfuzz-address-x86_64": /bin/sh: 1: /work/workdir/LinkTarget/Executable/concat-deps: not found
Step #3 - "compile-honggfuzz-address-x86_64": make[1]: *** [/src/libreoffice/solenv/gbuild/LinkTarget.mk:833: /work/workdir/LinkTarget/StaticLibrary/libdtoa.a] Error 127
Step #3 - "compile-honggfuzz-address-x86_64": make: *** [Makefile:170: StaticLibrary_dtoa] Error 2
Change-Id: I2dd48297f321b72bb28f993041d5728fd6c68a46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126217
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Duplication of external tarballs in flatpak-manifest.in is a maintenance
nightmare.
The only difference between the current flatpak-manifest.in and the one
generated from:
make -s cmd cmd='${SRCDIR}/solenv/bin/generate-flatpak-manifest.sh master' > org.libreoffice.LibreOffice.json
... is that the current one contains an outdated reference to
zxing-cpp-1.1.1.tar.gz which was upgraded to zxing-cpp-1.2.0.tar.gz
in download.lst.
Change-Id: I98ab9346244f2c0d788da391928fcb4ffebbe23f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124891
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I4595bb2345db025b04073538ae680bd74696260e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124527
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Do not require the IDE version in vs*-ide-integration. Instead, use
VCVER environment variable, that is set in configure, to obtain
the toolset for the VCPROJ files. When introducing support for new
VS version, the 'VisualStudioIntegrationGenerator.retrieve_toolset'
method needs to be updated synchronously to list the toolset.
This simplifies the make command to
make vs-ide-integration
TODO: also set the toolset in configure, to simplify the code here,
and also in places like external/python3/ExternalProject_python3.mk
(see commit c156a8c708f74dd31e1ef024edc578c3915619cb).
Change-Id: I95960029a933be2cab96898eee6be6ca6bc5794a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
VS2017 is not supported since 24973523ba59087185d434396fd614e73d72107f.
Change-Id: I1a2af1eb8c9216eaed87d5454def2176728f719b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123161
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
which requires dropping ---disable-database-connectivity
Change-Id: I5b3a2027916a3cf844cefd90629c3fe918ead31e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
dependencies need to be built with the msan flags so undo the
--with-system .a usage now that trying to squeeze into the 12 hour build
window isn't critical because the afl 6-8 hour build+check is disabled
Change-Id: I3729d37e0f028c5efe62ce5d66ea6fe636d3d0c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120788
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I12e44bf2dbeebc0d18e48a22831099c3dad7b12d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120402
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7e03be4c0137f49b8822991f91fdfe4367653c2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120172
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I67c1c00fa716242336bbad1dd3df079e277ea776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120126
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Regression from commit af70b5b8aa7b9dac3b64ef58968208475f673f5c (Allow
--enable-macosx-sandbox without the codesigning identities, 2020-11-19),
which started to assume that non-Windows means macOS for test-install
purposes.
Change-Id: If3c281b330363eb9c853ce6193e09698835ed765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119908
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
bash appears to remove comments only up to the next line-continuation
backslash/newline pair, while SUS mandates that the "<backslash> and <newline>
shall be removed before splitting the input into tokens", and at least zsh 5.8
follows that interpretation and thus complained about a `then` not followed by a
`fi`
Change-Id: Ifedb002f133a7bc4f79bb9bec3e8c97ccc704aaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119227
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
also fix the file filtering in case directories are passed for recursive
traversal (pdb files are not created in instdir, so that never really
matched our build-env)
Pass a directory to the invocation to make use of that filtering, and
also add a retry in case dump_syms segfaults during processing
(see also 73299faa75a4974eb49c93ffdfb2d6329cb4e519)
Change-Id: I8989c3fd72de0b18eecce490fac81db956f87515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117386
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
while self compiled one still segfaults frequently, it is a tad better
than the included one (and compiling froms source instead of using
precompiled binaries is a net win in any case)
Out of 50 attempts with the mergedlo.dll, the new compiled dump_syms
succeeded 11 times, the shipped one succeeded 7 times - so could still
be regular variance in that small sample size, but at least not
significantly worse either.
Change-Id: I86c213fe6aece58f1391d4c2bf9906b85eee9c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117056
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|