summaryrefslogtreecommitdiff
path: root/accessibility
AgeCommit message (Collapse)Author
2015-02-02callcatcher: remove some unused methodsCaolán McNamara
Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-27tdf#88702 ACCESSIBILITY Toggle buttons state not reliably updatedNiklas Johansson
We need to adapt the accessibility code to handle VCLEVENT_TOOLBOX_ITEMUPDATED, since it is now sent from vcl/source/window/toolbox2.cxx. I have tested the patch successfully on Windows and Fedora. Change-Id: Ia4328d3c34547cc28ce9a3946f90223442ee84e3 Reviewed-on: https://gerrit.libreoffice.org/14190 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-07Accessibility: Expose keyboard short-cuts of menu entriesNiklas Johansson
On Windows the keyboard short-cuts of menu items like "Open Ctrl+O" is not exposed to accessibility tools on Windows. On Mac and Linux it is. If I understand Microsoft's notes correctly, it is expected that the short-cut gets appended to the accessibleName. This is what Acrobat Reader, Internet Explorer, Firefox is doing. And with this patch LibreOffice as well. For info from Microsoft on the matter see: http://msdn.microsoft.com/en-us/library/windows/desktop/dd318482%28v=vs.85%29.aspx Change-Id: I4ed7c4c45998063bb50744b44c792351070489d7 Reviewed-on: https://gerrit.libreoffice.org/13516 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-06fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-08reduce scope of local variablesMichael Weghorn
This eliminates some of the warnings from Cppcheck report of 2014-11-29. Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9 Reviewed-on: https://gerrit.libreoffice.org/13330 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-30fdo#86117 a11y: Exception when closing popup from ToolBox w/o separatorMaxim Monastirsky
For some reason PopupWindowControllerImpl::WindowEventListener is getting the VCLEVENT_WINDOW_HIDE event twice, and while processing the second one the ToolBox no longer has an active down item, which results in a IndexOutOfBoundsException in VCLXAccessibleToolBox::getAccessibleChild, because ToolBox::GetItemPos(0) correctly returns TOOLBOX_ITEM_NOTFOUND. But when a ToolBox has at least one separator, ToolBox::GetItemPos(0) "detects" its position as the current down item, and no exception is thrown. Probably it just hides the bug, because it seems to me that getting the hide event twice is the real bug here. Change-Id: If018350dd91cd959c0c8f7d6859474f95fb8cd1e Reviewed-on: https://gerrit.libreoffice.org/13173 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18convert SV_BMP_ constants to enumNoel Grandin
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-08coverity#1242517 Arguments in wrong order (gold ?)Caolán McNamara
Looks like they are backwards to me Change-Id: I20f38050172c1671a81d6ab7de80123ad1703528
2014-10-03coverity#1242449 Identical code for different branchesCaolán McNamara
Change-Id: I0cffc9df6d971393ae874060a8c306e12966370c
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: Ib36c0f4f8afa0bcaafa0836182e90a9f1d8aff75
2014-09-30loplugin: cstylecastNoel Grandin
Change-Id: Ie5cbad7ee18b0ecbca5df97808431be577449c32 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15accessibility: sal_False/True -> false/trueStephan Bergmann
Change-Id: I4ac9d6ce48217893246a82fde4546dad09c58bd0
2014-09-12toolkit: sal_Bool -> boolStephan Bergmann
Change-Id: I8819d408e8556bbf38605c2feef2fa87d8dd41c3
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-07-18coverity#1132662 Dereference after null checkCaolán McNamara
Change-Id: Ifbaa05e70c8958d0289047efb75a13e0b8a13a4b
2014-07-08use SimpleReferenceObject in svtools moduleNoel Grandin
to replace hand-rolled version Change-Id: I7a1048ff1ea335c3934fe7e91a09489a4d7aeb96
2014-07-08use SimpleReferenceObject in accessibilityNoel Grandin
to replace hand-rolled version Change-Id: I9dd8d02024702972722b43f2654db91eb3da3794
2014-07-04Notify screen readers when selection changes in listboxesNiklas Johansson
When you change selections in listboxes without dropdown fuctionality an accessilble event needs to be sent, this does not happen today. An example of such listbox is the Suggestions in the Spelling and Grammar dialog. Change-Id: I6100c88ae5398d8bf3f511aee7b35e88fbf151f5 Reviewed-on: https://gerrit.libreoffice.org/10087 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-02fix some more indent and strip ::rtl::Caolán McNamara
Change-Id: I8a4f220e6e07babbb2fa8f8dcab524ba90e62986
2014-07-02Related: #i124856# guard against crashJürgen Schmidt
Patch By: hanya Review By: jsc (cherry picked from commit efe87c0d84e5f76034378d48d0d1fc2025a37645) Conflicts: accessibility/source/standard/vclxaccessiblebox.cxx Change-Id: I24fd4278406dacea33230cc1bf1528e3c5aaedf2
2014-07-02fix some mangled indentationCaolán McNamara
Change-Id: I09be3a66562e1c5c1c2b27c670672f63b0a652b0
2014-06-20hmm, that's not rightCaolán McNamara
Change-Id: Id714a54b08127c594c108c824bb0dedd74bb5c06
2014-06-20Dropdown combo-/listboxes should support accessible action togglePopupNiklas Johansson
At least VoiceOver needs it to be able to open the dropdown in a native way (through AXShowMenu). The list still isn't accessible on mac but that is an other issue. Change-Id: I825b54536dfc9743b722eb55873bde3d5eef953d Reviewed-on: https://gerrit.libreoffice.org/9833 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-16fdo#74681: quick help may be used as accessible textJacobo Aragunde Pérez
In case a tool box item does not contain some text to be used as the accessible item name, use the quick help text. Change-Id: I9caadb0989729787d8572f4007652bcab02b0412
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Ie8e6f615b6338b736fafda92a7991642fde47b15
2014-06-10-Werror,-Wundefined-bool-conversionStephan Bergmann
Change-Id: I373d795951120d19bc7664282741d956d1ec3768
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-28update_pchThomas Arnhold
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-27css already means ::com::sun::starThomas Arnhold
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-22Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-19fix-includes.pl: accessibilityThomas Arnhold
Change-Id: I61bd6e7f104f23e5480350a9b1bd6ba31b95a9cb
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-15fix cut and paste into macro editor crashCaolán McNamara
e.g. select all in macro editor in virtualbox and paste into Linux macro editor and explode in debugging iterator land. regression due to IA2 integration of efb23f29983f87104a684e7fab00b84fc59d131d Change-Id: Ic7a4e9f5455f4ba3eaf0afd38fd5e445d6dc28e6
2014-05-09update_pch: add a bunch of pch filesThomas Arnhold
I had to fix some source files because of macro redefinitions and such stuff. Small modules like basic have a great win, too: make basic.clean && time make basic: with w/o pch pch accessibility 23s 1m59s basctl 30s 1m42s basic 56s 1m35s comphelper 23s 51s editeng 48s 2m04s forms 40s 1m40s unotools 19s 38s sd 3m37s 4m33s Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f Reviewed-on: https://gerrit.libreoffice.org/9293 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
generated by cgit (git 2.34.1) at 2025-02-20 15:03:09 +0000