summaryrefslogtreecommitdiff
path: root/android
AgeCommit message (Collapse)Author
2017-02-25Fixed text alignment in listaleksandar-stefanovic
Changed text alignment in file browser to not center horizontally, because it should be glanceable and therefore should be left-aligned (ideally the start-aligned). See https://material.io/guidelines/components/lists.html . Change-Id: I383141bc2f49b63927c136d911f50cfd15bdef45 Reviewed-on: https://gerrit.libreoffice.org/34290 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-17tdf#99967 Drop Web WizardSamuel Mehrbrodt
Change-Id: Ibc0f45a03e16f3fe4ee54b24de30ba88e43a4aab Reviewed-on: https://gerrit.libreoffice.org/26381 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-16Fixed the runtime crash of app by catching exceptionbrainbreaker
Steps to reproduce crash: Click on remote server option in navigation menu, in case of invalid server URL it will show a toast. Then click on Storage Provider Settings once and press back, app will crash throwing runtime exception. The exception is not catched anywhere so Java runtime exits the app Change-Id: I2bccca633e62fec82c868661f14765596c4b83f1 Reviewed-on: https://gerrit.libreoffice.org/34166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-15Fixed the margins of list items of File Recycler Viewbrainbreaker
Screenshots of the change:- Before: 1. https://s19.postimg.org/bbs91keyr/Screenshot_20170212_182941.png 2. https://s19.postimg.org/k5j5io1xf/Screenshot_20170212_183334.png Now: 1. https://s19.postimg.org/4o08spkub/Screenshot_20170212_222359.png 2. https://s19.postimg.org/5p0hhu1tv/Screenshot_20170212_222406.png Change-Id: I3137ce2648c4dda30d7bbe93245618a83e9048c0 Reviewed-on: https://gerrit.libreoffice.org/34175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-14Moved file filtering to a menu optionaleksandar-stefanovic
Moved file filtering from a toolbar spinner to a menu option. The toolbar title is now free to display some other information. The options are grouped, so they display radio buttons, and show which item is selected. The radio group default selection is the one defined in the settings. Change-Id: Ib8d8716ec0038d2cd273423c756563680b84ae55 Reviewed-on: https://gerrit.libreoffice.org/34019 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-13Fix typosAndrea Gelmini
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-12Changed description of setting entriesaleksandar-stefanovic
Changed to make more sense to non-tech-savvy users. See https://material.io/guidelines/style/writing.html for writing guidelines. Changed grid default value from string to integer, since the value is effectively an integer, and no point in being a string. Change-Id: I6c1737927e7f9d20536756c3cb8b7059cf49500b Reviewed-on: https://gerrit.libreoffice.org/34074 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-11Moved "storage provider settings" to nav draweraleksandar-stefanovic
Moved "storage provider settings" to the navigation drawer, because it makes more sense to put it below the storage options, than in a overflow menu. Also, switched positions of "Settings" and "About", because About is always the last item, by convention. Change-Id: If6d621abfee7a3bdda28311a9cadf35ea674f852 Reviewed-on: https://gerrit.libreoffice.org/34073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-10Default Value added to File Explorer View Preferencebrainbreaker
Change-Id: Ibbca76cae7fb189d94c37397ad49e9cff2755cd2 Reviewed-on: https://gerrit.libreoffice.org/34082 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-09Explorer File View option in Settings working nowbrainbreaker
Explorer file view option in Settings is working now. To listen to the preference updates in the app a custom class SettingsListernerModel has been added. SettingsListenerModel.java file contains the methods to instantiate and set OnSettingPreferenceChangedListener in the implementing class. LibreOfficeUIActivity implements this listener and it is triggered by onSharedPreferenceChanged() method in SettingsActivity. This class can also be used to listen to other preference changes in Settings. Change-Id: I063024df01cf183d2a6211648e32805795af20a9 Reviewed-on: https://gerrit.libreoffice.org/34012 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-07android: move sort options to separate menualeksandar-stefanovic
This is one in a series of commits of trying to unclutter the context menu, which was pretty unorganized. Change-Id: I8a9473041730492a0b60c6b71fd7fd7996cedd89 Reviewed-on: https://gerrit.libreoffice.org/33768 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-07Add recents files to the document browseraleksandar-stefanovic
The recents mechanism works like this: Every time the file is opened, it saves that file to the shared preferences set, by putting it in the first place, and removing the oldest file from the list, if there are more than 4 recent files. It also adds dynamic App Shortcuts if the device is 7.0 and above. Screenshot: http://imgur.com/a/7kWOl Edited the layout to add a new RecyclerView for recent items, as well as the headers for both the recycler view's. Recent files appear only if in home directory, below app bar and above the file browser. This could be subjected to change in the future. Screenshot of the recents section: http://imgur.com/a/qrqZq Change-Id: I5c99aa26351d9ad2313e18b5b696d04a782e6155 Reviewed-on: https://gerrit.libreoffice.org/33759 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-07Removed static context from DisplayPortCalculatoraleksandar-stefanovic
Refactored many fields of DisplayPortCalculator to not be static, so that they could use the Context object from the constructor. Once refactored, the static context object could be removed from LibreOfficeMainActivity. Change-Id: Ic23030b74a24c753a4a2d2086fc6301eeb9d8728 Reviewed-on: https://gerrit.libreoffice.org/33765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-06Retaining the default file explorer viewbrainbreaker
Change-Id: I273ee17fc94e9d6e3b73ca0b9a4853a632123bd0 Reviewed-on: https://gerrit.libreoffice.org/33946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-31Removed static context from LOKitThreadaleksandar-stefanovic
Moved LOKitThread back to LibreOfficeMainActivity, so that it could use the context in the constructor. Once the Context became available in LOKitThread, it was simply a matter of replacing static references with the one passed in the constructor. Also changed access levels of some methods in LOKitThread. Change-Id: I0cc2c846c67b90907cbf3dce363666f9ab02d887 Reviewed-on: https://gerrit.libreoffice.org/33546 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-31Removed static context from JavaPanZoomControlleraleksandar-stefanovic
Removed static context, and edited the access levels of some methods in the classes, along with some general code style fixes. Change-Id: I89c71fa38eaafb5cda721602cfc8dad10ba7d26a Reviewed-on: https://gerrit.libreoffice.org/33557 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-31Removed static context from LOKitTileProvideraleksandar-stefanovic
Removed references to static context, replaced them with the context object already available in the class, and changed access levels on some methods in LOKitTileProvider. Change-Id: Ib52d325650377b77ec166ddbfb760f74c19067ff Reviewed-on: https://gerrit.libreoffice.org/33554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-26Moved About dialog to DialogFragmentaleksandar-stefanovic
This makes the dialog more modular, and it takes no parameters instead of two. This is in the preparation of making the classes more independent on each-other's states, which is very important. Also, this follows the Android way of workflow better, since there is no "wrapper" class around the dialog, but instead the dialog is called directly. Change-Id: I7571480a040efaf202fae3929cfe76d65c19653e Reviewed-on: https://gerrit.libreoffice.org/33086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-25Replaced empty spinner with the document titlealeksandar-stefanovic
Replaced empty spinner with the document title in the Main (viewer) activity. Had to edit the themes to not disable title, and edit the manifest to make the desired activities use that theme. If the theme is set in the "application" tag, it will apply the theme globablly. Also cleaned up and tightened the ToolbarController. Change-Id: I5099860787b5f84d01c98c5e53ade519c2f89cc4 Reviewed-on: https://gerrit.libreoffice.org/33306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-25Reduce usage of memory-leaking Context objectaleksandar-stefanovic
Huge refactoring of the methods to use the passed instance of the Context object instead of using the static one. I couldn't completely remove the static object, because it requires restructuring of the workflow so that it originates from the activity, and not from some other random place. The way it was refactored is: 1. Find a place where the static object (LibreOfficeMainActivity.mAppContext) is used. 2. Add a LibreOfficeMainActivity object to the method signature. 3. Repeat the process with a method that calls it, and repeat until the LibreOfficeMainActivity object isn't available, so that it can be passed through all the methods, to the place where the static object was used. 4. Replace that static object with the parameter of the function. The commit looks pretty huge, but it's basically just the simple refactoring explained above. The memory leak isn't completely gone, but this a progress towards it. Also moved the "global" objects of Handler and LOKitThread from an Activity to an Application, which is the correct place for "global" variables. Can someone explain why Handler and LOKitThread are used? They seem to mostly do nothing, but steeply increasing the complexity of the application. Change-Id: Ib2be77fa3adea94d6b7849d0e2afa90bf318d68b Reviewed-on: https://gerrit.libreoffice.org/33073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-16Cleaned up FormattingControlleraleksandar-stefanovic
It was coded pretty badly, so I cleaned it up. Most notably, it used a static instance of the Activity, which is a huge no-no which creates memory leaks. The irony is, it already had a reference to the Activity used correctly in the constructor. One memory-leak fixed, 29 more to go (LibreOfficeMainActivity holds that static Activity object which needs fixing). Also, simplified the "bottom toolbar" in preparation for the CoordinatorLayout implementation which will allow the activity to have fancy animations and smart interactions. Change-Id: I31aa117f6179910db73a5256b0a287357e1dec83 Reviewed-on: https://gerrit.libreoffice.org/33010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-16Fixed typo in SearchControlleraleksandar-stefanovic
Fixed typo in SearchController (SearchDriection -> SearchDirection) Also tightened up the code. Change-Id: Iedb6f95c9d8ed04cc166638250c2d565e92d79ff Reviewed-on: https://gerrit.libreoffice.org/33011 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-16Replaced list and grid with RecyclerViewaleksandar-stefanovic
Because RecyclerView is more optimized, especially if there are lot of items. This way, we don't have to recreate ListView and GridView each time we switch view modes. Changed list adapter to appropriate RecyclerView adapter, and created new grid adapter inline, next to the list adapter, while deleting the older grid adapter file. Since these adapters are almost identical in content, maybe we could: a) Make them extend the same "base" adapter, to avoid duplicate code b) Unite them into one adapter which would display appropriate views at appropriate times. Change-Id: I1545c2c245ca642a689dee584bffb15f90aac4a6 Reviewed-on: https://gerrit.libreoffice.org/32976 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-16Revamped the navigation draweraleksandar-stefanovic
Replaced the custom implementation of the drawer with the support library one. This one inherently follows Material Design guidelines, and is much easier to maintain. This implementation also allows for header in the drawer, and so we could put something useful there to make the drawer even better. Also kept the original way of programatically adding the menu items, although I find this practice somewhat unelegant. Maybe we could have static list of items, and then grey-out the ones that aren't currently available? Also added appropriate icons to the menu items (which are vector drawables, of course), but I only covered the providers that appeared on my device (I can't confirm that there are no other providers), so if the provider is covered, it will have an icon, but if I didn't cover it, it will appear just fine, but without an icon. Maybe we could move the settings and sorting to the navigation drawer, also? It would be cleaner and more elegant, IMO. Change-Id: I02a051f0b75c6d4e16f518aa19fb9c6eef00f5e4 Reviewed-on: https://gerrit.libreoffice.org/32881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-13tdf#101689 - Fix returning to first part of documents when resumedMert Tumer
Change-Id: I6d3a9354c702628e991c69176086efbbc28ddd74 Reviewed-on: https://gerrit.libreoffice.org/31753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-11Folder icon redesignaleksandar-stefanovic
Replaced old and busted icon design, with Google's generic app icon. It is now a vector drawable, which means it will be sharp at any resolution, while we only need to keep one tiny xml file for it. No folder thumbnail support, but this a welcomed change nontheless. Change-Id: Ie6e38a6ac8e6cf1bc2d22247c11b5de0bd0d8478 Reviewed-on: https://gerrit.libreoffice.org/32498 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-11Updated toolbar spinner to newer implementationaleksandar-stefanovic
Lowered all-caps navigation labels to something more professional. Added a Spinner to the Toolbar in XML. Reworked many lines of LibreOfficeUIActivity to remove possible NPE's, and also removed redundant lines, which were mostly deprecated, as well as switching to a newer implementation of a toolbar-spinner navigation pattern. There are more deprecated methods, but I wanted them in a separate commit. Change-Id: I15d5365ed7c00880873bf7874bc794008436bb99 Reviewed-on: https://gerrit.libreoffice.org/32497 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-11Removed unnecessary importsaleksandar-stefanovic
Import redundancy reported by Android Studio. Change-Id: If46a43bb18268877d41d4957094acc543c4588fd Reviewed-on: https://gerrit.libreoffice.org/32496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-11Bumped version numbers in Gradlealeksandar-stefanovic
It builds correctly. Note that the target version remained the same (22) instead of the current 25. Change-Id: Ic14fc5b2e5aa04d621e86249d33c1d6d9bdce3c2 Reviewed-on: https://gerrit.libreoffice.org/32495 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-24tdf#104856 - Fix for closing the document without asking for savingMert Tumer
Change-Id: I37b6fbf2639439a57c6d162b7817d009d1d49023 Reviewed-on: https://gerrit.libreoffice.org/32332 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-06tdf#103524 - Fix Bottom Toolbars closing operationMert Tumer
Added variables to control state of bottom toolbars, and based on their state open/close the bars Change-Id: I5f9429b336451a354b95dcee18b71fb577c28559 Reviewed-on: https://gerrit.libreoffice.org/30298 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-26android: launcher icon should be mipmap, not drawableChristian Lohmaier
as non-native mipmap resolutions don't get stripped from the apk (as drawables would), but launchers and similar might still want to show the higher-res version instead. Google Play store now enforces this. Also rename to the common name for it ("ic_launcher" instead of "main") Change-Id: I97318287f05556f5db0afaa0b23c0d8c9628465e Reviewed-on: https://gerrit.libreoffice.org/31204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-11-16bump gradle plugin, build-tools and support lib versionsChristian Lohmaier
Change-Id: I94036432e23b2d73b6e2006ed49f9890ae11aa05
2016-11-10re-apply "use material style selection handles""Christian Lohmaier
and account for the libreofficekit changes This reverts commit 50e9065cbbb2c62fa925cf5b561a85c715a0eb1e. that did in turn revert 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3. Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01
2016-11-10temporarily revert "use material style selection handles"Christian Lohmaier
the linux build / libreofficekit also uses those and needs to be told about this change as well. This reverts commit 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3.
2016-11-10bump gradle/gradle-plugin to instant-run compatible versionsChristian Lohmaier
Change-Id: Ib0d2dac42814c9daf752f0421922fb093507eb7c
2016-11-10refresh app icons to flat/material styleMirek Mazel
Change-Id: I0c0a8a540eccc022c405659f53da73bd87eced18
2016-11-10use material style selection handlesMirek Mazel
Change-Id: If42bf5757e2010fccc7061ccffda76048b2e0dda
2016-10-26normalize existing emacs/vim mode-lines in python filesMichael Stahl
Bunch of these were setting C++ or Make modes and icky tabs... Also, reportedly Emacs can figure out to enable python-mode automatically. Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
2016-09-19tdf#101919: rename ownCloud to Remote serverJulien Nabet
Change-Id: I217fdc805ce425f8a4a17d0d0e924e532ec070de Reviewed-on: https://gerrit.libreoffice.org/28983 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-09-19tdf#96797 - Android: Viewer file filter is not working on ownCloudMert Tumer
Change-Id: I6ffb450d935ae1f7b4900243b9ff2f8df408628f Reviewed-on: https://gerrit.libreoffice.org/27829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-19tdf#101260 - Android: Filter in External SD doesn't workMert Tumer
Change-Id: Iaba74749c11cbac972fecf816e5bb090edd9e06c Reviewed-on: https://gerrit.libreoffice.org/27802 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-09tdf#96810 - Fix Android Viewer: Keyboard can not hide with keyboard button.Mert Tumer
Change-Id: I87d83953094d31ed4e1bcf60c55dd19056a7994e Reviewed-on: https://gerrit.libreoffice.org/28005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-08-28tdf#96771 - bug fix for owncloudfiles with white space charactersMert Tumer
Change-Id: I373db55ed819ed5d2a574ba2590032ee628218f4 Reviewed-on: https://gerrit.libreoffice.org/27634 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-02android: prevent crash if storage is unavailableChristian Lohmaier
Change-Id: I350acc1735d5fd22a27434fc5ccf2ab39bf3d2cf
2016-07-01lokdocview: replace handle_graphic.png with manual drawingMiklos Vajna
If we draw a black graphic handle manually, then it's possible to color it later, this isn't easy if a bitmap is painted. Change-Id: Ib4456fd5155862d52e3ffa79ee49c7bfd16fb742 Reviewed-on: https://gerrit.libreoffice.org/26860 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-01tdf#99539 - fıx crash on android 5.1Mert Tumer
Change-Id: I3d484f7d7d9e466ae1b2ac4afe2b59d060fa8b77 Reviewed-on: https://gerrit.libreoffice.org/24537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-29 01:57:52 +0000