summaryrefslogtreecommitdiff
path: root/apple_remote
AgeCommit message (Collapse)Author
2020-02-21Blind fix of -Werror,-Wpointer-to-int-cast in apple_remoteStephan Bergmann
(That warning is probably new in recent Clang 10 trunk, hence the issue only got reported now.) To me, this looks like a bug introduced with > commit aaf218d025326ef54dcbc724b33666d7ddcff187 > Author: ericb2 <ericb2@apache.org> > AuthorDate: Sun Oct 30 22:57:34 2011 +0000 > Commit: Thorsten Behrens <tbehrens@suse.com> > CommitDate: Mon Dec 5 13:00:11 2011 +0100 > > Propragating the modif in the implementation (HIDRemoteControlDevice.m) > > * found under MIT-style at svn rev 1195272 (http://svn.apache.org/viewvc?view=revision&revision=1195272) > > diff --git a/apple_remote/HIDRemoteControlDevice.m b/apple_remote/HIDRemoteControlDevice.m > index 94215900717b..2cd7506e60d3 100644 > --- a/apple_remote/HIDRemoteControlDevice.m > +++ b/apple_remote/HIDRemoteControlDevice.m > @@ -281,7 +281,17 @@ - (void) handleEventWithCookieString: (NSString*) cookieString sumOfValues: (SIn > > NSNumber* buttonId = [[self cookieToButtonMapping] objectForKey: cookieString]; > if (buttonId != nil) { > - [self sendRemoteButtonEvent: [buttonId intValue] pressedDown: (sumOfValues>0)]; > + switch ( (int)buttonId ) > + { > + case kMetallicRemote2009ButtonPlay: > + case kMetallicRemote2009ButtonMiddlePlay: > + buttonId = [NSNumber numberWithInt:kRemoteButtonPlay]; > + break; > + default: > + break; > + } > + [self sendRemoteButtonEvent: [buttonId intValue] pressedDown: (sumOfValues>0)]; > + > } else { > // let's see if a number of events are stored in the cookie string. this does > // happen when the main thread is too busy to handle all incoming events in time. (which indeed appears to be a faithful copy of all the non-whitespace changes made at the cited <http://svn.apache.org/viewvc?view=revision&revision=1195272> "Propragating the modif in the implementation (HIDRemoteControlDevice.m)"). I assume that my fix here is what was originally intended, but I don't know how to actually test this code (if it is still testable at all). Change-Id: If8faa8e068c7d7dffb4677efdaa5896cf6fd4c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-11Fix typoAndrea Gelmini
Change-Id: I1b5424df5b26cd18b6f28e48b8a1c3e4a3f1d0c8 Reviewed-on: https://gerrit.libreoffice.org/70576 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-21loplugin:indentation (macOS)Stephan Bergmann
* Some .m/.mm files that still contained tabs instead of spaces have been cleaned up with Emacs' untabify (and apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions): apple_remote/source/GlobalKeyboardDevice.m apple_remote/source/HIDRemoteControlDevice.m apple_remote/source/KeyspanFrontRowControl.m apple_remote/source/RemoteControl.m vcl/osx/a11yrolehelper.mm * Some of the changes predate 0626e66d761de18f62e4d00d427903032da9d517 "Avoid loplugin:indentation after preproc conditional inclusion lines" and would likely have no longer been flagged since. Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f Reviewed-on: https://gerrit.libreoffice.org/68090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-06Fix typoAndrea Gelmini
Change-Id: I1ba3434d13b8976ee80a8c45c137dccf27cecac7 Reviewed-on: https://gerrit.libreoffice.org/67432 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-12Following tdf#111561: no need to autorelease "elements" (apple_remote)Julien Nabet
Change-Id: Ic074af74a9f48618ac1c4b3752b15661f2003815 Reviewed-on: https://gerrit.libreoffice.org/43333 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-11tdf#111561: try to fix leak in HIDRemoteControlDevice (apple_remote)Julien Nabet
Change-Id: I6539f1cc9612eb3380381a54d3d1d674fd66cc03 Reviewed-on: https://gerrit.libreoffice.org/43329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21Typo notifcation->notificationJulien Nabet
Change-Id: I411105f1a3d519dd08bee55c722e4a06a14f238d Reviewed-on: https://gerrit.libreoffice.org/41368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-07loplugin:oncevarStephan Bergmann
Change-Id: I9d6902d86c9b72ad28a025374077ef90a350e598
2017-03-30loplugin:loopvartoosmallStephan Bergmann
Change-Id: Idd385c764778313bfb419a04ca7a3884b78e88f6
2017-03-26Fix typosAndrea Gelmini
Change-Id: Idbf0aa261b829e83d4c08a2e989a4ced871dc6de Reviewed-on: https://gerrit.libreoffice.org/35616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-09loplugin:externvarStephan Bergmann
Change-Id: I35449ee2d7294024fde83e36af83311a08a7ccae
2016-10-05SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP around new macOS 10.12 deprecationsStephan Bergmann
...for now Change-Id: I64a0a8f6a006d75b6f82d7aae570aef414984a78
2016-03-07apple_remote: autorelease --> release in dealloc (destructor)Douglas Mencken
using autorelease here leads to “just leaking” because there's no autorelease pool for thread besides, make sure that released fields do not contain used•to•be•a•valid•pointer value Change-Id: Id6cb37643230f64dbe9f6128f52236f04d0c88e4 Reviewed-on: https://gerrit.libreoffice.org/22981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07apple_remote: fix “variable set but not used” for non-debug buildsDouglas Mencken
Change-Id: I038fd0bee0e983a91557226aaba1dcff56512ccb Reviewed-on: https://gerrit.libreoffice.org/22856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann
Change-Id: Ie5a52b097ff2992de5cc82ba0d303618b44e3213
2014-11-01Fixed license encoding to have all the same apple_remote/source/*Andrea Gelmini
Change-Id: Ibeee5a8c49f2d4710de6a1e0ee2013f3755a177b Reviewed-on: https://gerrit.libreoffice.org/12149 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-04-28prefer makefile-gmake-modeTakeshi Abe
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-02-25Remove visual noise from apple_remoteAlexander Wilms
Change-Id: I12bec42cb699d8cbcfab2eb4d2f8ad8f5ed83b78 Reviewed-on: https://gerrit.libreoffice.org/8229 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10Resolved: #i124201# mark debug-infos from the apple_remote...Herbert Dürr
module appropriately to make the source of some log messages more clear (cherry picked from commit fe4ae4735c5a5e2b2210e684e97228cd91174e4c) Conflicts: apple_remote/AppleRemote.m apple_remote/source/HIDRemoteControlDevice.m apple_remote/source/RemoteControl.m apple_remote/source/RemoteControlContainer.m Change-Id: Ie57114f4d2d67f258808d03e01dff8bc05ba9f2c
2014-02-10Resolves: #i124201# rename apple_remote's MainController...Herbert Dürr
to AppleRemoteController having a MainController class in the global namespace of an application with gazillions of MVC patterns is not a good idea. Renaming it to better match its scope (i.e. the Apple Remote) cleans this up. (cherry picked from commit 8ef3836059ca613d125f66e6bad21c83200dadad) Conflicts: apple_remote/source/RemoteMainController.m include/apple_remote/RemoteMainController.h vcl/inc/osx/saldata.hxx vcl/osx/saldata.cxx vcl/osx/salinst.cxx vcl/osx/vclnsapp.mm Change-Id: I1f252ac51ef65966a48ee03b2cd3519f98d57383
2013-09-07s/wiki.services.openoffice.org/wiki.openoffice.org/gAndras Timar
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-08-30ENABLE_MACOSX_SANDBOX Harmonize ENABLE_* variable to TRUE/<nothing>Norbert Thiebaud
Change-Id: Ice05796a9887c4ff311b78fcddd9820e0f06e7f1 Reviewed-on: https://gerrit.libreoffice.org/5708 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-22The AppleRemote code is blocked by sandboxing so bypass it in that caseTor Lillqvist
Change-Id: I0e86c82fb81732468cf0a60eb8ff1d0579986767
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-04-24gbuild: drop empty use_packages callsDavid Tardon
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: https://gerrit.libreoffice.org/3503 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23execute move of global headersBjoern Michaelsen
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-21blind fix for MacOS X build problemDavid Tardon
Change-Id: I56f0fd27fa246643d611f9fc6a9f1bcfed759c60
2013-04-15fdo#60724 successfull -> successfulThomas Arnhold
Change-Id: I287bef5b7f2baf5aaaab47141267ae2cadfe2451
2013-04-07Drop workarounds for Mac OS X SDKs 10.4 and 10.5Tor Lillqvist
Change-Id: Ifa07f9b5613b4a75c5b72178cb276b9c0b495a62
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks
2013-02-28remove all d.lstMichael Stahl
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2012-12-18Replace GUIBASE checks with equivalent OS checksTor Lillqvist
The idea is to get rid of GUIBASE and GUI checks as much as possible. GUIBASE=aqua <=> OS=MACOSX GUIBASE=WIN <=> OS=WNT GUIBASE=cocoatouch <=> OS=IOS GUIBASE=android <=> OS=ANDROID Don't set GUIBASE to these values any more in configure.ac either. GUIBASE_FOR_BUILD is not used anywhere. Conflicts: configure.ac postprocess/packcomponents/makefile.mk postprocess/packregistry/makefile.mk Change-Id: Ie0526b40e1073f2328ba6c333e28752104b0fed3
2012-09-28gbuild: clean up Mac OS X framework handling:Michael Stahl
There are currently 3 different mechanisms being used for frameworks, which is of course intolerable so we invent a 4th one and standardize on it: gb_LinkTarget_use_darwin_frameworks (This doesn't mean using add_libs or externals was wrong, it was just inconsistent... and i don't see an obvious benefit of using externals here) Change-Id: I5de9020402c87e7236c6a358c47f02fa56642d3d
2012-07-28WaE: cast from pointer to integer of different sizeTor Lillqvist
Change-Id: I28195a347dd63b7e44268a396aa70150c917e55f
2012-07-28WaE: format specifies type 'int' but the argument has type 'void *'Tor Lillqvist
Change-Id: I0b8fad6adcef16fb93e4cc0d1beec8e5ae2a3c79
2012-05-08ImproveTor Lillqvist
Change-Id: I4a822a8f132f91c1b21ead4e1811b04323485356
2012-05-08Bin a line of apparently meaningless and wrong Mac OS X codeTor Lillqvist
When LibreOffice is compiled against the 10.6 SDK and run under gdb, the apple_remote code caused "cannot init a class object" exception messages to be printed. Upon closer inspection this was caused by the call to [super init] in the sendDistributedNotification class method of the RemoteControl class. As far as I understand, calling [super init] and assigning its return value to self, even, is pointless and wrong in a class method. This code apparently has not been causing any harm when built against the 10.4 SDK. This is probably just accidental thanks to a more lenient Objective-C runtime getting used? When built against the 10.6 SDK, though, the resulting Objective-C exception seemed to make input event handling non-functional. After this fix LibreOffice built this way works better. Change-Id: I I I383611753f3f83a9efa4694b1900c8b66ed1a8e3
2012-05-08Add Emacs and vim mode linesTor Lillqvist
Change-Id: I8ccb7be448faf42904eb6246a4f5a06ff8028ffc
2012-04-29make gbuild the default assumption of build.plBjoern Michaelsen
this removes dmake completely out of the build for migrated modules build.pl now assumes modules to be gbuild, unless there is a prj/dmake file Change-Id: I674a036b182ee13c5ec093e83cb3d38133112d3b
2012-04-08LinkTarget.mk: remove gb_LinkTarget_add_package_headersMichael Stahl
2012-02-29add missing dep on headers' packageDavid Tardon
2012-02-08Added and improved READMEs for modules whihc used to be in libs-externJosh Heidenreich
2012-02-05gbuildify apple_remoteNorbert Thiebaud
2012-01-28Revert "gbuildify apple_remote" need to have soenv2 merged beforeNorbert Thiebaud
This reverts commit 3d75a28274b2fb299c5a2ff5b017984054cac873. This will be pused again _after_ feature/soenv2 is merged
2012-01-28gbuildify apple_remoteNorbert Thiebaud
2012-01-27Decrease verbiage a little bitTor Lillqvist
2011-12-05Propragating the modif in the implementation (MultiClickRemoteBehavior.m)ericb2
* found under MIT-style license at svn rev 1195274 (http://svn.apache.org/viewvc?view=revision&revision=1195274)
generated by cgit (git 2.34.1) at 2024-12-26 17:21:26 +0000