summaryrefslogtreecommitdiff
path: root/basctl/source/basicide
AgeCommit message (Collapse)Author
2013-07-13use static LanguageTag::convertTo...() for standalone conversionsEike Rathke
If no LanguageTag instance is at hand use the static methods to convert between BCP 47 string, Locale and MS-LangID instead of creating temporary instances. Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-06-27improve performance switching modules in large Libraries fdo#66148Noel Power
object catalog when updated, updates ( all ) entries and was parsing the source for every method in every module Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
2013-06-27Revert "tweak object catalog to improve switching modules in large Libraries"Noel Power
This reverts commit 21eeeccfa64a4c03554c1fe3715d38c1695245ab.
2013-06-27tweak object catalog to improve switching modules in large LibrariesNoel Power
object catalog when updated updates ( all ) entries and was parsing the source for every method in every module Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
2013-06-15Related: #i108689# Invalidate Basic IDE slots to trigger feature updateAriel Constenla-Haile
(cherry picked from commit 060758a289c134548d8ad376eaca3d24ea84a0db) Conflicts: basctl/source/basicide/baside2b.cxx basctl/source/basicide/baside3.cxx Change-Id: I2bbe4eeae9b2e4d3ad257b26a6a9694deeaaa87c
2013-06-03fdo#46808, Convert XMultiServiceFactory to XComponentContextNoel Grandin
Change-Id: Ice5ec3a056f7f2f5184523bda1c709ccac876736
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-16Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
Change-Id: Ie154eadd9960b159f5a250cde93c4bd7a8a948cf
2013-05-02Related: #i120515# fixed memory leakArmin Le Grand
(cherry picked from commit b24737fc55e797d03002d44a1fa325a101617c55) Change-Id: Ib59957fb2c9e198012898293aaa2e5afbe561ef4
2013-05-01convert message box return types to an enumCaolán McNamara
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-22Replace chained O(U)StringBuffer::append() with operator+anuragkanungo
modified: basctl/source/basicide/basides2.cxx Change-Id: I681188553058ac8712365bc2de39b0453fd19ed9 Reviewed-on: https://gerrit.libreoffice.org/3546 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-20fdo#63154: Change Min/Max/Abs for std::min/max/absMarcos Paulo de Souza
Now all these usages were removed from LO. Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Reviewed-on: https://gerrit.libreoffice.org/3326 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-12Should initialise Module::mpModule to 0Tor Lillqvist
Change-Id: Ie4648b82a524a7ddcd427d7d2543bc7691eddcf8
2013-04-12Get rid of GetAppData(SHL_IDE)Tor Lillqvist
It seems to be used only locally in basctl so there is really no reason for it. Change-Id: I9ad0a67621e190257e028fd3689f692e639eaf56
2013-04-09use common image from res/ folderAndras Timar
Change-Id: I89203c277277d409cfe46f62af82b2621c9101b2
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-01write even better codeThomas Arnhold
Change-Id: I0f193b9c17da5855fd515251543afc68b8885b9b
2013-04-01remove boilerplate commentsThomas Arnhold
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-03-30Use OUString in basctl(basicide)Chr. Rossmanith
Change-Id: I176088d3d33f02a1721e4027571a1f22dc6bd986 Reviewed-on: https://gerrit.libreoffice.org/3116 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-29ResMgr with LanguageTagEike Rathke
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-28Use OUString and sal_Int32 in GetTextWidth()Chr. Rossmanith
Change-Id: I0b3cdbe8576300d098027cc98d7dff841d148f18 Reviewed-on: https://gerrit.libreoffice.org/3097 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-27-Wunused-macrosStephan Bergmann
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-22String::AppendAscii cleanupRicardo Montania
Change-Id: I3c1ff291488b7747e143982aa7ea95169175c2c2 Reviewed-on: https://gerrit.libreoffice.org/2914 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-19further OUString cleanupThomas Arnhold
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-13make sure basic IDE cut/copy buttons on toolbar are refreshed fdo#30545Noel Power
Change-Id: I483469f0b76ade7fb107c6f4ae5c28a4b03877b1
2013-03-12Abbreviate Rectangle as Rect, not RecTor Lillqvist
Change-Id: If38a5d23150bcd19a6eb6024c2ef1eea826898f5
2013-03-11fdo#38838: Converting String/UniString to OUStringelixir
Change-Id: If64db96005fcd8a42e4fa24041867b99183965f9 Reviewed-on: https://gerrit.libreoffice.org/2586 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08fdo#60691 add modelines to *.src and *.hrc filesBorim
use solenv/bin/add-modulelines script for the task and remove all UTF bom from *.src and *.hrc files svx/source/dialog/hdft.src Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-05fdo#38838, replacement of String with OUStringÁdám Csaba Király
Replaced String with OUString in mediawindow.cxx, basdoc.cxx, basdoc.hxx and bastype3.cxx. In other files I only replaced, what was necessary for the changes in basdoc to work. Change-Id: I1ad0e7e262f8becdf57f182853aaa914a88895a4 Reviewed-on: https://gerrit.libreoffice.org/2554 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
2013-03-04fdo#38838, change String to OUStringÁdám Csaba Király
Change-Id: I373f5d2f453dff83141a4cdaeed94ce0268bf70c Reviewed-on: https://gerrit.libreoffice.org/2497 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-02-25loplugin: unused variablesThomas Arnhold
aErrorText usage was commented out since 2000. Change-Id: Ic4d81c2d48e59a36e2f4280ceb36ea8148b9dc9d
2013-02-23sal: update log areasThomas Arnhold
Change-Id: Id7b2c7e871abf19b70f427095371c6a6c0208607
2013-02-22fix editeng and basctl buildCaolán McNamara
Change-Id: I0d70449ad9b42219969c82e2054694c4a5830dcf
2013-02-22coverity#982443 Explicitt null dereferencedNorbert Thiebaud
Change-Id: I470c34c38eda673e6663b23cdb28ea4be0bef914 Reviewed-on: https://gerrit.libreoffice.org/2218 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22coverity#735665 Dereference after null checkNorbert Thiebaud
Change-Id: I9d217789116602838dabbf93e81ab8d0467c5c7b Reviewed-on: https://gerrit.libreoffice.org/2217 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22coverity#735664 coverity#736134 coverity#736135 Dereference NullNorbert Thiebaud
Change-Id: I1a5c7d7bb2d60a43bb6197fc04a01d981a1396d1 Reviewed-on: https://gerrit.libreoffice.org/2215 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-18coverity#735601 coverity#736164Norbert Thiebaud
Change-Id: I5805d749ba32bec778ae98e9b30ba68d74cc44c3 Reviewed-on: https://gerrit.libreoffice.org/2219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-16Move SyntaxHighlighter class from svtools to comphelperAndras Timar
We use this class in helpcompiler, and it is not desirable to compile svtools (thus half of LibreOffice) for a build tool in cross-compiling environment. Change-Id: I5e6bc3e576af41eb03c1420dd347c542306f69fa
2013-02-13String to OUStringAndras Timar
Change-Id: Ibb0b1808532622ffb2dfc55d533428f6d72b890c
2013-02-12fdo#46808, script::DocumentDialogLibraryContainer needed a new constructorNoel Grandin
Change-Id: I44184dc45150e9b3b8ca4b838ea88ad260578b93
2013-02-12fdo#46808, script::DocumentScriptLibraryContainer needed a new constructorNoel Grandin
Change-Id: I9a657cf3fd7715b4890257e1aa4d97d0cf79cecc
2013-02-12fdo#46808, Adapt ui::dialogs::FilePicker UNO service to new styleNoel Grandin
Change-Id: I1cafbfc53994e5d74241042dbd1d292ddbda67d5
2013-02-11fdo#46808, Use singleton util::theMacroExpander new-style constructorNoel Grandin
And deprecate the old-style service util::MacroExpander Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-09Remove unused methodsThomas Arnhold
GetOptimalSizePixel and GetHCtrlWidth are never called Change-Id: Ib2ce1445447e85de66683f8b0fdf4fc8aa464084
2013-01-22fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac
Also used the new OUString::number(...) methods. Change-Id: I3174c43d56d1ae359901bb8a13fe0096f2c74808 Reviewed-on: https://gerrit.libreoffice.org/1766 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21Changed SetText() / GetText() to take/return OUStringChr. Rossmanith
replaced lots of Len() with isEmpty() Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0 Reviewed-on: https://gerrit.libreoffice.org/1795 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>