summaryrefslogtreecommitdiff
path: root/basctl/source/inc
AgeCommit message (Collapse)Author
2014-01-27coverity#736985 Uncaught exceptionCaolán McNamara
Change-Id: I58f2bc50a87ed07340caa148b4ade07062d730fc
2014-01-17bool improvementsStephan Bergmann
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-14Remove unused bForBrowsing parameterStephan Bergmann
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
2014-01-14PrepareClose should probably return boolStephan Bergmann
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-03convert default language dialog to .uiCaolán McNamara
Change-Id: Ia4d5b983168d6645fce8e2549db2b6c3fd410690
2013-12-18No need for DlgEdObj::supportsService to be virtualStephan Bergmann
Change-Id: Ib324adb4bc894f16c051fe956c25e37b0502006c
2013-12-06Get rid of DECLARE_STL_VECTORStephan Bergmann
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-11-11basctl: include <> for external includesNorbert Thiebaud
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
2013-09-17convert basctl/source/inc/basobj.hxx from String to OUStringNoel Grandin
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
2013-08-14convert GetSelectionText... methods to OUString and boolIvan Timofeev
Change-Id: I77726f009338ae49877c5f58fe6c14d386089bbe
2013-08-06WaE: private field 'rLayout' is not usedTor Lillqvist
Change-Id: Iad6ab86123bd3c5f83452a1037c661003dcd7cdc
2013-08-06Prevent basctl::PropBrw using basctl::Layout from within ~LayoutStephan Bergmann
...as is reproducible when creating a new dialog via "Tools - Macros - Organize Dialogs", adding e.g. some date/time controls to it, then closing LO. Invalid read of size 8 at 0x23DD58DB: basctl::Layout::SplittedSide::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:205) by 0x23DD4F65: basctl::Layout::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:62) by 0x23D847B7: basctl::DialogWindowLayout::RemovePropertyBrowser() (/basctl/source/basicide/baside3.cxx:1459) by 0x23E45AB3: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:202) by 0x23E45BA5: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:205) by 0x7E03A49: VCLXDevice::DestroyOutputDevice() (/toolkit/source/awt/vclxdevice.cxx:56) by 0x7E4655D: VCLXWindow::dispose() (/toolkit/source/awt/vclxwindow.cxx:956) by 0x7FD451C: UnoWrapper::WindowDestroyed(Window*) (/toolkit/source/helper/unowrapper.cxx:263) by 0x95EA632: Window::~Window() (/vcl/source/window/window.cxx:4365) by 0x23DD4EFD: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56) by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so) by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125) ... Address 0x19d17da0 is 0 bytes inside a block of size 80 free'd at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x23DD92D5: __gnu_cxx::new_allocator<basctl::Layout::SplittedSide::Item>::deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/ext/new_allocator.h:110) by 0x23DD8C77: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::_M_deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/bits/stl_vector.h:174) by 0x23DD7F89: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~_Vector_base() (/usr/include/c++/4.8.1/bits/stl_vector.h:160) by 0x23DD73DC: std::__cxx1998::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/bits/stl_vector.h:416) by 0x23DD6A05: std::__debug::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/debug/vector:144) by 0x23DD6889: basctl::Layout::SplittedSide::~SplittedSide() (/basctl/source/basicide/layout.hxx:80) by 0x23DD4EF1: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56) by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so) by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125) by 0x23D997F3: void boost::checked_delete<basctl::DialogWindowLayout>(basctl::DialogWindowLayout*) (/workdir/unxlngx6/UnpackedTarball/boost/boost/checked_delete.hpp:34) by 0x23D99694: boost::scoped_ptr<basctl::DialogWindowLayout>::~scoped_ptr() (/workdir/unxlngx6/UnpackedTarball/boost/boost/smart_ptr/scoped_ptr.hpp:82) by 0x23D9A5E7: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:223) by 0x23D9A717: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:248) by 0x6942297: SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:1089) by 0x6943BAB: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1484) by 0x6943E09: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1505) by 0x69427EC: SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1144) by 0x6919441: SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:175) by 0x6934542: SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1035) by 0x1BC8C5B3: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1357) by 0x1BBAF54B: framework::CloseDispatcher::implts_establishBackingMode() (/framework/source/dispatch/closedispatcher.cxx:540) by 0x1BBAEB15: framework::CloseDispatcher::impl_asyncCallback(void*) (/framework/source/dispatch/closedispatcher.cxx:391) by 0x1BBAE6AF: framework::CloseDispatcher::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (/framework/source/dispatch/closedispatcher.cxx:228) by 0x23A2A71D: framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/dispatchhelper.cxx:142) by 0x1BC06442: framework::LayoutManager::MenuBarClose(void*) (/framework/source/layoutmanager/layoutmanager.cxx:2638) by 0x1BC062F6: framework::LayoutManager::LinkStubMenuBarClose(void*, void*) (/framework/source/layoutmanager/layoutmanager.cxx:2621) by 0x9053555: Link::Call(void*) const (/include/tools/link.hxx:123) by 0x9610263: ImplHandleUserEvent(ImplSVEvent*) (/vcl/source/window/winproc.cxx:1975) by 0x961173A: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (/vcl/source/window/winproc.cxx:2590) by 0x961FCAE: SalFrame::CallCallback(unsigned short, void const*) const (in /data/lo/core/solver/unxlngx6/installation/opt/program/libvcllo.so) by 0x961F74D: SalGenericDisplay::DispatchInternalEvent() (/vcl/generic/app/gendisp.cxx:91) by 0x171A5821: GtkData::userEventFn(void*) (/vcl/unx/gtk/app/gtkdata.cxx:933) by 0x171A587C: call_userEventFn (/vcl/unx/gtk/app/gtkdata.cxx:943) by 0x3B78E47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x3B78E48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x3B78E481FB: g_main_context_iteration (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x171A47B0: GtkData::Yield(bool, bool) (/vcl/unx/gtk/app/gtkdata.cxx:574) by 0x171A82BD: GtkInstance::Yield(bool, bool) (/vcl/unx/gtk/app/gtkinst.cxx:405) by 0x906C838: ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:417) by 0x9068F00: Application::Yield() (/vcl/source/app/svapp.cxx:451) by 0x9068EB0: Application::Execute() (/vcl/source/app/svapp.cxx:396) by 0x4EC6117: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1720) by 0x9075192: ImplSVMain() (/vcl/source/app/svmain.cxx:162) by 0x907529C: SVMain() (/vcl/source/app/svmain.cxx:198) by 0x4F0A9C0: soffice_main (/desktop/source/app/sofficemain.cxx:81) by 0x40096B: sal_main (/desktop/source/app/main.c:48) by 0x40094C: main (/desktop/source/app/main.c:47) Change-Id: If7ec0fceec6da1731df8ac389406327fbd95b382
2013-04-08fdo#46808, Convert frame::Frame to new styleNoel Grandin
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
2013-04-01remove unused GetCurDocViewWinThomas Arnhold
Change-Id: I7fe825cd1fb9e988eb8037e1f5dca7252c192f33
2013-03-08fdo#60691 add modelines to *.src and *.hrc filesBorim
use solenv/bin/add-modulelines script for the task and remove all UTF bom from *.src and *.hrc files svx/source/dialog/hdft.src Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-04remove unused and commented out codeThomas Arnhold
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-02-09Remove unused methodsThomas Arnhold
GetOptimalSizePixel and GetHCtrlWidth are never called Change-Id: Ib2ce1445447e85de66683f8b0fdf4fc8aa464084
2012-11-20Bin pointless _SOLAR__PRIVATE which was always 1 anywayTor Lillqvist
Change-Id: I98f35920f02d4ee71787a9968158b220af69bde6
2012-11-15fdo#46808, use service constructor for i18n::NumberFormatMapperNoel Grandin
Also create a utility constructor for LocaleDataWrapper, which simplifies many of the calling sites. Change-Id: Ic8510b51c4201fa17fc0620e18d3e258e43636ba
2012-10-27OUString cleanup finished in basctlRicardo Montania
Change-Id: I6d18f5cde7866828ca95ccff702eb86d2e40c58d Reviewed-on: https://gerrit.libreoffice.org/925 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-10-27OUString cleanup and some identationRicardo Montania
Change-Id: Id222047750b7527e35977b73213ceeb12a53b57a Reviewed-on: https://gerrit.libreoffice.org/924 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2012-10-09rtl::OUString to OUString in basctlRicardo Montania
Change-Id: Iaa56c5f8a15032c3102ad58011c80e3c86fe287c
2012-09-28::rtl::OUString to OUString in basctlRicardo Montania
Change-Id: I7be699102eab9cbf7184a5777a4b161db885adec Reviewed-on: https://gerrit.libreoffice.org/711 Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br> Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-09-27::rtl::OUString cleanup in basctlRicardo Montania
Change-Id: Icb6f04d6ad22f1652abbb399beb08645daf8b9c9 Reviewed-on: https://gerrit.libreoffice.org/705 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-09-07-Werror,-Wmismatched-tagsStephan Bergmann
Change-Id: Idc0830c4b893f55f56e0d322e87b4eff4a60d995
2012-09-07basctl: int -> long for Point and SizeUray M. János
To be consequent, because Point and Size use long. Change-Id: I776a1839ee5d2cbdbcedad2b2922cb33b94c7b37
2012-09-07Basic IDE: Filling space of non-docking windowsUray M. János
Now if we make e.g. the stack window floating, then the watch window will occupy the whole width of the line (and vice versa, also for the Dialog Editor with object catalog and property browser). If we put it back again, than we get back the previous state of the strip. Change-Id: I634614ff2e9d5f790ad759656a79a38d49c4afc4
2012-09-07Cleanup in basctl (raw pointers)Uray M. János
Lots of raw pointers have been converted to boost::scoped_ptr to reduce the number of 'delete's and the possibility of memory leaks. Some pointers have been converted to references, to reduce the needless checking for nullptrs, and so simplifying the code. Also some #define-s have been converted to C++ constants or enumerations. Change-Id: Ifbeb78f744bac7a96c8a446ff4db90dedf85fe26
2012-09-07Fix for docking property browserUray M. János
This fixes the crash of 'Basic IDE: Docking property browser under object catalog' commit. The aPropertyBrowser data member was replaced by a new-allocated pointer. We need this because toolkit releases it by delete. When the property browser is closed in the floating state, it tells DialogWindowLayout to null the pointer. If the user clicks the 'property browser' button on the toolbar, it is created again. Change-Id: Ie842a72fe37dfdd2ed5921ffa2f1f41d3f2c51c6 Reviewed-on: https://gerrit.libreoffice.org/568 Tested-by: Noel Power <noel.power@suse.com> Reviewed-by: Noel Power <noel.power@suse.com>
2012-09-07Basic IDE: Docking property browser under object catalogUray M. János
Now the property browser can be docked in the same way as all other dialogs in the Basic IDE and the Dialog Editor. The property browser (PropBrw, for which PropertyBrowser would be a better and easier-to-remember name IMO) is derived from basctl::DockingWindow instead of SfxDockingWindow. PropBrwMgr was removed (it seemed to be only a wrapper), and PropBrw is now a data member of DialogWindowLayout (aPropertyBrowser). Change-Id: I06737a5cbc985888432630714cb919d1bbbcbb49 Reviewed-on: https://gerrit.libreoffice.org/518 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-08-31-Werror,-Wunused-private-field (Clang towards 3.2)Stephan Bergmann
Change-Id: I6166876b069ac98cf7747eb313f4d3af78ec98dd
2012-08-29Basic IDE: namespace basctlUray M. János
Now all names in basctl are in namespace 'basctl'. There were lots of names that included the word 'Basic' or 'BasicIDE' in it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox, BasicIDEModule, IDEBaseWindow etc. This information is now stored in the namespace name, so the names could be shortened: basctl::DocumentEntry, basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc. Some other minor changes: * LibInfos, LibInfoItem, LibInfoKey -> LibInfos, LibInfos::Item, LibInfos::Key * The header guards are now uniformly BASCTL_FILENAME_HXX, instead of e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'. * namespace BasicIDE, BasicIDEGlobals, basicide -> namespace basctl * BASICIDE_TYPE_MODULE, ... -> basctl::TYPE_MODULE, ... Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b Reviewed-on: https://gerrit.libreoffice.org/501 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2012-08-17followup changes to 44861f2435a0c487d4fb5b196f7e4fe7f9569396Noel Power
a) got rid of defaulted params in virtual base class methods b) made some no-op virtual methods in the base class pure thus making the base class abstract c) made LayoutManager no longer inherit utl::ConfigurationListener as it wasn't actually listening or acting on any configuration changes Change-Id: Iab1783f6b5a35b130287a2aedbd1dc8413793182
2012-08-17Object Catalog in Dialog EditorUray M. János
Change-Id: Ia74faa1452a4200c28fbd7c63130700df0a70b24 Object Catalog in Dialog Editor Change-Id: I97f2e0497b0e87cf630bba16dd98f9f7d0bb86e7
2012-08-10Bin BasicDockingWindow( Window* pParent, const ResId& rResId )Julien Nabet
Change-Id: I84f4929eb923bc3d05bdf04a8958cb58b5bfb921
2012-08-08make property browser dockable in basic IDENoel Power
very basic support for this, basicially you can dock the browser anywhere now hence lots of behaviour niggles remain, e.g 1) it probably doesn't make sense to be able to dock the browser into top or bottom quadrants ( we need to implement the Docking ( maybe PrepareToggleFloating mode ) method(s) in PropBrw ( propbrw.cxx ) 2) open floating or not ( if propertybrowswer is open ) 3) should we leave the 'properties' context menu when selecting shapes in place or not 4) switching between Module and Dialog tabs, we probably should 'remember' docked position and state Change-Id: Ibea4be3397eeac613642934662c3a9868fdf783b
2012-08-07IDE: PTR_CAST, ISA to dynamic_castUray M. János
Convert the obsolete PTR_CAST and ISA macros (from tools/rtti.hxx) to C++ dynamic_cast is basctl. Change-Id: I45530d1d34d132904f812e238ee3b59b1a4f227b
2012-08-07Remove forwards of non-existing structsThomas Arnhold
Change-Id: Ie1d7ed56c69539587df5310c0a1ea0476abd5542
2012-08-07Remove non-existing forward declarationsThomas Arnhold
Those classes don't exist. So remove friend class operators too. Change-Id: I8e3b32db933dea7cbab86015f0c926df967511f6
2012-08-07IDE: sal_Bool to boolUray M. János
Convert all occurences of sal_Bool, sal_True and sal_False in basctl to bool, true and false -- except in prototypes of virtual function overrides. (The virtual functions that are internal to basctl can be and was converted.) Note that since sal_Bool and bool are implicitly convertible to each other, for functions that take a sal_Bool (by value), true and false can be given too. Change-Id: Ie44740fa87f89e9fedd913840ca2b38e95e6b957
2012-08-07Basic IDE Object Catalog improvementsUray M. János
Change-Id: I4c3bbf721428e93cdfa8f062f37c5911faba0fa4
2012-08-03sal_Bool -> boolTakeshi Abe
Change-Id: I49749f327d6a9c3661ef9bd684647e0a45b9203a
2012-08-02sal_Bool -> boolTakeshi Abe
Change-Id: Id2addfc6e0c4e0b30281c9f3d22ec0624a61dab1
2012-08-01sal_Bool -> boolTakeshi Abe
Change-Id: I82157e89d04eda35525c5a540504e6a8d18bc86c
2012-07-31sal_Bool -> boolTakeshi Abe
Change-Id: Ic982c4da144ecdf7198b84b98d672ced8f1f70b6
2012-07-29Remove strange DummyTypeCaolán McNamara
I can see no purpose to DummyType Change-Id: I25d9d3b321df28f8c2bcb4bf915eb176a14fdaf8
2012-07-27sal_Bool -> boolTakeshi Abe
Change-Id: I97618ffb138f292665edb634a29c39ab5a332ab1
generated by cgit (git 2.34.1) at 2025-04-27 22:52:29 +0000