summaryrefslogtreecommitdiff
path: root/basctl/source/inc
AgeCommit message (Collapse)Author
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-15remove legacy svheader.hxxThomas Arnhold
none of the corresponding headers is included... Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-04-28Improve TabBar return typesNoel Grandin
DeactivatePage() goes from returning long to returning bool. StartRenaming goes from returning long to returning bool. AllowRenaming goes from returning long to returning a constant from a new enum. Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca Reviewed-on: https://gerrit.libreoffice.org/9161 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-25coverity#736993 Uncaught exceptionCaolán McNamara
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
2014-04-25coverity#736992 Uncaught exceptionCaolán McNamara
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
2014-04-25coverity#736990 Uncaught exceptionCaolán McNamara
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
2014-04-19fixincludeguards.sh: basctlThomas Arnhold
2014-04-18sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.Jan Holesovsky
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-15basctl: sal_Bool->boolNoel Grandin
Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-19sfx2: sal_Bool->boolNoel Grandin
Change-Id: I73acb3a150b01114d32274a6842f6db9654b3e63
2014-03-18sfx2: sal_Bool->boolNoel Grandin
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-17basct: prefer passing OUString by referenceNoel Grandin
Change-Id: Ide803f793e829767fad89ab2aef776ef24fedb37
2014-03-11No need for implGetBounds to be SAL_CALLStephan Bergmann
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from basctlAlexander Wilms
Change-Id: I3e6a238a0bafbb70a7c22bde1f2258b8014ed2d2 Reviewed-on: https://gerrit.libreoffice.org/8232 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-11convert manage languages dialog to .uiCaolán McNamara
Change-Id: I1a50f8715040e64758cf18bee8ca6ac1d04652c8
2014-01-27coverity#736985 Uncaught exceptionCaolán McNamara
Change-Id: I58f2bc50a87ed07340caa148b4ade07062d730fc
2014-01-17bool improvementsStephan Bergmann
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-14Remove unused bForBrowsing parameterStephan Bergmann
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
2014-01-14PrepareClose should probably return boolStephan Bergmann
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-03convert default language dialog to .uiCaolán McNamara
Change-Id: Ia4d5b983168d6645fce8e2549db2b6c3fd410690
2013-12-18No need for DlgEdObj::supportsService to be virtualStephan Bergmann
Change-Id: Ib324adb4bc894f16c051fe956c25e37b0502006c
2013-12-06Get rid of DECLARE_STL_VECTORStephan Bergmann
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-11-11basctl: include <> for external includesNorbert Thiebaud
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
2013-09-17convert basctl/source/inc/basobj.hxx from String to OUStringNoel Grandin
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
2013-08-14convert GetSelectionText... methods to OUString and boolIvan Timofeev
Change-Id: I77726f009338ae49877c5f58fe6c14d386089bbe
2013-08-06WaE: private field 'rLayout' is not usedTor Lillqvist
Change-Id: Iad6ab86123bd3c5f83452a1037c661003dcd7cdc
2013-08-06Prevent basctl::PropBrw using basctl::Layout from within ~LayoutStephan Bergmann
...as is reproducible when creating a new dialog via "Tools - Macros - Organize Dialogs", adding e.g. some date/time controls to it, then closing LO. Invalid read of size 8 at 0x23DD58DB: basctl::Layout::SplittedSide::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:205) by 0x23DD4F65: basctl::Layout::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:62) by 0x23D847B7: basctl::DialogWindowLayout::RemovePropertyBrowser() (/basctl/source/basicide/baside3.cxx:1459) by 0x23E45AB3: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:202) by 0x23E45BA5: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:205) by 0x7E03A49: VCLXDevice::DestroyOutputDevice() (/toolkit/source/awt/vclxdevice.cxx:56) by 0x7E4655D: VCLXWindow::dispose() (/toolkit/source/awt/vclxwindow.cxx:956) by 0x7FD451C: UnoWrapper::WindowDestroyed(Window*) (/toolkit/source/helper/unowrapper.cxx:263) by 0x95EA632: Window::~Window() (/vcl/source/window/window.cxx:4365) by 0x23DD4EFD: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56) by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so) by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125) ... Address 0x19d17da0 is 0 bytes inside a block of size 80 free'd at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x23DD92D5: __gnu_cxx::new_allocator<basctl::Layout::SplittedSide::Item>::deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/ext/new_allocator.h:110) by 0x23DD8C77: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::_M_deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/bits/stl_vector.h:174) by 0x23DD7F89: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~_Vector_base() (/usr/include/c++/4.8.1/bits/stl_vector.h:160) by 0x23DD73DC: std::__cxx1998::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/bits/stl_vector.h:416) by 0x23DD6A05: std::__debug::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/debug/vector:144) by 0x23DD6889: basctl::Layout::SplittedSide::~SplittedSide() (/basctl/source/basicide/layout.hxx:80) by 0x23DD4EF1: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56) by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so) by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125) by 0x23D997F3: void boost::checked_delete<basctl::DialogWindowLayout>(basctl::DialogWindowLayout*) (/workdir/unxlngx6/UnpackedTarball/boost/boost/checked_delete.hpp:34) by 0x23D99694: boost::scoped_ptr<basctl::DialogWindowLayout>::~scoped_ptr() (/workdir/unxlngx6/UnpackedTarball/boost/boost/smart_ptr/scoped_ptr.hpp:82) by 0x23D9A5E7: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:223) by 0x23D9A717: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:248) by 0x6942297: SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:1089) by 0x6943BAB: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1484) by 0x6943E09: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1505) by 0x69427EC: SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1144) by 0x6919441: SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:175) by 0x6934542: SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1035) by 0x1BC8C5B3: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1357) by 0x1BBAF54B: framework::CloseDispatcher::implts_establishBackingMode() (/framework/source/dispatch/closedispatcher.cxx:540) by 0x1BBAEB15: framework::CloseDispatcher::impl_asyncCallback(void*) (/framework/source/dispatch/closedispatcher.cxx:391) by 0x1BBAE6AF: framework::CloseDispatcher::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (/framework/source/dispatch/closedispatcher.cxx:228) by 0x23A2A71D: framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/dispatchhelper.cxx:142) by 0x1BC06442: framework::LayoutManager::MenuBarClose(void*) (/framework/source/layoutmanager/layoutmanager.cxx:2638) by 0x1BC062F6: framework::LayoutManager::LinkStubMenuBarClose(void*, void*) (/framework/source/layoutmanager/layoutmanager.cxx:2621) by 0x9053555: Link::Call(void*) const (/include/tools/link.hxx:123) by 0x9610263: ImplHandleUserEvent(ImplSVEvent*) (/vcl/source/window/winproc.cxx:1975) by 0x961173A: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (/vcl/source/window/winproc.cxx:2590) by 0x961FCAE: SalFrame::CallCallback(unsigned short, void const*) const (in /data/lo/core/solver/unxlngx6/installation/opt/program/libvcllo.so) by 0x961F74D: SalGenericDisplay::DispatchInternalEvent() (/vcl/generic/app/gendisp.cxx:91) by 0x171A5821: GtkData::userEventFn(void*) (/vcl/unx/gtk/app/gtkdata.cxx:933) by 0x171A587C: call_userEventFn (/vcl/unx/gtk/app/gtkdata.cxx:943) by 0x3B78E47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x3B78E48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x3B78E481FB: g_main_context_iteration (in /usr/lib64/libglib-2.0.so.0.3600.3) by 0x171A47B0: GtkData::Yield(bool, bool) (/vcl/unx/gtk/app/gtkdata.cxx:574) by 0x171A82BD: GtkInstance::Yield(bool, bool) (/vcl/unx/gtk/app/gtkinst.cxx:405) by 0x906C838: ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:417) by 0x9068F00: Application::Yield() (/vcl/source/app/svapp.cxx:451) by 0x9068EB0: Application::Execute() (/vcl/source/app/svapp.cxx:396) by 0x4EC6117: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1720) by 0x9075192: ImplSVMain() (/vcl/source/app/svmain.cxx:162) by 0x907529C: SVMain() (/vcl/source/app/svmain.cxx:198) by 0x4F0A9C0: soffice_main (/desktop/source/app/sofficemain.cxx:81) by 0x40096B: sal_main (/desktop/source/app/main.c:48) by 0x40094C: main (/desktop/source/app/main.c:47) Change-Id: If7ec0fceec6da1731df8ac389406327fbd95b382
2013-04-08fdo#46808, Convert frame::Frame to new styleNoel Grandin
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
2013-04-01remove unused GetCurDocViewWinThomas Arnhold
Change-Id: I7fe825cd1fb9e988eb8037e1f5dca7252c192f33
2013-03-08fdo#60691 add modelines to *.src and *.hrc filesBorim
use solenv/bin/add-modulelines script for the task and remove all UTF bom from *.src and *.hrc files svx/source/dialog/hdft.src Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-04remove unused and commented out codeThomas Arnhold
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-02-09Remove unused methodsThomas Arnhold
GetOptimalSizePixel and GetHCtrlWidth are never called Change-Id: Ib2ce1445447e85de66683f8b0fdf4fc8aa464084
2012-11-20Bin pointless _SOLAR__PRIVATE which was always 1 anywayTor Lillqvist
Change-Id: I98f35920f02d4ee71787a9968158b220af69bde6
2012-11-15fdo#46808, use service constructor for i18n::NumberFormatMapperNoel Grandin
Also create a utility constructor for LocaleDataWrapper, which simplifies many of the calling sites. Change-Id: Ic8510b51c4201fa17fc0620e18d3e258e43636ba
generated by cgit (git 2.34.1) at 2025-02-12 23:51:58 +0000