summaryrefslogtreecommitdiff
path: root/basctl/source
AgeCommit message (Collapse)Author
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in avmedia..bridgesNoel Grandin
Change-Id: Iba1282caadab91a0c6e1c044dbab5e6e15f3707b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-04Use pragma once instead of include guardsFatih
Change-Id: Ife31f595e7b704903f65eb8ba327da12a8fcf4d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92786 Tested-by: Jenkins Reviewed-by: Yusuf Keten <ketenyusuf@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26all ItemWindows are now weldedCaolán McNamara
where native widgetery is hostable in a vcl toolbar or a native one Change-Id: I942ada335bb4bd6ced0f3352f632e25787f68597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22move InterimItemWindow to svtoolsCaolán McNamara
Change-Id: I058b1d96a3ddfaa1aa96f66d0ebc6fa68900a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-18loplugin:flatten in basctlNoel Grandin
Change-Id: I66e3f46fcaae4e15d230a5a7c98c1b20cfb4dbda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92485 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15tdf#126828 hide macro organize dialog before launching macro editingCaolán McNamara
so the macro editor isn't forced behind the window with an active dialog Change-Id: Iae89f6910a8183bcf01872eef71c04bc993f1550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15set cursor after thawedCaolán McNamara
Change-Id: I3e9ebee84c8a65b7231b0947e1044445b656780c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29OSL_ASSERT->assert in basctlNoel Grandin
and simplify the surrounding code, assuming the asserts to hold Change-Id: I9152402f267c17a39f4af275a0de79e9529375c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-23tdf#124176: Use pragma once instead of include guardsHarshit Jain
Change-Id: Ia4a6b35a9a734e9fa1dc9dea702fc1ec370021f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90901 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-04tdf#114441: Convert use of sal_uLong to better integer typesBugra
Change-Id: I484cc39ebde5bfefa8ea26f3e6351ef12e303f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89755 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-29tdf#124176: Use pragma once instead of include guardsjames
Change-Id: I548c21fab001217095e7ad603f42e4495d19505d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89729 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-26explicitly call ActivatePageHdl when programatically calling set_current_pageCaolán McNamara
Change-Id: I6113e51565cf4f89e77829f56e08f6b98f2fe244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26tdf#130925 use the maximum document line number for the width calculationCaolán McNamara
not the max line number in the range currently getting rendered Change-Id: I447e4152ef6a1ec327a95a8260d1616940e5d6c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25check if edit can be enabled after setting cursor into treeCaolán McNamara
Change-Id: I264dc4db7e3ddc64faf0edec18d96d2c46ce00f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19weld CodeCompleteWindowCaolán McNamara
Change-Id: Ibe620a42592761ee25d6329d26b1b1c452bdfd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89007 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19merge common code togetherCaolán McNamara
Change-Id: I1c514c1a83dac4556ad68b44972a97fb4b3384e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19remove and replace newly unused ctorCaolán McNamara
Change-Id: I67e0dc6fe419ad0cac04105cb2e89435dd3fc107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld WatchWindow panelCaolán McNamara
Change-Id: Idb43d7bd168ce37fce8694946be6c7de7ca5a2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88930 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld StackWindow DockingWindowCaolán McNamara
Change-Id: I46626fdbfcaeabed48da9ae14fe5d351c335df55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld SelectorListBox Item WindowCaolán McNamara
Change-Id: I9752d03d9a70831d6e15fe3ac3ebdfc7d2728550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16clang-format accessibility & basctl with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: Idc890cac4bb6aed4e36c3556a2abc0744fd086df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88770 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Restore simple undo and redo buttons for the basctl moduleMaxim Monastirsky
Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module. These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo. This commit removes the unused controller, and restores the previous behavior with the other controller. Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13use TopLevelWindowLocker for the lock other windows problemCaolán McNamara
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13remove unneeded includes and update pchCaolán McNamara
Change-Id: I6b38e96e6eb509e9d1ea0acaf30cb2a542bdbc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 adding a document dialog or modules doesn't update catalogCaolán McNamara
in basctl UI, seems to be since... commit 44861f2435a0c487d4fb5b196f7e4fe7f9569396 Date: Fri Aug 17 07:29:20 2012 +0200 Object Catalog in Dialog Editor if it even really worked before that changed UpdateObjectCatalog to only get called for non-document changes Change-Id: I77a94bb4859cc399e86d75fdf2c9ca7c50288b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#57307 - Expand word boundaries to include connector punctuationsAndreas Heinisch
Include connector punctuations when adding a variable to the watch window using "Enable Watch (F7)" in order to add the correct variable name. Change-Id: Idaf7699dde3f4147d603c6aea4b2381e2af497a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12Fix typoAndrea Gelmini
Change-Id: I2b0fe68cf5346a6788bbd63242eadf872d58a87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88556 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-12drop newly unused TreeListBoxCaolán McNamara
Change-Id: Iea157bb472ee409a1a15b9f6c9cfe0adc21d1a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12weld ObjectCatalogCaolán McNamara
Change-Id: I1979c6f8f5705360aa0df8cb7aeaeca00cd66ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12only freeze/thaw if we have toCaolán McNamara
because gtk will relayout and things jump around confusingly and unnecessarily Change-Id: I817e803f8ad7e523e5855326fc097f8798ddb679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12we always want to expand/collapse on double clickCaolán McNamara
Change-Id: Idf5496b44f5e2d5782d99317029aa0e9cb99e8d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
a) for vcl version, listen to modify and select, instead of just modify so we can get the artificial select via uiobject that the mobile makes use of. (and disregard the modify which we know will lead to select so we get just one event in that case) b) default to assuming something has been picked "directly" unless we know otherwise. ideally the result is that https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: Ibbf33eab88dabd55d0c329aa00c8adaf001a4f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11ensure the module combobox gets updated with the current selectionCaolán McNamara
Change-Id: Ia9bf71c1890d9f2700a67ad9a3727dbf140c0492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara
xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11add some more libs to libmergedNoel Grandin
and fix a consequent symbol name clash in basctl Change-Id: Idc836fcbb379e1046a60008391635eb6241b27c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10weld SvxFmAbsRecWin item windowCaolán McNamara
Change-Id: I6a11d8ba226b28447e2ab04925090491d6953132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08weld LibBox and LanguageBox Item WindowsCaolán McNamara
Change-Id: Ifdbef243093b588887c3d3fe1efcaf2e4c7c982a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07property browser appearing as a blank area when changing modulesCaolán McNamara
under gtk, so just don't create it until we need it Change-Id: I0fd86c6b587788c42646a107746e8e4e10f2a13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28remove some unused local varsNoel Grandin
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#124176: Use pragma once instead of include guardsAleyna Doğrucan
Change-Id: Ib0708c72fff342c25f79662cc3f4bbbfdfe0574a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86230 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#124176:Use pragma once instead of include guardsayhanyalcinsoy
Change-Id: Ie00f05a3661a9fd6159c424e01f11e7bb1ea45fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85640 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-01-25 03:23:57 +0000