summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I89796134a0cce33279ba7f02492857a656e8aee3
2015-08-10tdf#93065 Swap next and previous buttons in find toolbarYousuf Philips
Change-Id: Ie07364696175038130cb5b94fbad39b88e646921 Reviewed-on: https://gerrit.libreoffice.org/17473 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-08-07Resolves: tdf#92896 wrong delete language dialog pathCaolán McNamara
Change-Id: I720e95c6c5e8b613ef880aa65f5e8cdb85143b58 Reviewed-on: https://gerrit.libreoffice.org/17565 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-04basic,basctl: inline some use-once typedefsNoel Grandin
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
2015-08-01sal_uInt16 to sal_Int32, constify, minor optimizationsMatteo Casalin
Change-Id: Icc41bbe09e495454ca27e9281eca6f4731a135c8
2015-08-01sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: I723d7c187ec186ccc68f061ba2357712a5f31869
2015-07-28inline the "old" SbxErr constantsNoel Grandin
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28convert SbxFlagsBits to scoped enumNoel Grandin
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-24loplugin:unusedmethodsNoel Grandin
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20svtools: change these SvTreeListEntry functions to unique_ptrMichael Stahl
... parameters to make it clear that they take ownership. Change-Id: I572c5fa6268438a86d0a4fa1d2aef15382cb5607
2015-07-17com::sun::star->css in basctlNoel Grandin
Change-Id: If0013cdd734a58397ab4972f9cca5584f05d1715 Reviewed-on: https://gerrit.libreoffice.org/17164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17Convert dialog controls button to the generic controllerMaxim Monastirsky
Change-Id: I3d03fba86139a3495e1cfd67b3f17149c73e3377
2015-07-06tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, in basctl. Change-Id: I52da577a6f6298eb89b0cc8c8ff243ecd341e9b3 Reviewed-on: https://gerrit.libreoffice.org/16718 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05SfxToolBoxControl::GetPopupWindowType seems unused, kill itMaxim Monastirsky
together with SfxPopupWindowType enum. Change-Id: Ia0b2388b34c96bb044f1bfcc7e89b33ac37d5f95 Reviewed-on: https://gerrit.libreoffice.org/16766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29remove custom RTTI from basctl::BaseWindowNoel Grandin
unused Change-Id: Icfb5a29f592629e4332c31b083d78efcd2d0161e
2015-06-28coverity#1308514 Uncaught exceptionCaolán McNamara
Change-Id: I62d3d390ff9d1a44d8704b41ef62fff5d532bcc4
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I7c79445bfa1536706561752da107090599ef26a2
2015-06-24tdf#92258 - fix crash editing macro module name.Michael Meeks
Change-Id: I8e0bbab7d7497ed7c136ddbfba73618834d5a204
2015-06-24remove SFX_NOTIFY macroNoel Grandin
it has not served any purpose since we switched to using normal C++ RTTI for the SfxHint objects Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-17protect against NULL current SfxViewShellLionel Elie Mamane
Change-Id: I748493de799902f5acf905c7ce919e3ebbf1a800
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I6ea774c635335106a7a8ddc4214c20bdf3f021ba
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05Resolves: tdf#90361 CellValueBinding/CellRangeListSource need WithArgumentsCaolán McNamara
otherwise they are not initialized and every call on them throws. This at least results in the dialog editor not falling over immediately on inserting anything in calc. Change-Id: Ie1668ef440937c75dd08671c669c021c2efecd2a
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I625929f9cfa3a2d403d0a4652e57c2bb7a998fa6
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29tdf#91484 fix macro editor - Invalidate in paintTomaž Vajngerl
Change-Id: I787da9a665e54caea229def185076b29c00fd11e
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-26tdf#91575 - CRASH: when "My Macros & Dialogs Standard" window closeNoel Grandin
Change-Id: Iad4f67e78a0aa4c67f0c450e17278f873944aa23
2015-05-26convert SCROLL constants to scoped enumNoel Grandin
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-22convert POINTER constants to scoped enumNoel Grandin
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20coverity#1298898 coverity seems a little confused hereCaolán McNamara
Change-Id: Ibc80e242b8fda8fb304ed5cd1a52716d1b7fc33d
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20convert TEXT_DRAW constants to scoped enumNoel Grandin
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-19basic: used typed LINKsNoel Grandin
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
2015-05-18cppunit: noExplicitConstructorCaolán McNamara
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
2015-05-18basctl: Use typed LinksNoel Grandin
Change-Id: I0e0b6086852c06df88e1b623d4631f364eb28b09 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-03 09:46:36 +0000