Age | Commit message (Collapse) | Author |
|
Change-Id: Id38a9e2e0ca0b1c52cb3306adf77eb43d710c9c6
|
|
regression from
commit bf28399df0b73364b12309032e4a8b571389c2cf
Date: Fri Feb 7 15:54:45 2014 +0100
auto_ptr -> heap_ptr
Change-Id: Ib54c708cbdcb97a7489df4a1b3a7e9367f81ff6b
|
|
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")
Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia936814ae37ae802fab36f7bde56de09338eb617
|
|
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
|
|
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
|
|
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.
Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: Ia77a94a486b8e5203617eb00cb5189359798482f
|
|
Change-Id: I098cdc4899c27930f3d0a16d7fbd26dbce91d4c5
Reviewed-on: https://gerrit.libreoffice.org/11212
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I007820c7717a437414bc43936e3138f7e63d090e
|
|
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
|
|
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
|
|
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
|
|
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.
Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
|
|
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
|
|
Quick fix for this bt:
3 0x00002aaaab2935d2 in __GI___assert_fail (assertion=0x2aaae1f2806a "_pInterface != 0",
file=0x2aaae1f28018 "/home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h", line=402,
function=0x2aaae1f28480 <com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator->() const::__PRETTY_FUNCTION__> "interface_type* com::sun::star::uno::Reference< <template-parameter-1-1> >::operator->() const [with interface_type = com::sun::star::resource::XStringResourceManager]") at assert.c:101
4 0x00002aaae1e2963b in com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator-> (this=0x7fffffff2d00)
at /home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h:402
5 0x00002aaae1eb5c87 in basctl::LocalizationMgr::implHandleControlResourceProperties (aControlAny=
uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aDialogName="Dialog1", aCtrlName="TextField1",
xStringResourceManager=empty uno::Reference, xSourceStringResolver=empty uno::Reference, eMode=basctl::LocalizationMgr::REMOVE_IDS_FROM_RESOURCE)
at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:202
6 0x00002aaae1eb92a0 in basctl::LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject (pEditor=0x919d820, aControlAny=
uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aCtrlName="TextField1")
at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:896
Indeed, LocalizationMgr::setControlResourceIDsForNewEditorObject just returns if !xStringResourceManager.is()
So let's do the same when trying to delete ControlResources
See http://opengrok.libreoffice.org/xref/core/basctl/source/basicide/localizationmgr.cxx#835
Change-Id: I4be49503cd2464f97a25840dfdc29877e5fb2b93
|
|
- Remove includes from files where they are not needed.
- Update pch files
Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
|
|
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
|
|
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
|
|
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
|
|
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
|
|
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: Ida2e09b88c9df0d70c8298020d768e6386714edd
|
|
Change-Id: Iee4e5dd2936979a9bcb8bd5db781e51551270a7f
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
|
|
Change-Id: I1988d2766d8bdeb5f8a22a5673dcff9b898dd637
|
|
Change-Id: I5316693452427ed76a7738b090de023b110caa40
|
|
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
|
|
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
|
|
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
|
|
As an InfoBar, so hopefully not annoying...
Change-Id: I5d4e79273edc03829fdab2d6d5a291576c954e4b
|
|
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
|
|
(cherry picked from commit 7bc75c1a7b05d81631ebccf05bf022636d1a3a14)
Conflicts:
basctl/source/basicide/objdlg.cxx
basctl/source/basicide/objdlg.hxx
Change-Id: Id3fa3686fd60df192c02cc8137c9bc59e68c1d49
|
|
none of the corresponding headers is included...
Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
|
|
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
|
|
I had to fix some source files because of macro redefinitions and such stuff.
Small modules like basic have a great win, too:
make basic.clean && time make basic:
with w/o
pch pch
accessibility 23s 1m59s
basctl 30s 1m42s
basic 56s 1m35s
comphelper 23s 51s
editeng 48s 2m04s
forms 40s 1m40s
unotools 19s 38s
sd 3m37s 4m33s
Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I7e3778e5203438bc5db942c813a03896d7df895b
|
|
Change-Id: Iacf4373221b93a97e030b09501cc91589f2fdff7
|
|
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|
|
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.
Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
|
|
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
|
|
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
|