summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2016-08-04tdf#100726: Improve readability of OUString concatenationnadith
all most all of the places in the basic basctl modules this bug fixed Change-Id: I1a4a03e207c1b520449c31a05265585120da07f6 Reviewed-on: https://gerrit.libreoffice.org/27662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04loplugin:countusersofdefaultparams in basctl..basicNoel Grandin
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695 Reviewed-on: https://gerrit.libreoffice.org/27793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara
in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#91665 l10n: replace string lists - by separate stringsMuhammet Kara
Convert the stingarray to resource strings. Change-Id: Iae9c52c21fd004c052fa78d959dfa92ad1d16a7d Reviewed-on: https://gerrit.libreoffice.org/27641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15remove excess whitespaceStephan Bergmann
Change-Id: I11d775eed216e7d8a59d0b891dffcf191780aa9b
2016-07-15tdf#100726: Improve readability of OUString concatenations in basctl modulenadith
Change-Id: Iad8e3a2b74062640660c0ea8121dc6a5d043c080 Reviewed-on: https://gerrit.libreoffice.org/27228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-08loplugin:redundantcast: redundant static_casts in basctlStephan Bergmann
Change-Id: Iac1a400f37ee25bfbebbe95bb22f9708581899f4
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I2ddc6111cede4f7322aabbd1e5ecc671fe101d4e
2016-07-04tdf#100726: Improve readability of OUString concatenationsArnold Dumas
Change-Id: I7018f3c339ffcab7d46d97f1d3784da1be644f0a Reviewed-on: https://gerrit.libreoffice.org/26870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-04SfxModule to use initializer_list instead of variadic argumentsMark Page
The compiler can perform type checking with initializer lists Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1 Reviewed-on: https://gerrit.libreoffice.org/26852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04loplugin:stringconcatStephan Bergmann
Change-Id: I4156d1d57d0afaa2fc7ef93370fa824b38d273e4
2016-07-03Improve readability of OUString concatanation in LibPageMuhammet Kara
, ScriptDocument , PropBrw , VBATest , SbUnoClass , SbModule , and SbiSymPool It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I73926989345193b133e538d5aeca36f12723162c Reviewed-on: https://gerrit.libreoffice.org/26853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-24loplugin:singlevalfields in vcl(part1)Noel Grandin
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f Reviewed-on: https://gerrit.libreoffice.org/26595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24loplugin:singlevalfields in basctlNoel Grandin
Change-Id: Ia533309bb0e7f33b492b230a372916c0c6fd6ec3 Reviewed-on: https://gerrit.libreoffice.org/26631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23Improve readability of OUString concatanation in LocalizationMgrMuhammet Kara
It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I56ba7aa1477361a686ffb50955525b73cce24197 Reviewed-on: https://gerrit.libreoffice.org/26585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16Fixed a typo where highlighting was highlightningGökhan Gurbetoğlu
Or maybe it was intentionally done by some lightning superpowered guy? Change-Id: I76c6b6ef94dae4c97a26537451cff0179074995b Reviewed-on: https://gerrit.libreoffice.org/26295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-13loplugin:sallogareasNoel Grandin
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12BASIC : Add SbModule::FindMethodArnaud Versini
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a Reviewed-on: https://gerrit.libreoffice.org/24346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01remove unused SID constants and associated codeNoel Grandin
found with a python script that looks like: process = subprocess.Popen( "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u", shell=True, stdout=subprocess.PIPE) for line in iter(process.stdout.readline, b''): line = line.strip() if line.startswith("//"): continue if line.startswith("sfx"): continue if len(line) < 10: continue i = subprocess.check_output("git grep -nP \"#define +" + line + " \"", shell=True) if i.count("#define") < 2: continue print line + " " + i Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264 Reviewed-on: https://gerrit.libreoffice.org/25715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Convert SbxClassType to scoped enumNoel Grandin
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
2016-05-06connectivity: replace boost::remove_reference with std::remove_referenceMichael Stahl
Change-Id: I7c11fcdaf8065fa86d224ad2fab88b0bcb907255
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21Resolves: tdf#99425 crash when closing dialog editorCaolán McNamara
with undocked "Object Catalog" toolbar Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove the hardly used SyntaxLineSet typedefRyan McCoskrie
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6 Reviewed-on: https://gerrit.libreoffice.org/24176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-16tdf#97380: don't destroy completely window when replace dialogJulien Nabet
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 210 inline bool isApplication() const { return m_bValid && m_bIsApplication; } (gdb) bt 0 0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 1 0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311 2 0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256 3 0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=..., aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154 4 0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213 Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed Reviewed-on: https://gerrit.libreoffice.org/24139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16basctl: prefix some membersJulien Nabet
Change-Id: I59660153a33e83dc9457fbee082e8da444b04b58 Reviewed-on: https://gerrit.libreoffice.org/24126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
generated by cgit (git 2.34.1) at 2025-01-19 02:22:51 +0000