summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2012-09-25replace remaining InterlockedCount() with inlined versionNorbert Thiebaud
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c Reviewed-on: https://gerrit.libreoffice.org/671 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-24callcatcher: update unused code listsCaolán McNamara
Change-Id: I58bad0806354eff2e91370ab3395199fa8691764
2012-09-24::rtl::OUString to OUString in basctlRicardo Montania
Change-Id: I3fc3d463fbaefe31b3541502c9f3dfbd4d1db4f9 Reviewed-on: https://gerrit.libreoffice.org/678 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-09-19ComponentContext::getUnoContext -> getComponentContext simplificationStephan Bergmann
...and some further clean-up. Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-14Improvement on previous commit, UCB clean upStephan Bergmann
* As UCB is only ever initialized with "Local"/"Office", remove this configuration vector completely. The "create" ctor creates an instance internally initialized with those "Local"/"Office" keys. Special (test) code can still instantiate an uninitialized one via plain createInstance. And for backwards compatilibity process startup still ensures to create an initialized instance early, in case there is still code out there (in extensions) that later calls plain createInstance and expects to get the already-initialized (single) instance. * XInitialization is an "implementation detail" of the UniversalContentBroker service, do not expose in XUniversalContentBroker. * ucbhelper/configurationkeys.hxx is no longer needed and is removed. * ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that requires ucbhelper::Content constructors to take explicit XComponentContext arguments now. * The only remaining code in ucbhelper/source/client/contentbroker.cxx is Android-only InitUCBHelper. Is that relevant still? Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-10-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I5f450365498304d8118dce88af3becc5a8c9ddeb
2012-09-07-Werror,-Wmismatched-tagsStephan Bergmann
Change-Id: Idc0830c4b893f55f56e0d322e87b4eff4a60d995
2012-09-07-Werror: initialize iLastWin with an invalid valueUray M. János
iLastWin will get a valid value if !bEmpty Change-Id: I8f598b7a9d5e8317fca0ef0fcc3313bc0691f0da
2012-09-07basctl: int -> long for Point and SizeUray M. János
To be consequent, because Point and Size use long. Change-Id: I776a1839ee5d2cbdbcedad2b2922cb33b94c7b37
2012-09-07Basic IDE: Filling space of non-docking windowsUray M. János
Now if we make e.g. the stack window floating, then the watch window will occupy the whole width of the line (and vice versa, also for the Dialog Editor with object catalog and property browser). If we put it back again, than we get back the previous state of the strip. Change-Id: I634614ff2e9d5f790ad759656a79a38d49c4afc4
2012-09-07Cleanup in basctl (raw pointers)Uray M. János
Lots of raw pointers have been converted to boost::scoped_ptr to reduce the number of 'delete's and the possibility of memory leaks. Some pointers have been converted to references, to reduce the needless checking for nullptrs, and so simplifying the code. Also some #define-s have been converted to C++ constants or enumerations. Change-Id: Ifbeb78f744bac7a96c8a446ff4db90dedf85fe26
2012-09-07Fix for docking property browserUray M. János
This fixes the crash of 'Basic IDE: Docking property browser under object catalog' commit. The aPropertyBrowser data member was replaced by a new-allocated pointer. We need this because toolkit releases it by delete. When the property browser is closed in the floating state, it tells DialogWindowLayout to null the pointer. If the user clicks the 'property browser' button on the toolbar, it is created again. Change-Id: Ie842a72fe37dfdd2ed5921ffa2f1f41d3f2c51c6 Reviewed-on: https://gerrit.libreoffice.org/568 Tested-by: Noel Power <noel.power@suse.com> Reviewed-by: Noel Power <noel.power@suse.com>
2012-09-07Basic IDE: Docking property browser under object catalogUray M. János
Now the property browser can be docked in the same way as all other dialogs in the Basic IDE and the Dialog Editor. The property browser (PropBrw, for which PropertyBrowser would be a better and easier-to-remember name IMO) is derived from basctl::DockingWindow instead of SfxDockingWindow. PropBrwMgr was removed (it seemed to be only a wrapper), and PropBrw is now a data member of DialogWindowLayout (aPropertyBrowser). Change-Id: I06737a5cbc985888432630714cb919d1bbbcbb49 Reviewed-on: https://gerrit.libreoffice.org/518 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-09-05fdo#46808, Adapt frame::ModuleManager UNO service to new styleNoel Grandin
Create a merged XModuleManager2 interface for this service to implement. Which is backwards-compatible, but does not require creating a new service. Explicitly document the XNameReplace interface in the IDL, which is already implemented by the service, since there is code currently using it. Change-Id: Ib46349174b1ce495c240031e93c9427fc33d9853
2012-09-03Some clean up of previous commitStephan Bergmann
Change-Id: I6507b731665eb3d98a8fbf3d445f6c85e6d49258
2012-09-03fdo#46808, Adapt io::Pipe UNO service to new styleNoel Grandin
Create a merged XPipe interface for this service to implement. Which is backwards-compatible, but does not require creating a new service. Change-Id: I682633c6252aab503eb2469c9bd2ba771f10bc4b
2012-08-31-Werror,-Wunused-private-field (Clang towards 3.2)Stephan Bergmann
Change-Id: I6166876b069ac98cf7747eb313f4d3af78ec98dd
2012-08-30Object Catalog: double-click to modules and dialogsUray M. János
In Basic IDE in Object Catalog, only methods could be loaded by double-click. Now modules and dialogs can be too. Change-Id: If1c4412d2f6d35e6d1cbf48e700e2566dad9e97a Reviewed-on: https://gerrit.libreoffice.org/515 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2012-08-30Undo/Redo description+shortcut in Basic IDEUray M. János
This solves an issue about Edit > Redo in BasicIDE (Hungarian site): http://bug.openscope.org/browse/OOO-269 1. Redo should have a shortcut (Ctrl+Y), like in other parts of LibreOffice. (Undo has the usual Ctrl+Z.) 2. In the Edit menu, Undo and Redo should print something after the colon (what is to be undone, redone). This patch fixes both. Unfortunately the shortcut isn't shown in the menu (it's in vcl/source/window/keycod.cxx like Undo, and not in officecfg/registry/data/org/openoffice/Office/Accelerators.xcu). Change-Id: I2cfbfeb7d57309a27676e48943633cdb194288bc Reviewed-on: https://gerrit.libreoffice.org/514 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2012-08-29Basic IDE: namespace basctlUray M. János
Now all names in basctl are in namespace 'basctl'. There were lots of names that included the word 'Basic' or 'BasicIDE' in it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox, BasicIDEModule, IDEBaseWindow etc. This information is now stored in the namespace name, so the names could be shortened: basctl::DocumentEntry, basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc. Some other minor changes: * LibInfos, LibInfoItem, LibInfoKey -> LibInfos, LibInfos::Item, LibInfos::Key * The header guards are now uniformly BASCTL_FILENAME_HXX, instead of e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'. * namespace BasicIDE, BasicIDEGlobals, basicide -> namespace basctl * BASICIDE_TYPE_MODULE, ... -> basctl::TYPE_MODULE, ... Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b Reviewed-on: https://gerrit.libreoffice.org/501 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2012-08-22more old module-description xml filesMatúš Kukan
Change-Id: I9ac503b073ee3f9b8e7958264ffcc26d9446c220
2012-08-22remove unused module-description xml filesMatúš Kukan
Change-Id: I531e47538f308ee43e0fe8d7db59f525e45942c3
2012-08-22do not deliver these module-description xml filesMatúš Kukan
Change-Id: Ife2f42b3a917ece10dc7ee9fcd83f1558084c4f1 Reviewed-on: https://gerrit.libreoffice.org/454 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2012-08-22callcatcher: update listCaolán McNamara
Change-Id: Id297f32de5fba9d17fec89d2f8ea21c5d1a2a4bc
2012-08-17silence macosx uninitialized warningCaolán McNamara
Change-Id: I8472cf79aaf193ce63a1d2bfa9d329ad35ddd2c6
2012-08-17followup changes to 44861f2435a0c487d4fb5b196f7e4fe7f9569396Noel Power
a) got rid of defaulted params in virtual base class methods b) made some no-op virtual methods in the base class pure thus making the base class abstract c) made LayoutManager no longer inherit utl::ConfigurationListener as it wasn't actually listening or acting on any configuration changes Change-Id: Iab1783f6b5a35b130287a2aedbd1dc8413793182
2012-08-17Object Catalog in Dialog EditorUray M. János
Change-Id: Ia74faa1452a4200c28fbd7c63130700df0a70b24 Object Catalog in Dialog Editor Change-Id: I97f2e0497b0e87cf630bba16dd98f9f7d0bb86e7
2012-08-16Set ide sizer color to dark grey; was dark blackJean-Tiare LE BIGOT
The color setting was picked from SplitWindow::Paint() for visual consistency with the sizers used in Impress for example. This commit also resurects presumably dead code. In fact GDB let me see that only the short path was taken. This has an impact on Calc's window splitters and on more visibly on the basic IDE which now looks much nicer :) EDITS: restricted this commit impact to IDE as a poc Change-Id: I9a051fd894feccff4bbc7db7efe1160cb2c3a2c6
2012-08-10Bin BasicDockingWindow( Window* pParent, const ResId& rResId )Julien Nabet
Change-Id: I84f4929eb923bc3d05bdf04a8958cb58b5bfb921
2012-08-08Some MSVC warningsStephan Bergmann
Change-Id: Ib4856779bb2060e3e95d24b8a00249e411f92b62
2012-08-08make property browser dockable in basic IDENoel Power
very basic support for this, basicially you can dock the browser anywhere now hence lots of behaviour niggles remain, e.g 1) it probably doesn't make sense to be able to dock the browser into top or bottom quadrants ( we need to implement the Docking ( maybe PrepareToggleFloating mode ) method(s) in PropBrw ( propbrw.cxx ) 2) open floating or not ( if propertybrowswer is open ) 3) should we leave the 'properties' context menu when selecting shapes in place or not 4) switching between Module and Dialog tabs, we probably should 'remember' docked position and state Change-Id: Ibea4be3397eeac613642934662c3a9868fdf783b
2012-08-07IDE: dynamic_cast fixUray M. János
Change-Id: Ia8826be6e6fe7c09adb4f0104b52ceba6b89163b
2012-08-07IDE: PTR_CAST, ISA to dynamic_castUray M. János
Convert the obsolete PTR_CAST and ISA macros (from tools/rtti.hxx) to C++ dynamic_cast is basctl. Change-Id: I45530d1d34d132904f812e238ee3b59b1a4f227b
2012-08-07Remove forwards of non-existing structsThomas Arnhold
Change-Id: Ie1d7ed56c69539587df5310c0a1ea0476abd5542
2012-08-07drop bogus eof linesThomas Arnhold
Change-Id: Idda2852c3e96ce15fde75d5a95369ec50a012410
2012-08-07Remove non-existing forward declarationsThomas Arnhold
Those classes don't exist. So remove friend class operators too. Change-Id: I8e3b32db933dea7cbab86015f0c926df967511f6
2012-08-07fdo#46193 MessBox was made copyableZolnai Tamás
Part of MultiLineEdit was moved down from stvools to vcl with name VCLMultiLineEdit. MessBox uses it to display the message in read-only mode. Some of svtools' classes - which are necessary to implement VCLMultiLineEdit - were moved to vcl as a whole, and their includes are rewrite. Note: ExtTextView and ExtTextEngine classes would be leaved in svtools if VCLMultiLineEdit is a template class, but two macros: IMPL_LINK end IMPL_LINK_NOARG make it impossible to use template syntax. Change-Id: I26543868d8081c225c7125404d23369de3c3afcd
2012-08-07IDE: sal_Bool to boolUray M. János
Convert all occurences of sal_Bool, sal_True and sal_False in basctl to bool, true and false -- except in prototypes of virtual function overrides. (The virtual functions that are internal to basctl can be and was converted.) Note that since sal_Bool and bool are implicitly convertible to each other, for functions that take a sal_Bool (by value), true and false can be given too. Change-Id: Ie44740fa87f89e9fedd913840ca2b38e95e6b957
2012-08-07Basic IDE Object Catalog improvementsUray M. János
Change-Id: I4c3bbf721428e93cdfa8f062f37c5911faba0fa4
2012-08-03readd fix for fdo#47907 i.e "Revert "Revert "fix for fdo#47907""Noel Power
This reverts commit f29c91f3351db2887f994c2cc82ceaaa6d717906. Change-Id: I347a4e115cd1d85fa36242f89d2e8131de9cf57e
2012-08-03sal_Bool -> boolTakeshi Abe
Change-Id: I49749f327d6a9c3661ef9bd684647e0a45b9203a
2012-08-02Revert "fix for fdo#47907"Noel Power
This reverts commit 8ba8aca1ac4744a23eefb7bb5892e2a697d9d987.
2012-08-02fix for fdo#47907Noel Power
Change-Id: Ia5e4e7429db122db505d59289b1106814ea7c378
2012-08-02sal_Bool -> boolTakeshi Abe
Change-Id: Id2addfc6e0c4e0b30281c9f3d22ec0624a61dab1
2012-08-01sal_Bool -> boolTakeshi Abe
Change-Id: I82157e89d04eda35525c5a540504e6a8d18bc86c
2012-07-31sal_Bool -> boolTakeshi Abe
Change-Id: Ic982c4da144ecdf7198b84b98d672ced8f1f70b6
2012-07-30Bug 48549 - System::Beep() removalMathieu Vonlanthen
Change-Id: I011048912af051a762a78af8646513a1fc624073
2012-07-29Remove strange DummyTypeCaolán McNamara
I can see no purpose to DummyType Change-Id: I25d9d3b321df28f8c2bcb4bf915eb176a14fdaf8
2012-07-27sal_Bool -> boolTakeshi Abe
Change-Id: I97618ffb138f292665edb634a29c39ab5a332ab1
2012-07-26fdo#50632 IDE: update Object Catalog when closing a documentUray M. János
Change-Id: Ia635aee1611eaff663906e2238bf23a5013242a3