summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2016-11-08loplugin:unnecessaryvirtual in basctl..chart2Noel Grandin
Change-Id: Id4eeb12792c3a66b68a907cb459ab437e3d64e4c Reviewed-on: https://gerrit.libreoffice.org/30680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:oncevarNoel Grandin
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d Reviewed-on: https://gerrit.libreoffice.org/30668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: Ief4a9dfc0e0a2dad04c3ac9f1840b823fd9357de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01Omit the default comparatorTakeshi Abe
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-25tdf#103209 Apply application color settings to Basic IDETakeshi Abe
This makes the text and background colors in the editor window follow the custom colors "Font color" and "Document background" respectively in Options > LibreOffice > Applications Colors. ... for those who think BASIC looks cooler when written in green text on black background. Change-Id: I82647865f7c2915341249c2fd5ebc9bd8d617bd1 Reviewed-on: https://gerrit.libreoffice.org/29815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19loplugin:expandablemethodds in basctl..chart2Noel Grandin
Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993 Reviewed-on: https://gerrit.libreoffice.org/29998 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14loplugin:mergeclasses merge TextView with ExtTextViewNoel Grandin
Change-Id: If7e11dd8f6b2cb6dc19c6aa3f7e50e2e88861eac Reviewed-on: https://gerrit.libreoffice.org/29828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12de-src silly RID_TLB_MACROS resourceCaolán McNamara
Change-Id: I0b1bd13b1d8408c2b8d83411beb36615612ddadc
2016-10-12de-src solo image buttonCaolán McNamara
Change-Id: I82a613c8f371d8f585c53b2625e7dbed8ea0b703
2016-10-11de-src solo variable watch editboxCaolán McNamara
Change-Id: I9e69df546d5d6453fbd89b38d4865c9fd3088678
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-05loplugin:unnecessaryoverride in accessibility..chart2Noel Grandin
Change-Id: I14ba52fe8352f8bbdfcaa90177f4f3ac9f0e08b1
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-20Related cid#1371289: Improve code to not depend on missing move assignmentStephan Bergmann
Change-Id: I332010574a2ddd13590452f08da32f21f8ef882b
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14put all SfxShell feature flags in one typed_flags classJochen Nitschke
make values unique across modules. check if flag used in correct module. Change-Id: I656ffd3d527dd895777e14e1cc933c8b9b3f6e46 Reviewed-on: https://gerrit.libreoffice.org/28906 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14tdf#88205 use list ctor for uno::Sequence a11y to canvasJochen Nitschke
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18 Reviewed-on: https://gerrit.libreoffice.org/28866 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-11coverity#1371151 rearrange code to avoid assignmentCaolán McNamara
Change-Id: Iccba596ce958bcdd62aae572f3189592f96cad25
2016-08-30no point in these dtors being virtualCaolán McNamara
nothing inherits from these classes Change-Id: Ic887ac8a046b8697e310e19b6e7fdf9efae8f074
2016-08-30Translate some German comments and messagesMaarten Bosmans
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577 Reviewed-on: https://gerrit.libreoffice.org/28493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-23Remaining clang-tidy misc-move-constructor-initStephan Bergmann
...by turning the relevant ctor parameters into "const &" (following 8f30da6386fa414b9fe4c704b294a978df77347b "Some clang-tidy misc-move-constructor-init"). Change-Id: I6686dabe2f05156d6ecd49aa76a3a1166ccac045
2016-08-23clean up the SdrObjFactory create callbacksNoel Grandin
passing params by setting fields on yourself is just gross Change-Id: Iee98a9e8e266b56fc886c76eab470ab1ff7ff8e4
2016-08-22convert SdrHintKind to scoped enumNoel Grandin
Change-Id: I77ad33425d440263a71bc94f41d8e141f16dfb78
2016-08-19convert SdrCreateCmd to scoped enumNoel Grandin
Change-Id: I8772032dee25c790314384750b8c7277c4879318
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for basctlArmin Le Grand
All *.ui files create a screenshot, but not all look useful Change-Id: I79be2811df628286e5af058a5a8e0232ddf6a2f7
2016-08-17loplugin:unusedenumconstants in basctl..editengNoel Grandin
Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-04tdf#100726: Improve readability of OUString concatenationnadith
all most all of the places in the basic basctl modules this bug fixed Change-Id: I1a4a03e207c1b520449c31a05265585120da07f6 Reviewed-on: https://gerrit.libreoffice.org/27662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04loplugin:countusersofdefaultparams in basctl..basicNoel Grandin
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695 Reviewed-on: https://gerrit.libreoffice.org/27793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara
in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#91665 l10n: replace string lists - by separate stringsMuhammet Kara
Convert the stingarray to resource strings. Change-Id: Iae9c52c21fd004c052fa78d959dfa92ad1d16a7d Reviewed-on: https://gerrit.libreoffice.org/27641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15remove excess whitespaceStephan Bergmann
Change-Id: I11d775eed216e7d8a59d0b891dffcf191780aa9b
2016-07-15tdf#100726: Improve readability of OUString concatenations in basctl modulenadith
Change-Id: Iad8e3a2b74062640660c0ea8121dc6a5d043c080 Reviewed-on: https://gerrit.libreoffice.org/27228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-08loplugin:redundantcast: redundant static_casts in basctlStephan Bergmann
Change-Id: Iac1a400f37ee25bfbebbe95bb22f9708581899f4
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I2ddc6111cede4f7322aabbd1e5ecc671fe101d4e
2016-07-04tdf#100726: Improve readability of OUString concatenationsArnold Dumas
Change-Id: I7018f3c339ffcab7d46d97f1d3784da1be644f0a Reviewed-on: https://gerrit.libreoffice.org/26870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-25 22:46:00 +0000