summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2015-03-20tdf#88230: cleanup solar mutex yieldingPranav Kant
Use SolarMutexReleaser, instead. Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-19loplugin:constantfunction: sotNoel Grandin
this appears to be completely unused Change-Id: I74dad8b0c478a1aed035ce9cc663a74de157816e
2015-03-19loplugin:constantfunction: unotoolsNoel Grandin
Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-10tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>Swachhand Lokhande
Change-Id: Idef9dd55eb1719eaf592bc4a86440cbd5aa4fb32 Reviewed-on: https://gerrit.libreoffice.org/14781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-09cppcheck: cstyleCastCaolán McNamara
Change-Id: I3a1aaafe30f13f2eb388f7db3d78ecafaf0a4a2d
2015-03-06Idle: Changed to new enum nameTobias Madl
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
2015-03-06Idle: Removed VCL_IDLE_PRIORITY_ prefix of enumTobias Madl
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
2015-03-06Idle and Timer are now completely independentTobias Madl
And everything is functionating pretty well. Change-Id: Id7f5a995362f6f7c5235f2e9facb7c7f119f3140
2015-03-06Timer: Adapted all idle includes and enum usesTobias Madl
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-03-02replace SVX_SEARCHCMD_ constants with enum classNoel Grandin
Change-Id: I675c488742219cc19624a21d1fc8e5033e7cbefa
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-17boost->stdCaolán McNamara
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17tdf#39440 - cppcheck cleanlinessRadu Ioan
Fixed some cppcheck defects Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb Reviewed-on: https://gerrit.libreoffice.org/14487 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-12these can all be made constCaolán McNamara
Change-Id: I6a8af82e8612196f20143f4997eb95c80a2ca13d
2015-02-12BASIC IDE : add the current procedure name in the status barLaurent Godard
Change-Id: Icecef1748bcc964670b0b95263314d9d8a4555f0 Reviewed-on: https://gerrit.libreoffice.org/14367 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10coverity#1268024 coverity#1267686: basctl: uncaught exceptionMichael Stahl
DlgEdObj::_propertyChange() should have same exception spec. as XPropertyChangeListener::propertyChange(). Change-Id: I8d5b628b7cc382dae55a9e17bf813fba647453eb
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I71bfb6628bb746498ff47d6d9aba50e150757144
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-01coverity#1267686 Uncaught exceptionCaolán McNamara
Change-Id: Iab9067590cd15b3b60cfa2a98ee6be30d2fdf13d
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-12Resolves: #i120772# do not ignore last three properties...Tsutomu Uchino
when special properties not found in watching window (cherry picked from commit 8815f3f3fbb3632cccbbf8476f4c40c9bda8eb6e) Conflicts: basctl/source/basicide/baside2b.cxx Change-Id: I6069d55b9f894846a7b4d81b981cf4523b444753
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05fdo#39596: replace cstyle castsJuan Picca
Change-Id: I1a0814ec973b1dc0f4db4ee88a999d9ffc219e7a Reviewed-on: https://gerrit.libreoffice.org/13701 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05fdo#67343 Arrange Help button in a secondary groupAdolfo Jayme Barrientos
This helps de-clutter action button groups and eases visual scanning. This patch also contains little layout tweaks where needed to separate the Help button from its neighbors when the dialog is too small. Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce Reviewed-on: https://gerrit.libreoffice.org/13427 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-22avoid 'don't create ItemSets with full range before FreezeIdRanges assert'Caolán McNamara
Change-Id: I3dbb760cd5dbf2e72d1886eaca537bb9ecf9f8cc
2014-12-18basctl: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I3e1ff06ac42b53d4cbbdc5a4590bf505d0746d2d
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-09timers: Timer never started, remove it completely.Tobias Madl
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4
2014-12-09changed timers to idleJennifer Liebel
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09changed timers to idlesJennifer Liebel
Change-Id: Ic045e0c066ff1f607f0582b88e72375efaaa708f
2014-12-08Remove more unnecessary header includes and use forward declaration.Kohei Yoshida
Change-Id: I88d0fb0e7c20d4b1414516e3bd2f961811b2eb8c
2014-12-08reduce scope of local variablesMichael Weghorn
This eliminates some of the warnings from Cppcheck report of 2014-11-29. Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9 Reviewed-on: https://gerrit.libreoffice.org/13330 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05loplugin:unreffunStephan Bergmann
Change-Id: I6dbb20c82b58b81aa4cfb8cc3cf80f6d1202075d
2014-12-05Removed useless includes in basctl/source/basicide/ treeAndrea Gelmini
It compiles on Windows and Linux, here, with flags: --with-help --with-java --with-lang="it" Made with the ignorant brute force of removing each include one by one. The tree with each commit (used to bisect) it's here: https://github.com/Gelma/core/commits/gr_push_brute_force_slot_2 Conflicts: basctl/source/basicide/bastype2.cxx Change-Id: If88eebb6ecba6ae7ab1e98713b66b10f1ad57dca Reviewed-on: https://gerrit.libreoffice.org/12963 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-04be more explicitDavid Tardon
Change-Id: I33b639b3505d5db2ea8b708d80e68e576ec53308
2014-12-04impl. Clone for all subclasses of SdrPageDavid Tardon
Change-Id: Ie370161e51ff83cb605bc57d317ff945404e5611
2014-12-04ooo#93212 avoid slicing during construction of SdrPageDavid Tardon
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b
2014-12-03Use std::initializer_listStephan Bergmann
Change-Id: I726fc6429a2eb7827d09d04584fd0b725e78f650
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25all these ids and their associated resources were unnecessaryCaolán McNamara
Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156
2014-11-25We now only need one bit of information hereCaolán McNamara
whether there *is* an id, or whether there is not an id. An id of 0 seems to be used as a flag that an interface is some sort of superclass which can be subclassed by something else and have its toolbars etc reused. Convert this to a bool so we don't need an a resource id for each one and just drop the third arg for the normal "final" case and use a different define for the inheritable case Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-11-22timers: Timer never started, remove it completely.Tobias Madl
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4 Reviewed-on: https://gerrit.libreoffice.org/13030 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-12 01:53:07 +0000