summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-28make PostUserEvent Link<> typedNoel Grandin
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-26Clean up aEmptyStrStephan Bergmann
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-25simplify, IsEmpty() checks both Right and Bottom alreadyNoel Grandin
Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc
2015-08-22tdf#93077 - basic dialog localization issues.Michael Meeks
Don't remove non-existent languages to clean the dialog. Avoid crashing when adding languages to a non-localized dialog. Change-Id: Ie356177e00e56c214727d513ae0ce6d62d32591c Reviewed-on: https://gerrit.libreoffice.org/17929 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-20avoid autocorrection misreplacingLaurent Godard
takes the last token in case of chained "." instead of the first one to avoid aa.b. autocorrects (wrongly) to aaaa. Change-Id: Ibca68850282a0d3aec67ca518bdcbf1da676e155 Reviewed-on: https://gerrit.libreoffice.org/17858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-18avoid basic ide crash in code autocompletionLaurent Godard
due to code completion and user defined types type MyType a as string b as string end type dim aa as MyType typing aa.b. the last point led to crash remaining problem code autocorrection now shows wrong behaviour as aa.b. autocorrects (wrongly) to aaaa. Change-Id: I3e05680cd9d82f7dc124c5923f9858e22961896e Reviewed-on: https://gerrit.libreoffice.org/17824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-17o3tl: rename compat_functional headerThorsten Behrens
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-16sal_uLong to sal_Int32/longMatteo Casalin
Change-Id: Ia4ae190da37351b8c2b7ee9fc953508c5b1ab062
2015-08-16sal_uLong to sal_uInt32Matteo Casalin
Change-Id: Ifcde090747127680a9e4b810ff062d024663632c
2015-08-16Use constants instead of (possibly wrong) magic numbersMatteo Casalin
Change-Id: I0829d271337b9fe77341c62a1c2ef4d6ae62c727
2015-08-16Rework loops so to have exit condition on correct unsigned valueMatteo Casalin
Change-Id: I91e647d6b1aebe8342f95c88fc81bd2c5a43ce71
2015-08-16sal_uLong to sal_uInt32 as TextPaM paragraph numberMatteo Casalin
Applied also to related functions. Also fix a couple of minor issues while at it. Change-Id: I615094d047c87a0f4854054e720492d3ab25c575
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I89796134a0cce33279ba7f02492857a656e8aee3
2015-08-10tdf#93065 Swap next and previous buttons in find toolbarYousuf Philips
Change-Id: Ie07364696175038130cb5b94fbad39b88e646921 Reviewed-on: https://gerrit.libreoffice.org/17473 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-08-07Resolves: tdf#92896 wrong delete language dialog pathCaolán McNamara
Change-Id: I720e95c6c5e8b613ef880aa65f5e8cdb85143b58 Reviewed-on: https://gerrit.libreoffice.org/17565 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-04basic,basctl: inline some use-once typedefsNoel Grandin
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
2015-08-01sal_uInt16 to sal_Int32, constify, minor optimizationsMatteo Casalin
Change-Id: Icc41bbe09e495454ca27e9281eca6f4731a135c8
2015-08-01sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: I723d7c187ec186ccc68f061ba2357712a5f31869
2015-07-28inline the "old" SbxErr constantsNoel Grandin
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28convert SbxFlagsBits to scoped enumNoel Grandin
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-24loplugin:unusedmethodsNoel Grandin
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20svtools: change these SvTreeListEntry functions to unique_ptrMichael Stahl
... parameters to make it clear that they take ownership. Change-Id: I572c5fa6268438a86d0a4fa1d2aef15382cb5607
2015-07-17com::sun::star->css in basctlNoel Grandin
Change-Id: If0013cdd734a58397ab4972f9cca5584f05d1715 Reviewed-on: https://gerrit.libreoffice.org/17164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17Convert dialog controls button to the generic controllerMaxim Monastirsky
Change-Id: I3d03fba86139a3495e1cfd67b3f17149c73e3377
2015-07-06tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, in basctl. Change-Id: I52da577a6f6298eb89b0cc8c8ff243ecd341e9b3 Reviewed-on: https://gerrit.libreoffice.org/16718 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05SfxToolBoxControl::GetPopupWindowType seems unused, kill itMaxim Monastirsky
together with SfxPopupWindowType enum. Change-Id: Ia0b2388b34c96bb044f1bfcc7e89b33ac37d5f95 Reviewed-on: https://gerrit.libreoffice.org/16766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29remove custom RTTI from basctl::BaseWindowNoel Grandin
unused Change-Id: Icfb5a29f592629e4332c31b083d78efcd2d0161e
2015-06-28coverity#1308514 Uncaught exceptionCaolán McNamara
Change-Id: I62d3d390ff9d1a44d8704b41ef62fff5d532bcc4
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I7c79445bfa1536706561752da107090599ef26a2
2015-06-24tdf#92258 - fix crash editing macro module name.Michael Meeks
Change-Id: I8e0bbab7d7497ed7c136ddbfba73618834d5a204
2015-06-24remove SFX_NOTIFY macroNoel Grandin
it has not served any purpose since we switched to using normal C++ RTTI for the SfxHint objects Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-17protect against NULL current SfxViewShellLionel Elie Mamane
Change-Id: I748493de799902f5acf905c7ce919e3ebbf1a800
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I6ea774c635335106a7a8ddc4214c20bdf3f021ba
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05Resolves: tdf#90361 CellValueBinding/CellRangeListSource need WithArgumentsCaolán McNamara
otherwise they are not initialized and every call on them throws. This at least results in the dialog editor not falling over immediately on inserting anything in calc. Change-Id: Ie1668ef440937c75dd08671c669c021c2efecd2a
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-26 04:36:12 +0000