summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)Author
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28Remove unnecessary SyntaxHighlighter::Tokenizer statefulnessStephan Bergmann
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it. Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Move implementation details to syntaxhighlight.cxxStephan Bergmann
(and clean up a little) Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza
Change-Id: I90a7a07a43559b8d7e1d4b886b2624255200d46b Reviewed-on: https://gerrit.libreoffice.org/6406 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22HighlightPortion's indizes into strings should be sal_Int32Stephan Bergmann
(Had to fix type of some variables holding TextPaM::GetIndex() values from sal_uLong to sal_uInt16 to avoid -Werror,-Wsign-compare failures when comparing those against HightlightPortion's nEnd.) Change-Id: Ia8a0ba682ae28e86e394ee48adff3225eb8de053
2013-10-22Use conventional std::vector idiomsStephan Bergmann
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22Unwind HighlightPortions typedefStephan Bergmann
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-16cleanupThomas Arnhold
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-12What (who?) are OW and MTF?Tor Lillqvist
Change-Id: I47b9b91d72e423c0ef37eaa9f081e755adfc36d6
2013-10-12Test WNT instead of the vague UNXTor Lillqvist
Change-Id: I99aa82d29d056afde92d258fd5cdf13359f9b74c
2013-10-11Basic: When we warned & stopped the program, don't warn again.Jan Holesovsky
It's extremely annoying to have to dismiss the warning with every keypress ;-) Change-Id: Ie117085ef25676065aedd0744cf618e1b566688b
2013-10-11-Werror,-Wunused-variableStephan Bergmann
Change-Id: Iac999c157d0d3fdb737bd2d92240e252cfb05333
2013-10-11Fix whitespace.Jan Holesovsky
Change-Id: I76acfa77eea862a1562521eea5160ed054f68650
2013-10-07CID#738562 uninitialized memberCaolán McNamara
Change-Id: I65f64b1604c9c0aa3538d6e9384014fd44e16c0b
2013-10-07CID#738561 uninitialized memberCaolán McNamara
Change-Id: Icac2ca781f067975746d4b861fcbd60e6577b64e
2013-10-07CID#738560 uninitialized memberCaolán McNamara
Change-Id: I270455041b73450e6ed1fc5a05e68c88db4310ab
2013-10-07CID#984418 unused returned pointerCaolán McNamara
Change-Id: I92864b2491882e0553b87d9d87d126ec30ef3974
2013-10-07CID#984417 unused returned pointerCaolán McNamara
Change-Id: I638d7d89b7c1414aac34bcf1c92fdde8eee98e2a
2013-10-07CID#738954 unused returned pointerCaolán McNamara
Change-Id: Ieb47b91dd745db400c7ad4756167de758a625a64
2013-10-03CID#738559 uninitialized memberCaolán McNamara
Change-Id: I68d9c84dbaa1a9a8d60d572027fcbc1d8c481e8e
2013-10-03CID#738558 uninitialized membersCaolán McNamara
Change-Id: I159693ff794482c772186947fa6ce5cb9aa71ad6
2013-10-02-Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: I22101fec4b75e567153c6401ab754e1a5e158a77
2013-10-01convert basctl module from String to OUStringNoel Grandin
Change-Id: Iac38d4fd5d1d8b5c305bbb20eb1b40a7c7dec9bf
2013-09-22Related: fdo#38838 remove UniString::CompareIgnoreCaseToAsciiCaolán McNamara
Change-Id: I4a9b34d63d2534a35aa9a878b8c2bec15262c2be
2013-09-17convert basctl/source/inc/basobj.hxx from String to OUStringNoel Grandin
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
2013-09-13fix for fdo#69173 crasherNoel Power
the layout changes for the basic IDE ( for the object browser and object catalog ) seem flacky, I have seen since those changes have been introduced some strange ( but random ) behaviour ( like the odd unrepeatable core ( maybe related to this ) and also sometimes Modules appearing in the tree under the wrong nodes etc. I'm no expert in the basic IDE code but this patch seems to fix the problem. However there is one drawback, in the core inducing scenario the tree view ( object catalog ) dissappears, this is because the patch suppresses the problematic layout in this case ( as the layout seem not to be currently able to deal with 'no-existent' (recently) deleted current window ) Probably in this scenario a fallback currentwin (instead of nil) could be set this would behave better but ideally. Ultimately the layout class should probably be modified ( possibly redesigned ) Change-Id: I9d1e23bd6fc4aae32aa78da8278c318f7051136a
2013-09-03WaE: C4101: 'ex' : unreferenced local variableTor Lillqvist
Change-Id: I804bafb4057e1bb409b7f30d79554f2773cb3967
2013-09-03completition->completion :)Ivan Timofeev
Change-Id: I7a5ae7cc0d6a253bbc27db076babedd65c89be1a
2013-09-02GSOC work, renaming+listbox right side fixGergo Mocsi
Fixed the small bug in positioning the listbox to the right side. Function ResizeListBox was renamed to ResizeAndPositionListBox. Change-Id: I3cea54ad5658ee1628935b4975f52fe78c1ff5c3
2013-09-02GSOC work, fix the clipped listboxGergo Mocsi
Listbox clipping works correcly on the right side and on the bottom. The function calculations are done from the initial position: if the actual X/Y coordinate + width/height exceeds the visible area, listbox is poitioned up/a bit left. Change-Id: I17ff28cd23423819b55d7079c6d35484b567899c
2013-09-02GSOC work, fixed clipping of the listbox in the bottomGergo Mocsi
Listbox positioning on the bottom is corrected. Change-Id: I75af0ff68b24ad26e9c9bd41d91a6ac9d1fa9d1c
2013-09-02GSOC work, arrow navigation+TextSelection problems fixedGergo Mocsi
I've added a new function called EditorWindow::GetLastHighlightPortionTextSelection, which gets the last edited word (from the highlight portion), and creates a TextSelection from it. Later, this is used to remove/replace text in the listbox when pressing the tab key. The proble was, that is cleared the whole line, but now, it just clears the newly edited word. Change-Id: I61b6721696e89002705c9980579023b42ad1faaa
2013-09-02GSOC work, fix strange TextPaM errorsGergo Mocsi
Wrong TextPaM's caused the autocorrection to insert the string multiple times, this is now fixed. I use the values from the HighlightPortion struct. Change-Id: I5ff5f01c06738088639186c35eb58ee9ff497d95
2013-09-02GSOC work, multiple fixesGergo Mocsi
Code completion: parser recognizes extended types ony when the checkbox is checked. Fixed a crash caused by a misspelled uno type. Fixed function CodeCompleteDataCache::Clear() to clear both internal variables. Change-Id: I82fdd2e1cf749237e2e2de4a9a2fc7d07fb7eb4a
2013-09-02GSOC work, options fixGergo Mocsi
Tools/Options are now saving correctly. I've added a check for empty string in EditorWindow::HandleCodeCompletition. Change-Id: Ib5d75fe840e3c3fd12cd7175fb7828b8a1d76db6
2013-09-02GSOC work, small fixesGergo Mocsi
Some code fixes in function EditorWindow::HandleAutoCorrect(): updating the module and getting the data from parse is necessary(not just when code complete is on). Removed some duplicate code when checking for the type of the actual highlight portion. Change-Id: I29a62dae23f2c28e54f9185ac59ff2747c64e0d7
2013-09-02GSOC work, autocorrect procedures+variablesGergo Mocsi
Fixed some small issue with the right arrow key in the ListBox. Autocorrection now correct all variable types and procedure names. Change-Id: Iff1abaf10c621aef04772837faa272bb6f987e37
2013-09-02GSOC work, small code fixesGergo Mocsi
Added some constants for CodeCompleteWindow::ResizeListBox(). Simplified a condition is EditorWindow::HandleAutoCorrect(). Change-Id: If8aa34273b6170130d95a309ed385a5152418b76
2013-09-02GSOC work, simplify CodeCompleteWindow::ResizeListBoxGergo Mocsi
Now all calculations are done in this function, plus the initial TextSelection is passed as a parameter (it it needed to determine the location of the ListBox). Some local variables were made constant. Change-Id: I36942ded72cc988c8fd5114e0d666f447b80d396
2013-09-02GSOC work, autocorrect fixGergo Mocsi
Autocorrect fixes the new types independently from code completition(not just pressing the "." after the variable). Change-Id: Icc31af29f1dcc0de662d7fc191c3f215188b571b
2013-09-02GSOC work, renaming + options fixGergo Mocsi
Options now work correctly: I've added the missing function. Rename: renamed some variables and methods to kep the consistence( Autocorrect keywords -> Autocorrect). Change-Id: I6b4914575f1a06eb3268c133b8b990364e3d24e4
2013-09-02GSOC work, behavior fixesGergo Mocsi
Code completition: left/right arrow keys handled. Left arrow dismisses the dialog when reaches the dot. Right arrow dismissed the dialog when reaches the next line. ListBox appearance fixed. TAB key can insert the first matching entry. Autocorrect: "Autocorrect Keywords" has been renamed to "Autcorrect" (in the UI, and the config file, after this patch a make dev-install is needed). Keyword case correction is not just capitalizing the first letter ( eg. Elseif -> ElseIf ). Autoclose procedures: cursor is being placed inside the preocedure. Change-Id: Ie7e9ae96b49bd94562db83f96e1c4ad63ab3f3d6
2013-09-02GSOC work, Tool/Options/Basic IDE Options createdGergo Mocsi
Created a new tab in Tools/Options/Basic IDE options instead of the ModalDialog. The original dialog under Basic IDE/View/IDE Options was removed. Tab page is disabled when experimetal flag is off, entry node in the treebox is visible. Change-Id: Iaad1ea5fadc3f05ca81f2240dceb513f25be35b9
2013-09-02GSOC work, TAB key inserts match+code fixesGergo Mocsi
Feature: TAB key now inserts the matching entry. When the TAB key is pressed simultaneously, it selects+inserts the next match. Fixed some duplicate code calls. Added a function called CodeCompleteListBox::GetParentEditWiew() to shorter the parent's ExtTextView variable access. Change-Id: I2ae2eaa07fff760d91d05120439c76b215fcd3c1
generated by cgit (git 2.34.1) at 2025-01-09 07:47:41 +0000