summaryrefslogtreecommitdiff
path: root/basegfx
AgeCommit message (Collapse)Author
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke
... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-06CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
2016-10-03Fix typosAndrea Gelmini
Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1 Reviewed-on: https://gerrit.libreoffice.org/29430 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-23coverity#1371281 Missing move assignment operatorCaolán McNamara
Change-Id: I7d0351931b0baa434bd24db05358e096cfa1b6e2
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-05tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc.Gökhan Gurbetoğlu
Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08 Reviewed-on: https://gerrit.libreoffice.org/28584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-29tdf#43157 Clean up OSL_ASSERTdrazil
Clean up OSL_ASSERT in basegfx/source/tools/b2dclipstate.cxx Change-Id: I4107980aa079b0e0e8605de34ecfd01587647af6 Reviewed-on: https://gerrit.libreoffice.org/28417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-08-29cid#1371223 Missing move assignment operatorNoel Grandin
and cid#1371216, cid#1371179 Change-Id: I64faaada85cc92a8b47c2a665488f07050be6fc3
2016-08-25cid#1371276 Missing move assignment operatorNoel Grandin
also cid#1371234, cid#1371249, cid#1371208, cid#1371250, cid#1371258, cid#1371266, cid#1371257, cid#1371221 Change-Id: I18d952887b684e1999d003cec0f668789c851b52
2016-08-25cid#1371281 Missing move assignment operatorNoel Grandin
Change-Id: I29e1b042d2550bbe909ea432b161bdcb418d8976
2016-08-25cid#1371285 Missing move assignment operatorNoel Grandin
Change-Id: Ia822a01caec28f8137e30c05b6904c9fac367ce4
2016-08-17loplugin:unusedenumconstants in basctl..editengNoel Grandin
Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
2016-08-04loplugin:countusersofdefaultparams in basctl..basicNoel Grandin
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695 Reviewed-on: https://gerrit.libreoffice.org/27793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara
in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-30tdf#96505 get rid of "long" integer literals 'L'Asela Dasanayaka
Remove L from integer literals in module basegfx all 0L, 1L, and 2L Change-Id: Ia8a0d660033651f6d0a35392b74b67358b639fb3 Reviewed-on: https://gerrit.libreoffice.org/27717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25basegfx: use polygon initializer_list in some placesTomaž Vajngerl
Change-Id: Ibb83476376e1c46aedf67c9455292405219a45c1 Reviewed-on: https://gerrit.libreoffice.org/27476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-25basegfx: initializer_list from polygonTomaž Vajngerl
Change-Id: I2d6cdb7189217e1fadb1ecf4e11cf4dd04043ec6 Reviewed-on: https://gerrit.libreoffice.org/27475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-19simplify code nowCaolán McNamara
Change-Id: Ic9fed523c9077f3e9efa2af00ac5f9e9071a0dc9
2016-07-19Resolves: tdf#100909 artifacts in hole of polypolygon shapeCaolán McNamara
regression from... commit 1ca06ce59b7d3cea873d2dc109a2acaec0a80759 Date: Tue Aug 5 16:11:21 2014 +0000 Related: #i125349# moved clip enhancements to base clipping functionality The "reversed" clipPolyPolygonOnRange path is the problem apparently. The case in #i125349# uses the other clipPolyPolygonOnRange path. So for simplicity just remove the branch that's causing trouble here. Change-Id: Ia4c60ebc44a8c239c1a7d5c84e9b970c2885ff05
2016-07-07tdf#82214 optimize performance for primitivesArmin Le Grand
See svg bug doc, which is processed quite slowly. Beyond needing faster renderers, there is also demand to improve the handling of primitives created by SVG import. Conflicts: drawinglayer/source/primitive2d/patternfillprimitive2d.cxx vcl/win/gdi/gdiimpl.cxx Change-Id: I10992a5746b8b2d6b50e3ee3fe415a035685c9ba
2016-07-07tdf#50613 speedup fat line drawing on linux using cairoArmin Le Grand
Drawing fat lines is slow on linux due to X11 having no direct support for it. This leads to creating the PolyPolygon geometry for each fat line, then tesselate and draw as trapezoids. This is not buffered in any way and is done at each paint. As a side effect, fat lines composed of multiple anti-aliased lines also show errors since AA-ed edges do not add up graphically. Since we have cairo now available it makes sense to use it for fat line drawing, it is markedly faster despite being a software renderer. No such gains for PolyPolygons though. Change-Id: If4001556e2dd4c15ecf2587cad6ce1e864558f2d
2016-07-04"it is working properly", not "it is working property"Christian Lohmaier
Change-Id: Ief34f2e110060dc9d6200e8533c64b1e12bfb37b
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17tdf#99130 use subdivision on B2DPolygon, angle based subdivisionTomaž Vajngerl
Remove the subdivider we used until now as there is a better way to subdivide a polygon with getDefaultAdaptiveSubdivision, which in additiona also caches the result. The subdivider used in getDefaultAdaptiveSubdivision was a limited count based subdivider so this exchanges that with an angle based one which gives much better results. Change-Id: I95c009ccf3d54305df0d8eef177cab0df0a23bea Reviewed-on: https://gerrit.libreoffice.org/25033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-02Fix typosAndrea Gelmini
Change-Id: I38b5e720af67d0bfb1be72ff82a7f5c595a94c14 Reviewed-on: https://gerrit.libreoffice.org/24535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13loplugin:passstuffbyref in basegfxNoel Grandin
Change-Id: Ia7fc22152af2facf3134d9e0975cfb9608b2e931
2016-03-31tdf#96505 Remove 0L occurences from avmedia and basegfx modulesslideon
No compiler warnings on my machine Change-Id: Ibd303c64f04f6f52272ac19c3069da2f14cb4e9a Reviewed-on: https://gerrit.libreoffice.org/23558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-30loplugin:nullptrStephan Bergmann
Change-Id: I7f6d030317fc7910e69c742b3160b0156e9f9200
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I036cb407c29ee375e1893b7418c7fa63bf1d592a
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-03loplugin:unuseddefaultparams variousNoel Grandin
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25opengl: shader based polyline rendering - fixes tdf#97137 for OGLTomaž Vajngerl
Adds native opengl polyline rendering to draw polylines, line joins and line caps as triangle strips. The vertex shader allows for the dynamic line width by calculating the correct vertex posiitons, and the fragment shader is used for anti-aliasing. Change-Id: If7982c828cae1fae59c57194c8ac77e5ad7f1d26
2016-02-19tdf#97703 Removed a few redundant calls to setUp and tearDownJaskaran
Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown have been removed. I hope that saves a few milliseconds of build time :) Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34 Reviewed-on: https://gerrit.libreoffice.org/22496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09crashtesting: crash on loading moz414782-1.svgCaolán McNamara
Change-Id: I1324b902c0790350bc8c44e7d63ce45915e3b33f
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-31boost::tuple -> std::tupleCaolán McNamara
Change-Id: Ia08c184b792ff73d3ed49d6a5d54dec1a35943e9 Reviewed-on: https://gerrit.libreoffice.org/21955 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-22loplugin:fpcomparison in basegfxNoel Grandin
fix comparing of floating point values Change-Id: I54db66968cb999514747171eed82082612e0cac8 Reviewed-on: https://gerrit.libreoffice.org/21708 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-19Bin unneeded variableTor Lillqvist
As far as I see, the only use of aNormalizedEdgeVector is as a parameter to areParallel(), and there is no need for that to be normalized, is there? Change-Id: I31ca09391894ab441e5b88dbdd636cf4b91ac5c2
generated by cgit (git 2.34.1) at 2025-01-10 04:08:04 +0000